[Lldb-commits] [lldb] [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (PR #71267)

2023-11-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/71267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (PR #71267)

2023-11-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. https://github.com/llvm/llvm-project/pull/71267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (PR #71267)

2023-11-04 Thread Alex Langford via lldb-commits
@@ -96,6 +96,10 @@ typedef std::optional (*SymbolLocatorFindSymbolFileInBundle)( const FileSpec &dsym_bundle_fspec, const UUID *uuid, const ArchSpec *arch); typedef std::optional (*SymbolLocatorLocateExecutableSymbolFile)( const ModuleSpec &module_spec, const FileSpecL

[Lldb-commits] [clang] [llvm] [compiler-rt] [libcxx] [clang-tools-extra] [openmp] [lldb] [flang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

2023-11-04 Thread Giorgis Georgakoudis via lldb-commits
https://github.com/ggeorgakoudis requested changes to this pull request. https://github.com/llvm/llvm-project/pull/70667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxx] [clang] [compiler-rt] [clang-tools-extra] [flang] [lldb] [openmp] [llvm] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

2023-11-04 Thread Giorgis Georgakoudis via lldb-commits
https://github.com/ggeorgakoudis edited https://github.com/llvm/llvm-project/pull/70667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [openmp] [compiler-rt] [clang] [libcxx] [clang-tools-extra] [llvm] [flang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

2023-11-04 Thread Giorgis Georgakoudis via lldb-commits
@@ -151,6 +151,74 @@ struct RecordReplayTy { OS.close(); } + void dumpDeviceMemoryDiff(StringRef Filename) { +ErrorOr> DeviceMemoryMB = +WritableMemoryBuffer::getNewUninitMemBuffer(MemorySize); +if (!DeviceMemoryMB) + report_fatal_error("Error creat

[Lldb-commits] [compiler-rt] [openmp] [clang] [flang] [llvm] [lldb] [libcxx] [clang-tools-extra] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

2023-11-04 Thread Giorgis Georgakoudis via lldb-commits
@@ -151,6 +151,74 @@ struct RecordReplayTy { OS.close(); } + void dumpDeviceMemoryDiff(StringRef Filename) { +ErrorOr> DeviceMemoryMB = +WritableMemoryBuffer::getNewUninitMemBuffer(MemorySize); +if (!DeviceMemoryMB) + report_fatal_error("Error creat

[Lldb-commits] [llvm] [clang-tools-extra] [openmp] [clang] [libcxx] [lldb] [compiler-rt] [flang] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

2023-11-04 Thread Giorgis Georgakoudis via lldb-commits
@@ -151,6 +151,74 @@ struct RecordReplayTy { OS.close(); } + void dumpDeviceMemoryDiff(StringRef Filename) { +ErrorOr> DeviceMemoryMB = +WritableMemoryBuffer::getNewUninitMemBuffer(MemorySize); +if (!DeviceMemoryMB) + report_fatal_error("Error creat

[Lldb-commits] [llvm] [clang-tools-extra] [flang] [lldb] [clang] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

2023-11-04 Thread Markos Horro via lldb-commits
@@ -0,0 +1,28 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt < %s -passes=indvars -S | FileCheck %s + +declare void @foo(i16 noundef) + +; Function Attrs: mustprogress noreturn uwtable +define void @bar(i64 noundef %ptr) { +; CHECK-LABEL:

[Lldb-commits] [llvm] [clang-tools-extra] [flang] [lldb] [clang] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

2023-11-04 Thread Markos Horro via lldb-commits
https://github.com/markoshorro edited https://github.com/llvm/llvm-project/pull/71072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [compiler-rt] [flang] [libcxx] [clang] [openmp] [llvm] [clang-tools-extra] [lldb] [OpenMP] Add memory diff dump for kernel record-replay (PR #70667)

2023-11-04 Thread via lldb-commits
https://github.com/nmustakin updated https://github.com/llvm/llvm-project/pull/70667 >From 153c6d812939cd23bb71e53c71378117ed5b23c7 Mon Sep 17 00:00:00 2001 From: Nafis Mustakin Date: Mon, 30 Oct 2023 07:50:59 -0700 Subject: [PATCH 1/5] Add memory diff dump for kernel record-replay --- .../Pl

[Lldb-commits] [lldb] [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (PR #71267)

2023-11-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/71267 >From 8b237e9be1a17008b45d87596ee7384633d78f71 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 3 Nov 2023 14:21:24 -0700 Subject: [PATCH 1/2] [lldb] Move DownloadObjectAndSymbolFile to SymbolLoca

[Lldb-commits] [lldb] [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (PR #71267)

2023-11-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/71267 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] e7c6147 - [lldb] Move DownloadObjectAndSymbolFile to SymbolLocator plugin (#71267)

2023-11-04 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2023-11-04T17:58:35-07:00 New Revision: e7c61479cecb3d4359936d323ae1c62c217a6e20 URL: https://github.com/llvm/llvm-project/commit/e7c61479cecb3d4359936d323ae1c62c217a6e20 DIFF: https://github.com/llvm/llvm-project/commit/e7c61479cecb3d4359936d323ae1c62c217a6e20.d

[Lldb-commits] [lldb] [lldb] Remove LocateSymbolFile (PR #71301)

2023-11-04 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/71301 This completes the conversion of LocateSymbolFile into a SymbolLocator plugin. The only remaining function is DownloadSymbolFileAsync which doesn't really fit into the plugin model, and therefore moves into

[Lldb-commits] [lldb] [lldb] Remove LocateSymbolFile (PR #71301)

2023-11-04 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: The fifth and final installment in the SymbolLocator saga. https://github.com/llvm/llvm-project/pull/71301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove LocateSymbolFile (PR #71301)

2023-11-04 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This completes the conversion of LocateSymbolFile into a SymbolLocator plugin. The only remaining function is DownloadSymbolFileAsync which doesn't really fit into the plugin model, and therefore mo

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-04 Thread Med Ismail Bennani via lldb-commits
@@ -26,6 +26,10 @@ class ScriptedPlatformInterface : virtual public ScriptedInterface { return {llvm::make_error()}; } + llvm::SmallVector GetAbstractMethods() const override { +return {}; + } medismailben wrote: If we don't implement this, we ca

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-04 Thread Med Ismail Bennani via lldb-commits
@@ -32,6 +32,42 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { ScriptedPythonInterface(ScriptInterpreterPythonImpl &interpreter); ~ScriptedPythonInterface() override = default; + enum class AbstractMethodCheckerCases { +eNotImplemented, +eN

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben edited https://github.com/llvm/llvm-project/pull/71260 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-04 Thread Med Ismail Bennani via lldb-commits
@@ -103,24 +139,79 @@ class ScriptedPythonInterface : virtual public ScriptedInterface { "Resulting object is not initialized."); std::apply( - [&method, &expected_return_object](auto &&...args) { + [&init, &expected_r

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-04 Thread Med Ismail Bennani via lldb-commits
@@ -0,0 +1,19 @@ +import os + + +class MissingMethodsScriptedProcess: +def __init__(self, exe_ctx, args): +pass + + +def __lldb_init_module(debugger, dict): +if not "SKIP_SCRIPTED_PROCESS_LAUNCH" in os.environ: medismailben wrote: Not really, this

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-04 Thread Med Ismail Bennani via lldb-commits
@@ -663,6 +663,18 @@ bool PythonDictionary::Check(PyObject *py_obj) { return PyDict_Check(py_obj); } +bool PythonDictionary::HasKey(const llvm::Twine &key) const { + if (!IsValid()) +return false; + PythonString key_object(key.str().data()); medismailb

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-04 Thread Med Ismail Bennani via lldb-commits
@@ -663,6 +663,18 @@ bool PythonDictionary::Check(PyObject *py_obj) { return PyDict_Check(py_obj); } +bool PythonDictionary::HasKey(const llvm::Twine &key) const { medismailben wrote: `PythonDictionary::GetItem` have an overload that takes a `const llvm::Tw

[Lldb-commits] [lldb] [lldb] Remove LocateSymbolFile (PR #71301)

2023-11-04 Thread Alex Langford via lldb-commits
https://github.com/bulbazord approved this pull request. 🚀 https://github.com/llvm/llvm-project/pull/71301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/71260 >From 4a95ebbcd2547f802558b4051ef703add9f58ee0 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Sat, 4 Nov 2023 20:37:13 -0700 Subject: [PATCH] [lldb] Check for abstract methods implementation in Scri

[Lldb-commits] [lldb] [lldb] Remove LocateSymbolFile (PR #71301)

2023-11-04 Thread Logan Abernathy via lldb-commits
https://github.com/M4ximumPizza approved this pull request. https://github.com/llvm/llvm-project/pull/71301 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Check for abstract methods implementation in Scripted Plugin Objects (PR #71260)

2023-11-04 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben updated https://github.com/llvm/llvm-project/pull/71260 >From a2beec8a508712ff92191e47eb4ee214617cbfe4 Mon Sep 17 00:00:00 2001 From: Med Ismail Bennani Date: Sat, 4 Nov 2023 23:53:58 -0700 Subject: [PATCH] [lldb] Check for abstract methods implementation in Scri