[Lldb-commits] [compiler-rt] [flang] [clang] [libc] [llvm] [clang-tools-extra] [libcxx] [lldb] [PowerPC] Support mcmodel=large for AIX (PR #70652)

2023-11-02 Thread Fangrui Song via lldb-commits
@@ -5723,16 +5723,14 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, if (Arg *A = Args.getLastArg(options::OPT_mcmodel_EQ)) { StringRef CM = A->getValue(); bool Ok = false; -if (Triple.isOSAIX() && CM == "medium") { +if (Triple.isOSAIX() && C

[Lldb-commits] [lldb] [lldb][AArch64] Simplify handing of scalable registers using vg and svg (PR #70914)

2023-11-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: That's correct. Given how much churn this logic has had, I wanted to keep the changes clearly separated (for when I inevitably realise it's still not quite right :) ). https://github.com/llvm/llvm-project/pull/70914 ___ lldb-comm

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread via lldb-commits
taalhaataahir0102 wrote: Hi David! Thanks for the detailed explanation. I got you point that instead of passing the whole object, we should only pass the information required by the next functions. Now I' passing a vector down the track that holds a pair of two things: `std::vector> info;` -

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
@@ -762,82 +756,22 @@ uint32_t GDBRemoteRegisterContext::ConvertRegisterKindToRegisterNumber( return m_reg_info_sp->ConvertRegisterKindToRegisterNumber(kind, num); } -void GDBRemoteRegisterContext::AArch64Reconfigure() { - assert(m_reg_info_sp); - - // Once we start to re

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
@@ -93,6 +93,10 @@ class DynamicRegisterInfo { return llvm::iterator_range(m_regs); } + llvm::iterator_range registers_mutable() { DavidSpickett wrote: Wouldn't that have to overload on return type? I didn't think that was possible. https://github.com

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
@@ -762,82 +756,22 @@ uint32_t GDBRemoteRegisterContext::ConvertRegisterKindToRegisterNumber( return m_reg_info_sp->ConvertRegisterKindToRegisterNumber(kind, num); } -void GDBRemoteRegisterContext::AArch64Reconfigure() { - assert(m_reg_info_sp); - - // Once we start to re

[Lldb-commits] [lldb] 805a36a - [lldb][AArch64] Simplify handing of scalable registers using vg and svg (#70914)

2023-11-02 Thread via lldb-commits
Author: David Spickett Date: 2023-11-02T10:27:37Z New Revision: 805a36aaf571a8d53781c0c413d1af125137bfa2 URL: https://github.com/llvm/llvm-project/commit/805a36aaf571a8d53781c0c413d1af125137bfa2 DIFF: https://github.com/llvm/llvm-project/commit/805a36aaf571a8d53781c0c413d1af125137bfa2.diff LOG

[Lldb-commits] [lldb] [lldb][AArch64] Simplify handing of scalable registers using vg and svg (PR #70914)

2023-11-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/70914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [flang] [mlir] [clang] [libcxx] [llvm] [lldb] [Flang][OpenMP] Port openmp threadprivate-use-association.f90 test to HLFIR flow (PR #71043)

2023-11-02 Thread chandan singh via lldb-commits
https://github.com/chandankds created https://github.com/llvm/llvm-project/pull/71043 None >From 029b1687e5217e73655442b319a482865587277b Mon Sep 17 00:00:00 2001 From: chandan singh <36783761+chandan...@users.noreply.github.com> Date: Thu, 2 Nov 2023 11:53:03 +0530 Subject: [PATCH 1/2] [Flang]

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/70950 >From 47a48746a8a8f8e37d12a2d38a30dbfa52d5c645 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 1 Nov 2023 13:41:54 + Subject: [PATCH] [lldb][AArch64] Move register info reconfigure into archit

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread via lldb-commits
https://github.com/harishch4 updated https://github.com/llvm/llvm-project/pull/70950 >From 47a48746a8a8f8e37d12a2d38a30dbfa52d5c645 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 1 Nov 2023 13:41:54 + Subject: [PATCH] [lldb][AArch64] Move register info reconfigure into architectu

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
@@ -109,6 +110,24 @@ class Architecture : public PluginInterface { virtual const MemoryTagManager *GetMemoryTagManager() const { return nullptr; } + + // This returns true if a write to the named register should cause lldb to + // reconfigure its register information.

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
@@ -762,82 +756,22 @@ uint32_t GDBRemoteRegisterContext::ConvertRegisterKindToRegisterNumber( return m_reg_info_sp->ConvertRegisterKindToRegisterNumber(kind, num); } -void GDBRemoteRegisterContext::AArch64Reconfigure() { - assert(m_reg_info_sp); - - // Once we start to re

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
@@ -93,6 +93,10 @@ class DynamicRegisterInfo { return llvm::iterator_range(m_regs); } + llvm::iterator_range registers_mutable() { DavidSpickett wrote: Still not sure here, I guess you could pass a reference to an iterator to be set, then overload on

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
@@ -762,82 +756,22 @@ uint32_t GDBRemoteRegisterContext::ConvertRegisterKindToRegisterNumber( return m_reg_info_sp->ConvertRegisterKindToRegisterNumber(kind, num); } -void GDBRemoteRegisterContext::AArch64Reconfigure() { - assert(m_reg_info_sp); - - // Once we start to re

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
@@ -373,14 +374,8 @@ bool GDBRemoteRegisterContext::WriteRegisterBytes(const RegisterInfo *reg_info, if (dst == nullptr) return false; - // Code below is specific to AArch64 target in SVE or SME state - // If vector granule (vg) register is being written then thread's

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: This got rebased to include https://github.com/llvm/llvm-project/pull/70914 so there is just 1 commit now. Comments probably got shuffled so feel free to repeat anything I missed. https://github.com/llvm/llvm-project/pull/70950 _

[Lldb-commits] [libc] [clang] [lld] [clang-tools-extra] [flang] [libcxx] [llvm] [lldb] [compiler-rt] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-11-02 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/70349 >From 7329f68092d5f8f5a5978e5a6cbad6ada87d4fe8 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 26 Oct 2023 16:09:25 +0300 Subject: [PATCH 1/6] [clang][NFC] Annotate `Type` bit-fields with `clang::pr

[Lldb-commits] [libc] [clang] [lld] [clang-tools-extra] [flang] [libcxx] [llvm] [lldb] [compiler-rt] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-11-02 Thread Vlad Serebrennikov via lldb-commits
@@ -49,7 +49,7 @@ struct ExprDependenceScope { using ExprDependence = ExprDependenceScope::ExprDependence; struct TypeDependenceScope { - enum TypeDependence : uint8_t { + enum TypeDependence : unsigned { Endilll wrote: I reverted changes to underlying type

[Lldb-commits] [lldb] [DRAFT][lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/71004 >From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 1 Nov 2023 12:25:06 + Subject: [PATCH] [lldb][DWARFASTParserClang] Fetch constant value from variable

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/71004 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/71004 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/71004 >From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 1 Nov 2023 12:25:06 + Subject: [PATCH 1/2] [lldb][DWARFASTParserClang] Fetch constant value from varia

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Michael Buch via lldb-commits
Michael137 wrote: @clayborg what are your thoughts on this? This could be a way to continue supporting static inline members in the expression evaluator without having the constant on the declaration DIE. https://github.com/llvm/llvm-project/pull/71004 _

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/71004 >From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 1 Nov 2023 12:25:06 + Subject: [PATCH 1/3] [lldb][DWARFASTParserClang] Fetch constant value from varia

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/71004 >From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 1 Nov 2023 12:25:06 + Subject: [PATCH 1/4] [lldb][DWARFASTParserClang] Fetch constant value from varia

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/71004 >From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 1 Nov 2023 12:25:06 + Subject: [PATCH 1/5] [lldb][DWARFASTParserClang] Fetch constant value from varia

[Lldb-commits] [llvm] [mlir] [libcxx] [clang] [lldb] [flang] [Flang][OpenMP] Port openmp threadprivate-use-association.f90 test to HLFIR flow (PR #71043)

2023-11-02 Thread Kiran Chandramohan via lldb-commits
https://github.com/kiranchandramohan approved this pull request. LG. Thanks. https://github.com/llvm/llvm-project/pull/71043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 7d77bbef4ad9230f6f427649373fe46a668aa909 5a37a703cd7c44bf9ecdfdfb77491ce9a18a4a72 --

[Lldb-commits] [llvm] [clang-tools-extra] [lld] [libc] [clang] [libcxx] [lldb] [compiler-rt] [flang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-11-02 Thread Aaron Ballman via lldb-commits
https://github.com/AaronBallman approved this pull request. LGTM aside from a nit with the new macro (feel free to fix when landing). https://github.com/llvm/llvm-project/pull/70349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lld] [compiler-rt] [flang] [libcxx] [llvm] [libc] [clang] [clang-tools-extra] [lldb] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-11-02 Thread Aaron Ballman via lldb-commits
@@ -569,4 +569,12 @@ void AnnotateIgnoreWritesEnd(const char *file, int line); #define LLVM_NO_PROFILE_INSTRUMENT_FUNCTION #endif +/// \macro LLVM_PREFERRED_TYPE +/// Adjust type of bit-field in debug info. +#if __has_attribute(preferred_type) AaronBallman wro

[Lldb-commits] [libcxx] [flang] [compiler-rt] [clang] [lld] [lldb] [llvm] [libc] [clang-tools-extra] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-11-02 Thread Aaron Ballman via lldb-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/70349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/71004 >From a3d165aa30e8cd32877f30812b41fee380e24e60 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 1 Nov 2023 12:25:06 + Subject: [PATCH 1/6] [lldb][DWARFASTParserClang] Fetch constant value from varia

[Lldb-commits] [llvm] [clang-tools-extra] [lldb] [libc] [clang] [libcxx] [lld] [flang] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-02 Thread Erich Keane via lldb-commits
@@ -0,0 +1,14 @@ +// RUN: %clang -S -### -fopenacc %s 2>&1 | FileCheck %s --check-prefix=CHECK-DRIVER +// CHECK-DRIVER: "-cc1" {{.*}} "-fopenacc" erichkeane wrote: At the moment, there should be no problem with them co-existing. Kernels can be separately gener

[Lldb-commits] [llvm] [libcxx] [libc] [flang] [clang] [lldb] [clang-tools-extra] [lld] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-02 Thread Erich Keane via lldb-commits
@@ -1342,6 +1342,15 @@ def err_opencl_logical_exclusive_or : Error< def err_openclcxx_virtual_function : Error< "virtual functions are not supported in C++ for OpenCL">; +// OpenACC Support. +def warn_pragma_acc_ignored : Warning< + "unexpected '#pragma acc ...' in program"

[Lldb-commits] [llvm] [compiler-rt] [libcxx] [libc] [flang] [clang] [lldb] [clang-tools-extra] [lld] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-11-02 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/70349 >From 7329f68092d5f8f5a5978e5a6cbad6ada87d4fe8 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 26 Oct 2023 16:09:25 +0300 Subject: [PATCH 1/7] [clang][NFC] Annotate `Type` bit-fields with `clang::pr

[Lldb-commits] [lld] [clang] [clang-tools-extra] [flang] [libcxx] [llvm] [libc] [lldb] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-02 Thread Erich Keane via lldb-commits
@@ -605,6 +605,17 @@ static void InitializeStandardPredefinedMacros(const TargetInfo &TI, Builder.defineMacro("HIP_API_PER_THREAD_DEFAULT_STREAM"); } } + + if (LangOpts.OpenACC) { +// FIXME: When we have full support for OpenACC, we should set this to the +

[Lldb-commits] [llvm] [lld] [libc] [libcxx] [flang] [clang-tools-extra] [clang] [lldb] [OpenACC] Initial commits to support OpenACC (PR #70234)

2023-11-02 Thread Erich Keane via lldb-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/70234 >From b3d64b3f744ccb37e334e3aae8d6874cd8391c56 Mon Sep 17 00:00:00 2001 From: erichkeane Date: Mon, 23 Oct 2023 11:09:11 -0700 Subject: [PATCH 1/6] [OpenACC] Initial commit for OpenACC Support This is the ini

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Kevin Frei via lldb-commits
@@ -4892,6 +4894,21 @@ void TargetProperties::SetDebugUtilityExpression(bool debug) { SetPropertyAtIndex(idx, debug); } +Args TargetProperties::GetDebugInfoDURLs() const { + Args urls; + m_collection_sp->GetPropertyAtIndexAsArgs(ePropertyDebugInfoDURLs, urls); + return u

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Kevin Frei via lldb-commits
@@ -4892,6 +4894,21 @@ void TargetProperties::SetDebugUtilityExpression(bool debug) { SetPropertyAtIndex(idx, debug); } +Args TargetProperties::GetDebugInfoDURLs() const { + Args urls; + m_collection_sp->GetPropertyAtIndexAsArgs(ePropertyDebugInfoDURLs, urls); + return u

[Lldb-commits] [flang] [clang] [libcxx] [mlir] [lldb] [llvm] [Flang][OpenMP] Port openmp threadprivate-use-association.f90 test to HLFIR flow (PR #71043)

2023-11-02 Thread chandan singh via lldb-commits
https://github.com/chandankds closed https://github.com/llvm/llvm-project/pull/71043 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: Apparently I didn't submit the last set of review comments sorry about that. The one about vector is the key one this time. https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -0,0 +1,31 @@ +UNSUPPORTED: system-windows + +# RUN: %clang_host -g %S/Inputs/main.c -o %t DavidSpickett wrote: If you can, a test where the regular expression matches at the very end of the name would be a good addition. This would check the tail end of you

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
DavidSpickett wrote: Oh and good work on the updates! (because that feedback is probably hard to see with all these comments :) ) https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -1,6 +1,7 @@ # RUN: yaml2obj %S/Inputs/symbols.yaml -o %t # RUN: %lldb %t -b -o "target modules lookup -A -r -s some" | FileCheck %s -DMODULE=%basename_t.tmp --implicit-check-not ignoreThisFunction + DavidSpickett wrote: Undo the unrelated changes in this

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -1506,13 +1514,50 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/69422 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -247,7 +247,17 @@ class Address { bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, DumpStyle fallback_style = DumpStyleInvalid, uint32_t addr_byte_size = UINT32_MAX, -bool all_ranges = false) const; +bo

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -1506,13 +1514,50 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -0,0 +1,31 @@ +UNSUPPORTED: system-windows + +# RUN: %clang_host -g %S/Inputs/main.c -o %t +# RUN: %lldb %t -b -o 'settings set use-color true' -o 'image lookup -r -s ma' | FileCheck %s --check-prefix CHECK1 + +# CHECK1: 3 symbols match the regular expression 'ma' in {{.*}} +#

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -0,0 +1,31 @@ +UNSUPPORTED: system-windows + +# RUN: %clang_host -g %S/Inputs/main.c -o %t DavidSpickett wrote: Also just for sanity checking, add one where you don't match anything at all. It shouldn't do any matching or even attempt to, so the test would ju

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -247,7 +247,17 @@ class Address { bool Dump(Stream *s, ExecutionContextScope *exe_scope, DumpStyle style, DumpStyle fallback_style = DumpStyleInvalid, uint32_t addr_byte_size = UINT32_MAX, -bool all_ranges = false) const; +bo

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -0,0 +1,31 @@ +UNSUPPORTED: system-windows + +# RUN: %clang_host -g %S/Inputs/main.c -o %t +# RUN: %lldb %t -b -o 'settings set use-color true' -o 'image lookup -r -s ma' | FileCheck %s --check-prefix CHECK1 + +# CHECK1: 3 symbols match the regular expression 'ma' in {{.*}} +#

[Lldb-commits] [lldb] [lldb][AArch64] Read SME2's ZT0 register from Linux core files (PR #70934)

2023-11-02 Thread David Spickett via lldb-commits
@@ -339,6 +337,18 @@ bool RegisterContextCorePOSIX_arm64::ReadRegister(const RegisterInfo *reg_info, value.SetFromMemoryData(*reg_info, src + sizeof(sve::user_za_header), reg_info->byte_size, lldb::eByteOrderLittle,

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -1506,13 +1514,50 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] 0d0ca51 - [lldb][AArch64] Read SME2's ZT0 register from Linux core files (#70934)

2023-11-02 Thread via lldb-commits
Author: David Spickett Date: 2023-11-02T15:56:46Z New Revision: 0d0ca51ffe1002cec3b1b7a332e290176b650390 URL: https://github.com/llvm/llvm-project/commit/0d0ca51ffe1002cec3b1b7a332e290176b650390 DIFF: https://github.com/llvm/llvm-project/commit/0d0ca51ffe1002cec3b1b7a332e290176b650390.diff LOG

[Lldb-commits] [lldb] [lldb][AArch64] Read SME2's ZT0 register from Linux core files (PR #70934)

2023-11-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/70934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang-tools-extra] [llvm] [clang] [lldb] [flang] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

2023-11-02 Thread Markos Horro via lldb-commits
https://github.com/markoshorro ready_for_review https://github.com/llvm/llvm-project/pull/71072 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -1506,13 +1514,50 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] [lldb][AArch64] Read SME2's ZT0 register from Linux core files (PR #70934)

2023-11-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/70934 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/71004 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Adrian Prantl via lldb-commits
@@ -373,6 +373,17 @@ class DWARFASTParserClang : public lldb_private::plugin::dwarf::DWARFASTParser { lldb_private::CompilerType &class_clang_type, const lldb::AccessType default_accesibility, lldb_private::C

[Lldb-commits] [clang-tools-extra] [llvm] [clang] [lldb] [flang] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

2023-11-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-transforms Author: Markos Horro (markoshorro) Changes The same idea as in 34d380e1f63a7e2cdb9ab1e6498f727fcd710a14, but for truncation instructions. Improvement for #59633. --- Full diff: https://github.com/llvm/llvm-project/pull/71072.diff 2 Fi

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Kevin Frei via lldb-commits
https://github.com/kevinfrei edited https://github.com/llvm/llvm-project/pull/70996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [clang] [clang-tools-extra] [lldb] [flang] [IndVars] Add check of loop invariant for trunc instructions (PR #71072)

2023-11-02 Thread Markos Horro via lldb-commits
https://github.com/markoshorro created https://github.com/llvm/llvm-project/pull/71072 The same idea as in 34d380e1f63a7e2cdb9ab1e6498f727fcd710a14, but for truncation instructions. Improvement for #59633. >From 0c5299adb30888aa0dfd7c3106547a69606d5ab1 Mon Sep 17 00:00:00 2001 From: Marcos Hor

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Kevin Frei via lldb-commits
kevinfrei wrote: > First off, thank you for working on this. `debuginfod` has been on my radar > since support was added to LLVM and I was curious at which point someone was > going to add support for it to LLDB. I wasn't super familiar with what > exactly it provides, and in case others here

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Kevin Frei via lldb-commits
@@ -396,8 +398,22 @@ Symbols::LocateExecutableSymbolFile(const ModuleSpec &module_spec, } } } - - return LocateExecutableSymbolFileDsym(module_spec); + FileSpec dsym_bundle = LocateExecutableSymbolFileDsym(module_spec); + if (dsym_bundle) +return dsym_bundle

[Lldb-commits] [lldb] [lldb][docs] Update reference to test directory location (PR #71081)

2023-11-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Chelsea Cassanova (chelcassanova) Changes The instructions for running single tests in the LLDB test suite used an older directory structure from before the LLVM project became a monorepo. This commit updates the references to these direct

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Fetch constant value from variable defintion if available (PR #71004)

2023-11-02 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/71004 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [llvm] [lldb] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Kevin Frei via lldb-commits
https://github.com/kevinfrei edited https://github.com/llvm/llvm-project/pull/70996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update reference to test directory location (PR #71081)

2023-11-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/71081 The instructions for running single tests in the LLDB test suite used an older directory structure from before the LLVM project became a monorepo. This commit updates the references to these directories.

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -1506,13 +1514,50 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [flang] [compiler-rt] [libc] [llvm] [lldb] [lld] [libcxx] [clang-tools-extra] [clang] [clang][NFC] Annotate `Type` bit-fields with `clang::preferred_type` (PR #70349)

2023-11-02 Thread Vlad Serebrennikov via lldb-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/70349 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-11-02 Thread David Spickett via lldb-commits
@@ -1506,13 +1514,50 @@ static bool LookupAddressInModule(CommandInterpreter &interpreter, Stream &strm, ExecutionContextScope *exe_scope = interpreter.GetExecutionContext().GetBestExecutionContextScope(); -DumpAddress(exe_scope, so_addr, verbose, all_ranges,

[Lldb-commits] [lldb] d483abd - [lldb][docs] Update reference to test directory location (#71081)

2023-11-02 Thread via lldb-commits
Author: Chelsea Cassanova Date: 2023-11-02T10:35:42-07:00 New Revision: d483abd0fdd032c4169f8fcaedd2bc63986f7a40 URL: https://github.com/llvm/llvm-project/commit/d483abd0fdd032c4169f8fcaedd2bc63986f7a40 DIFF: https://github.com/llvm/llvm-project/commit/d483abd0fdd032c4169f8fcaedd2bc63986f7a40.d

[Lldb-commits] [lldb] [lldb][docs] Update reference to test directory location (PR #71081)

2023-11-02 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/71081 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > Yes, that specific kind of refactoring seemed like a good idea, but given > that this is my first real foray into the LLDB space, I didn't want to bite > off that much work to start with. I'd be happy to help with that and I'm sure @clayborg wouldn't mind providing guid

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Kevin Frei via lldb-commits
@@ -48,6 +48,7 @@ add_lldb_library(lldbSymbol NO_PLUGIN_DEPENDENCIES lldbHost lldbTarget lldbUtility +LLVMDebuginfod kevinfrei wrote: `LINK_COMPONENTS` gets added to targets all over the place. The library is only used in this particular targe

[Lldb-commits] [lldb] [llvm] DEBUGINFOD based DWP acquisition for LLDB (PR #70996)

2023-11-02 Thread Kevin Frei via lldb-commits
https://github.com/kevinfrei updated https://github.com/llvm/llvm-project/pull/70996 >From 6454d4fb652f61a20850c75f0e69759dffe28511 Mon Sep 17 00:00:00 2001 From: Kevin Frei Date: Wed, 18 Oct 2023 14:37:34 -0700 Subject: [PATCH 1/2] DEBUGINFOD based DWP acquisition for LLDB Summary: I've plumb

[Lldb-commits] [lldb] [lldb][AArch64] Move register info reconfigure into architecture plugin (PR #70950)

2023-11-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/70950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][split-dwarf] Add --errors-only argument separate-debug-info list (PR #71000)

2023-11-02 Thread Tom Yang via lldb-commits
@@ -445,7 +445,11 @@ class SymbolFile : public PluginInterface { /// contains the keys "type", "symfile", and "separate-debug-info-files". /// "type" can be used to assume the structure of each object in /// "separate-debug-info-files". - virtual bool GetSepa

[Lldb-commits] [lldb] [lldb][split-dwarf] Add --errors-only argument separate-debug-info list (PR #71000)

2023-11-02 Thread Alex Langford via lldb-commits
@@ -445,7 +445,11 @@ class SymbolFile : public PluginInterface { /// contains the keys "type", "symfile", and "separate-debug-info-files". /// "type" can be used to assume the structure of each object in /// "separate-debug-info-files". - virtual bool GetSepa

[Lldb-commits] [lldb] [lldb][docs] Update reference to test directory location (PR #71081)

2023-11-02 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: LGTM! Thanks! https://github.com/llvm/llvm-project/pull/71081 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update reference to test directory location (PR #71081)

2023-11-02 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/71081 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][docs] Update reference to test directory location (PR #71081)

2023-11-02 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/71081 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][split-dwarf] Add --errors-only argument separate-debug-info list (PR #71000)

2023-11-02 Thread Tom Yang via lldb-commits
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/71000 >From c6900333c54d1c3f5dd3e6a88f0627b65ff0efca Mon Sep 17 00:00:00 2001 From: Tom Yang Date: Wed, 1 Nov 2023 00:53:19 -0700 Subject: [PATCH 1/3] [lldb] Add --errors-only argument separate-debug-info list --- lldb

[Lldb-commits] [libunwind] [compiler-rt] [lldb] [flang] [clang] [lld] [clang-tools-extra] [libcxx] [libc] [llvm] Test pr (PR #71086)

2023-11-02 Thread Zahira Ammarguellat via lldb-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/71086 None >From 340e3777509f70b5b300adcb181261e84247cf1a Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Mon, 23 Oct 2023 12:51:21 -0700 Subject: [PATCH 1/4] Revert "[clang] Support fixed point types in C++ (#677

[Lldb-commits] [lldb] [lldb][split-dwarf] Add --errors-only argument separate-debug-info list (PR #71000)

2023-11-02 Thread Alex Langford via lldb-commits
@@ -445,7 +445,11 @@ class SymbolFile : public PluginInterface { /// contains the keys "type", "symfile", and "separate-debug-info-files". /// "type" can be used to assume the structure of each object in /// "separate-debug-info-files". - virtual bool GetSepa

[Lldb-commits] [lldb] [lldb][windows] Export dwarf plugin symbols in LLDB_EXPORT_ALL_SYMBOLS (PR #71087)

2023-11-02 Thread River Riddle via lldb-commits
https://github.com/River707 created https://github.com/llvm/llvm-project/pull/71087 These are already exported in non-windows builds, they aren't in the msvc path because we explicitly limit the symbols exported to prevent hitting the symbol export limit. These symbols are useful for downstre

[Lldb-commits] [lldb] [lldb][windows] Export dwarf plugin symbols in LLDB_EXPORT_ALL_SYMBOLS (PR #71087)

2023-11-02 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: River Riddle (River707) Changes These are already exported in non-windows builds, they aren't in the msvc path because we explicitly limit the symbols exported to prevent hitting the symbol export limit. These symbols are useful for downs

[Lldb-commits] [lldb] [lldb][windows] Export dwarf plugin symbols in LLDB_EXPORT_ALL_SYMBOLS (PR #71087)

2023-11-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord requested changes to this pull request. https://github.com/llvm/llvm-project/pull/71087 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][windows] Export dwarf plugin symbols in LLDB_EXPORT_ALL_SYMBOLS (PR #71087)

2023-11-02 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/71087 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][windows] Export dwarf plugin symbols in LLDB_EXPORT_ALL_SYMBOLS (PR #71087)

2023-11-02 Thread Alex Langford via lldb-commits
@@ -196,13 +196,15 @@ elseif (LLDB_EXPORT_ALL_SYMBOLS) MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces") # Pull out the various lldb libraries linked into liblldb, these will be used - # when looking for symbols to extract.

[Lldb-commits] [lldb] [lldb][windows] Export dwarf plugin symbols in LLDB_EXPORT_ALL_SYMBOLS (PR #71087)

2023-11-02 Thread River Riddle via lldb-commits
@@ -196,13 +196,15 @@ elseif (LLDB_EXPORT_ALL_SYMBOLS) MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces") # Pull out the various lldb libraries linked into liblldb, these will be used - # when looking for symbols to extract.

[Lldb-commits] [lldb] [lldb][split-dwarf] Add --errors-only argument separate-debug-info list (PR #71000)

2023-11-02 Thread Tom Yang via lldb-commits
https://github.com/zhyty closed https://github.com/llvm/llvm-project/pull/71000 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9e0a5be - [lldb][split-dwarf] Add --errors-only argument separate-debug-info list (#71000)

2023-11-02 Thread via lldb-commits
Author: Tom Yang Date: 2023-11-02T11:36:24-07:00 New Revision: 9e0a5be0de320e29226225b6e466474c031d9ca6 URL: https://github.com/llvm/llvm-project/commit/9e0a5be0de320e29226225b6e466474c031d9ca6 DIFF: https://github.com/llvm/llvm-project/commit/9e0a5be0de320e29226225b6e466474c031d9ca6.diff LOG:

[Lldb-commits] [lldb] [lldb][windows] Export dwarf plugin symbols in LLDB_EXPORT_ALL_SYMBOLS (PR #71087)

2023-11-02 Thread Walter Erquinigo via lldb-commits
@@ -196,13 +196,15 @@ elseif (LLDB_EXPORT_ALL_SYMBOLS) MESSAGE("-- Symbols (liblldb): exporting all symbols from the lldb and lldb_private namespaces") # Pull out the various lldb libraries linked into liblldb, these will be used - # when looking for symbols to extract.

[Lldb-commits] [lldb] [lldb][windows] Export dwarf plugin symbols in LLDB_EXPORT_ALL_SYMBOLS (PR #71087)

2023-11-02 Thread Walter Erquinigo via lldb-commits
https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/71087 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][windows] Export dwarf plugin symbols in LLDB_EXPORT_ALL_SYMBOLS (PR #71087)

2023-11-02 Thread River Riddle via lldb-commits
https://github.com/River707 updated https://github.com/llvm/llvm-project/pull/71087 >From 7201d6d99c22450681b9f788e5fe1833d50ab7c4 Mon Sep 17 00:00:00 2001 From: River Riddle Date: Thu, 2 Nov 2023 11:12:18 -0700 Subject: [PATCH] [lldb][windows] All exporting plugin symbols in LLDB_EXPORT_ALL_S

  1   2   >