[Lldb-commits] [lldb] [lldb][AArch64][Linux] Rename IsEnabled to IsPresent (PR #70303)

2023-10-30 Thread David Spickett via lldb-commits
DavidSpickett wrote: Unless there are objections this is going in end of today. https://github.com/llvm/llvm-project/pull/70303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/70639 When an LLDB user asks for the value of a static data member, LLDB starts by searching the Names accelerator table for the corresponding variable definition DIE. For static data members with out-of-class defini

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
Michael137 wrote: Summing the size of all *.o files in my local debug Clang build increased by `0.7%` with this patch https://github.com/llvm/llvm-project/pull/70639 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 ready_for_review https://github.com/llvm/llvm-project/pull/70639 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Michael Buch (Michael137) Changes When an LLDB user asks for the value of a static data member, LLDB starts by searching the Names accelerator table for the corresponding variable definition DIE. For static data members with out-of-class de

[Lldb-commits] [lldb] [lldb][test] Add FindGlobalVariables tests for C++ constexpr static data members (PR #70641)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/70641 Tests that LLDB can find inline static data members. Relies on the debug-info change in: https://github.com/llvm/llvm-project/pull/70639 >From 7de2335efd85ae6058705a6a6cd9c5b160aef757 Mon Sep 17 00:00:00 200

[Lldb-commits] [lldb] [lldb][test] Add FindGlobalVariables tests for C++ constexpr static data members (PR #70641)

2023-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Tests that LLDB can find inline static data members. Relies on the debug-info change in: https://github.com/llvm/llvm-project/pull/70639 --- Full diff: https://github.com/llvm/llvm-project/pull/70641.diff

[Lldb-commits] [lldb] [lldb][test] Add FindGlobalVariables tests for C++ constexpr static data members (PR #70641)

2023-10-30 Thread Michael Buch via lldb-commits
@@ -113,6 +113,37 @@ def test_class_with_only_const_static(self): self.expect_expr("ClassWithOnlyConstStatic::member", result_value="3") +def check_global_var(self, name: str, expect_type, expect_val): +var_list = self.target().FindGlobalVariables(name, ll

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a902ca66428164b4f11dedf1c551393add511271 e3ae0862dd834ca54a096b3154bbbcc5a627014f --

[Lldb-commits] [lldb] [lldb][test] Add FindGlobalVariables tests for C++ inline static data members (PR #70641)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/70641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][test] Add FindGlobalVariables tests for C++ inline static data members (PR #70641)

2023-10-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r a902ca66428164b4f11dedf1c551393add511271..7de2335efd85ae6058705a6a6cd9c5b160aef757 lldb/

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70551)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/70551 >From e02939572877cdc839894454a6fab36ab143d924 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 27 Oct 2023 16:33:07 +0100 Subject: [PATCH 1/4] [clang][DebugInfo][NFC] Add createConstantValueExpression

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/70639 >From cbae5425ac00e3cb597827e4b6c402446cc40d9d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 27 Oct 2023 16:33:07 +0100 Subject: [PATCH 1/3] [clang][DebugInfo][NFC] Add createConstantValueExpression

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/70639 >From cbae5425ac00e3cb597827e4b6c402446cc40d9d Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 27 Oct 2023 16:33:07 +0100 Subject: [PATCH 1/4] [clang][DebugInfo][NFC] Add createConstantValueExpression

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70551)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/70551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-10-30 Thread via lldb-commits
taalhaataahir0102 wrote: Hi David! I've done the following: 1. Used regex search in the `printRed` format function instead of sub string search. 2. Used ANSI function which you mentioned above https://github.com/llvm/llvm-project/blob/cbbb545c4618969850d88bb008ab7f1c2918d5c3/lldb/include/lldb/U

[Lldb-commits] [lldb] [lldb] Adapt code to Python 3.13 (PR #70445)

2023-10-30 Thread Tulio Magno Quites Machado Filho via lldb-commits
https://github.com/tuliom closed https://github.com/llvm/llvm-project/pull/70445 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] b2929be - [lldb] Adapt code to Python 3.13 (#70445)

2023-10-30 Thread via lldb-commits
Author: Tulio Magno Quites Machado Filho Date: 2023-10-30T08:55:34-03:00 New Revision: b2929bebb6ce8d75acab4f2fde43213673cb6010 URL: https://github.com/llvm/llvm-project/commit/b2929bebb6ce8d75acab4f2fde43213673cb6010 DIFF: https://github.com/llvm/llvm-project/commit/b2929bebb6ce8d75acab4f2fde4

[Lldb-commits] [lldb] Colorize output when searching for symbols in lldb (PR #69422)

2023-10-30 Thread David Spickett via lldb-commits
DavidSpickett wrote: > Can you please confirm if passing the pointer to CommandInterpreter object in > PrintRed function to get the use-color options a good idea? Yes but it can be better :) See my comments. > Are the test cases good enough and also does the future plan sounds Okay? I suggest

[Lldb-commits] [lldb] [sanitizer][msan] fix AArch64 vararg support for KMSAN (PR #70659)

2023-10-30 Thread Alexander Potapenko via lldb-commits
https://github.com/ramosian-glider created https://github.com/llvm/llvm-project/pull/70659 Cast StackSaveAreaPtr, GrRegSaveAreaPtr, VrRegSaveAreaPtr to pointers to fix assertions in getShadowOriginPtrKernel(). Fixes: https://github.com/llvm/llvm-project/issues/69738 Patch by Mark Johnston. >

[Lldb-commits] [lldb] [sanitizer][msan] fix AArch64 vararg support for KMSAN (PR #70659)

2023-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Alexander Potapenko (ramosian-glider) Changes Cast StackSaveAreaPtr, GrRegSaveAreaPtr, VrRegSaveAreaPtr to pointers to fix assertions in getShadowOriginPtrKernel(). Fixes: https://github.com/llvm/llvm-project/issues/69738

[Lldb-commits] [lldb] [sanitizer][msan] fix AArch64 vararg support for KMSAN (PR #70659)

2023-10-30 Thread Alexander Potapenko via lldb-commits
https://github.com/ramosian-glider closed https://github.com/llvm/llvm-project/pull/70659 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [AMDGPU] Select 64-bit imm moves if can be encoded as 32 bit operand (PR #70395)

2023-10-30 Thread Stanislav Mekhanoshin via lldb-commits
https://github.com/rampitec closed https://github.com/llvm/llvm-project/pull/70395 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread via lldb-commits
https://github.com/nmustakin updated https://github.com/llvm/llvm-project/pull/70667 >From 153c6d812939cd23bb71e53c71378117ed5b23c7 Mon Sep 17 00:00:00 2001 From: Nafis Mustakin Date: Mon, 30 Oct 2023 07:50:59 -0700 Subject: [PATCH] Add memory diff dump for kernel record-replay --- .../Plugin

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6a62707c048e16ce9bad37ed8e3520799139436b 153c6d812939cd23bb71e53c71378117ed5b23c7 --

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread Shilei Tian via lldb-commits
@@ -274,7 +317,7 @@ struct RecordReplayTy { void saveKernelOutputInfo(const char *Name) { SmallString<128> OutputFilename = { Name, (isRecording() ? ".original.output" : ".replay.output")}; -dumpDeviceMemory(OutputFilename); +dumpDeviceMemory(OutputFilenam

[Lldb-commits] [lldb] bb9dced - [lldb][AArch64][Linux] Rename IsEnabled to IsPresent (#70303)

2023-10-30 Thread via lldb-commits
Author: David Spickett Date: 2023-10-30T15:45:40Z New Revision: bb9dced2d3b479fc47221a25eae496f15c573c3c URL: https://github.com/llvm/llvm-project/commit/bb9dced2d3b479fc47221a25eae496f15c573c3c DIFF: https://github.com/llvm/llvm-project/commit/bb9dced2d3b479fc47221a25eae496f15c573c3c.diff LOG

[Lldb-commits] [lldb] [lldb][AArch64][Linux] Rename IsEnabled to IsPresent (PR #70303)

2023-10-30 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/70303 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
Michael137 wrote: This could also help with the type merging issues discussed in https://github.com/llvm/llvm-project/pull/68721#issuecomment-1764685418 https://github.com/llvm/llvm-project/pull/70639 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/70639 >From 18db082fc5008283f77cc98d9c733a47c63b7096 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 27 Oct 2023 16:19:47 +0100 Subject: [PATCH 1/3] [clang][DebugInfo] Emit global variable definitions for st

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread via lldb-commits
https://github.com/nmustakin updated https://github.com/llvm/llvm-project/pull/70667 >From 153c6d812939cd23bb71e53c71378117ed5b23c7 Mon Sep 17 00:00:00 2001 From: Nafis Mustakin Date: Mon, 30 Oct 2023 07:50:59 -0700 Subject: [PATCH 1/2] Add memory diff dump for kernel record-replay --- .../Pl

[Lldb-commits] [lldb] [lldb][Test] TestDataFormatterLibcxxChrono.py: skip test on older clang versions (PR #70544)

2023-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/70544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread Giorgis Georgakoudis via lldb-commits
ggeorgakoudis wrote: @nmustakin What's the use-case/motivation for this patch? https://github.com/llvm/llvm-project/pull/70667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread via lldb-commits
avl-llvm wrote: Should not we remove constant initializer from the type definition if we have a DW_TAG_variable with a DW_AT_const_value now? ``` 0x008d: DW_TAG_member DW_AT_name("i") DW_AT_type(0x0062 "const int") DW_AT_

[Lldb-commits] [lldb] Fix the DEVELOPER_DIR computation (PR #70528)

2023-10-30 Thread Adrian Prantl via lldb-commits
@@ -461,13 +461,11 @@ static void ParseOSVersion(llvm::VersionTuple &version, NSString *Key) { // Invoke xcrun with the shlib dir. if (FileSpec fspec = HostInfo::GetShlibDir()) { if (FileSystem::Instance().Exists(fspec)) { -std::string contents_dir = -

[Lldb-commits] [lldb] c42b640 - Fix the DEVELOPER_DIR computation (#70528)

2023-10-30 Thread via lldb-commits
Author: Adrian Prantl Date: 2023-10-30T10:00:40-07:00 New Revision: c42b640208aa74c65cef5943bc05522780a72723 URL: https://github.com/llvm/llvm-project/commit/c42b640208aa74c65cef5943bc05522780a72723 DIFF: https://github.com/llvm/llvm-project/commit/c42b640208aa74c65cef5943bc05522780a72723.diff

[Lldb-commits] [lldb] Fix the DEVELOPER_DIR computation (PR #70528)

2023-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/70528 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c3f7ca7 - [lldb][Test] TestDataFormatterLibcxxChrono.py: skip test on older clang versions (#70544)

2023-10-30 Thread via lldb-commits
Author: Michael Buch Date: 2023-10-30T17:08:25Z New Revision: c3f7ca78101b77fa522f059af520526ff878a5b0 URL: https://github.com/llvm/llvm-project/commit/c3f7ca78101b77fa522f059af520526ff878a5b0 DIFF: https://github.com/llvm/llvm-project/commit/c3f7ca78101b77fa522f059af520526ff878a5b0.diff LOG:

[Lldb-commits] [lldb] [lldb][Test] TestDataFormatterLibcxxChrono.py: skip test on older clang versions (PR #70544)

2023-10-30 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/70544 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread via lldb-commits
nmustakin wrote: @ggeorgakoudis To reduce the memory consumption for kernel tuning using record/replay. https://github.com/llvm/llvm-project/pull/70667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread via lldb-commits
https://github.com/nmustakin edited https://github.com/llvm/llvm-project/pull/70667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [Release] Build compiler-rt during Phase 1 on AIX (PR #70672)

2023-10-30 Thread via lldb-commits
https://github.com/azhan92 updated https://github.com/llvm/llvm-project/pull/70672 >From 691672671fb29bf8e98df22444c428f1392798be Mon Sep 17 00:00:00 2001 From: Alison Zhang Date: Mon, 30 Oct 2023 11:27:43 -0400 Subject: [PATCH] build clang-rt on AIX --- llvm/utils/release/test-release.sh | 6

[Lldb-commits] [lldb] [Release] Build compiler-rt during Phase 1 on AIX (PR #70672)

2023-10-30 Thread David Tenty via lldb-commits
@@ -1,4 +1,4 @@ -#!/usr/bin/env bash +u!/usr/bin/env bash daltenty wrote: Unintended typo? https://github.com/llvm/llvm-project/pull/70672 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.o

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread via lldb-commits
https://github.com/nmustakin updated https://github.com/llvm/llvm-project/pull/70667 >From 153c6d812939cd23bb71e53c71378117ed5b23c7 Mon Sep 17 00:00:00 2001 From: Nafis Mustakin Date: Mon, 30 Oct 2023 07:50:59 -0700 Subject: [PATCH 1/3] Add memory diff dump for kernel record-replay --- .../Pl

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread Giorgis Georgakoudis via lldb-commits
ggeorgakoudis wrote: > @ggeorgakoudis To reduce the memory consumption for kernel tuning using > record/replay. I do not see this so much about saving memory consumption but more as saving disk space. Makes sense to me this way, will review shortly. https://github.com/llvm/llvm-project/pull/7

[Lldb-commits] [lldb] [openmp] Add memory diff dump for kernel record-replay (PR #70667)

2023-10-30 Thread via lldb-commits
https://github.com/nmustakin edited https://github.com/llvm/llvm-project/pull/70667 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread David Blaikie via lldb-commits
@@ -0,0 +1,87 @@ +// RUN: %clangxx -target arm64-apple-macosx11.0.0 -g %s -emit-llvm -S -o - | FileCheck --check-prefixes=CHECK %s + +enum class Enum : int { + VAL = -1 +}; + +struct Empty {}; + +constexpr auto func() { return 25; } + +struct Foo { +static constexpr int cexp

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread David Blaikie via lldb-commits
dwblaikie wrote: > Should not we remove constant initializer from the type definition if we have > a DW_TAG_variable with a DW_AT_const_value now? Yep, +1 to this. This is where the type normalization benefit would come from - no longer having this const value on the member declaration, but on

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread David Blaikie via lldb-commits
dwblaikie wrote: > Summing the size of all *.o files in my local debug Clang build increased by > 0.7% with this patch That's a bit significant. Any chance you could get a per-section breakdown/growth on that? (& exact flags - is this with compressed debug info, for instance? Or not?) I use `

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
Michael137 wrote: > > Should not we remove constant initializer from the type definition if we > > have a DW_TAG_variable with a DW_AT_const_value now? > > Yep, +1 to this. This is where the type normalization benefit would come from > - no longer having this const value on the member declarat

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread David Blaikie via lldb-commits
dwblaikie wrote: > > > Should not we remove constant initializer from the type definition if we > > > have a DW_TAG_variable with a DW_AT_const_value now? > > > > > > Yep, +1 to this. This is where the type normalization benefit would come > > from - no longer having this const value on the m

[Lldb-commits] [lldb] [lldb][test] Add FindGlobalVariables tests for C++ inline static data members (PR #70641)

2023-10-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg approved this pull request. This will be great to get it (this PR and the related one). The tests LGTM. https://github.com/llvm/llvm-project/pull/70641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/70351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-30 Thread Greg Clayton via lldb-commits
@@ -614,6 +614,8 @@ class Process : public std::enable_shared_from_this, return error; } + virtual void DidLoadCore() {} clayborg wrote: We could avoid adding the DidLoadCore and re-use the existing Process DidAttach: ``` class Process { ... virtual

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-30 Thread Greg Clayton via lldb-commits
@@ -2668,7 +2655,23 @@ Status Process::LoadCore() { StateAsCString(state)); error.SetErrorString( "Did not get stopped event after loading the core file."); +} else { + DidLoadCore(); clayborg wrote: Call `DidAttach(...

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg commented: Looks good, just a question if we want to use the existing Process::DidAttach() instead of adding a new Process::DidLoadCore() https://github.com/llvm/llvm-project/pull/70351 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] [lldb][test] Add FindGlobalVariables tests for C++ inline static data members (PR #70641)

2023-10-30 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM modulo formatting https://github.com/llvm/llvm-project/pull/70641 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace the usage of module imp with module importlib (PR #70443)

2023-10-30 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: +1, if you can verify that Python 3.6 supports the `importlib` approach we should drop the fallback. https://github.com/llvm/llvm-project/pull/70443 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
@@ -0,0 +1,87 @@ +// RUN: %clangxx -target arm64-apple-macosx11.0.0 -g %s -emit-llvm -S -o - | FileCheck --check-prefixes=CHECK %s + +enum class Enum : int { + VAL = -1 +}; + +struct Empty {}; + +constexpr auto func() { return 25; } + +struct Foo { +static constexpr int cexp

[Lldb-commits] [lldb] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

2023-10-30 Thread Sang Ik Lee via lldb-commits
@@ -54,22 +55,52 @@ void GPUToSPIRVPass::runOnOperation() { SmallVector gpuModules; OpBuilder builder(context); + + auto targetEnvSupportsKernelCapability = [](gpu::GPUModuleOp moduleOp) { +Operation *gpuModule = moduleOp.getOperation(); +auto targetAttr = spirv::

[Lldb-commits] [lldb] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

2023-10-30 Thread Sang Ik Lee via lldb-commits
@@ -108,6 +138,25 @@ void GPUToSPIRVPass::runOnOperation() { if (failed(applyFullConversion(gpuModule, *target, std::move(patterns return signalPassFailure(); } + + // For OpenCL, the gpu.func op in the original gpu.module op needs to be silee2

[Lldb-commits] [lldb] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

2023-10-30 Thread Sang Ik Lee via lldb-commits
https://github.com/silee2 edited https://github.com/llvm/llvm-project/pull/69941 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (PR #70639)

2023-10-30 Thread Michael Buch via lldb-commits
Michael137 wrote: > I use `bloaty` for this ( https://github.com/google/bloaty ) - though it's a > bit involved to do this to sum over all the object files - summing up the > results from per-object file, etc... ``` bloaty `find ./patched-build/lib -name *.o` │ bloaty `find ./no-patch-

[Lldb-commits] [lldb] [MLIR] Update convert-gpu-to-spirv pass to prepare using GPU compilat… (PR #69941)

2023-10-30 Thread Jungwook Park via lldb-commits
@@ -108,6 +138,25 @@ void GPUToSPIRVPass::runOnOperation() { if (failed(applyFullConversion(gpuModule, *target, std::move(patterns return signalPassFailure(); } + + // For OpenCL, the gpu.func op in the original gpu.module op needs to be jungpa

[Lldb-commits] [lldb] Also log the error output from xcrun, if it fails. (PR #70716)

2023-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/70716 In the rare case that an Xcode installation is damaged, this output could contain clues to further diagnose the issue. rdar://117698630 >From 8a3b45751c033483266e91b30af22d5bd8d17e2c Mon Sep 17 00:00:0

[Lldb-commits] [lldb] Also log the error output from xcrun, if it fails. (PR #70716)

2023-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Adrian Prantl (adrian-prantl) Changes In the rare case that an Xcode installation is damaged, this output could contain clues to further diagnose the issue. rdar://117698630 --- Full diff: https://github.com/llvm/llvm-project/pull/7071

[Lldb-commits] [lldb] [lldb] Part 2 of 2 - Refactor `CommandObject::DoExecute(...)` return `void` (not `bool`) (PR #69991)

2023-10-30 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/69991 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-30 Thread Med Ismail Bennani via lldb-commits
@@ -614,6 +614,8 @@ class Process : public std::enable_shared_from_this, return error; } + virtual void DidLoadCore() {} medismailben wrote: Good point! At least for core file process plugins, the `DidAttach` override shouldn't be implemented so we s

[Lldb-commits] [lldb] [lldb] Fix misleading indentiation warning in ScriptInterpreterPython (NFC) (PR #70732)

2023-10-30 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben created https://github.com/llvm/llvm-project/pull/70732 This should silence the "misleading indentiation" warnings introduced by b2929be, by ignoring the flag for that specific chunk of code, if the surrounding if-statement have been compiled out. >From 4b21aec

[Lldb-commits] [lldb] [lldb] Fix misleading indentiation warning in ScriptInterpreterPython (NFC) (PR #70732)

2023-10-30 Thread Med Ismail Bennani via lldb-commits
medismailben wrote: The warning was introduced by #70445 (cc. @tuliom). https://github.com/llvm/llvm-project/pull/70732 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Support target names with dots in more utilities (PR #65812)

2023-10-30 Thread Dan McGregor via lldb-commits
dankm wrote: Sounds good. Everything I want is in the pull request, I'm going to create a new pull request to update some tests as we discussed above. I'll update the description to be a bit more clear. Thanks for all help. https://github.com/llvm/llvm-project/pull/65812 _

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-10-30 Thread via lldb-commits
https://github.com/jimingham created https://github.com/llvm/llvm-project/pull/70734 This allows you to specify options and arguments and their definitions and then have lldb handle the completions, help, etc. in the same way that lldb does for its parsed commands internally. This feature has

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-10-30 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (jimingham) Changes This allows you to specify options and arguments and their definitions and then have lldb handle the completions, help, etc. in the same way that lldb does for its parsed commands internally. This feature has some

[Lldb-commits] [lldb] Support target names containing dots in all utilities (PR #65812)

2023-10-30 Thread Dan McGregor via lldb-commits
https://github.com/dankm edited https://github.com/llvm/llvm-project/pull/65812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to define a Python based command that uses CommandObjectParsed (PR #70734)

2023-10-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a41b149f481e2bcba24e81f208a1938247f040e0 7bb11d65e11329cdde801d04a1900a45b6cd6d19 --

[Lldb-commits] [lldb] Support target names containing dots in all utilities (PR #65812)

2023-10-30 Thread Dan McGregor via lldb-commits
https://github.com/dankm edited https://github.com/llvm/llvm-project/pull/65812 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Replace the usage of module imp with module importlib (PR #70443)

2023-10-30 Thread Tulio Magno Quites Machado Filho via lldb-commits
tuliom wrote: Do you know what is the reason for requiring such an old Python version? I'm asking because it's been hard to find a distro that provides both Python 3.6 (released in 2016) and cmake 3.20 (released in 2021). For the record, Ubuntu 18.04 does have Python 3.6, but it has cmake 3.10.

[Lldb-commits] [lldb] 4b3cd37 - [lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (#70392)

2023-10-30 Thread via lldb-commits
Author: Med Ismail Bennani Date: 2023-10-30T16:52:17-07:00 New Revision: 4b3cd379cce3f455bf3c8677ca7a5be6e708a4ce URL: https://github.com/llvm/llvm-project/commit/4b3cd379cce3f455bf3c8677ca7a5be6e708a4ce DIFF: https://github.com/llvm/llvm-project/commit/4b3cd379cce3f455bf3c8677ca7a5be6e708a4ce.

[Lldb-commits] [lldb] [lldb] Make use of Scripted{Python, }Interface for ScriptedThreadPlan (PR #70392)

2023-10-30 Thread Med Ismail Bennani via lldb-commits
https://github.com/medismailben closed https://github.com/llvm/llvm-project/pull/70392 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-10-30 Thread Greg Clayton via lldb-commits
https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/67599 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 7fbd427 - Add the ability to get a C++ vtable ValueObject from another ValueObj… (#67599)

2023-10-30 Thread via lldb-commits
Author: Greg Clayton Date: 2023-10-30T17:46:18-07:00 New Revision: 7fbd427f5ebea4a4ebf25747758851875bb7e173 URL: https://github.com/llvm/llvm-project/commit/7fbd427f5ebea4a4ebf25747758851875bb7e173 DIFF: https://github.com/llvm/llvm-project/commit/7fbd427f5ebea4a4ebf25747758851875bb7e173.diff

[Lldb-commits] [lldb] Add the ability to get a C++ vtable ValueObject from another ValueObj… (PR #67599)

2023-10-30 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6eafe2cb7a3286c1b13eea7d8370374553fe81a9 f06cd76bd05f95277dced786ac3ca3e83f2e8779 --

[Lldb-commits] [lldb] [lldb/Target] Delay image loading after corefile process creation (PR #70351)

2023-10-30 Thread Greg Clayton via lldb-commits
@@ -614,6 +614,8 @@ class Process : public std::enable_shared_from_this, return error; } + virtual void DidLoadCore() {} clayborg wrote: Yeah, I checked and none of the core file plug-ins currently override the DidAttach() (mach-o, ELF or minidump).

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-30 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,140 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-30 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,155 @@ +//===-- WatchpointResource.h *- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-30 Thread Jason Molenda via lldb-commits
@@ -266,33 +268,73 @@ void Watchpoint::Dump(Stream *s) const { // If prefix is nullptr, we display the watch id and ignore the prefix // altogether. -void Watchpoint::DumpSnapshots(Stream *s, const char *prefix) const { - if (!prefix) { -s->Printf("\nWatchpoint %u hit:",

[Lldb-commits] [lldb] [lldb] [mostly NFC] Large WP foundation: WatchpointResources (PR #68845)

2023-10-30 Thread Jason Molenda via lldb-commits
@@ -0,0 +1,146 @@ +//===-- WatchpointResourceList.h *- C++ -*-===// jasonmolenda wrote: I think it's the same except for the obvious BreakpointSite/WatchpointResource and BreakpointLocation/Watchpoint. It's a little tricky readi

[Lldb-commits] [llvm] [clang] [flang] [lldb] [libcxxabi] [mlir] [libcxx] [Clang][LoongArch] Support builtin functions for LSX and LASX (PR #70404)

2023-10-30 Thread via lldb-commits
https://github.com/yjijd closed https://github.com/llvm/llvm-project/pull/70404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] On AArch64, reconfigure register context first (PR #70742)

2023-10-30 Thread Med Ismail Bennani via lldb-commits
@@ -1642,9 +1642,22 @@ ThreadSP ProcessGDBRemote::SetThreadStopInfo( } ThreadGDBRemote *gdb_thread = static_cast(thread_sp.get()); - RegisterContextSP gdb_reg_ctx_sp(gdb_thread->GetRegisterContext()); + RegisterContextSP reg_ctx_sp(gdb_thread->GetRegisterContext()); -