[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/68452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

@@ -0,0 +1,27 @@ +""" +Tests whether the do-what-I-mean (DWIM) print `po` alias applies FixIts like `expr` does +""" +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class CPP_DWIM_Fixit_TestCas

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/68452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/68452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

https://github.com/PortalPete edited https://github.com/llvm/llvm-project/pull/68452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

@@ -43,6 +43,10 @@ class CommandObjectDWIMPrint : public CommandObjectRaw { HandleArgumentCompletion(CompletionRequest &request, OptionElementVector &opt_element_vector) override; +protected: + /// Stores the expression after applying any Fix-Its.

[Lldb-commits] [lldb] [NVPTX] Improve lowering of v4i8 (PR #67866)

Artem-B wrote: Found another issue. We merge four independent byte loads with `align 1` into a 32-bit load, which fails at runtime on misaligned pointers. ``` %t0 = type { [17 x i8] } @shared_storage = linkonce_odr local_unnamed_addr addrspace(3) global %t0 undef, align 1 define <4 x i8> @i

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

@@ -43,6 +43,10 @@ class CommandObjectDWIMPrint : public CommandObjectRaw { HandleArgumentCompletion(CompletionRequest &request, OptionElementVector &opt_element_vector) override; +protected: + /// Stores the expression after applying any Fix-Its.

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

https://github.com/PortalPete updated https://github.com/llvm/llvm-project/pull/68452 >From 08f4d4ae5afdedb0fbc6196272fcf8316de5f5ea Mon Sep 17 00:00:00 2001 From: Pete Lawrence Date: Thu, 5 Oct 2023 14:22:35 -1000 Subject: [PATCH] [lldb] Update the `po` alias to print Fix-Its to the console.

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

@@ -43,6 +43,10 @@ class CommandObjectDWIMPrint : public CommandObjectRaw { HandleArgumentCompletion(CompletionRequest &request, OptionElementVector &opt_element_vector) override; +protected: + /// Stores the expression after applying any Fix-Its.

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

PortalPete wrote: > The code is not something I am familiar with, but I did notice that the PR > title and the commit title are quite different. Not sure which one is better, > but it is generally nice to have them match (in particular it is nice to add > the `[lldb]` tag to the commit title t

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

@@ -172,8 +172,18 @@ bool CommandObjectDWIMPrint::DoExecute(StringRef command, { auto *exe_scope = m_exe_ctx.GetBestExecutionContextScope(); ValueObjectSP valobj_sp; -ExpressionResults expr_result = -target.EvaluateExpression(expr, exe_scope, valobj_sp, ev

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

https://github.com/PortalPete updated https://github.com/llvm/llvm-project/pull/68452 >From f842928b5300c2ea98dbdc1bf3e3fe768dcf31ed Mon Sep 17 00:00:00 2001 From: Pete Lawrence Date: Thu, 5 Oct 2023 14:22:35 -1000 Subject: [PATCH] [lldb] Update the `po` alias to print Fix-Its to the console.

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

@@ -0,0 +1,27 @@ +""" +Tests whether the do-what-I-mean (DWIM) print `po` alias applies FixIts like `expr` does +""" +import lldb +from lldbsuite.test.decorators import * +from lldbsuite.test.lldbtest import * +from lldbsuite.test import lldbutil + + +class CPP_DWIM_Fixit_TestCas

[Lldb-commits] [lldb] [lldb] Fix `po` alias by printing fix-its to the console. (PR #68452)

https://github.com/PortalPete updated https://github.com/llvm/llvm-project/pull/68452 >From 6ba636bde2a51704025637f3c35d1b98ba6dd7f3 Mon Sep 17 00:00:00 2001 From: Pete Lawrence Date: Thu, 5 Oct 2023 14:22:35 -1000 Subject: [PATCH] [lldb] Update the `po` alias to print Fix-Its to the console.

<    1   2