https://github.com/aeubanks closed
https://github.com/llvm/llvm-project/pull/66295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
mysterymath wrote:
I dug into this a little bit; it looks like the autodetection for
`LLDB_EDITLINE_USE_WCHAR` was broken on our build, so it was turned `OFF`, even
though our libedit supports the wchar API. I can fix this on our end, but more
generally, is there a way to condition this test o
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -459,6 +470,14 @@ class SymbolFile : public PluginInterface {
virtual void GetCompileOptions(
std::unordered_map &args) {}
+ /// If separate debug info files are supported and this function succeeded,
+ /// return some string representing the type of debug info. E
@@ -162,6 +163,21 @@ void SymbolFile::AssertModuleLock() {
SymbolFile::RegisterInfoResolver::~RegisterInfoResolver() = default;
+bool SymbolFile::ListSeparateDebugInfoFiles(StructuredData::Dictionary &d) {
+ StructuredData::Array array;
+ std::optional debug_info_type =
Ge
@@ -2035,8 +2118,8 @@ class CommandObjectTargetModulesDumpSymtab
result.GetOutputStream().EOL();
result.GetOutputStream().EOL();
}
- if (INTERRUPT_REQUESTED(GetDebugger(),
clayborg wrote:
It would be
clayborg wrote:
> > ```
> >SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address, size_t
> > size, uint32_t access_flags, SBError &error);
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > with `eWatchpointAccess{Read,Write,Modify}` fl
jasonmolenda wrote:
> > > ```
> > >SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address,
> > > size_t size, uint32_t access_flags, SBError &error);
> > > ```
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > >
> > > with `eWat
https://github.com/dankm updated
https://github.com/llvm/llvm-project/pull/65812:
>From 416d75e617cc87b6e497815ce6ad1da630eb14a1 Mon Sep 17 00:00:00 2001
From: Dan McGregor
Date: Mon, 14 Aug 2023 18:44:08 -0600
Subject: [PATCH 1/2] Support: hoist lld's executable name code to Path
Instead of u
bulbazord wrote:
> > ```
> >SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address, size_t
> > size, uint32_t access_flags, SBError &error);
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > with `eWatchpointAccess{Read,Write,Modify}` f
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
dankm wrote:
Hm. I'm happy with this file, but I also discovered a bunch of other
`tool-name` tests that can be updated. I'll add those too.
https://github.com/llvm/llvm-project/pull/65812
___
lldb-commits mailing li
@@ -71,7 +71,8 @@ void GPUToSPIRVPass::runOnOperation() {
std::unique_ptr target =
spirv::getMemorySpaceToStorageClassTarget(*context);
spirv::MemorySpaceToStorageClassMap memorySpaceMap =
- spirv::mapMemorySpaceToVulkanStorageClass;
+ th
https://github.com/JDevlieghere review_requested
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere review_requested
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere review_requested
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/66447:
Add a configuration entry for whether LLDB was configured with wide character
support in Editline and use it in a decorator to guard the UTF-8 prompt test.
>From 6e745a62dea1efd8cd614c7a206ddf715aefc867 Mo
JDevlieghere wrote:
I added a configuration entry and corresponding decorator in #66447.
https://github.com/llvm/llvm-project/pull/66312
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Add a configuration entry for whether LLDB was configured with wide character
support in Editline and use it in a decorator to guard the UTF-8 prompt test.
--
Full diff: https://github.com/llvm/llvm-project/pull/66447.diff
3 File
@@ -781,6 +781,9 @@ SBStructuredData SBDebugger::GetBuildConfiguration() {
AddBoolConfigEntry(
*config_up, "editline", LLDB_ENABLE_LIBEDIT,
"A boolean value that indicates if editline support is enabled in LLDB");
+ AddBoolConfigEntry(
+ *config_up, "editlin
https://github.com/mysterymath approved this pull request.
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From 2bb9a2a245d214bf4201d28037f498da5a94c78f Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comm
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2035,8 +2118,8 @@ class CommandObjectTargetModulesDumpSymtab
result.GetOutputStream().EOL();
result.GetOutputStream().EOL();
}
- if (INTERRUPT_REQUESTED(GetDebugger(),
zhyty wrote:
Done. Turns out
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zhyty wrote:
Addressed @clayborg's comments: removed trailing whitespaces, simplify the
`SymbolFile` functions into one.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/66447:
>From 1d9a7f7302b57883d316205967904268e0e54e59 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Thu, 14 Sep 2023 16:47:49 -0700
Subject: [PATCH] [lldb] Add config and decorator for wide character supp
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
https://github.com/clayborg requested changes to this pull request.
Just need tests for the non --json output for OSO and DWO. If you can also
attach the output of the 4 cases (OSO no errors, OSO with errors, DWO no errors
and DWO with errors), that might help people see what this output looks
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -11,6 +11,7 @@
#include "DIERef.h"
#include "lldb/Symbol/SymbolFile.h"
+#include "lldb/Utility/ConstString.h"
clayborg wrote:
Remove this now that we aren't returning a std::optional
https://github.com/llvm/llvm-project/pull/66035
jimingham wrote:
I'm not sure I see the benefit of the SBWatchpointSpec including the way the
watched region is specified. That's just moving the proliferation of API's
from SBTarget::WatchpointCreate*() to the SBWatchpointSpec constructor. We'd
have to have:
SBWatchpointSpec::SBWatchpointSp
clayborg wrote:
> You and Alex both preferred adding an Options class to pass in to this (and
> future WatchpointCreate API) so I'll write that up for my next revision of
> this PR, I didn't see your earlier message talking about your preference for
> that when I ping'ed Alex on their opinion.
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
@@ -57,6 +57,29 @@ def test_add_dsym_with_dSYM_bundle(self):
self.exe_name = "a.out"
self.do_add_dsym_with_dSYM_bundle(self.exe_name)
+@no_debug_info_test
+def test_report_symbol_load(self):
+"""Test that when adding a symbol file, the eBroadcas
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/66447
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2023-09-14T22:16:24-07:00
New Revision: 111bc6f1fe6536ac091d4490c112ce7242e00349
URL:
https://github.com/llvm/llvm-project/commit/111bc6f1fe6536ac091d4490c112ce7242e00349
DIFF:
https://github.com/llvm/llvm-project/commit/111bc6f1fe6536ac091d4490c112ce7242e00349.d
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From 5bf6c4a90bf578af56fb0da30586086fd777bd55 Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comman
https://github.com/zhyty updated https://github.com/llvm/llvm-project/pull/66035
>From 9a52ac5193af2a8ddca2a5d922684935b043d0ef Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comman
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zhyty wrote:
Added tests for the human-readable/table format.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
101 - 146 of 146 matches
Mail list logo
