omjavaid added a comment.
This apparently requires a rebase now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159504/new/
https://reviews.llvm.org/D159504
___
lldb-commits mailing list
lldb-commits@list
omjavaid added inline comments.
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:566
TLS,
+ ZA,
+ // SME pseudo registers are read only.
ZA -> SME?
Comment at: lldb/source/Plugins/Process/Utility/Register
DavidSpickett wrote:
I'll be cheeky and assume this is fine to go in.
https://github.com/llvm/llvm-project/pull/66053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/66053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
omjavaid added inline comments.
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:597
+ // Here this means, does the system have ZA, not whether it is active.
+ if (GetRegisterInfo().IsZAEnabled()) {
+error = ReadZAHeader();
---
DavidSpickett added inline comments.
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:597
+ // Here this means, does the system have ZA, not whether it is active.
+ if (GetRegisterInfo().IsZAEnabled()) {
+error = ReadZAHeader();
--
DavidSpickett added a comment.
ping! (in the interest of clearing Phabricator reviews soon)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159011/new/
https://reviews.llvm.org/D159011
___
lldb-commits mai
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/66345:
Running:
$ clang-format -i $(find -regex "\./lldb/.*\.c") $(find -regex
"\./lldb/.*\.cpp") $(find -regex "\./lldb/.*\.h")
Resulted in:
1602 files changed, 25090 insertions(+), 25849 deletions(-)
(note: t
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Running:
$ clang-format -i $(find -regex "\./lldb/.*\.c") $(find -regex
"\./lldb/.*\.cpp") $(find -regex "\./lldb/.*\.h")
Resulted in:
1602 files changed, 25090 insertions(+), 25849 deletions(-)
(note: this includes tests which
DavidSpickett wrote:
@bulbazord This would be a good place to put your plugin dependency / const
string guidance. Or tell me where it lives now and I'll link to it.
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-com
DavidSpickett wrote:
If anyone knows the other big differences I'll add them. This is what I came up
with from my experience and reading the lllvm style doc.
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@li
DavidSpickett updated this revision to Diff 556752.
DavidSpickett added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159502/new/
https://reviews.llvm.org/D159502
Files:
lldb/include/lldb/Utility/RegisterValue
DavidSpickett marked 3 inline comments as done.
DavidSpickett added inline comments.
Comment at:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:597
+ // Here this means, does the system have ZA, not whether it is active.
+ if (GetRegisterInfo().IsZAEnab
DavidSpickett updated this revision to Diff 556753.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159503/new/
https://reviews.llvm.org/D159503
Files:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLi
DavidSpickett updated this revision to Diff 556754.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159504/new/
https://reviews.llvm.org/D159504
Files:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC
DavidSpickett updated this revision to Diff 556755.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159505/new/
https://reviews.llvm.org/D159505
Files:
lldb/test/API/commands/register/register/aarch64_dynamic
DavidSpickett updated this revision to Diff 556756.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154927/new/
https://reviews.llvm.org/D154927
Files:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLi
DavidSpickett updated this revision to Diff 556757.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158500/new/
https://reviews.llvm.org/D158500
Files:
lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_
DavidSpickett updated this revision to Diff 556758.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158506/new/
https://reviews.llvm.org/D158506
Files:
lldb/docs/index.rst
lldb/docs/use/aarch64-linux.rst
l
DavidSpickett updated this revision to Diff 556759.
DavidSpickett added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158514/new/
https://reviews.llvm.org/D158514
Files:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterC
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/66345:
>From bcabec98725255c4abed93311d73837d09ac8dde Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 14 Sep 2023 10:05:44 +0100
Subject: [PATCH] [lldb][Docs] Document our major differences from the LLVM
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-09-14T11:16:33+01:00
New Revision: 3ae76e4fdc17ad7a7bb94d84cd746e7a98f7d105
URL:
https://github.com/llvm/llvm-project/commit/3ae76e4fdc17ad7a7bb94d84cd746e7a98f7d105
DIFF:
https://github.com/llvm/llvm-project/commit/3ae76e4fdc17ad7a7bb94d84cd746e7a98f7d105.diff
fdeazeve accepted this revision.
fdeazeve added a comment.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159011/new/
https://reviews.llvm.org/D159011
___
lldb-commits mailing list
lldb-commits@list
https://github.com/gchatelet updated
https://github.com/llvm/llvm-project/pull/65750:
>From 5023264dce58aaa46b18404a4578b7a777962758 Mon Sep 17 00:00:00 2001
From: Guillaume Chatelet
Date: Fri, 8 Sep 2023 13:10:05 +
Subject: [PATCH 1/4] [libc] add invoke / invoke_result type traits
---
li
@@ -0,0 +1,26 @@
+//===-- invoke_result type_traits ---*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/gchatelet review_requested
https://github.com/llvm/llvm-project/pull/65750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
ldionne wrote:
There shouldn't be any changes under libcxxabi. Those changes are not necessary.
https://github.com/llvm/llvm-project/pull/66295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
@@ -0,0 +1,59 @@
+//===-- invoke type_traits --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/gchatelet edited
https://github.com/llvm/llvm-project/pull/65750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -145,6 +145,110 @@ TEST(LlvmLibcTypeTraitsTest, integral_constant) {
EXPECT_EQ((integral_constant::value), 4);
}
+namespace invoke_detail {
+
+enum State { INIT = 0, A_APPLY_CALLED, B_APPLY_CALLED };
+
+struct A {
+ State state = INIT;
+ virtual ~A() {}
+ virtual void
@@ -145,6 +145,110 @@ TEST(LlvmLibcTypeTraitsTest, integral_constant) {
EXPECT_EQ((integral_constant::value), 4);
}
+namespace invoke_detail {
+
+enum State { INIT = 0, A_APPLY_CALLED, B_APPLY_CALLED };
+
+struct A {
+ State state = INIT;
+ virtual ~A() {}
+ virtual void
@@ -145,6 +145,110 @@ TEST(LlvmLibcTypeTraitsTest, integral_constant) {
EXPECT_EQ((integral_constant::value), 4);
}
+namespace invoke_detail {
+
+enum State { INIT = 0, A_APPLY_CALLED, B_APPLY_CALLED };
+
+struct A {
+ State state = INIT;
+ virtual ~A() {}
+ virtual void
https://github.com/gchatelet resolved
https://github.com/llvm/llvm-project/pull/65750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/gchatelet resolved
https://github.com/llvm/llvm-project/pull/65750
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
@@ -661,27 +661,27 @@ static bool FixupInvocation(CompilerInvocation
&Invocation,
static unsigned getOptimizationLevel(ArgList &Args, InputKind IK,
DiagnosticsEngine &Diags) {
- unsigned DefaultOpt = llvm::CodeGenOpt::None;
+ unsigned De
https://github.com/banach-space approved this pull request.
Flang driver changes LGTM, thanks!
https://github.com/llvm/llvm-project/pull/66295
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw==?=,Jonas Devlieghere
,Douglas Yung ,daisy202309
<144047963+daisy202...@users.noreply.github.com>,Jonas Devlieghere
,Mehdi Amini ,Siva Chandra
,Jonas Devlieghere ,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=
gulfemsavrun wrote:
We started seeing a test failure after this commit.
```
UNRESOLVED: lldb-api :: terminal/TestEditline.py (2430 of 2430)
TEST 'lldb-api :: terminal/TestEditline.py' FAILED
Script:
--
/b/s/w/ir/x/w/lldb_install/python3/bin/python3
/b/s
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
Excellent write up, thanks for taking care of that!
https://github.com/llvm/llvm-project/pull/66345
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
bulbazord wrote:
> @bulbazord This would be a good place to put your plugin dependency / const
> string guidance. Or tell me where it lives now and I'll link to it.
Oh, yes! I'd be happy to take care of that after this goes in, thanks for
pointing that out! :)
https://github.com/llvm/llvm-pro
@@ -211,6 +212,35 @@ bool Watchpoint::CaptureWatchedValue(const
ExecutionContext &exe_ctx) {
return (m_new_value_sp && m_new_value_sp->GetError().Success());
}
+bool Watchpoint::WatchedValueReportable(const ExecutionContext &exe_ctx) {
+ if (!m_watch_modify)
+return tr
@@ -3109,14 +3109,15 @@ static GDBStoppointType GetGDBStoppointType(Watchpoint
*wp) {
assert(wp);
bool watch_read = wp->WatchpointRead();
bool watch_write = wp->WatchpointWrite();
+ bool watch_modify = wp->WatchpointModify();
- // watch_read and watch_write cannot bo
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/66400:
None
>From d14e5d08571ea206b1ee8dd0ffc66f896306d15e Mon Sep 17 00:00:00 2001
From: Adrian Prantl
Date: Thu, 14 Sep 2023 09:44:15 -0700
Subject: [PATCH] Clean up test case
---
.../Makefile
https://github.com/adrian-prantl review_requested
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl review_requested
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/adrian-prantl review_requested
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Adrian Prantl
Date: 2023-09-14T09:48:36-07:00
New Revision: 9dfc6d37da65b94208bf81b06908bb20d92de8fb
URL:
https://github.com/llvm/llvm-project/commit/9dfc6d37da65b94208bf81b06908bb20d92de8fb
DIFF:
https://github.com/llvm/llvm-project/commit/9dfc6d37da65b94208bf81b06908bb20d92de8fb.diff
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/66400
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
None
--
Full diff: https://github.com/llvm/llvm-project/pull/66400.diff
3 Files Affected:
- (renamed) lldb/test/API/lang/objc/charstar_dyntype/Makefile (-3)
- (renamed) lldb/test/API/lang/objc/charstar_dyntype/TestCharStarDynTyp
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
@@ -18,19 +18,38 @@ Please refer to the `LLVM Developer Policy
authoring and uploading a patch. LLDB differs from the LLVM Developer
Policy in the following respects.
- - **Test infrastructure**: Like LLVM it is important to submit tests with
your
- patches, but note that
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2f377c5bd713: [lldb][NFCI] Remove use of ConstString from
UnixSignals (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
Author: Alex Langford
Date: 2023-09-14T10:19:53-07:00
New Revision: 2f377c5bd713e9ee72faa6a99088bb81358059e3
URL:
https://github.com/llvm/llvm-project/commit/2f377c5bd713e9ee72faa6a99088bb81358059e3
DIFF:
https://github.com/llvm/llvm-project/commit/2f377c5bd713e9ee72faa6a99088bb81358059e3.diff
bulbazord added inline comments.
Comment at: lldb/source/Utility/StructuredData.cpp:249-251
+ llvm::sort(sorted_entries, [&](const Entry &lhs, const Entry &rhs) -> bool {
+return lhs.first < rhs.first;
+ });
Oh I can remove this lambda too -- Let me update.
bulbazord updated this revision to Diff 556798.
bulbazord added a comment.
Remove unneeded lambda
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
https://reviews.llvm.org/D159313
Files:
lldb/include/lldb/Utility/StructuredData.h
lldb
fdeazeve accepted this revision.
fdeazeve added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
https://reviews.llvm.org/D159313
__
@@ -0,0 +1,23 @@
+.. title:: clang-tidy - performance-move-smart-pointer-contents
+
+performance-move-smart-pointer-contents
+===
+
+Given a smart pointer containing a movable type, such as a
+`std::unique_ptr`, it's possible to move the content
@@ -0,0 +1,23 @@
+.. title:: clang-tidy - performance-move-smart-pointer-contents
+
+performance-move-smart-pointer-contents
+===
+
+Given a smart pointer containing a movable type, such as a
EugeneZelenko wrote:
Please synchro
@@ -0,0 +1,23 @@
+.. title:: clang-tidy - performance-move-smart-pointer-contents
+
+performance-move-smart-pointer-contents
+===
+
+Given a smart pointer containing a movable type, such as a
+`std::unique_ptr`, it's possible to move the content
Author: Alex Langford
Date: 2023-09-14T10:53:39-07:00
New Revision: a5a2a5a3eca06998d9f71186db2ce78ae2716022
URL:
https://github.com/llvm/llvm-project/commit/a5a2a5a3eca06998d9f71186db2ce78ae2716022
DIFF:
https://github.com/llvm/llvm-project/commit/a5a2a5a3eca06998d9f71186db2ce78ae2716022.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa5a2a5a3eca0: [lldb][NFCI] Remove use of ConstString in
StructuredData (authored by bulbazord).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
ht
adrian-prantl wrote:
IIUC, this is an infrastructure change that fixes a test failure in swift
branch. Augusto can speak to whether it's testable on `main`.
https://github.com/llvm/llvm-project/pull/66286
___
lldb-commits mailing list
lldb-commits@lis
clayborg wrote:
> > > Just to be clear, I need to find a solution for
> > > SBTarget::CreateWatchpoint before this PR is ready to land. I'm inclined
> > > towards adding a third bool parameter 'modify', but I'm not sure that's
> > > the best choice.
> >
> >
> > Anytime we keep adding more op
augusto2112 wrote:
@clayborg as Adrian said, this fixes a test failure downstream. I don't there's
any visible change in behavior to test in main, unfortunately.
https://github.com/llvm/llvm-project/pull/66286
___
lldb-commits mailing list
lldb-commit
clayborg wrote:
> @clayborg as Adrian said, this fixes a test failure downstream. I don't
> there's any visible change in behavior to test in main, unfortunately.
Gotcha. Let me guess: Swift? :-)
https://github.com/llvm/llvm-project/pull/66286
___
l
augusto2112 wrote:
> > @clayborg as Adrian said, this fixes a test failure downstream. I don't
> > there's any visible change in behavior to test in main, unfortunately.
>
> Gotcha. Let me guess: Swift? :-)
Exactly :)
https://github.com/llvm/llvm-project/pull/66286
___
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From d0538bc86ec02819ed9a24d06a2e7fc355447f4b Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comm
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From 94b834f747fe66a50288e23fec2d00918f4fc8ef Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comm
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty resolved
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty edited https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
zhyty wrote:
Updated to show a more human-readable format @jimingham.
Also addressed comments by @DavidSpickett.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
bnbarham wrote:
Everything seems to work fine without it, so I'll put up that PR again without
that check and close this PR.
https://github.com/llvm/llvm-project/pull/66271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/bnbarham closed
https://github.com/llvm/llvm-project/pull/66271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -57,6 +57,29 @@ def test_add_dsym_with_dSYM_bundle(self):
self.exe_name = "a.out"
self.do_add_dsym_with_dSYM_bundle(self.exe_name)
+@no_debug_info_test
+def test_report_symbol_load(self):
+"""Test that when adding a symbol file, the eBroadcas
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/4] [lldb][Commands] Show symbol change bit in SB API
jasonmolenda wrote:
> ```
>SBWatchpoint SBTarget::WatchpointCreateByAddress(addr_t address, size_t
> size, uint32_t access_flags, SBError &error);
> ```
>
> with `eWatchpointAccess{Read,Write,Modify}` flags defined.
@bulbazord what do you think about this suggestion? Would you still pref
1 - 100 of 146 matches
Mail list logo
