https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/65945:
Some functions in Process were using LLDB_INVALID_ADDRESS instead of
LLDB_INVALID_TOKEN.
The only visible effect of this appears to be that "process unload " would
complete to 0 even after the image was
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Some functions in Process were using LLDB_INVALID_ADDRESS instead of
LLDB_INVALID_TOKEN.
The only visible effect of this appears to be that "process unload " would
complete to 0 even after the image was unloaded. Since the command is checking
Author: David Spickett
Date: 2023-09-11T11:00:57Z
New Revision: 825adbe5585219ce731045defa019defaf96faab
URL:
https://github.com/llvm/llvm-project/commit/825adbe5585219ce731045defa019defaf96faab
DIFF:
https://github.com/llvm/llvm-project/commit/825adbe5585219ce731045defa019defaf96faab.diff
LOG
jimingham wrote:
It seems a bit weird to have an Execution context with a thread and a stack
frame but not the process they belong to. I think it's easier to deal with it
when we hand them out.
Jim
> On Sep 9, 2023, at 11:57 AM, Greg Clayton ***@***.***> wrote:
>
>
> @clayborg commented
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/65945:
>From b041cf0965a397104cd44d76d29f8d69ab26856d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Sep 2023 10:46:53 +
Subject: [PATCH] [lldb] Correctly invalidate unloaded image tokens
Some f
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/65945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/65973:
* Assert no completions for tests that should not find completions.
* Remove regex mode from complete_from_to, which was unused.
This exposed bugs in 2 of the tests, target stop-hook and
process unload. Th
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
* Assert no completions for tests that should not find completions.
* Remove regex mode from complete_from_to, which was unused.
This exposed bugs in 2 of the tests, target stop-hook and
process unload. These were fixed in previous commits but
DavidSpickett wrote:
This builds on https://github.com/llvm/llvm-project/pull/65945, so the first
commit is from that PR. If you review using the per commit tab instead that
should make it clearer, I hope.
This is me trying to imitate a stacked PR and maybe failing, let's see how it
goes.
ht
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/65974:
Previously we would check all built-ins first for suggestions,
then check built-ins and aliases. This meant that if you had
an alias brkpt -> breakpoint, "br" would complete to "breakpoint".
Instead of giv
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65974
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65974
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
This is a PR "stacked" on https://github.com/llvm/llvm-project/pull/65973, so
the first 2 commits are from that and the original one. Review with the commits
tab instead of "files changed".
https://github.com/llvm/llvm-project/pull/65974
___
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Previously we would check all built-ins first for suggestions,
then check built-ins and aliases. This meant that if you had
an alias brkpt -> breakpoint, "br" would complete to "breakpoint".
Instead of giving you the choice of "brkpt" or "break
Author: David Spickett
Date: 2023-09-11T17:12:09+01:00
New Revision: 3125bd4bc7367a05ddf5477793a1ee51cecc3046
URL:
https://github.com/llvm/llvm-project/commit/3125bd4bc7367a05ddf5477793a1ee51cecc3046
DIFF:
https://github.com/llvm/llvm-project/commit/3125bd4bc7367a05ddf5477793a1ee51cecc3046.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/65945
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/65973:
>From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Sep 2023 09:09:31 +
Subject: [PATCH] [lldb] Improve completion tests
* Assert no completions
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/65973:
>From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Sep 2023 09:09:31 +
Subject: [PATCH 1/2] [lldb] Improve completion tests
* Assert no completi
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/65974:
>From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Sep 2023 09:09:31 +
Subject: [PATCH 1/3] [lldb] Improve completion tests
* Assert no completi
jimingham wrote:
> > This is in reply to Alex's comment about why we keep the process around,
> > but the quote this reply didn't seem to work...
> > After a process exits you might still want to ask it what its exit status
> > was. Plus there might be other system accounting we've gathered for
Author: David Spickett
Date: 2023-09-11T16:44:12Z
New Revision: 6bf923d5c3daf5d66e0acf53d037a12ceff4a275
URL:
https://github.com/llvm/llvm-project/commit/6bf923d5c3daf5d66e0acf53d037a12ceff4a275
DIFF:
https://github.com/llvm/llvm-project/commit/6bf923d5c3daf5d66e0acf53d037a12ceff4a275.diff
LOG
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/65979:
By running this from lldb/
$ black --exclude "third_party/|scripts/|utils/" ./
>From 56cea5795e0274fe7672c727340330cf46aa30a4 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Sep 2023 16:52:05
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/65979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Putting this into review mainly to ask @JDevlieghere if any of these shouldn't
be formatted.
Third party obviously we don't want to format that. Scripts and utils I don't
see why not but maybe there are downstream concerns?
https://github.com/llvm/llvm-project/pull/65979
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
By running this from lldb/
$ black --exclude "third_party/|scripts/|utils/" ./
--
Patch is 21.03 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/65979.diff
9 Files Affected:
- (modified) lldb/bindi
DavidSpickett wrote:
I looked around for a way to exclude dirs from black but unfortunately the way
is `--exclude`. I was hoping to place some settings file in third_party/ to
disable it.
https://github.com/llvm/llvm-project/pull/65979
___
lldb-commi
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self):
self.assertTrue(result.Succeeded())
self.assertEqual("apropos script", result.GetOutput())
-command_interpreter.ResolveCommand("h", result)
+command_interpreter.ResolveCommand("
https://github.com/jimingham commented:
This looks right to me, but I'm worried about why you had to change the "h"
completion test to "he"?
https://github.com/llvm/llvm-project/pull/65974
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self):
self.assertTrue(result.Succeeded())
self.assertEqual("apropos script", result.GetOutput())
-command_interpreter.ResolveCommand("h", result)
+command_interpreter.ResolveCommand("
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/65973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham approved this pull request.
Other than that tiny quibble, this looks fine to me.
https://github.com/llvm/llvm-project/pull/65973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
@@ -2254,21 +2251,18 @@ def complete_from_to(self, str_input, patterns,
turn_off_re_match=False):
for idx in range(1, num_matches + 1):
compare_string += match_strings.GetStringAtIndex(idx) +
"\n"
+# If the singular pattern is the
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self):
self.assertTrue(result.Succeeded())
self.assertEqual("apropos script", result.GetOutput())
-command_interpreter.ResolveCommand("h", result)
+command_interpreter.ResolveCommand("
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/65974:
>From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Sep 2023 09:09:31 +
Subject: [PATCH 1/4] [lldb] Improve completion tests
* Assert no completi
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/65973:
>From ea172bdf8b1d66087076b7ed842021749a49b9fb Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Sep 2023 09:09:31 +
Subject: [PATCH 1/3] [lldb] Improve completion tests
* Assert no completi
@@ -2254,21 +2251,18 @@ def complete_from_to(self, str_input, patterns,
turn_off_re_match=False):
for idx in range(1, num_matches + 1):
compare_string += match_strings.GetStringAtIndex(idx) +
"\n"
+# If the singular pattern is the
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-09-11T18:26:51+01:00
New Revision: 2378ba632e5cdc761584a4154449833ac0f86384
URL:
https://github.com/llvm/llvm-project/commit/2378ba632e5cdc761584a4154449833ac0f86384
DIFF:
https://github.com/llvm/llvm-project/commit/2378ba632e5cdc761584a4154449833ac0f86384.diff
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/65973
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self):
self.assertTrue(result.Succeeded())
self.assertEqual("apropos script", result.GetOutput())
-command_interpreter.ResolveCommand("h", result)
+command_interpreter.ResolveCommand("
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/65974:
>From a279ee8b0a7fca5561f5c4703fc7bdd599419a43 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Mon, 11 Sep 2023 11:42:45 +
Subject: [PATCH 1/2] [lldb] Treat user aliases the same as built-ins when
@@ -20,7 +20,7 @@ def test_command_abbreviations_and_aliases(self):
self.assertTrue(result.Succeeded())
self.assertEqual("apropos script", result.GetOutput())
-command_interpreter.ResolveCommand("h", result)
+command_interpreter.ResolveCommand("
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/65974
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Spickett
Date: 2023-09-11T17:35:27Z
New Revision: 8012518f600bebaa4ed99a57d553eeea25c2d0c9
URL:
https://github.com/llvm/llvm-project/commit/8012518f600bebaa4ed99a57d553eeea25c2d0c9
DIFF:
https://github.com/llvm/llvm-project/commit/8012518f600bebaa4ed99a57d553eeea25c2d0c9.diff
LOG
https://github.com/JDevlieghere approved this pull request.
LGTM. I formatted the test, examples and script subdirectory. This is more
comprehensive.
https://github.com/llvm/llvm-project/pull/65979
___
lldb-commits mailing list
lldb-commits@lists.llv
bulbazord updated this revision to Diff 556469.
bulbazord marked 7 inline comments as done.
bulbazord added a comment.
Address feedback from @fdeazeve
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159313/new/
https://reviews.llvm.org/D159313
Files
bulbazord added inline comments.
Comment at: lldb/include/lldb/Utility/StructuredData.h:436
auto array_sp = std::make_shared();
- collection::const_iterator iter;
- for (iter = m_dict.begin(); iter != m_dict.end(); ++iter) {
+ for (auto iter = m_dict.begin()
Author: walter erquinigo
Date: 2023-09-11T15:25:05-04:00
New Revision: c154ba8abeb6f59f85a9bb6fdf7bd79ad0d8c05c
URL:
https://github.com/llvm/llvm-project/commit/c154ba8abeb6f59f85a9bb6fdf7bd79ad0d8c05c
DIFF:
https://github.com/llvm/llvm-project/commit/c154ba8abeb6f59f85a9bb6fdf7bd79ad0d8c05c.di
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/66001:
Instead of creating a copy of the vector, we should just pass a reference
along. The only method that calls this Ctor also holds onto a non-mutable
reference to the vector of strings, so this should just make
https://github.com/bulbazord review_requested
https://github.com/llvm/llvm-project/pull/66001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/66001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Instead of creating a copy of the vector, we should just pass a reference
along. The only method that calls this Ctor also holds onto a non-mutable
reference to the vector of strings so a copy should be unnecessary.
--
Full diff: https://githu
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/65687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/65687:
>From 6415738e5c359553212d4a04780694587a536a82 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 7 Sep 2023 18:35:10 -0400
Subject: [PATCH] [lldb-vscode] Make descriptive summaries and raw chil
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/66001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
I really dislike all the manual memory management that's going on in this file,
but I realize that's not the result of this patch, but rather because of the
code that was factored
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/65687:
>From 6415738e5c359553212d4a04780694587a536a82 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 7 Sep 2023 18:35:10 -0400
Subject: [PATCH 1/2] [lldb-vscode] Make descriptive summaries and raw
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/65687
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Walter Erquinigo
Date: 2023-09-11T17:00:01-04:00
New Revision: a2a9918a8524f3f7675297b75daa2a80bc0790ff
URL:
https://github.com/llvm/llvm-project/commit/a2a9918a8524f3f7675297b75daa2a80bc0790ff
DIFF:
https://github.com/llvm/llvm-project/commit/a2a9918a8524f3f7675297b75daa2a80bc0790ff.di
https://github.com/jimingham approved this pull request.
Makes sense
https://github.com/llvm/llvm-project/pull/66001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham resolved
https://github.com/llvm/llvm-project/pull/65822
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jimingham resolved
https://github.com/llvm/llvm-project/pull/65822
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jasonmolenda updated this revision to Diff 556505.
jasonmolenda added a comment.
Update patch to not use malloc/free for a temporary heap allocation; a
std::string works fine. One caveat is that the c-strings we read in may have a
nul byte terminator, and left alone the std::string will conside
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar
<1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song
,Razvan Lupusoru ,Walter Erquinigo
,"Yaxun (Sam) Liu" ,Nico Weber
,Stella Laurenzo ,Lang Hames
,Matthias Braun ,Arthur
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar
<1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song
,Razvan Lupusoru ,Walter Erquinigo
,"Yaxun (Sam) Liu" ,Nico Weber
,Stella Laurenzo ,Lang Hames
,Matthias Braun ,Arthur
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar
<1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song
,Razvan Lupusoru ,Walter Erquinigo
,"Yaxun (Sam) Liu" ,Nico Weber
,Stella Laurenzo ,Lang Hames
,Matthias Braun ,Arthur
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar
<1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song
,Razvan Lupusoru ,Walter Erquinigo
,"Yaxun (Sam) Liu" ,Nico Weber
,Stella Laurenzo ,Lang Hames
,Matthias Braun ,Arthur
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar
<1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song
,Razvan Lupusoru ,Walter Erquinigo
,"Yaxun (Sam) Liu" ,Nico Weber
,Stella Laurenzo ,Lang Hames
,Matthias Braun ,Arthur
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar
<1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song
,Razvan Lupusoru ,Walter Erquinigo
,"Yaxun (Sam) Liu" ,Nico Weber
,Stella Laurenzo ,Lang Hames
,Matthias Braun ,Arthur
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar
<1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song
,Razvan Lupusoru ,Walter Erquinigo
,"Yaxun (Sam) Liu" ,Nico Weber
,Stella Laurenzo ,Lang Hames
,Matthias Braun ,Arthur
Author: Jason Molenda
Date: 2023-09-11T16:46:18-07:00
New Revision: 2cab996192cf143d10e3381fcefa75e270cc7ddb
URL:
https://github.com/llvm/llvm-project/commit/2cab996192cf143d10e3381fcefa75e270cc7ddb
DIFF:
https://github.com/llvm/llvm-project/commit/2cab996192cf143d10e3381fcefa75e270cc7ddb.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2cab996192cf: Add "process metadata" Mach-O
LC_NOTE for corefiles (authored by jasonmolenda).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158785/new/
http
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,
Valentin Clement =?utf-8?b?KOODkOODrOODsw=?=,MaheshRavishankar
<1663364+maheshravishan...@users.noreply.github.com>,Fangrui Song
,Razvan Lupusoru ,Walter Erquinigo
,"Yaxun (Sam) Liu" ,Nico Weber
,Stella Laurenzo ,Lang Hames
,Matthias Braun ,Arthur
https://github.com/zhyty review_requested
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty review_requested
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty review_requested
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/zhyty created
https://github.com/llvm/llvm-project/pull/66035:
Summary:
Add a new command
```
target modules dump separate-debug-info [ ...]
```
or
```
image dump separate-debug-info [ ...]
```
(since `image` is an alias for `target modules`).
This lists the separate debug i
https://github.com/llvmbot labeled
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Changes
Summary:
Add a new command
```
target modules dump separate-debug-info [ ...]
```
or
```
image dump separate-debug-info [ ...]
```
(since `image` is an alias for `target modules`).
This lists the separate debug info files and their current sta
https://github.com/zhyty updated
https://github.com/llvm/llvm-project/pull/66035:
>From 0f4cf3648bd1a8d6e9114965e6eb6cdbc7ed01dd Mon Sep 17 00:00:00 2001
From: Tom Yang
Date: Mon, 11 Sep 2023 17:17:13 -0700
Subject: [PATCH] Add `target modules dump separate-debug-info`
Summary:
Add a new comm
jimingham wrote:
I don't think the lldb command line dumps raw JSON anywhere as a command
result. Can we make something a little more human readable?
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits mailing list
lldb-commits@lists.llv
jimingham wrote:
BTW, the idea seems useful to me, but particularly if you're doing OSO you can
get a whole lot of these so a space efficient presentation where you can scan
the names easily, etc, will be important as well.
https://github.com/llvm/llvm-project/pull/66035
__
clayborg wrote:
> I don't think the lldb command line dumps raw JSON anywhere as a command
> result. Can we make something a little more human readable?
It was my idea to make this JSON. The problem is each debug info (.dwo and
DWARF in .o files for Mac) has very different fields and pretty pr
clayborg wrote:
We also want to show the .dwo error or OSO error strings that explain why the
file wasn't loaded as we see when we do "frame variable" and the OSO or DWO are
missing.
https://github.com/llvm/llvm-project/pull/66035
___
lldb-commits m
dblaikie added a comment.
Any chance we could simplify this situation and have dwo searches use exactly
the same/shared logic as source file searches? It seems like the dwarf spec
intent was for that to be the case.
I don't mind adding more ways to find things, but think it'd be useful if we
o
92 matches
Mail list logo
