[Lldb-commits] [PATCH] D158971: [lldb][NFC] Put disassembler test classes and methods in anonymous namespace

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. > Are you referring to > https://llvm.org/docs/CodingStandards.html#anonymous-namespaces? That's the one, please include that in the commit message. Other than that this LGTM.

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

DavidSpickett added a comment. The added context helps document what was already there so that's a nice improvement. Something I'm not clear on mechanically. The original r_debug has eAdd set. Then the second r_debug is loaded, which also has eAdd set. What is the state of r_map at that point?

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/ABI/RISCV/ABISysV_riscv.cpp:145 + return false; +} + ted wrote: > DavidSpickett wrote: > > Looking at the comments in lldb/include/lldb/Target/ABI.h I'm not sure > > which of these should be i

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

DavidSpickett added a comment. > I've done the following: Great. Could you include that in the commit message? Seems like we get a lot of questions about how mature risc-v support is, so we can point to this as a milestone for that. There is https://lldb.llvm.org/#platform-support but there's

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

DavidSpickett updated this revision to Diff 554648. DavidSpickett added a comment. Single function to set the simd values, that takes a base value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157000/new/ https://reviews.llvm.org/D157000 Files:

[Lldb-commits] [PATCH] D157000: [lldb][AArch64] Check SIMD save/restore in SVE SIMD test

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_sve_simd_registers/main.c:43 +void write_simd_regs_expr() { +#define WRITE_SIMD(NUM)

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett updated this revision to Diff 554652. DavidSpickett added a comment. Remove unused includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157488/new/ https://reviews.llvm.org/D157488 Files: lldb/test/API/commands/register/register

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett added a comment. > This looks fine but instead of adding a new test cant we add MTE control > register tests to already available MTE tests? We have these existing tests: mte_core_file - clearly it can't go here, core files are read only. mte_memory_region - memory regions have not

[Lldb-commits] [PATCH] D157488: [lldb][AArch64] Add testing of save/restore for Linux MTE control register

DavidSpickett updated this revision to Diff 554657. DavidSpickett added a comment. Remove HWCAP check from program file. The runner will check cppuinfo and even if that was fooled, the prctl would fail at runtime if you didn't have MTE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [lldb] 9a4b3fd - [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

Author: Yuxuan Shui Date: 2023-08-30T15:53:31+03:00 New Revision: 9a4b3fdb82327e808213070fd157be3c557b8b9d URL: https://github.com/llvm/llvm-project/commit/9a4b3fdb82327e808213070fd157be3c557b8b9d DIFF: https://github.com/llvm/llvm-project/commit/9a4b3fdb82327e808213070fd157be3c557b8b9d.diff L

[Lldb-commits] [PATCH] D156817: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE`

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a4b3fdb8232: [lldb][windows] _wsopen_s does not accept bits other than `_S_IREAD | _S_IWRITE` (authored by yshui, committed by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D156817?vs=54

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace updated this revision to Diff 554712. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159031/new/ https://reviews.llvm.org/D159031 Files: lldb/include/lldb/Core/IOHandler.h lldb/include/lldb/Host/Editline.h lldb/source/Core/IOHandler.cpp lldb/source/Expression/REPL.cpp In

[Lldb-commits] [PATCH] D159031: [LLDB] Fix IOHandlerEditline::GetCurrentLines()

wallace marked an inline comment as done. wallace added a comment. @aprantl , it turns out that there are no tests for this. I also don't know how easy it'd be to test this very specific feature, because it relies on the terminal not being affected by stuff like test runners. CHANGES SINCE LAS

[Lldb-commits] [PATCH] D159076: [lldb] Add DynamicLoader for FreeBSD Kernel post-mortem debug facility

aokblast updated this revision to Diff 554722. aokblast added a comment. Add "real comment" for commented code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159076/new/ https://reviews.llvm.org/D159076 Files: lldb/source/Plugins/DynamicLoader/F

[Lldb-commits] [PATCH] D159076: [lldb] Add DynamicLoader for FreeBSD Kernel post-mortem debug facility

aokblast updated this revision to Diff 554724. aokblast added a comment. This change fix the indentation for the ObjectFileELF.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159076/new/ https://reviews.llvm.org/D159076 Files: lldb/source/Plug

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. For the sake of unblocking this diff, I'm accepting it because there's no clear actionable feedback at the moment. @electriclilies, please follow up any feedback that is submitted post-land

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett updated this revision to Diff 554744. DavidSpickett added a comment. clang-format some missing bits. Replace a missing memcpy in the FPR case. This only works because the buffer happens to still contain the previous state. If there is some route to restore arbitray states, this wo

[Lldb-commits] [PATCH] D156687: [lldb][AArch64] Add kind marker to ReadAll/WriteALLRegisterValues data

DavidSpickett added a comment. First thing to note is that WriteRegister also behaves this way, but there it is more appropriate because it updates only part of the buffer before writing it out in its entirety. Useful to know where the pattern came from though. You would need roughly the follow

[Lldb-commits] [PATCH] D158583: Fix shared library loading when users define duplicate _r_debug structure.

clayborg added a comment. In D158583#4627644 , @DavidSpickett wrote: > The added context helps document what was already there so that's a nice > improvement. > > Something I'm not clear on mechanically. The original r_debug has eAdd set. > Then the se

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

This revision was automatically updated to reflect the committed changes. Closed by commit rG79d5d9a0824d: [lldb] Allow synthetic providers in C++ and fix linking problems (authored by wallace). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158010/ne

[Lldb-commits] [lldb] 79d5d9a - [lldb] Allow synthetic providers in C++ and fix linking problems

Author: walter erquinigo Date: 2023-08-30T14:14:28-04:00 New Revision: 79d5d9a0824ddcd5493a451e5009dd6393646e51 URL: https://github.com/llvm/llvm-project/commit/79d5d9a0824ddcd5493a451e5009dd6393646e51 DIFF: https://github.com/llvm/llvm-project/commit/79d5d9a0824ddcd5493a451e5009dd6393646e51.di

[Lldb-commits] [PATCH] D158010: [lldb] Allow synthetic providers in C++ and fix linking problems

jingham added a comment. Sorry, I got distracted, but after the fact I also agree this is reasonable. We might actually be able to support externally adding C++ based synthetic providers, though I think the best way to do that is to add a way to make an SBTypeSynthetic from the appropriate C++

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. LGTM this is just mechanical passing around of the user's setting though the layers. Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.h:76

[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

bulbazord added inline comments. Comment at: lldb/source/Core/Section.cpp:153 + case eSectionTypeSwiftModules: +return "swift-modules"; } compnerd wrote: > kastiglione wrote: > > I wonder if this should be "swiftmodules". I have never seen it spelled > >

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

ted added a comment. In D159101#4627705 , @DavidSpickett wrote: > I have some vague idea that maybe we could put a hack in the test suite to > use the qemu-user platform instead of lldb-server. To at least give it a go, > but I haven't tried it myself

[Lldb-commits] [lldb] 3621f83 - Don't enable stdin/out with a no-output test program

Author: Jason Molenda Date: 2023-08-30T15:12:31-07:00 New Revision: 3621f83804809fa50892ee81d9b3854ec2e5074f URL: https://github.com/llvm/llvm-project/commit/3621f83804809fa50892ee81d9b3854ec2e5074f DIFF: https://github.com/llvm/llvm-project/commit/3621f83804809fa50892ee81d9b3854ec2e5074f.diff

[Lldb-commits] [PATCH] D159234: [llvm-objdump] Enable assembly highlighting in llvm-objdump

JDevlieghere created this revision. JDevlieghere added reviewers: MaskRay, jhenderson. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Enable assembly highlighting in llvm-objdump. https://reviews

[Lldb-commits] [PATCH] D159237: [lldb][NFCI] Remove unneeded ConstString conversions

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham, fdeazeve. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. ConstString can be implicitly converted into a llvm::St

[Lldb-commits] [PATCH] D159142: [lldb] Add support for recognizing swift ast sections in object files

bulbazord added a comment. It seems like there is consensus for actually implementing this functionality but that there were some questions about the actual string. I hope everyone finds my reasoning understandable. If nobody has a strong objection to the actual string, I will land this tomorro

[Lldb-commits] [PATCH] D158833: [lldb] Move ScriptInterpreter Interfaces to subdirectory (NFC)

bulbazord added a comment. In D158833#4626023 , @mib wrote: > In D158833#4625775 , @bulbazord > wrote: > >> Re-organizing the paths seems okay to me, especially since this is going to >> grow further. I think th

[Lldb-commits] [PATCH] D159237: [lldb][NFCI] Remove unneeded ConstString conversions

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159237/new/ https://reviews.llvm.org/D159237 ___

[Lldb-commits] [PATCH] D159164: [lldb] Add assembly syntax highlighting

JDevlieghere updated this revision to Diff 554873. JDevlieghere added a comment. - Fix inconsistencies and use `use_color` everywhere CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159164/new/ https://reviews.llvm.org/D159164 Files: lldb/include/lldb/Core/Disassembler.h lldb/include

[Lldb-commits] [lldb] 394e52a - [lldb] NFC reflow comments in WatchpointLocations

Author: Jason Molenda Date: 2023-08-30T17:58:44-07:00 New Revision: 394e52a0bb576508e0fed59ab267e75cf1350fca URL: https://github.com/llvm/llvm-project/commit/394e52a0bb576508e0fed59ab267e75cf1350fca DIFF: https://github.com/llvm/llvm-project/commit/394e52a0bb576508e0fed59ab267e75cf1350fca.diff

[Lldb-commits] [PATCH] D159101: [RISC-V] Add RISC-V ABI plugin

kito-cheng added inline comments. Comment at: lldb/source/Plugins/Disassembler/LLVMC/DisassemblerLLVMC.cpp:1554 +// Turn them on by default now, since everyone seems to use them +features_str += "+a,+m,"; } DavidSpickett wrote: > ted wrote: > > DavidSp

[Lldb-commits] [PATCH] D159150: [lldb][NFCI] Replace bespoke iterator check with std::next

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM 🚢 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159150/new/ https://reviews.llvm.org/D159150 _