[Lldb-commits] [PATCH] D157214: [lldb] Fix typo in comments and in test

Eymay created this revision. Herald added a project: All. Eymay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D157214 Files: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFi

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 547589. bolshakov-a added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp clang/docs/Releas

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a updated this revision to Diff 547603. bolshakov-a added a comment. Fixes after review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140996/new/ https://reviews.llvm.org/D140996 Files: clang-tools-extra/clangd/DumpAST.cpp clang-tools-extra/clangd/FindTarget.cpp clang/

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. Btw, formatting of unrelated lines has leaked into `TemplateBase.h`. Sorry. Comment at: clang/lib/AST/MicrosoftMangle.cpp:1624-1626 + return const_cast( + V.getLValueBase().dyn_cast()); +} aaron.ballman wrote: > Does this work

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added inline comments. Comment at: clang/test/SemaTemplate/temp_arg_nontype_cxx20.cpp:56 +using CF = ComplexFloat<1.0f + 3.0fi>; +using CF = ComplexFloat<3.0fi + 1.0f>; bolshakov-a wrote: > aaron.ballman wrote: > > bolshakov-a wrote: > > > shafik wr

[Lldb-commits] [PATCH] D156086: [lldb][NFC] Use MCInstrAnalysis when available in the disassembler plugin

RamNalamothu marked an inline comment as done. RamNalamothu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156086/new/ https://reviews.llvm.org/D156086 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere updated this revision to Diff 547639. JDevlieghere added a comment. - Remove `Communication::Clear` method CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157159/new/ https://reviews.llvm.org/D157159 Files: lldb/include/lldb/Core/Communication.h lldb/include/lldb/Core/Th

[Lldb-commits] [PATCH] D157159: [lldb] Properly protect the Communication class with reader/writer lock

JDevlieghere added inline comments. Comment at: lldb/source/Core/ThreadedCommunication.cpp:63-67 -void ThreadedCommunication::Clear() { - SetReadThreadBytesReceivedCallback(nullptr, nullptr); - StopReadThread(nullptr); - Communication::Clear(); -} This wasn't

[Lldb-commits] [PATCH] D157152: [lldb] Make TSan errors fatal when running the test suite

JDevlieghere updated this revision to Diff 547641. JDevlieghere added a comment. Include the unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157152/new/ https://reviews.llvm.org/D157152 Files: lldb/test/API/lit.cfg.py lldb/test/Shell/lit.cfg.py lldb/test/Unit/lit.cfg.py