[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

Michael137 added a comment. @jwnhy Let me know which name and email I should attribute the patch to CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 ___ lldb-commits mailing list lldb-commits@lists.ll

[Lldb-commits] [lldb] c46d9af - Revert "Host: generalise `GetXcodeSDKPath`"

Author: Douglas Yung Date: 2023-05-01T10:22:53-07:00 New Revision: c46d9af26cefb0b24646d3235b75ae7a1b8548d4 URL: https://github.com/llvm/llvm-project/commit/c46d9af26cefb0b24646d3235b75ae7a1b8548d4 DIFF: https://github.com/llvm/llvm-project/commit/c46d9af26cefb0b24646d3235b75ae7a1b8548d4.diff

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd updated this revision to Diff 518520. kuilpd added a comment. Rebased and added a test. Instead of just getting a variable's address from allocated inside an expression, I decided to check for memory allocations inside logs. Exact variable address could change with the compilation change

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe updated this revision to Diff 518540. jgorbe added a comment. Addressed review comments: - Check pair values before attempting to call `GetChildMemberWithName` on them - Rename first child from `__value_` to `pointer`. This is friendlier and also matches the name used by the libstdcxx uni

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord updated this revision to Diff 518542. bulbazord added a comment. Sort output for dumping to be deterministic (based on alphabetical order like previous implementation) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/ https://rev

[Lldb-commits] [lldb] d366da9 - [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

Author: Jorge Gorbe Moya Date: 2023-05-01T13:08:04-07:00 New Revision: d366da97bd24ddfb91c9f260fa0aaf105d947652 URL: https://github.com/llvm/llvm-project/commit/d366da97bd24ddfb91c9f260fa0aaf105d947652 DIFF: https://github.com/llvm/llvm-project/commit/d366da97bd24ddfb91c9f260fa0aaf105d947652.di

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd366da97bd24: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters. (authored by jgorbe). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

bulbazord requested changes to this revision. bulbazord added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Host/macosx/objcxx/Host.mm:395-396 - static std::optional g_app_fsref; - static std::string g_app_error; - static std::once_f

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. Thanks for adding the test. The test itself doesn't seem portable and likely will fail on several platforms though I'm not sure which off the top of my head. After landing this, please w

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Core/Disassembler.cpp:805 - ConstString const_key(key.c_str()); + llvm::StringRef key_ref(key); // Check value to

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

aprantl added a comment. Looks like this broke on the Darwin incremental bot: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/54508/ Can you please take a look and revert in the mean time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

JDevlieghere updated this revision to Diff 518558. JDevlieghere marked 2 inline comments as done. JDevlieghere added a comment. Make `external-editor` setting take precedence over `LLDB_EXTRENAL_EDITOR` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149565/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

bulbazord accepted this revision. bulbazord added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149565/new/ https://reviews.llvm.org/D149565 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] b12b35a - [lldb] Add debugger.external-editor setting

Author: Jonas Devlieghere Date: 2023-05-01T14:11:11-07:00 New Revision: b12b35ad4bec98c028a1926e4891e746b1f55d2f URL: https://github.com/llvm/llvm-project/commit/b12b35ad4bec98c028a1926e4891e746b1f55d2f DIFF: https://github.com/llvm/llvm-project/commit/b12b35ad4bec98c028a1926e4891e746b1f55d2f.d

[Lldb-commits] [PATCH] D149565: [lldb] Add debugger.external-editor setting

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb12b35ad4bec: [lldb] Add debugger.external-editor setting (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe added a comment. Sure, I'll revert. Thanks for notifying me of the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148662/new/ https://reviews.llvm.org/D148662 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 4535112 - Revert "[lldb] Make the libcxx unique_ptr prettyprinter support custom deleters."

Author: Jorge Gorbe Moya Date: 2023-05-01T14:14:09-07:00 New Revision: 45351120105a7257ccb1e38ec1b1f8a452269da2 URL: https://github.com/llvm/llvm-project/commit/45351120105a7257ccb1e38ec1b1f8a452269da2 DIFF: https://github.com/llvm/llvm-project/commit/45351120105a7257ccb1e38ec1b1f8a452269da2.di

[Lldb-commits] [lldb] 930c8ac - Improve the help output for `type XXX delete` where XXX is summary, format,

Author: Jim Ingham Date: 2023-05-01T14:21:27-07:00 New Revision: 930c8ac5f56122251fc5fe7cb8584360924af62f URL: https://github.com/llvm/llvm-project/commit/930c8ac5f56122251fc5fe7cb8584360924af62f DIFF: https://github.com/llvm/llvm-project/commit/930c8ac5f56122251fc5fe7cb8584360924af62f.diff LO

[Lldb-commits] [PATCH] D148282: Fix the help for "type X delete" to make the -a & -w behaviors clear

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jingham marked an inline comment as done. Closed by commit rG930c8ac5f561: Improve the

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

bulbazord updated this revision to Diff 518569. bulbazord added a comment. Remove unneeded StringRef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/ https://reviews.llvm.org/D149482 Files: lldb/include/lldb/Interpreter/OptionValueDicti

[Lldb-commits] [lldb] e53e1de - [lldb] Change ObjectValueDictionary to use a StringMap

Author: Alex Langford Date: 2023-05-01T16:17:24-07:00 New Revision: e53e1de57eccda49a93c4368eabbd95d01c5b854 URL: https://github.com/llvm/llvm-project/commit/e53e1de57eccda49a93c4368eabbd95d01c5b854 DIFF: https://github.com/llvm/llvm-project/commit/e53e1de57eccda49a93c4368eabbd95d01c5b854.diff

[Lldb-commits] [PATCH] D149482: [lldb] Change ObjectValueDictionary to use a StringMap

This revision was automatically updated to reflect the committed changes. Closed by commit rGe53e1de57ecc: [lldb] Change ObjectValueDictionary to use a StringMap (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149482/new/ http

[Lldb-commits] [lldb] d69518b - Re-land "[lldb] Make the libcxx unique_ptr prettyprinter support custom deleters."

Author: Jorge Gorbe Moya Date: 2023-05-01T16:19:01-07:00 New Revision: d69518b4e52d527b3f8fcc41e90ae21f1f234555 URL: https://github.com/llvm/llvm-project/commit/d69518b4e52d527b3f8fcc41e90ae21f1f234555 DIFF: https://github.com/llvm/llvm-project/commit/d69518b4e52d527b3f8fcc41e90ae21f1f234555.di

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

jgorbe added a comment. Landed again, with a fix for the test that was failing on Darwin, as https://github.com/llvm/llvm-project/commit/d69518b4e52d527b3f8fcc41e90ae21f1f234555. I'll keep an eye on the build bot. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[Lldb-commits] [PATCH] D148662: [lldb] Make the libcxx unique_ptr prettyprinter support custom deleters.

aprantl added a comment. Thanks for the quick response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148662/new/ https://reviews.llvm.org/D148662 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D149625: [lldb] Refactor SBFileSpec::GetDirectory

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, mib, jingham. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. There's no reason to create an entire new filespec to mutate and

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

jgorbe added inline comments. Comment at: lldb/tools/lldb-vscode/VSCode.h:152 bool is_attach; + // The process event thread normally responds to process exited events by + // shutting down the entire adapter. When we're restarting, we keep the id of labath w

[Lldb-commits] [PATCH] D147831: [lldb-vscode] Implement RestartRequest

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. lgtm! Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:1983 + g_vsc.debugger.SetAsync(true); + LaunchProcess(*g_vsc.last_launch_or_attach_request); + j

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

jwnhy marked an inline comment as done. jwnhy added a comment. In D147370#4309481 , @Michael137 wrote: > @jwnhy Let me know which name and email I should attribute the patch to Oh, sorry. I am LU Hongyi, and the email is jwn...@gmail.com, my github acco

[Lldb-commits] [lldb] fdbe7c7 - [lldb] Refactor OptionValue to return a std::optional (NFC)

Author: Jonas Devlieghere Date: 2023-05-01T21:08:23-07:00 New Revision: fdbe7c7faa547b16bf6da0fedbb7234b6ee3adef URL: https://github.com/llvm/llvm-project/commit/fdbe7c7faa547b16bf6da0fedbb7234b6ee3adef DIFF: https://github.com/llvm/llvm-project/commit/fdbe7c7faa547b16bf6da0fedbb7234b6ee3adef.d

[Lldb-commits] [lldb] 9cb3af1 - [lldb] Fix bug introduced by fdbe7c7faa54

Author: Jonas Devlieghere Date: 2023-05-01T21:23:14-07:00 New Revision: 9cb3af1e8649444da7ac5080fe2ade70b5dc2992 URL: https://github.com/llvm/llvm-project/commit/9cb3af1e8649444da7ac5080fe2ade70b5dc2992 DIFF: https://github.com/llvm/llvm-project/commit/9cb3af1e8649444da7ac5080fe2ade70b5dc2992.d

[Lldb-commits] [lldb] fe3ee68 - [lldb] Fix warning: extra '; ' outside of a function is incompatible with C++98

Author: Jonas Devlieghere Date: 2023-05-01T21:23:47-07:00 New Revision: fe3ee680741d603dd1229571e86e62bdb88ea215 URL: https://github.com/llvm/llvm-project/commit/fe3ee680741d603dd1229571e86e62bdb88ea215 DIFF: https://github.com/llvm/llvm-project/commit/fe3ee680741d603dd1229571e86e62bdb88ea215.d

[Lldb-commits] [lldb] 76fb334 - [lldb] Remove TestExternalEditor.test

Author: Jonas Devlieghere Date: 2023-05-01T21:25:14-07:00 New Revision: 76fb3343029ea618c0cc14d1b20f82b7941cff5e URL: https://github.com/llvm/llvm-project/commit/76fb3343029ea618c0cc14d1b20f82b7941cff5e DIFF: https://github.com/llvm/llvm-project/commit/76fb3343029ea618c0cc14d1b20f82b7941cff5e.d

[Lldb-commits] [lldb] 9c48aa6 - [lldb] Refactor OptionValueProperties to return a std::optional (NFC)

Author: Jonas Devlieghere Date: 2023-05-01T21:46:32-07:00 New Revision: 9c48aa68f455a63fc5e20e196d3c3e8822bfa6af URL: https://github.com/llvm/llvm-project/commit/9c48aa68f455a63fc5e20e196d3c3e8822bfa6af DIFF: https://github.com/llvm/llvm-project/commit/9c48aa68f455a63fc5e20e196d3c3e8822bfa6af.d