DavidSpickett edited reviewers, added: omjavaid; removed: DavidSpickett.
DavidSpickett added a comment.
I don't know enough to approve, Omair is the expert here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148752/new/
https://reviews.llvm.org/D14
Author: Michael Buch
Date: 2023-04-24T08:33:07-04:00
New Revision: b767b050414399940f8d7f96e4564a1e5c84879f
URL:
https://github.com/llvm/llvm-project/commit/b767b050414399940f8d7f96e4564a1e5c84879f
DIFF:
https://github.com/llvm/llvm-project/commit/b767b050414399940f8d7f96e4564a1e5c84879f.diff
Author: Michael Buch
Date: 2023-04-24T08:40:32-04:00
New Revision: b4cae6bf53b92583e8d58f41e889704e9a473391
URL:
https://github.com/llvm/llvm-project/commit/b4cae6bf53b92583e8d58f41e889704e9a473391
DIFF:
https://github.com/llvm/llvm-project/commit/b4cae6bf53b92583e8d58f41e889704e9a473391.diff
Author: Michael Buch
Date: 2023-04-24T12:05:20-04:00
New Revision: 53791896de3fcc5606c190fa4e4552383ee1dcb8
URL:
https://github.com/llvm/llvm-project/commit/53791896de3fcc5606c190fa4e4552383ee1dcb8
DIFF:
https://github.com/llvm/llvm-project/commit/53791896de3fcc5606c190fa4e4552383ee1dcb8.diff
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148397/new/
https://reviews.llvm.org/D148397
___
lldb-commits mailing list
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda, clayborg.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
The goal of this patch is to speed up the
bulbazord added a comment.
Perhaps the right thing to do would be to try to do the larger FileSpec changes
instead? The changes in `Symbols::LocateExecutableSymbolFile` can probably go
in regardless though. We call `Resolve` on all the file specs in
`debug_file_search_paths` on line 307, so no
bulbazord created this revision.
bulbazord added reviewers: JDevlieghere, mib, jingham, jasonmolenda,
kastiglione, Michael137.
Herald added a project: All.
bulbazord requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This is useful in context
jingham updated this revision to Diff 516590.
jingham added a comment.
Adopt suggestions from Alex.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148282/new/
https://reviews.llvm.org/D148282
Files:
lldb/source/Commands/CommandObjectType.cpp
Ind
jingham marked 2 inline comments as done.
jingham added inline comments.
Comment at: lldb/source/Commands/CommandObjectType.cpp:879-885
+const char *CommandObjectTypeFormatterDelete::g_short_help_template =
+"Delete an existing %s for a type.";
+const char *CommandObjectType
10 matches
Mail list logo