[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

theraven added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:131 +ExecutionContext &exe_ctx) { + // TODO: This function is supposed to check whether an ObjC selector is +

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz marked 3 inline comments as done. sgraenitz added a comment. In D146154#4197454 , @aprantl wrote: > One thing I just realized — we need to make sure that we don't accidentally > create a GNUstep ObjC runtime in a Swift process that was built wi

[Lldb-commits] [PATCH] D146045: [LLDB] Show sub type of signals when debugging a core file

DavidSpickett updated this revision to Diff 505758. DavidSpickett added a comment. Update GetSignalDescription function name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146045/new/ https://reviews.llvm.org/D146045 Files: lldb/include/lldb/Tar

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz updated this revision to Diff 505760. sgraenitz marked 3 inline comments as done. sgraenitz added a comment. Extend the test to check both, zero initialization and assigned ivars Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ h

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

sgraenitz added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/GNUstepObjCRuntime/GNUstepObjCRuntime.cpp:131 +ExecutionContext &exe_ctx) { + // TODO: This function is supposed to check whether an ObjC selector is +

[Lldb-commits] [PATCH] D146221: [CodeView] Add source languages ObjC and ObjC++

sgraenitz created this revision. sgraenitz added reviewers: rnk, zturner, compnerd, aleksandr.urakov. Herald added a subscriber: hiraditya. Herald added a project: All. sgraenitz requested review of this revision. Herald added projects: LLDB, LLVM. Herald added a subscriber: lldb-commits. This pat

[Lldb-commits] [PATCH] D146154: [lldb][gnustep] Add minimal GNUstepObjCRuntime plugin for LanguageTypeObjC on non-Apple platforms

theraven added a comment. The test looks fine to me, I'm quite surprised that it passes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146154/new/ https://reviews.llvm.org/D146154 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D146222: [lldb] Add compile time checks for signal codes when on the matching platform

DavidSpickett created this revision. Herald added subscribers: krytarowski, arichardson, emaste. Herald added a project: All. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a new macro to the UnixSignals subclasses,

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

DavidSpickett marked 2 inline comments as done. DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:14 FreeBSDSignals::FreeBSDSignals() : UnixSignals() { Reset(); } void FreeBSDSignals::Reset() { DavidSpicke

[Lldb-commits] [PATCH] D146222: [lldb] Add compile time checks for signal codes when on the matching platform

emaste added inline comments. Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:14-16 +#ifndef SEGV_BNDERR +#define SEGV_BNDERR 3 +#endif I'm curious what this is for; we don't use it below? Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D146230: [lldb][test] Replace use of p with expression in Shell tests (NFC)

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere, mib. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In Shell tests, replace use of the `p` alias with the `expr

[Lldb-commits] [PATCH] D146230: [lldb][test] Replace use of p with expression in Shell tests (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. I probably would've gone with `expo` but as `expression` is the canonical name of the command, this makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[Lldb-commits] [PATCH] D146230: [lldb][test] Replace use of p with expression in Shell tests (NFC)

kastiglione added a comment. > I probably would've gone with `expr` I had it as `expr` at first and changed it to `expression`, since that's what I had done in D141539 . I'm down to change it to `expr`, I think it's probably fine too. Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D146262: [lldb] Set the watchpoint spec for expression watchpoints

JDevlieghere created this revision. JDevlieghere added reviewers: jingham, mib, delcypher. Herald added a project: All. JDevlieghere requested review of this revision. When setting a variable watchpoint, the watchpoint stores the variable name in the watchpoint spec. For expression variables we s

[Lldb-commits] [PATCH] D146262: [lldb] Set the watchpoint spec for expression watchpoints

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146262/new/ https://reviews.llvm.org/D146262 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D146263: [lldb] Move UnixSignals creation into Platform plugins

bulbazord created this revision. bulbazord added reviewers: JDevlieghere, jingham, mib, labath, clayborg. Herald added a subscriber: emaste. Herald added a project: All. bulbazord requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The high lev

[Lldb-commits] [PATCH] D108335: [lldb] Move UnixSignals subclasses to lldbTarget

bulbazord abandoned this revision. bulbazord added a comment. This is made defunct by https://reviews.llvm.org/D146263 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108335/new/ https://reviews.llvm.org/D108335 _

[Lldb-commits] [lldb] f341d7a - [lldb] Make MemoryCache::Read more resilient

Author: Alex Langford Date: 2023-03-16T15:22:46-07:00 New Revision: f341d7a4091a6ec1c1a4a49c4810d4a8b036ad60 URL: https://github.com/llvm/llvm-project/commit/f341d7a4091a6ec1c1a4a49c4810d4a8b036ad60 DIFF: https://github.com/llvm/llvm-project/commit/f341d7a4091a6ec1c1a4a49c4810d4a8b036ad60.diff

[Lldb-commits] [PATCH] D145624: [lldb] Make MemoryCache::Read more resilient

This revision was automatically updated to reflect the committed changes. Closed by commit rGf341d7a4091a: [lldb] Make MemoryCache::Read more resilient (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145624/new/ https://review

[Lldb-commits] [PATCH] D146043: [lldb] Refactor CrashReason

mysterymath added a comment. Hey, it looks like the reland of this is causing issues with the Fuchsia toolchain build: https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-linux-x64/b8786444992328058977/overview Seems that it's only legal to call AppendBounds if you first check

[Lldb-commits] [lldb] 88eb4cb - Remove #if guards from AppendBounds to fix compile on old POSIX.

Author: Daniel Thornburgh Date: 2023-03-16T16:16:21-07:00 New Revision: 88eb4cbbfe7ded9556131c3bd4228ee9e9d01b4d URL: https://github.com/llvm/llvm-project/commit/88eb4cbbfe7ded9556131c3bd4228ee9e9d01b4d DIFF: https://github.com/llvm/llvm-project/commit/88eb4cbbfe7ded9556131c3bd4228ee9e9d01b4d.d

[Lldb-commits] [PATCH] D146265: [lldb] Introduce SymbolFile::ParseAllLanguages

augusto2112 created this revision. augusto2112 added a reviewer: aprantl. Herald added a project: All. augusto2112 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, jplehr, sstefan1. Herald added a project: LLDB. SymbolFile::ParseAllLang

[Lldb-commits] [PATCH] D146222: [lldb] Add compile time checks for signal codes when on the matching platform

arichardson accepted this revision. arichardson added a comment. This revision is now accepted and ready to land. Much neater than my initial suggestion. LGTM Comment at: lldb/source/Plugins/Process/Utility/LinuxSignals.cpp:14 + +#ifndef SEGV_BNDERR +#define SEGV_BNDERR 3 -

[Lldb-commits] [PATCH] D146222: [lldb] Add compile time checks for signal codes when on the matching platform

arichardson added inline comments. Comment at: lldb/source/Plugins/Process/Utility/NetBSDSignals.cpp:15 +#ifndef SEGV_BNDERR +#define SEGV_BNDERR 3 +#endif Also unused like for FreeBSD? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://