[Lldb-commits] [PATCH] D142341: [LLDB][NFC] Fix valobj_sp null pointer checks in lldb/source/Plugins/Language/

xgupta added a comment. gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142341/new/ https://reviews.llvm.org/D142341 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

aprantl added a comment. > Alternatively, I suppose, the DWARF emission could just look at the preferred > name and use that as the DW_AT_type in all cases anyway? Avoids needing a new > attribute, etc, though would be a bit quirky in its own way. Am I understanding you correctly that you sugge

[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo created this revision. vporpo added a reviewer: aeubanks. Herald added subscribers: mattd, gchakrabarti, asavonic, snehasish, ormris, hiraditya. Herald added a project: All. vporpo requested review of this revision. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, jholewin

[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/unittests/IR/ModuleTest.cpp:49 EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare)); -M.getGlobalList().sort(compare); -

[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo updated this revision to Diff 497367. vporpo marked an inline comment as done. vporpo added a comment. Removed commented out lines from ModuleTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027

[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo added inline comments. Comment at: llvm/unittests/IR/ModuleTest.cpp:47-49 // Sort the globals by name. EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare)); -M.getGlobalList().sort(compare); I removed this because it is tes

[Lldb-commits] [lldb] eaeb8dd - [LLDB] add arch-specific watchpoint behavior defaults to lldb

Author: Jason Molenda Date: 2023-02-14T11:35:39-08:00 New Revision: eaeb8ddd4a9d3799470479a532e721d017f22a70 URL: https://github.com/llvm/llvm-project/commit/eaeb8ddd4a9d3799470479a532e721d017f22a70 DIFF: https://github.com/llvm/llvm-project/commit/eaeb8ddd4a9d3799470479a532e721d017f22a70.diff

[Lldb-commits] [PATCH] D143215: lldb can know architecture-dependent watchpoint behaviors, instead of depending on the remote stub

This revision was automatically updated to reflect the committed changes. Closed by commit rGeaeb8ddd4a9d: [LLDB] add arch-specific watchpoint behavior defaults to lldb (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D143215?vs=495976&id=497401#toc Repository: r

[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo updated this revision to Diff 497403. vporpo added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027 Files: clang/lib/CodeGen/CGHLSLRuntime.cpp clang/lib/CodeGen/CGObjCMac.cpp

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926 ___ lldb

[Lldb-commits] [PATCH] D144042: [lldb] Rename SetResultIsInternal to SetSuppressPersistentResult (NFC)

kastiglione created this revision. kastiglione added reviewers: jingham, Michael137, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Rename `SetResultIsInternal` and `GetResultIsInternal

[Lldb-commits] [lldb] 9093f3c - Report a useful error when someone passes an incorrect python class name.

Author: Jim Ingham Date: 2023-02-14T13:47:14-08:00 New Revision: 9093f3c39b8fa8ef836c627e1db329cd7349e9bb URL: https://github.com/llvm/llvm-project/commit/9093f3c39b8fa8ef836c627e1db329cd7349e9bb DIFF: https://github.com/llvm/llvm-project/commit/9093f3c39b8fa8ef836c627e1db329cd7349e9bb.diff LO

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

kastiglione created this revision. kastiglione added reviewers: jingham, Michael137, augusto2112. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Remove the persistent result variable after executing

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

kastiglione added a comment. I'll update with a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144044/new/ https://reviews.llvm.org/D144044 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D139740: [lldb] Disable macro redefinition warnings in expression wrapper

teemperor updated this revision to Diff 497440. teemperor added a comment. - Address builtin redefining (Thanks Michael!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139740/new/ https://reviews.llvm.org/D139740 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSource

[Lldb-commits] [PATCH] D139740: [lldb] Disable macro redefinition warnings in expression wrapper

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f3a3e1f3f97: [lldb] Disable macro redefinition warnings in expression wrapper (authored by teemperor). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [lldb] 9f3a3e1 - [lldb] Disable macro redefinition warnings in expression wrapper

Author: Raphael Isemann Date: 2023-02-14T23:20:56+01:00 New Revision: 9f3a3e1f3f9767ae52c492d20d63f65e82319ed2 URL: https://github.com/llvm/llvm-project/commit/9f3a3e1f3f9767ae52c492d20d63f65e82319ed2 DIFF: https://github.com/llvm/llvm-project/commit/9f3a3e1f3f9767ae52c492d20d63f65e82319ed2.dif

[Lldb-commits] [lldb] ed3e3ee - [NFC][IR] Make Module::getGlobalList() private

Author: Vasileios Porpodas Date: 2023-02-14T14:25:10-08:00 New Revision: ed3e3ee9e30dfbffd2170a770a49b36a7f444916 URL: https://github.com/llvm/llvm-project/commit/ed3e3ee9e30dfbffd2170a770a49b36a7f444916 DIFF: https://github.com/llvm/llvm-project/commit/ed3e3ee9e30dfbffd2170a770a49b36a7f444916.

[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGed3e3ee9e30d: [NFC][IR] Make Module::getGlobalList() private (authored by vporpo). Changed prior to commit: https://reviews.llvm.org/D144027?vs=49

[Lldb-commits] [lldb] cb5f239 - Revert "[NFC][IR] Make Module::getGlobalList() private"

Author: Vasileios Porpodas Date: 2023-02-14T14:29:42-08:00 New Revision: cb5f239363a3c94db5425c105fcd45e77d2a16a9 URL: https://github.com/llvm/llvm-project/commit/cb5f239363a3c94db5425c105fcd45e77d2a16a9 DIFF: https://github.com/llvm/llvm-project/commit/cb5f239363a3c94db5425c105fcd45e77d2a16a9.

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

kastiglione updated this revision to Diff 497453. kastiglione added a comment. Respect verbosity level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144044/new/ https://reviews.llvm.org/D144044 Files: lldb/source/Commands/CommandObjectExpression

[Lldb-commits] [lldb] 823186b - Recommit: [NFC][IR] Make Module::getGlobalList() private

Author: Vasileios Porpodas Date: 2023-02-14T15:12:51-08:00 New Revision: 823186b14dc97c950a808f6f4b434d399da9a220 URL: https://github.com/llvm/llvm-project/commit/823186b14dc97c950a808f6f4b434d399da9a220 DIFF: https://github.com/llvm/llvm-project/commit/823186b14dc97c950a808f6f4b434d399da9a220.

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda added inline comments. Comment at: lldb/source/API/SBValue.cpp:936 + if (ABISP abi_sp = process_sp->GetABI()) +return abi_sp->FixCodeAddress(ret_val); +return ret_val; DavidSpickett wrote: > We've talked about this before, and for no

[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

fmayer added a comment. This seems to have broken our buildbot: https://lab.llvm.org/buildbot/#/builders/169/builds/16797/steps/8/logs/stdio CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /b/sanitizer-x86_64-linux-qemu/build/llvm_build0/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_

[Lldb-commits] [PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

vporpo added a comment. Yeah sorry about that, I reverted it here: b5f239363a3 Revert "[NFC][IR] Make Module::getGlobalList() private" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144027/new/ https://reviews.llvm.org/D144027

[Lldb-commits] [PATCH] D142792: Add SBValue::GetValueAsAddress(), strip off ptrauth, TBI, MTE bits on AArch64 systems

jasonmolenda updated this revision to Diff 497461. jasonmolenda added a comment. Updated patch to address David's feedback. Thanks David! Updated comments and SB API doc to conform to English. Not decided on whether we should use FixCodeAddress for our strippings here; the difference between

[Lldb-commits] [PATCH] D144044: [lldb] Suppress persistent result when running po

kastiglione updated this revision to Diff 497466. kastiglione added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144044/new/ https://reviews.llvm.org/D144044 Files: lldb/source/Commands/CommandObjectExpression.cpp lldb/te

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 497467. ayermolo added a comment. fixed cross-project tests, and also normal test that I somehow missed. Need to get access to windows machine to figure out why that fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 497468. ayermolo added a comment. small clenaup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/include/lldb/Core/dwarf.h lldb/include/lldb/Symbol/DW

[Lldb-commits] [PATCH] D143955: Revert "[lldb] Use portable format string PRIx64"

pranavk updated this revision to Diff 497496. pranavk added a comment. Fix Bazel build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143955/new/ https://reviews.llvm.org/D143955 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp