[Lldb-commits] [PATCH] D143727: [Test][lldb] Fix YAML mapping keys duplication. NFC.

DavidSpickett accepted this revision. DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143727/new/ https://reviews.llvm.org/D143727 __

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

DavidSpickett updated this revision to Diff 496877. DavidSpickett added a comment. Address Jonas' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142715/new/ https://reviews.llvm.org/D142715 Files: lldb/include/lldb/Interpreter/OptionArg

[Lldb-commits] [lldb] e6ec76c - [LLDB] Apply FixCodeAddress to all forms of address arguments

Author: David Spickett Date: 2023-02-13T10:15:52Z New Revision: e6ec76c647aaa335de48b8534d3a044346d9656f URL: https://github.com/llvm/llvm-project/commit/e6ec76c647aaa335de48b8534d3a044346d9656f DIFF: https://github.com/llvm/llvm-project/commit/e6ec76c647aaa335de48b8534d3a044346d9656f.diff LOG

[Lldb-commits] [PATCH] D142715: [LLDB] Apply FixCodeAddress to all forms of address arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6ec76c647aa: [LLDB] Apply FixCodeAddress to all forms of address arguments (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142715

[Lldb-commits] [lldb] 3c160d3 - [lldb][Test][NFC] TestExternalCtorDtorLookup: add more instantiations to test linkage name is correct

Author: Michael Buch Date: 2023-02-13T12:51:05Z New Revision: 3c160d3051dc5d637bd35cfa673871338589ad8e URL: https://github.com/llvm/llvm-project/commit/3c160d3051dc5d637bd35cfa673871338589ad8e DIFF: https://github.com/llvm/llvm-project/commit/3c160d3051dc5d637bd35cfa673871338589ad8e.diff LOG:

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:402 DWARFUnit &unit, llvm::function_ref callback) { - lldbassert(!unit.GetSymbolFileDWARF().Ge

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

labath added a comment. Thank you for your patience. I'm really happy with the overall result here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 ___ lldb-com

[Lldb-commits] [lldb] afe9b0b - [Test][lldb] Fix YAML mapping keys duplication. NFC.

Author: Anton Sidorenko Date: 2023-02-13T16:41:15+03:00 New Revision: afe9b0ba87b7347614bdb043c919fe0a4fb1006b URL: https://github.com/llvm/llvm-project/commit/afe9b0ba87b7347614bdb043c919fe0a4fb1006b DIFF: https://github.com/llvm/llvm-project/commit/afe9b0ba87b7347614bdb043c919fe0a4fb1006b.dif

[Lldb-commits] [PATCH] D143727: [Test][lldb] Fix YAML mapping keys duplication. NFC.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGafe9b0ba87b7: [Test][lldb] Fix YAML mapping keys duplication. NFC. (authored by asi-sc). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

labath added inline comments. Comment at: lldb/test/API/lang/cpp/external_ctor_dtor_lookup/TestExternalCtorDtorLookup.py:28 +# CHECK: |-CXXConstructorDecl {{.*}} Wrapper 'void ()' +# CHECK-NEXT: | `-AsmLabelAttr {{.*}} Implicit "_ZN7WrapperI3FooEC1B4testEv" +# CH

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/external_ctor_dtor_lookup/TestExternalCtorDtorLookup.py:28 +# CHECK: |-CXXConstructorDecl {{.*}} Wrapper 'void ()' +# CHECK-NEXT: | `-AsmLabelAttr {{.*}} Implicit "_ZN7WrapperI3FooEC1B4testEv" +

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/external_ctor_dtor_lookup/TestExternalCtorDtorLookup.py:28 +# CHECK: |-CXXConstructorDecl {{.*}} Wrapper 'void ()' +# CHECK-NEXT: | `-AsmLabelAttr {{.*}} Implicit "_ZN7WrapperI3FooEC1B4testEv" +

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:358 case DW_TAG_namespace: +case DW_TAG_imported_declaration: if (name) SGTM. Repository: rG LLVM Github Monor

[Lldb-commits] [lldb] 6e10e6c - Reland "[lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation"

Author: Michael Buch Date: 2023-02-13T16:58:05Z New Revision: 6e10e6cb8fab015952edbc86d82e85b991ad26dc URL: https://github.com/llvm/llvm-project/commit/6e10e6cb8fab015952edbc86d82e85b991ad26dc DIFF: https://github.com/llvm/llvm-project/commit/6e10e6cb8fab015952edbc86d82e85b991ad26dc.diff LOG:

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e10e6cb8fab: Reland "[lldb][DWARFASTParserClang] Correctly resolve imported namespaces… (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

labath added inline comments. Comment at: lldb/test/API/lang/cpp/external_ctor_dtor_lookup/TestExternalCtorDtorLookup.py:28 +# CHECK: |-CXXConstructorDecl {{.*}} Wrapper 'void ()' +# CHECK-NEXT: | `-AsmLabelAttr {{.*}} Implicit "_ZN7WrapperI3FooEC1B4testEv" +# CH

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

labath added a comment. In D142926#4103185 , @bulbazord wrote: > In D142926#4102287 , @labath wrote: > >> I like this. >> >> I'm not sure what it would take, but I think it'd be nice if the >> de-swig-ification w

[Lldb-commits] [PATCH] D143652: [lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing

Michael137 added inline comments. Comment at: lldb/test/API/lang/cpp/external_ctor_dtor_lookup/TestExternalCtorDtorLookup.py:28 +# CHECK: |-CXXConstructorDecl {{.*}} Wrapper 'void ()' +# CHECK-NEXT: | `-AsmLabelAttr {{.*}} Implicit "_ZN7WrapperI3FooEC1B4testEv" +

[Lldb-commits] [lldb] 8a57748 - Revert "[lldb][Test][NFC] TestExternalCtorDtorLookup: add more instantiations to test linkage name is correct"

Author: Michael Buch Date: 2023-02-13T18:09:31Z New Revision: 8a57748804bd2247a8c0c5632af3364db58a087f URL: https://github.com/llvm/llvm-project/commit/8a57748804bd2247a8c0c5632af3364db58a087f DIFF: https://github.com/llvm/llvm-project/commit/8a57748804bd2247a8c0c5632af3364db58a087f.diff LOG:

[Lldb-commits] [lldb] bf7c421 - Revert "Reland "[lldb][DWARFASTParserClang] Attach linkage name to ctors/dtors if missing""

Author: Michael Buch Date: 2023-02-13T18:09:32Z New Revision: bf7c421617007d7202dcd74762cef3a49425bfab URL: https://github.com/llvm/llvm-project/commit/bf7c421617007d7202dcd74762cef3a49425bfab DIFF: https://github.com/llvm/llvm-project/commit/bf7c421617007d7202dcd74762cef3a49425bfab.diff LOG:

[Lldb-commits] [PATCH] D143932: Further delay simulator SDK filepath discovery until needed

jasonmolenda created this revision. jasonmolenda added a reviewer: aprantl. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. In https://reviews.llvm.org

[Lldb-commits] [lldb] f841c4a - [lldb] Fix image lookup crash

Author: Alex Langford Date: 2023-02-13T10:55:10-08:00 New Revision: f841c4af5f5ec88c33130ad744ee57ad672f URL: https://github.com/llvm/llvm-project/commit/f841c4af5f5ec88c33130ad744ee57ad672f DIFF: https://github.com/llvm/llvm-project/commit/f841c4af5f5ec88c33130ad744ee57ad672f.diff

[Lldb-commits] [PATCH] D143792: [lldb] Fix image lookup crash

This revision was automatically updated to reflect the committed changes. Closed by commit rGf841c4af5f5e: [lldb] Fix image lookup crash (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143792/new/ https://reviews.llvm.org/D143

[Lldb-commits] [PATCH] D143842: [lldb][test] Add check for Xcode binutils version to test-runner

aprantl added a comment. Should we put something like #if DARWIN STRIP=$(shell xcrun -find strip) #else STRIP=strip #fi in Makefile.rules instead? Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:889 +toolchain. Please make sure the Xcode tools are before a

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 497064. ayermolo marked an inline comment as done. ayermolo added a comment. Added asserts back in Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 Files: lldb/incl

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:402 DWARFUnit &unit, llvm::function_ref callback) { - lldbassert(!unit.GetSymbolFileDWARF().GetDwoNum()); + lldbassert(!unit.GetSymbolFileDWARF().GetFileIndex()); Index

[Lldb-commits] [lldb] f36fe00 - [LLDB] Enable 64 bit debug/type offset

Author: Alexander Yermolovich Date: 2023-02-13T13:08:01-08:00 New Revision: f36fe009c0fc1d655bfc6168730bedfa1b36e622 URL: https://github.com/llvm/llvm-project/commit/f36fe009c0fc1d655bfc6168730bedfa1b36e622 DIFF: https://github.com/llvm/llvm-project/commit/f36fe009c0fc1d655bfc6168730bedfa1b36e6

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

This revision was automatically updated to reflect the committed changes. Closed by commit rGf36fe009c0fc: [LLDB] Enable 64 bit debug/type offset (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D143932: Further delay simulator SDK filepath discovery until needed

JDevlieghere added a comment. LGTM with the `std::move`. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:50-51 m_os_type(preferred_os), m_supported_triples(supported_triples), - m_sdk(sdk), m_sdk_type(sdk_type) {} + m_sdk_name_primary

[Lldb-commits] [lldb] be7d7ca - [lldb] Use portable format string PRIx64

Author: Benjamin Kramer Date: 2023-02-13T22:45:21+01:00 New Revision: be7d7ca1101840fc8e19e0e48f9dc395da569d23 URL: https://github.com/llvm/llvm-project/commit/be7d7ca1101840fc8e19e0e48f9dc395da569d23 DIFF: https://github.com/llvm/llvm-project/commit/be7d7ca1101840fc8e19e0e48f9dc395da569d23.dif

[Lldb-commits] [lldb] 620b3d9 - Revert "[LLDB] Enable 64 bit debug/type offset"

Author: Alexander Yermolovich Date: 2023-02-13T14:08:40-08:00 New Revision: 620b3d9ba3343d7bc5bab2340174a20952fcd00f URL: https://github.com/llvm/llvm-project/commit/620b3d9ba3343d7bc5bab2340174a20952fcd00f DIFF: https://github.com/llvm/llvm-project/commit/620b3d9ba3343d7bc5bab2340174a20952fcd0

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo reopened this revision. ayermolo added a comment. This revision is now accepted and ready to land. Had to revert, broke some build bots. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138618/new/ https://reviews.llvm.org/D138618 ___

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In D142926#4123492 , @labath wrote: > Well... right now, there isn't anything else to do there. > > Anyway, I don't think this is particularly important. I don't know even if > the distros would like to do this or whether to th

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord updated this revision to Diff 497117. bulbazord added a comment. Rebasing against top of tree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142926/new/ https://reviews.llvm.org/D142926 Files: lldb/bindings/CMakeLists.txt lldb/binding

[Lldb-commits] [PATCH] D143955: Revert "[lldb] Use portable format string PRIx64"

pranavk created this revision. Herald added a project: All. pranavk requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This reverts commit be7d7ca1101840fc8e19e0e48f9dc395da569d23

[Lldb-commits] [PATCH] D143501: [clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

dblaikie added a comment. > I think /maybe/ we had some design principle that DWARF features wouldn't be > solely controlled by debugger tuning, the tuning only indicates defaults but > tehy can be controlled by flags? Not sure if I'm remembering that quite > right, though - maybe @probinson re

[Lldb-commits] [lldb] ee88f11 - Find SDK path more lazily in Apple Simulator platforms

Author: Jason Molenda Date: 2023-02-13T15:16:41-08:00 New Revision: ee88f11770032eac8998664e7102d37f54b9f027 URL: https://github.com/llvm/llvm-project/commit/ee88f11770032eac8998664e7102d37f54b9f027 DIFF: https://github.com/llvm/llvm-project/commit/ee88f11770032eac8998664e7102d37f54b9f027.diff

[Lldb-commits] [PATCH] D143932: Further delay simulator SDK filepath discovery until needed

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGee88f1177003: Find SDK path more lazily in Apple Simulator platforms (authored by jasonmolenda). Changed prior to commit:

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

yinghuitan updated this revision to Diff 497133. yinghuitan added a comment. Address review comments by using the same type for internal and public callbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143520/new/ https://reviews.llvm.org/D1435

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

vporpo created this revision. vporpo added a reviewer: aeubanks. Herald added subscribers: ormris, jeroen.dobbelaere, hiraditya. Herald added a project: All. vporpo requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. This patc

[Lldb-commits] [lldb] 5402110 - Revert "[lldb] Use portable format string PRIx64"

Author: Pranav Kant Date: 2023-02-13T15:51:36-08:00 New Revision: 5402110e0123ca323a5f6eaa3ed225027ce0179b URL: https://github.com/llvm/llvm-project/commit/5402110e0123ca323a5f6eaa3ed225027ce0179b DIFF: https://github.com/llvm/llvm-project/commit/5402110e0123ca323a5f6eaa3ed225027ce0179b.diff L

[Lldb-commits] [PATCH] D143955: Revert "[lldb] Use portable format string PRIx64"

saugustine added a comment. Committed as 5402110e0123ca323a5f6eaa3ed225027ce0179b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143955/new/ https://reviews.llvm.org/D143955 __

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

aeubanks added inline comments. Herald added subscribers: Michael137, JDevlieghere. Comment at: llvm/include/llvm/IR/Module.h:573 + /// Inserts \p Alias into the alias list before \p Where and takes ownership. + void insertAlias(AliasListType::iterator Where, GlobalAlias *Alias

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

vporpo added inline comments. Comment at: llvm/include/llvm/IR/Module.h:573 + /// Inserts \p Alias into the alias list before \p Where and takes ownership. + void insertAlias(AliasListType::iterator Where, GlobalAlias *Alias) { +AliasList.insert(Where, Alias); -

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

aeubanks added inline comments. Comment at: llvm/include/llvm/IR/Module.h:566 + /// Detaches \p Alias from the list but does not delete it. + void removeAlias(GlobalAlias *Alias) { AliasList.remove(Alias); } use the imperative `Detach` instead of `Detaches` (

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

vporpo updated this revision to Diff 497150. vporpo marked an inline comment as done. vporpo added a comment. Addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143958/new/ https://reviews.llvm.org/D143958 Files: lldb/source/Expres

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143958/new/ https://reviews.llvm.org/D143958 ___

[Lldb-commits] [lldb] b64f7d0 - [NFC][IR] Make Module::getAliasList() private

Author: Vasileios Porpodas Date: 2023-02-13T18:45:12-08:00 New Revision: b64f7d028bdcaf679130afeed9518c09663f6dc8 URL: https://github.com/llvm/llvm-project/commit/b64f7d028bdcaf679130afeed9518c09663f6dc8 DIFF: https://github.com/llvm/llvm-project/commit/b64f7d028bdcaf679130afeed9518c09663f6dc8.

[Lldb-commits] [PATCH] D143958: [NFC][IR] Make Module::getAliasList() private

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb64f7d028bdc: [NFC][IR] Make Module::getAliasList() private (authored by vporpo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 6d4a674 - Revert "[NFC][IR] Make Module::getAliasList() private"

Author: Vasileios Porpodas Date: 2023-02-13T19:12:30-08:00 New Revision: 6d4a674acbc56458bb084878d82d16e393d45a6b URL: https://github.com/llvm/llvm-project/commit/6d4a674acbc56458bb084878d82d16e393d45a6b DIFF: https://github.com/llvm/llvm-project/commit/6d4a674acbc56458bb084878d82d16e393d45a6b.

[Lldb-commits] [lldb] afad153 - Recommit: [NFC][IR] Make Module::getAliasList() private

Author: Vasileios Porpodas Date: 2023-02-13T20:07:56-08:00 New Revision: afad153a0890aadd1d239a4f8b94d201863c18f6 URL: https://github.com/llvm/llvm-project/commit/afad153a0890aadd1d239a4f8b94d201863c18f6 DIFF: https://github.com/llvm/llvm-project/commit/afad153a0890aadd1d239a4f8b94d201863c18f6.

[Lldb-commits] [PATCH] D140996: [c++20] P1907R1: Support for generalized non-type template arguments of scalar type.

bolshakov-a added a comment. @aaron.ballman, @rsmith, @mizvekov, @shafik, has the mankind any chance to get this reviewed and merged? Btw, FYI, I've investigated the Chromium compilation crash that caused the rollback in 8ba442bc2136