Author: Michael Buch
Date: 2023-02-12T10:14:43Z
New Revision: 19128792e2aa320c1a149f7f93638cbd7f3c83c6
URL:
https://github.com/llvm/llvm-project/commit/19128792e2aa320c1a149f7f93638cbd7f3c83c6
DIFF:
https://github.com/llvm/llvm-project/commit/19128792e2aa320c1a149f7f93638cbd7f3c83c6.diff
LOG:
Michael137 created this revision.
Herald added a project: All.
Michael137 requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Some tests in LLDB require the use of binutils tools. On Darwin,
we need to use the tools that ship with Xcode. Otherw
tschuett added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:889
+toolchain. Please make sure the Xcode tools are before any
+other tools in your path. Run `xcode -f strip` for the correct
+toolchain path.
Did you mean `xcrun -f strip
Michael137 added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:889
+toolchain. Please make sure the Xcode tools are before any
+other tools in your path. Run `xcode -f strip` for the correct
+toolchain path.
tschuett wrote:
> Did you
Michael137 added a comment.
My preference would be to check explicitly whether the tool is from the xcode
toolchain. But the tools dont really have a distinguishable version (in fact
the `strip` from Xcode doesnt have a version commandline flag. Perhaps that’s
deliberate and a good way to disbi
Michael137 reopened this revision.
Michael137 added a comment.
This revision is now accepted and ready to land.
Reopening to Ireland slightly adjusted patch.
New patch makes sure we populate the `ManualDWARFIndex` with
`DW_TAG_imported_declaration`.
Repository:
rG LLVM Github Monorepo
CHANGE
Michael137 updated this revision to Diff 496774.
Michael137 added a comment.
Herald added a subscriber: arphaman.
- Populate `ManualDWARFIndex`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143398/new/
https://reviews.llvm.org/D143398
Files:
lld
Michael137 updated this revision to Diff 496775.
Michael137 added a comment.
- Remove redundant header
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143398/new/
https://reviews.llvm.org/D143398
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFAS
Author: Jonas Devlieghere
Date: 2023-02-12T11:17:58-08:00
New Revision: 129eb5bcab91a12ed3c4712279f201834ae2d8e1
URL:
https://github.com/llvm/llvm-project/commit/129eb5bcab91a12ed3c4712279f201834ae2d8e1
DIFF:
https://github.com/llvm/llvm-project/commit/129eb5bcab91a12ed3c4712279f201834ae2d8e1.d
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG129eb5bcab91: [lldb] Add the ability to provide a message to
a progress event update (authored by JDevlieghere).
Herald added a project: LLDB.
Repos
10 matches
Mail list logo