[Lldb-commits] [lldb] 27aeb58 - [NFC][TargetParser] Remove llvm/Support/ARMTargetParser.h

Author: Archibald Elliott Date: 2023-02-07T11:05:58Z New Revision: 27aeb58ce4d12e15b966dba86738eb65a96703f7 URL: https://github.com/llvm/llvm-project/commit/27aeb58ce4d12e15b966dba86738eb65a96703f7 DIFF: https://github.com/llvm/llvm-project/commit/27aeb58ce4d12e15b966dba86738eb65a96703f7.diff

[Lldb-commits] [PATCH] D143347: [lldb][DWARF] Infer no_unique_address attribute

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:3896 + if (D->hasAttrs()) +ToField->setAttrs(D->getAttrs()); ToField->setAccess(D->getAccess()); The import of attributes is handled in function `ASTImporter::Import(Decl*)`. This

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

Michael137 updated this revision to Diff 495469. Michael137 added a comment. - use `find()` instead of `operator[]` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143398/new/ https://reviews.llvm.org/D143398 Files: lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D143398: [lldb][DWARFASTParserClang] Correctly resolve imported namespaces during expression evaluation

Michael137 updated this revision to Diff 495470. Michael137 added a comment. - Reduce scope of variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143398/new/ https://reviews.llvm.org/D143398 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFA

[Lldb-commits] [PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 created this revision. Michael137 added reviewers: aprantl, dblaikie. Herald added a project: All. Michael137 requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. **Summary** This patch makes debug-info generation a

[Lldb-commits] [PATCH] D143501: [WIP][clang][DebugInfo] lldb: Use preferred name's type when emitting DW_AT_names

Michael137 added a comment. Herald added a subscriber: JDevlieghere. The alternative would be attaching the preferred name as a new attribute or an existing attribute like `DW_AT_description`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143501/ne

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo updated this revision to Diff 495582. ayermolo added a comment. Implemented Gregs suggestion. Also consolidated three diffs back into one. To make it clear the scope of changes, and for ease of testing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, kusmour, GeorgeHuyubo. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Adding a new S

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada updated this revision to Diff 495609. domada added a reviewer: akyrtzi. domada added a comment. Added changes in `clang/lib/AST/CMakeLists.txt` to address build issue reported by @akyrtzi . I modified CMakeLists.txt so that it requires generation of missing `Attributes.inc`. @akyrtzi P

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

domada updated this revision to Diff 495627. domada added a comment. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141910/new/ https://reviews.llvm.org/D141910 Files: clang/include/clang/Basic/TargetInfo.h clang/lib/AST/ASTContext.cpp clang/lib/AST/CMakeLists.txt

[Lldb-commits] [PATCH] D141910: [OpenMP][OMPIRBuilder]Move SIMD alignment calculation to LLVM Frontend

akyrtzi added a comment. In D141910#4111048 , @domada wrote: > Added changes in `clang/lib/AST/CMakeLists.txt` to address build issue > reported by @akyrtzi . > > I modified CMakeLists.txt so that it requires generation of missing > `Attributes.inc`. >

[Lldb-commits] [PATCH] D143012: Add a bit of error checking to SBProcess::ReadMemory to check if a nullptr destination buffer was provided, return error

jasonmolenda updated this revision to Diff 495634. jasonmolenda added a comment. Update patch for Jonas' suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143012/new/ https://reviews.llvm.org/D143012 Files: lldb/source/API/SBProcess.cpp

[Lldb-commits] [PATCH] D143520: Add a new SBDebugger::SetDestroyCallback() API

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. If I am reading the code for this patch correctly, we need the BatonSP stuff because we have differing callback bytes for public vs private APIs. If we switch to using a common c

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

clayborg added a comment. Very clean patch now, just a few nits about asserts! Comment at: lldb/source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp:129 DWARFUnit &cu, llvm::function_ref callback) { - lldbassert(!cu.GetSymbolFileDWARF().GetDwoNum()); + lldbassert(!cu

[Lldb-commits] [lldb] 62c7475 - Check if null buffer handed to SBProcess::ReadMemory

Author: Jason Molenda Date: 2023-02-07T14:16:04-08:00 New Revision: 62c747517cd9a0d57f198e0fd0984f71fe75240f URL: https://github.com/llvm/llvm-project/commit/62c747517cd9a0d57f198e0fd0984f71fe75240f DIFF: https://github.com/llvm/llvm-project/commit/62c747517cd9a0d57f198e0fd0984f71fe75240f.diff

[Lldb-commits] [PATCH] D143012: Add a bit of error checking to SBProcess::ReadMemory to check if a nullptr destination buffer was provided, return error

This revision was automatically updated to reflect the committed changes. Closed by commit rG62c747517cd9: Check if null buffer handed to SBProcess::ReadMemory (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143012/new/ htt

[Lldb-commits] [lldb] 4a8cc28 - Fix TestProcessAPI.py to only allocate sys.maxsize buffer

Author: Jason Molenda Date: 2023-02-07T16:05:24-08:00 New Revision: 4a8cc285e9f3252ca31941dccfddf8fd10c9911b URL: https://github.com/llvm/llvm-project/commit/4a8cc285e9f3252ca31941dccfddf8fd10c9911b DIFF: https://github.com/llvm/llvm-project/commit/4a8cc285e9f3252ca31941dccfddf8fd10c9911b.diff

[Lldb-commits] [lldb] b1d8f40 - Only run the weird new try-to-read-too-much test on Darwin

Author: Jason Molenda Date: 2023-02-07T16:05:24-08:00 New Revision: b1d8f40484dfcb28b19c83aa33a674308b17e5dc URL: https://github.com/llvm/llvm-project/commit/b1d8f40484dfcb28b19c83aa33a674308b17e5dc DIFF: https://github.com/llvm/llvm-project/commit/b1d8f40484dfcb28b19c83aa33a674308b17e5dc.diff

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

jasonmolenda updated this revision to Diff 495686. jasonmolenda added a comment. Went over the rewrite one more time, fixing up comments, fixing a couple of logic bugs I wrote, and having tested it with a debugserver I hacked to remove the `watchpoint_exceptions_received:before;` key in the qHos

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory

JDevlieghere updated this revision to Diff 495693. JDevlieghere marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135631/new/ https://reviews.llvm.org/D135631 Files: lldb/source/Core/Debugger.cpp lldb/test/Shell/Diagnostics/Inputs/TestCopyLogs.in lldb/

[Lldb-commits] [PATCH] D141425: [lldb] Add --gdb-format flag to dwim-print

kastiglione updated this revision to Diff 495694. kastiglione added a comment. Add test with standard lldb flags Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141425/new/ https://reviews.llvm.org/D141425 Files: lldb/source/Commands/CommandObject

[Lldb-commits] [PATCH] D142926: [lldb][RFC] Replace SB swig interfaces with API headers

bulbazord updated this revision to Diff 495695. bulbazord added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: Michael137, sstefan1. First pass at a complete implementation. Actions taken: - Added swig flags to ignore swig warnings indicating that swig is ignoring certa

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

bulbazord added a comment. In addition to what I wrote above, I also fixed several documentation bugs (putting docstrings on the wrong method). I manually audited the generated code before and after this change. Here are my notes: Not too interesting: - Some parameter names changed - Fixed lo

[Lldb-commits] [PATCH] D142926: [lldb] Replace SB swig interfaces with API headers

JDevlieghere added a comment. I can see how having parity between the signatures that were exposed in the interface files makes the verification easier, but do we actually want to land the patch like that? Does anyone care that we expose more? Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D143215: Separate Process::GetWatchpointSupportInfo into two methods to get the two separate pieces of information

jasonmolenda added a comment. If I was going to describe this patch briefly at this point, I would say: "Change lldb from depending on the remote gdb stub to tell it whether watchpoints are received before or after the instruction, to knowing the architectures where watchpoint exceptions are re

[Lldb-commits] [PATCH] D143548: [lldb] Add the ability to remove diagnostic callbacks

JDevlieghere created this revision. JDevlieghere added reviewers: mib, bulbazord, labath. Herald added a project: All. JDevlieghere requested review of this revision. Add the ability to remove diagnostic callbacks. https://reviews.llvm.org/D143548 Files: lldb/include/lldb/Utility/Diagnostics.

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory

JDevlieghere updated this revision to Diff 495715. JDevlieghere added a comment. Remove callback in dtor CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135631/new/ https://reviews.llvm.org/D135631 Files: lldb/include/lldb/Core/Debugger.h lldb/source/Core/Debugger.cpp lldb/test/She

[Lldb-commits] [PATCH] D142862: [Support] change StringMap hash function from djbHash to xxHash

This revision was automatically updated to reflect the committed changes. Closed by commit rGd768b97424f9: [Support] change StringMap hash function from djbHash to xxHash (authored by erikdesjardins). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142