[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1533 +std::string +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE &die) { Ah the function was declared but not defined (presumably a left

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

Michael137 added a comment. In D142413#4075198 , @aeubanks wrote: > there may be an alternate solution involving making some declarations into > definitions (at all? earlier?), but I don't have that level of understanding > of lldb One idea that came t

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

Michael137 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1533 +std::string +DWARFASTParserClang::GetTemplateParametersString(const DWARFDIE &die) { Michael137 wrote: > Ah the function was declared but not define

[Lldb-commits] [PATCH] D142266: [lldb] Add PlatformMetadata for ScriptedPlatform

mib added a comment. Friendly reminding @labath @JDevlieghere Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142266/new/ https://reviews.llvm.org/D142266 ___ lldb-commits mailing list lldb-commits@lists.l

[Lldb-commits] [PATCH] D138618: [LLDB] Enable 64 bit debug/type offset

ayermolo added a comment. In D138618#4073329 , @labath wrote: > In D138618#4060565 , @clayborg > wrote: > >> ... >> Since the user IDs of SymbolFileDWARF plug-ins mean nothing to anyone else, >> we can make them

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetCPlusPlusQualifiedName

aeubanks updated this revision to Diff 491924. aeubanks marked an inline comment as done. aeubanks added a comment. use suggested alternative Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142413/new/ https://reviews.llvm.org/D142413 Files: lldb/

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetDIEClassTemplateParams

aeubanks added a comment. In D142413#4076749 , @Michael137 wrote: > In D142413#4075198 , @aeubanks > wrote: > >> there may be an alternate solution involving making some declarations into >> definitions (at all

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

kastiglione created this revision. kastiglione added reviewers: aprantl, JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Set compiler_versions on these tests, as they fail if tested on

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

kastiglione added a comment. These are failing on green dragon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142513/new/ https://reviews.llvm.org/D142513 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

JDevlieghere added a comment. In D142513#4078690 , @kastiglione wrote: > These are failing on green dragon. Which job is failing? GreenDragon looks green to me so I must be looking in the wrong places. But also isn't green dragon using the current ToT

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetDIEClassTemplateParams

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. awesome, looks much better now thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142413/new/ https://reviews.llvm.org/D142413 _

[Lldb-commits] [PATCH] D142513: [lldb][test] Set minimum compiler_versions

kastiglione added a comment. It's the LLDB matrix that's failing, where previous compiler versions are also used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142513/new/ https://reviews.llvm.org/D142513 __

[Lldb-commits] [lldb] 5dd7c16 - [lldb] Don't create Clang AST nodes in GetDIEClassTemplateParams

Author: Arthur Eubanks Date: 2023-01-24T19:13:19-08:00 New Revision: 5dd7c16c3dcfd3154a53ee59e0e092c1e0092197 URL: https://github.com/llvm/llvm-project/commit/5dd7c16c3dcfd3154a53ee59e0e092c1e0092197 DIFF: https://github.com/llvm/llvm-project/commit/5dd7c16c3dcfd3154a53ee59e0e092c1e0092197.diff

[Lldb-commits] [PATCH] D142413: [lldb] Don't create Clang AST nodes in GetDIEClassTemplateParams

This revision was automatically updated to reflect the committed changes. Closed by commit rG5dd7c16c3dcf: [lldb] Don't create Clang AST nodes in GetDIEClassTemplateParams (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142413/n

[Lldb-commits] [lldb] 5ed6d99 - [lldb] Remove legacy six module for py2->py3

Author: Jordan Rupprecht Date: 2023-01-24T19:46:26-08:00 New Revision: 5ed6d99a8311e54762df3d40dfb1d12578aaa4f5 URL: https://github.com/llvm/llvm-project/commit/5ed6d99a8311e54762df3d40dfb1d12578aaa4f5 DIFF: https://github.com/llvm/llvm-project/commit/5ed6d99a8311e54762df3d40dfb1d12578aaa4f5.di

[Lldb-commits] [PATCH] D142140: [lldb] Remove legacy six module for py2->py3

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ed6d99a8311: [lldb] Remove legacy six module for py2->py3 (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142140/new/ https://review

[Lldb-commits] [lldb] ff9c31b - [LLDB] Fix for libc++ atomic allowing modification of contained value

Author: Pavel Kosov Date: 2023-01-25T10:39:50+03:00 New Revision: ff9c31b23b7635f2c97c5f9c33fd4e032b717ad0 URL: https://github.com/llvm/llvm-project/commit/ff9c31b23b7635f2c97c5f9c33fd4e032b717ad0 DIFF: https://github.com/llvm/llvm-project/commit/ff9c31b23b7635f2c97c5f9c33fd4e032b717ad0.diff L

[Lldb-commits] [PATCH] D140623: [LLDB] Fix for libc++ atomic allowing modification of contained value

This revision was automatically updated to reflect the committed changes. Closed by commit rGff9c31b23b76: [LLDB] Fix for libc++ atomic allowing modification of contained value (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1406

[Lldb-commits] [lldb] 92f0e4c - [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value

Author: Pavel Kosov Date: 2023-01-25T10:48:04+03:00 New Revision: 92f0e4ccafacb61f7de93e7ef5bd4beb02047086 URL: https://github.com/llvm/llvm-project/commit/92f0e4ccafacb61f7de93e7ef5bd4beb02047086 DIFF: https://github.com/llvm/llvm-project/commit/92f0e4ccafacb61f7de93e7ef5bd4beb02047086.diff L

[Lldb-commits] [PATCH] D140624: [LLDB] Fixes summary formatter for libc++ map allowing modification of contained value

This revision was automatically updated to reflect the committed changes. Closed by commit rG92f0e4ccafac: [LLDB] Fixes summary formatter for libc++ map allowing modification of… (authored by kpdev42). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14