[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM In D140800#4044983 , @serge-sans-paille wrote: > In D140800#4043723 , @nikic wrote: > >> Just to check,

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140615/new/ https://reviews.llvm.org/D140615 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140386/new/ https://reviews.llvm.org/D140386 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D141245: [LLDB][LoongArch] ObjectFile: add a case for `EM_LOONGARCH`

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141245/new/ https://reviews.llvm.org/D141245 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D140759: [LLDB][LoongArch] Add FP branch instructions for EmulateInstructionLoongArch

DavidSpickett accepted this revision. DavidSpickett added a comment. Thanks for adding the testing in earlier patches. At this point my review isn't adding much value and @SixWeining has the ISA details covered. So changes like this can go in without extra approval in future unless there is som

[Lldb-commits] [PATCH] D138197: [lldb] Fix bitfield incorrectly printing when field crosses a storage unit

DavidSpickett added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138197/new/ https://reviews.llvm.org/D138197 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D136928: [LLDB] Fix help text for "platform settings"

DavidSpickett added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136928/new/ https://reviews.llvm.org/D136928 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [lldb] 07bb29d - [OptTable] Precompute OptTable prefixes union table through tablegen

Author: serge-sans-paille Date: 2023-01-12T12:08:06+01:00 New Revision: 07bb29d8ffc3b82d5a7bb1217d93e8fa86e6969a URL: https://github.com/llvm/llvm-project/commit/07bb29d8ffc3b82d5a7bb1217d93e8fa86e6969a DIFF: https://github.com/llvm/llvm-project/commit/07bb29d8ffc3b82d5a7bb1217d93e8fa86e6969a.d

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG07bb29d8ffc3: [OptTable] Precompute OptTable prefixes union table through tablegen (authored by serge-sans-paille). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

Michael137 added a comment. FYI, this is causing buildbot failures: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/49913/execution/node/74/log/ Currently checking what's wrong. /Users/buildslave/jenkins/workspace/lldb-cmake@2/llvm-project/lldb/test/API/lang/cpp/accelerator-table -p

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

Michael137 added a comment. Ah I think it's just a lack of curly braces around one of the format specifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 ___

[Lldb-commits] [lldb] ade3f1c - [lldb] Fix typo in integral format specifier

Author: Michael Buch Date: 2023-01-12T12:09:04Z New Revision: ade3f1ccd807b00122fdf374ce85987fee60f853 URL: https://github.com/llvm/llvm-project/commit/ade3f1ccd807b00122fdf374ce85987fee60f853 DIFF: https://github.com/llvm/llvm-project/commit/ade3f1ccd807b00122fdf374ce85987fee60f853.diff LOG:

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

xen0n added a comment. BTW do we have a way of fixing the bug while preserving the alias? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140615/new/ https://reviews.llvm.org/D140615 ___ lldb-commits maili

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

labath added a comment. In D68655#4045895 , @jasonmolenda wrote: > Both have to be written by the dwarf linker to be correct, but only the > former is written ONLY by the dwarf linker. I don't think that's right: $ clang -c -x c - -o - -gdwarf-arange

[Lldb-commits] [PATCH] D140385: [lldb] Add lldb-server targets to build docs

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fa023970daf: [lldb] Add lldb-server targets to build docs (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140385/new/ https://re

[Lldb-commits] [lldb] 3fa0239 - [lldb] Add lldb-server targets to build docs

Author: David Spickett Date: 2023-01-12T12:34:58Z New Revision: 3fa023970dafbbf2aa98ea67123d2e8318dd6916 URL: https://github.com/llvm/llvm-project/commit/3fa023970dafbbf2aa98ea67123d2e8318dd6916 DIFF: https://github.com/llvm/llvm-project/commit/3fa023970dafbbf2aa98ea67123d2e8318dd6916.diff LOG

[Lldb-commits] [PATCH] D141021: [lldb] Remove tools copied into LLDB.framework before install

labath added a comment. I don't dispute the value of determinism, but it seems like there ought to be a way to achieve this with corrupting the build tree (which in itself is not very 'deterministic'). What if we had two copies of the framework in the build-tree? One pristine copy, which would

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

lh03061238 added a comment. In D140615#4047069 , @xen0n wrote: > BTW do we have a way of fixing the bug while preserving the alias? The register iscurrently corresponds to only an alias in RegisterInfos_loongarch64.h. So far, no other way has been found

[Lldb-commits] [PATCH] D141330: [lldb] Limit 8b259fe573e1 to dSYMs

labath added a comment. Just to clarify: I was responding to the question about the ELF file usage, not questioning the overall approach. Given that MachO has a special code for dsym files, I think it makes sense to use it. In D141330#4043807 , @jasonmo

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

lh03061238 added a comment. In D140615#4047069 , @xen0n wrote: > BTW do we have a way of fixing the bug while preserving the alias? The register information defined in registerinfos_longarch64.h contains only one alias. So far, no other way has been fou

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/examples/python/scripted_process/scripted_platform.py:31 +def list_processes(self): +""" Get a list of processes that can be ran on the platf

[Lldb-commits] [PATCH] D141605: [lldb] Detach the child process when stepping over a fork

labath created this revision. labath added reviewers: jingham, mgorny. Herald added a project: All. labath requested review of this revision. Herald added a project: LLDB. Step over thread plans were claiming to explain the fork stop reasons, which prevented the default fork logic (detaching from

[Lldb-commits] [PATCH] D141605: [lldb] Detach the child process when stepping over a fork

labath added a comment. (The fix seems to make LLDB do the right thing, although I can't claim to fully understand what is going on. From what I can tell, we're currently detaching from the fork child when the fork event gets pulled off the public event queue, and this code is preventing that f

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. In D139955#4047011 , @Michael137 wrote: > Ah it's just a typoed format (and lack of curly braces around one of the > format specifiers) > > Fixed in https://reviews.llvm.org/rGade3f1ccd807 Thanks, for a fix. Sorry missed it.

[Lldb-commits] [PATCH] D136565: [clang] Instantiate alias templates with sugar

erichkeane added a comment. In D136565#4032150 , @erichkeane wrote: > Note that the Clang 16 branch is coming up approximately on January 24, and > this needs to be reverted or perf-regression fixed by then. @mizvekov : If > you or someone else don't

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. @mizvekov : I'm looking at the revert of this since no work seems to have been done to fix @steven_wu 's problem. Unfortunately, it seems that reverting this requires reverting https://reviews.llvm.org/D134604 plus all of the "Instantiate" patches, which undoes basi

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

v.g.vassilev added a comment. In D131858#4047785 , @erichkeane wrote: > @mizvekov : I'm looking at the revert of this since no work seems to have > been done to fix @steven_wu 's problem. Unfortunately, it seems that > reverting this requires revertin

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

erichkeane added a comment. In D131858#4047799 , @v.g.vassilev wrote: > In D131858#4047785 , @erichkeane > wrote: > >> @mizvekov : I'm looking at the revert of this since no work seems to have >> been done to f

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

jasonmolenda added a comment. In D68655#4047126 , @labath wrote: > In D68655#4045895 , @jasonmolenda > wrote: > >> Both have to be written by the dwarf linker to be correct, but only the >> former is written ONLY

[Lldb-commits] [lldb] ba35c27 - [lldb] Limit `nothreadallow` to Python in SWIG bindings

Author: Jonas Devlieghere Date: 2023-01-12T10:19:30-08:00 New Revision: ba35c27ec9aa9807f5b4be2a0c33ca9b045accc7 URL: https://github.com/llvm/llvm-project/commit/ba35c27ec9aa9807f5b4be2a0c33ca9b045accc7 DIFF: https://github.com/llvm/llvm-project/commit/ba35c27ec9aa9807f5b4be2a0c33ca9b045accc7.d

[Lldb-commits] [lldb] 9ec1159 - [lldb] Fix compile error in Lua typemap

Author: Jonas Devlieghere Date: 2023-01-12T10:51:26-08:00 New Revision: 9ec115978ea2bdfc60800cd3c21264341cdc8b0a URL: https://github.com/llvm/llvm-project/commit/9ec115978ea2bdfc60800cd3c21264341cdc8b0a DIFF: https://github.com/llvm/llvm-project/commit/9ec115978ea2bdfc60800cd3c21264341cdc8b0a.d

[Lldb-commits] [PATCH] D141624: [fix] Change formatting to use llvm::formatv Summary:

ayermolo created this revision. Herald added a reviewer: shafik. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. ayermolo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Missed one formating that was reversed.

[Lldb-commits] [PATCH] D139955: [LLDB] Change formatting to use llvm::formatv

ayermolo added a comment. Found another instance: https://reviews.llvm.org/D141624 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139955/new/ https://reviews.llvm.org/D139955 ___ lldb-commits mailing list

[Lldb-commits] [lldb] 4e7da80 - [fix] Change formatting to use llvm::formatv Summary:

Author: Alexander Yermolovich Date: 2023-01-12T11:18:29-08:00 New Revision: 4e7da8000e2771907609c3fe149dd4b96cfe0b08 URL: https://github.com/llvm/llvm-project/commit/4e7da8000e2771907609c3fe149dd4b96cfe0b08 DIFF: https://github.com/llvm/llvm-project/commit/4e7da8000e2771907609c3fe149dd4b96cfe0b

[Lldb-commits] [PATCH] D141624: [fix] Change formatting to use llvm::formatv Summary:

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e7da8000e27: [fix] Change formatting to use llvm::formatv Summary: (authored by ayermolo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141624/new/ https:

[Lldb-commits] [PATCH] D68655: Trust the arange accelerator tables in dSYMs

labath added a comment. In D68655#4048009 , @jasonmolenda wrote: > In D68655#4047126 , @labath wrote: > >> In D68655#4045895 , @jasonmolenda >> wrote: >> >>> Both have to b

[Lldb-commits] [PATCH] D141626: [lldb-vscode] Include the return value in 'local' variables

ivanhernandez13 created this revision. Herald added a project: All. ivanhernandez13 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This provides a convenient way for the user to easily inspect a functions return value after stepping out o

[Lldb-commits] [lldb] d9f4d1b - [lldb/Interpreter] Make ScriptedProcessInfo more generic

Author: Med Ismail Bennani Date: 2023-01-12T12:49:05-08:00 New Revision: d9f4d1b048520c50ca06e24b7886d77d3bb2fc29 URL: https://github.com/llvm/llvm-project/commit/d9f4d1b048520c50ca06e24b7886d77d3bb2fc29 DIFF: https://github.com/llvm/llvm-project/commit/d9f4d1b048520c50ca06e24b7886d77d3bb2fc29.

[Lldb-commits] [lldb] 3fbc890 - [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

Author: Med Ismail Bennani Date: 2023-01-12T12:49:05-08:00 New Revision: 3fbc89048517e7152cce763db3b1e5738d558113 URL: https://github.com/llvm/llvm-project/commit/3fbc89048517e7152cce763db3b1e5738d558113 DIFF: https://github.com/llvm/llvm-project/commit/3fbc89048517e7152cce763db3b1e5738d558113.

[Lldb-commits] [PATCH] D139247: [lldb/Interpreter] Make ScriptedProcessInfo more generic

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9f4d1b04852: [lldb/Interpreter] Make ScriptedProcessInfo more generic (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139247/new/ https://

[Lldb-commits] [lldb] 2d53527 - [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

Author: Med Ismail Bennani Date: 2023-01-12T12:49:05-08:00 New Revision: 2d53527e9c64c70c24e1abba74fa0a8c8b3392b1 URL: https://github.com/llvm/llvm-project/commit/2d53527e9c64c70c24e1abba74fa0a8c8b3392b1 DIFF: https://github.com/llvm/llvm-project/commit/2d53527e9c64c70c24e1abba74fa0a8c8b3392b1.

[Lldb-commits] [lldb] b1256f2 - [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

Author: Med Ismail Bennani Date: 2023-01-12T12:49:05-08:00 New Revision: b1256f2345f6c48b08cd8691778f39e3e9053f56 URL: https://github.com/llvm/llvm-project/commit/b1256f2345f6c48b08cd8691778f39e3e9053f56 DIFF: https://github.com/llvm/llvm-project/commit/b1256f2345f6c48b08cd8691778f39e3e9053f56.

[Lldb-commits] [PATCH] D139248: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod

This revision was automatically updated to reflect the committed changes. Closed by commit rG3fbc89048517: [lldb/Interpreter] Improve ScriptedPythonInterface::GetStatusFromMethod (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139248

[Lldb-commits] [lldb] bb4ccc6 - [lldb] Add ScriptedPlatform python implementation

Author: Med Ismail Bennani Date: 2023-01-12T12:49:05-08:00 New Revision: bb4ccc6688893d1bf38cfca76620d84f947b9de1 URL: https://github.com/llvm/llvm-project/commit/bb4ccc6688893d1bf38cfca76620d84f947b9de1 DIFF: https://github.com/llvm/llvm-project/commit/bb4ccc6688893d1bf38cfca76620d84f947b9de1.

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

This revision was automatically updated to reflect the committed changes. Closed by commit rG2d53527e9c64: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1256f2345f6: [lldb/Interpreter] Introduce ScriptedPlatform{,Python}Interface (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139251/new/ h

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb4ccc668889: [lldb] Add ScriptedPlatform python implementation (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews

[Lldb-commits] [PATCH] D141629: Run address expression argument values through ABI::FixCodeAddress to strip TBI/pointer auth bytes on AArch64

jasonmolenda created this revision. jasonmolenda added a reviewer: DavidSpickett. jasonmolenda added a project: LLDB. Herald added subscribers: Michael137, kristof.beyls. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. This is a

[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

JDevlieghere added a comment. This seems very intrusive: I don't think every plugin should have to be aware of this metadata that only one plugin needs. Is there a way to avoid this? For example, could we initialize a generic scripted platform first, with no backing Python class, and then have

[Lldb-commits] [lldb] d69e5df - [lldb/test] Disable TestScriptedProcess.py on linux while investigating the issue

Author: Med Ismail Bennani Date: 2023-01-12T14:11:36-08:00 New Revision: d69e5dfa234f8af7fb1c3bdbceb5c101c300bab1 URL: https://github.com/llvm/llvm-project/commit/d69e5dfa234f8af7fb1c3bdbceb5c101c300bab1 DIFF: https://github.com/llvm/llvm-project/commit/d69e5dfa234f8af7fb1c3bdbceb5c101c300bab1.

[Lldb-commits] [PATCH] D141633: [lldb-vscode] Use SBFrame.GetDisplayFunctionName() instead of SBFrame.GetFunctionName()

ivanhernandez13 created this revision. Herald added a project: All. ivanhernandez13 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change replaces calls to SBFrame.GetFunctionName() with SBFrame.GetDisplayFunctionName() which can retu

[Lldb-commits] [PATCH] D141637: [lldb-vscode] Fix an issue where lldb-vscode tries to display a source file for generated code

ivanhernandez13 created this revision. Herald added a project: All. ivanhernandez13 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. According to https://github.com/llvm/llvm-project/blob/fbcefff9d0a3f5e97270ef8e7b8e0f2afc33dc1c/lldb/source/

[Lldb-commits] [PATCH] D139951: [lldb/crashlog] Refactor CrashLogParser into a Factory patern

mib updated this revision to Diff 488796. mib marked 2 inline comments as done. mib edited the summary of this revision. mib added a comment. Address @kastiglione & @JDevlieghere comments: - rename the factory method to `create` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139951/new/

[Lldb-commits] [PATCH] D139951: [lldb/crashlog] Refactor CrashLogParser into a Factory pattern

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139951/new/ https://reviews.llvm.org/D139951 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

lebedev.ri resigned from this revision. lebedev.ri added a comment. Herald added a subscriber: StephenFan. What's the status here? Should this be abandoned? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130586/new/ https://reviews.llvm.org/D130586

[Lldb-commits] [PATCH] D131858: [clang] Track the templated entity in type substitution.

rsmith added a comment. In D131858#3957630 , @arphaman wrote: > This change has caused a failure in Clang's stage 2 CI on the green dragon > Darwin CI: > https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/6390/console. > > Assertion failed: (l

[Lldb-commits] [lldb] d52582b - [LLDB][LoongArch] ObjectFile: add a case for `EM_LOONGARCH`

Author: Hui Li Date: 2023-01-13T10:17:31+08:00 New Revision: d52582b6b7dfff5538008ad1ebb141da283d9206 URL: https://github.com/llvm/llvm-project/commit/d52582b6b7dfff5538008ad1ebb141da283d9206 DIFF: https://github.com/llvm/llvm-project/commit/d52582b6b7dfff5538008ad1ebb141da283d9206.diff LOG: [

[Lldb-commits] [lldb] 1eaadae - [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

Author: Hui Li Date: 2023-01-13T10:17:55+08:00 New Revision: 1eaadaea5090f88d4e26331a5046a1a07f15a6ea URL: https://github.com/llvm/llvm-project/commit/1eaadaea5090f88d4e26331a5046a1a07f15a6ea DIFF: https://github.com/llvm/llvm-project/commit/1eaadaea5090f88d4e26331a5046a1a07f15a6ea.diff LOG: [

[Lldb-commits] [PATCH] D141245: [LLDB][LoongArch] ObjectFile: add a case for `EM_LOONGARCH`

This revision was automatically updated to reflect the committed changes. Closed by commit rGd52582b6b7df: [LLDB][LoongArch] ObjectFile: add a case for `EM_LOONGARCH` (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D140386: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch

This revision was automatically updated to reflect the committed changes. Closed by commit rG1eaadaea5090: [LLDB][LoongArch] Add unittests for EmulateInstructionLoongArch (authored by lh03061238, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D140615: [LLDB][LoongArch] Delete the s9 register alias definition

lh03061238 added a comment. In D140615#4047171 , @lh03061238 wrote: > In D140615#4047069 , @xen0n wrote: > >> BTW do we have a way of fixing the bug while preserving the alias? > > The register information defi

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

thakis added a comment. Thanks for this change :) Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:141 -class WrapperOptTable : public opt::OptTable { +class WrapperOptTable : public opt::GenericOptTable { public: C Comm

[Lldb-commits] [PATCH] D140800: [OptTable] Precompute OptTable prefixes union table through tablegen

thakis added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:141 -class WrapperOptTable : public opt::OptTable { +class WrapperOptTable : public opt::GenericOptTable { public: thakis wrote: > C …not sure what this was, plea

[Lldb-commits] [lldb] 6b26e1d - [lldb/crashlog] Refactor CrashLogParser into a Factory pattern

Author: Med Ismail Bennani Date: 2023-01-12T19:20:51-08:00 New Revision: 6b26e1dad9608ec188446dcdc0734a7b41cf145b URL: https://github.com/llvm/llvm-project/commit/6b26e1dad9608ec188446dcdc0734a7b41cf145b DIFF: https://github.com/llvm/llvm-project/commit/6b26e1dad9608ec188446dcdc0734a7b41cf145b.

[Lldb-commits] [lldb] 44b81f6 - [lldb/Process] Populate queues in Scripted Process

Author: Med Ismail Bennani Date: 2023-01-12T19:20:51-08:00 New Revision: 44b81f621c41ce21b1a1352d9bd7b7e7a8b0179e URL: https://github.com/llvm/llvm-project/commit/44b81f621c41ce21b1a1352d9bd7b7e7a8b0179e DIFF: https://github.com/llvm/llvm-project/commit/44b81f621c41ce21b1a1352d9bd7b7e7a8b0179e.

[Lldb-commits] [lldb] c3b471c - [lldb] Force override when adding crashlog command

Author: Med Ismail Bennani Date: 2023-01-12T19:20:51-08:00 New Revision: c3b471c0be4f6b5a22afe10f95ff75bf1744d66e URL: https://github.com/llvm/llvm-project/commit/c3b471c0be4f6b5a22afe10f95ff75bf1744d66e DIFF: https://github.com/llvm/llvm-project/commit/c3b471c0be4f6b5a22afe10f95ff75bf1744d66e.

[Lldb-commits] [lldb] e3930e7 - [lldb] Update custom commands to always be overrriden

Author: Med Ismail Bennani Date: 2023-01-12T19:20:51-08:00 New Revision: e3930e77fc5b626a3c6b95f08ed25a3f8807c579 URL: https://github.com/llvm/llvm-project/commit/e3930e77fc5b626a3c6b95f08ed25a3f8807c579 DIFF: https://github.com/llvm/llvm-project/commit/e3930e77fc5b626a3c6b95f08ed25a3f8807c579.

[Lldb-commits] [lldb] 8f549c5 - [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

Author: Med Ismail Bennani Date: 2023-01-12T19:20:51-08:00 New Revision: 8f549c5329275293ced1d5eb87a1cf8b3d52a794 URL: https://github.com/llvm/llvm-project/commit/8f549c5329275293ced1d5eb87a1cf8b3d52a794 DIFF: https://github.com/llvm/llvm-project/commit/8f549c5329275293ced1d5eb87a1cf8b3d52a794.

[Lldb-commits] [PATCH] D139951: [lldb/crashlog] Refactor CrashLogParser into a Factory pattern

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b26e1dad960: [lldb/crashlog] Refactor CrashLogParser into a Factory pattern (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139951/new/ ht

[Lldb-commits] [PATCH] D139853: [lldb/Process] Populate queues in Scripted Process

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG44b81f621c41: [lldb/Process] Populate queues in Scripted Process (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140293: [lldb] Update custom commands to always be overrriden

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3930e77fc5b: [lldb] Update custom commands to always be overrriden (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140293/new/ https://rev

[Lldb-commits] [PATCH] D140113: [lldb] Force override when adding crashlog command

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3b471c0be4f: [lldb] Force override when adding crashlog command (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140113/new/ https://review

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f549c532927: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/

[Lldb-commits] [PATCH] D141658: [lldb/crashlog] Make interactive mode a default & report progress on image loading

mib created this revision. mib added reviewers: JDevlieghere, kastiglione, bulbazord. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch makes interactive mode as the default when using the crashlog com