[Lldb-commits] [PATCH] D139249: [lldb] Add Debugger & ScriptedMetadata reference to Platform::CreateInstance

mib updated this revision to Diff 481842. mib added a reviewer: bulbazord. mib added a comment. Addressed @jingham @bulbazord comments: - Add docstring to swig interface - Add comment on `nullptr` arguments @bulbazord Having a `PlatformSpec` object is a good idea but I don't think it's necessar

[Lldb-commits] [PATCH] D139250: [lldb] Add ScriptedPlatform python implementation

mib updated this revision to Diff 481844. mib marked 3 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139250/new/ https://reviews.llvm.org/D139250 Files: lldb/bindings/python/CMakeLists.txt lldb/bindings/pytho

[Lldb-commits] [PATCH] D139251: [lldb/Interpreter] Introduce ScriptedPlatform{, Python}Interface

mib updated this revision to Diff 481848. mib marked 4 inline comments as done. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139251/new/ https://reviews.llvm.org/D139251 Files: lldb/include/lldb/Interpreter/ScriptInterpreter.h lldb/

[Lldb-commits] [PATCH] D139740: [lldb] Disable macro redefinition warnings in expression wrapper

Michael137 accepted this revision. Michael137 added a comment. This revision is now accepted and ready to land. LGTM thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139740/new/ https://reviews.llvm.org/D139740 ___

[Lldb-commits] [PATCH] D139740: [lldb] Disable macro redefinition warnings in expression wrapper

Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionSourceCode.cpp:150 + stream << "#pragma clang diagnostic push\n"; + stream << "#pragma clang diagnostic ignored \"-Wmacro-redefined\"\n"; + auto pop_warning = llvm::make_sc

[Lldb-commits] [lldb] 8b5c302 - [lldb] Use std::optional instead of None in comments (NFC)

Author: Kazu Hirata Date: 2022-12-10T17:06:43-08:00 New Revision: 8b5c302efb26634126bb57c20727a13ec2237558 URL: https://github.com/llvm/llvm-project/commit/8b5c302efb26634126bb57c20727a13ec2237558 DIFF: https://github.com/llvm/llvm-project/commit/8b5c302efb26634126bb57c20727a13ec2237558.diff L