[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

mgorny added inline comments. Comment at: clang/CMakeLists.txt:14 set(CLANG_BUILT_STANDALONE TRUE) + if ("${CMAKE_VERSION}" VERSION_LESS "3.20.0") +message(WARNING I wonder if we could move this to `CMakePolicy.cmake`, though admittedly you'd have to som

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

ChuanqiXu accepted this revision. ChuanqiXu added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. Herald added a subscriber: Michael137. Apologies to everyone who has automatically been marked as a reviewer for this change. There is more context for it here: https://discourse.llvm.org/t/targetparser-auto-generation-of-riscv-cpu-definitions/66419/4?u=lenary Repositor

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

to268 accepted this revision. to268 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D137503: [CMake] Fix -Wstrict-prototypes

thesamesam added a comment. Thanks! Agreed -- I'll file the backport issue now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137503/new/ https://reviews.llvm.org/D137503 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

kadircet added a comment. LGTM for changes under `clang-tools-extra/clangd` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ lldb-commits mailing list lldb-c

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

aaron.ballman added a comment. I landed the Clang bits in 94738a5ac34283bb034b022602b9f9e93d67081f , thank you for the cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1373

[Lldb-commits] [PATCH] D137338: Fix dupe word typos

thakis added inline comments. Herald added a reviewer: njames93. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:47 // complete architecture list, nor a reasonable subset. The problem is that - // historically the driver driver accepts this and also ties its -march= //

[Lldb-commits] [PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

thakis added a comment. This is a gigantic diff. I'd recommend keeping the .h files in the old place for v0 and make them just forwarding headers that include the header at the new location. That way, you don't have to update oodles of include lines in this patch, and it makes it a bit easier t

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. In D137838#3921828 , @thakis wrote: > This is a gigantic diff. I'd recommend keeping the .h files in the old place > for v0 and make them just forwarding headers that include the header at the > new location. That way, you don't

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli added a comment. Hi @lenary - thank you for working on this! The patch is reasonable to me. I agree on the suggestion of using forwarding headers or the first iteration of the change, it will make it easier to review. I'll adapt the auto-get patch at D137517

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

MaskRay added a comment. Moving target-specific parsers outside LLVMSupport LGTM. I even objected a bit when more stuff of this kind was introduced into LLVMSupport. +1 for adding temporary forwarding headers for now to avoid update all `#include` users. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. I've updated the patch to use forwarding headers (and to rebase past some changes that have happened in the interim). The patch is still huge because of the number of places using the TargetParsers, which need the component added to their CMakeLists.txt. I think after t

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli added a comment. @lenary - thank you for the update! I have added a bunch of miso comments, a bit repetitive... by the time I realised they were repetitive it was faster to get to the bottom of it than removing them! In D137838#3931295 , @l

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added a comment. > As for the name TargetParser. @arsenm came up with the name > SubtargetRegistry. I am fine with either names. @fpetrogalli I'm going to stick with TargetParser, because I think this is less confusing, given that TargetRegistry is already a component. Repository: rG

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

lenary added inline comments. Comment at: clang/lib/Lex/CMakeLists.txt:3 -set(LLVM_LINK_COMPONENTS support) +set(LLVM_LINK_COMPONENTS + Support fpetrogalli wrote: > I wonder how `support` was not being detected as a linking error... Not sure, but I still think

Re: [Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

Hi Jason, Sorry for the late reply - your mail got caught in my spam filter, and I just realized about the build breakage now after you reverted the commits. Just to confirm: I looked at the original change again, and I think I know what's going wrong here: Devirtualization fails, and `promise_ty

Re: [Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

Hm... wait a second... Which clang-version is https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/ using? Is it using an older version of clang? Does that version already contain the patch https://reviews.llvm.org/D132580? If not, that might explain things... On Fri, Nov 25, 2022 at 11:18

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

MaskRay added a comment. The name `llvm/lib/TargetParser` LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137838 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. Thank you for working on this @lenary - LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137

Re: [Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

> I don't know what tools are installed on the builder but I'll ask around the office on Monday, I know there are people who are more familiar with how these bots are set up. Sounds good. Thank you! > FWIW I could repo promise_type failure on my macOS desktop which has the current Xcode 14 tools

[Lldb-commits] [PATCH] D137838: [RFC][Support] Move TargetParsers to new component

MaskRay accepted this revision. MaskRay added a comment. Please check these builds all work: - default - `-DLLVM_LINK_LLVM_DYLIB=on` - `-DBUILD_SHARED_LIBS=on` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137838/new/ https://reviews.llvm.org/D137

[Lldb-commits] [PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

rahmanl updated this revision to Diff 479905. rahmanl added a comment. Herald added subscribers: cfe-commits, libc-commits, openmp-commits, libcxx-commits, lldb-commits, Sanitizers, hanchung, kadircet, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, steakhal, mtrofin, Enna1, bzcheeseman, ko

[Lldb-commits] [PATCH] D100808: [Propeller] Use Fixed MBB ID instead of volatile MachineBasicBlock::Number.

rahmanl updated this revision to Diff 479906. rahmanl added a comment. - Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100808/new/ https://reviews.llvm.org/D100808 Files: llvm/include/llvm/CodeGen/BasicBlockSectionsProfileReader.h llvm

[Lldb-commits] [PATCH] D138141: [amdgpu] Reimplement LDS lowering

JonChesterfield updated this revision to Diff 480484. JonChesterfield added a comment. Herald added subscribers: cfe-commits, libc-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, hanchung, kadircet, jsetoain, Moerafaat, zero9178, pcwang-thead, anlunx, steakhal, mtrofin, Enna1,

[Lldb-commits] [PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

thieta added a comment. I think this is ready to land @Mordante or is there anything else missing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137724/new/ https://reviews.llvm.org/D137724 ___ lldb-comm

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

mib updated this revision to Diff 480796. mib added a comment. Address @bulbazord comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139484/new/ https://reviews.llvm.org/D139484 Files: lldb/test/API/functionalities/scripted_process/Makefile lldb/test/API/functionalities/scripte

[Lldb-commits] [PATCH] D139461: Fix dwarf5-lazy-dwo.c for the default c target not being c99.

Eric accepted this revision. Eric added a comment. This revision is now accepted and ready to land. LGTM. It would also be fine to not check the language. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139461/new/ https://reviews.llvm.org/D139461 _

[Lldb-commits] [lldb] bdfa310 - Store OptTable::Info::Name as a StringRef

Author: serge-sans-paille Date: 2022-12-07T16:32:37+01:00 New Revision: bdfa3100dc3ea9e9ce4d3d4100ea6bb4c3fa2b81 URL: https://github.com/llvm/llvm-project/commit/bdfa3100dc3ea9e9ce4d3d4100ea6bb4c3fa2b81 DIFF: https://github.com/llvm/llvm-project/commit/bdfa3100dc3ea9e9ce4d3d4100ea6bb4c3fa2b81.d

[Lldb-commits] [lldb] 40ade84 - Revert "Store OptTable::Info::Name as a StringRef"

Author: serge-sans-paille Date: 2022-12-07T17:29:53+01:00 New Revision: 40ade845be698355b230abc19c7a76b200188772 URL: https://github.com/llvm/llvm-project/commit/40ade845be698355b230abc19c7a76b200188772 DIFF: https://github.com/llvm/llvm-project/commit/40ade845be698355b230abc19c7a76b200188772.d

[Lldb-commits] [lldb] fc5bda5 - Fix dwarf5-lazy-dwo.c for the default c target not being c99.

Author: Mitch Phillips Date: 2022-12-07T09:07:56-08:00 New Revision: fc5bda52f00b63fbe4b503b813380d9b81ee7f0b URL: https://github.com/llvm/llvm-project/commit/fc5bda52f00b63fbe4b503b813380d9b81ee7f0b DIFF: https://github.com/llvm/llvm-project/commit/fc5bda52f00b63fbe4b503b813380d9b81ee7f0b.diff

[Lldb-commits] [PATCH] D139461: Fix dwarf5-lazy-dwo.c for the default c target not being c99.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc5bda52f00b: Fix dwarf5-lazy-dwo.c for the default c target not being c99. (authored by hctim). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D139484: [lldb/test] Fix data racing issue in TestStackCoreScriptedProcess

bulbazord added inline comments. Comment at: lldb/test/API/functionalities/scripted_process/main.cpp:18 + std::unique_lock lock(mutex); + cv.notify_one(); + n = foo(n); Why do you need this initial notification? Comment at: lldb/test/API/fun

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 480994. ayermolo added a comment. rebase, clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFR

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. Accidentally pushed when pushing bolt changes. Reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D139577: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo created this revision. Herald added subscribers: mstorsjo, hoy, modimo, wenlei, arphaman, hiraditya. Herald added a reviewer: rafauler. Herald added a reviewer: Amir. Herald added a reviewer: maksfb. Herald added a project: All. ayermolo requested review of this revision. Herald added subs

[Lldb-commits] [PATCH] D139577: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo added a comment. Re-did D139379 after pushing it by mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139577/new/ https://reviews.llvm.org/D139577 ___ lld

[Lldb-commits] [PATCH] D139577: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo updated this revision to Diff 481047. ayermolo added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139577/new/ https://reviews.llvm.org/D139577 Files: bolt/lib/Core/DebugData.cpp bolt/lib/Rewrite/DWARFRewriter.cpp

[Lldb-commits] [PATCH] D139379: [llvm][dwwarf] Change CU/TU index to 64-bit

ayermolo abandoned this revision. ayermolo added a comment. Redid in D139577 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139379/new/ https://reviews.llvm.org/D139379 ___

[Lldb-commits] [lldb] e0fdc56 - [lldb] Don't use Optional::getPointer (NFC)

Author: Kazu Hirata Date: 2022-12-07T17:42:59-08:00 New Revision: e0fdc563585f38e7b20507b541dacbfe58aa904b URL: https://github.com/llvm/llvm-project/commit/e0fdc563585f38e7b20507b541dacbfe58aa904b DIFF: https://github.com/llvm/llvm-project/commit/e0fdc563585f38e7b20507b541dacbfe58aa904b.diff L

[Lldb-commits] [PATCH] D139158: [LLDB][LoongArch] Make software single stepping work

seehearfeel added inline comments. Comment at: lldb/source/Plugins/Instruction/LoongArch/EmulateInstructionLoongArch.h:58 + uint32_t reg_num) override; + lldb::addr_t ReadPC(bool *success); + bool WritePC(lldb::addr_t pc);

<    1   2