[Lldb-commits] [PATCH] D136578: [LLDB] [LoongArch] Add minimal LoongArch support

2022-11-25 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a comment. Nice, glad to see that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136578/new/ https://reviews.llvm.org/D136578 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] 3427cb5 - [lldb] Prevent an infinite loop while reading memory regions

2022-11-25 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-11-25T11:55:41+01:00 New Revision: 3427cb5b3a55a454e5750f6318ced8a5d7c1442d URL: https://github.com/llvm/llvm-project/commit/3427cb5b3a55a454e5750f6318ced8a5d7c1442d DIFF: https://github.com/llvm/llvm-project/commit/3427cb5b3a55a454e5750f6318ced8a5d7c1442d.diff

[Lldb-commits] [lldb] c699a81 - [lldb/test] Remove the module cache directory in module-ownership.mm

2022-11-25 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-11-25T11:55:42+01:00 New Revision: c699a81bc98804650fdd4a85de085e257e074878 URL: https://github.com/llvm/llvm-project/commit/c699a81bc98804650fdd4a85de085e257e074878 DIFF: https://github.com/llvm/llvm-project/commit/c699a81bc98804650fdd4a85de085e257e074878.diff

[Lldb-commits] [lldb] b32931c - [lldb][nfc] Deindent ProcessGDBRemote::SetThreadStopInfo by two levels

2022-11-25 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-11-25T13:51:13+01:00 New Revision: b32931c5b32eb0d2cf37d688b34f8548c9674c19 URL: https://github.com/llvm/llvm-project/commit/b32931c5b32eb0d2cf37d688b34f8548c9674c19 DIFF: https://github.com/llvm/llvm-project/commit/b32931c5b32eb0d2cf37d688b34f8548c9674c19.diff

[Lldb-commits] [lldb] ed34590 - [LLDB] Add LoongArch register definitions and operations

2022-11-25 Thread Weining Lu via lldb-commits
Author: Tiezhu Yang Date: 2022-11-25T21:19:36+08:00 New Revision: ed34590c1acb300abe51d2686148c62e8c517993 URL: https://github.com/llvm/llvm-project/commit/ed34590c1acb300abe51d2686148c62e8c517993 DIFF: https://github.com/llvm/llvm-project/commit/ed34590c1acb300abe51d2686148c62e8c517993.diff L

[Lldb-commits] [PATCH] D138407: [LLDB] Add LoongArch register definitions and operations

2022-11-25 Thread Lu Weining via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGed34590c1acb: [LLDB] Add LoongArch register definitions and operations (authored by seehearfeel, committed by SixWeining). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

2022-11-25 Thread Michael Buch via Phabricator via lldb-commits
Michael137 created this revision. Michael137 added reviewers: jingham, aprantl. Herald added a project: All. Michael137 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. **Summary** This patch addresses #59128, where LLDB would crash when ev

[Lldb-commits] [lldb] 1df47db - Revert "[lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE"

2022-11-25 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2022-11-25T12:13:31-08:00 New Revision: 1df47dbe131d2aed676d9d5e0441ff4b61fec018 URL: https://github.com/llvm/llvm-project/commit/1df47dbe131d2aed676d9d5e0441ff4b61fec018 DIFF: https://github.com/llvm/llvm-project/commit/1df47dbe131d2aed676d9d5e0441ff4b61fec018.diff

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

2022-11-25 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. Reverted for now. commit 1df47dbe131d2aed676d9d5e0441ff4b61fec018 Author: Jason Molenda Date: Fri Nov 25 12:11:37 2022 -0800 Revert "[lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE" The changes in https://re

[Lldb-commits] [lldb] f6d4e68 - Revert "[LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer"

2022-11-25 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2022-11-25T12:22:58-08:00 New Revision: f6d4e687172ab14728c569a0c1d3eb1c76021250 URL: https://github.com/llvm/llvm-project/commit/f6d4e687172ab14728c569a0c1d3eb1c76021250 DIFF: https://github.com/llvm/llvm-project/commit/f6d4e687172ab14728c569a0c1d3eb1c76021250.diff

[Lldb-commits] [PATCH] D132815: [LLDB] Do not dereference promise pointer in `coroutine_handle` pretty printer

2022-11-25 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. I reverted this change for now to unblock the macOS CI bots. commit a410b34a66accd864b174b6330d3d353e73f54d8 Author: Jason Molenda Date: Fri Nov 25 12:15:47 2022 -0800 Revert "[LLDB] Do not dereference promise pointer in `coroutine_handle` pretty p

[Lldb-commits] [lldb] 2b2f2f6 - Revert "[LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer"

2022-11-25 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2022-11-25T12:32:33-08:00 New Revision: 2b2f2f66141d52dc0d3082ddd12805d36872a189 URL: https://github.com/llvm/llvm-project/commit/2b2f2f66141d52dc0d3082ddd12805d36872a189 DIFF: https://github.com/llvm/llvm-project/commit/2b2f2f66141d52dc0d3082ddd12805d36872a189.diff

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

2022-11-25 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. I temporarily reverted this via commit 2b2f2f66141d52dc0d3082ddd12805d36872a189 Author: Jason Molenda Date: Fri Nov 25 12:28:28 2022 -0800 Revert "[LLDB] Recognize `std::noop_coroutine()` in `std::coroutine_handle` pretty printer" This

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

2022-11-25 Thread Adrian Vogelsgesang via Phabricator via lldb-commits
avogelsgesang added a comment. @jasonmolenda I am a bit confused about your revert. Did you indeed revert this change here? Afaict, you reverted https://reviews.llvm.org/D132735 and https://reviews.llvm.org/D132815, but left this commit in place. I did not actually read through your code changes

[Lldb-commits] [PATCH] D138612: [lldb][NFC] Change FindDefinitionTypeForDWARFDeclContext() to take DWARFDIE

2022-11-25 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. FWIW when I was commenting on this last night, I hadn't realized that the test case was unmodified by the patch. Reverting the patch until we can figure out the cause of the behavior change made the most sense. The macOS incremental bot is green now. Repositor

[Lldb-commits] [PATCH] D132624: [LLDB] Devirtualize coroutine promise types for `std::coroutine_handle`

2022-11-25 Thread Jason Molenda via Phabricator via lldb-commits
jasonmolenda added a comment. In D132624#3951525 , @avogelsgesang wrote: > @jasonmolenda I am a bit confused about your revert. > Did you indeed revert this change here? Afaict, you reverted > https://reviews.llvm.org/D132735 and https://reviews.llvm.or

Re: [Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

2022-11-25 Thread Jason Molenda via lldb-commits
Hi Adrian, thanks for digging in. I am not sure about the policies of the builders, I think we had failing test cases for a bunch of days & it may have already been red when your change went in, so it wasn't detected as a change in status. That might have something to do with it. I thought th

Re: [Lldb-commits] green dragon testsuite crash on TestCoroutineHandle.py from coroutines formatter changes, temporarily revert?

2022-11-25 Thread Jason Molenda via lldb-commits
FWIW I could repo promise_type failure on my macOS desktop which has the current Xcode 14 tools installed, but I can't tell you exactly what this corresponds to in github hash terms (it's "Apple clang version 14.0.0 (clang-1400.0.29.100)"), I think it was originally branched 2021-10-26, althoug

[Lldb-commits] [PATCH] D138724: [lldb][Target] Flush the scratch TypeSystem when process gets deleted

2022-11-25 Thread Michael Buch via Phabricator via lldb-commits
Michael137 updated this revision to Diff 478044. Michael137 added a comment. - Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138724/new/ https://reviews.llvm.org/D138724 Files: lldb/source/Target/Target.cpp lldb/test/API/functio