[Lldb-commits] [PATCH] D133366: [lldb] Fix SBFileSpec.fullpath for Windows

labath added a comment. The real problem here is that the `__get_fullpath__` implementation does not use the path style information from within the FileSpec object. Hardcoding it to use the host os path style (instead of posix style) just changes the set of bugs. Repository: rG LLVM Github

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

labath added a comment. This dual environment thing is tricky.. MSVC is probably a better default, but it would still mean that the same bugs will appear if the situation is reversed (we assume MSVC environ, but the binary actually uses GNU). Have you looked at how this interacts with https://r

[Lldb-commits] [PATCH] D135631: [lldb] Copy log files into diagnostic directory

labath added inline comments. Comment at: lldb/source/Core/Debugger.cpp:815 +Diagnostics::Instance().AddCallback( +[&](const FileSpec &dir) -> llvm::Error { + for (auto &entry : m_stream_handlers) { A default reference capture is dangerous wh

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

labath added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerType.h:58 +template TypeSystemType *dyn_cast_or_null() { + return llvm::dyn_cast_or_null(m_typesystem_sp.get()); +} Maybe do something like this instead: ``` template std::s

[Lldb-commits] [PATCH] D137247: [lldb] Allow plugins to extend DWARF expression parsing for vendor extensions

pfaffe updated this revision to Diff 475399. pfaffe added a comment. Stray change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137247/new/ https://reviews.llvm.org/D137247 Files: lldb/include/lldb/Expression/DWARFExpression.h lldb/source/Exp

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

dblaikie added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2676-2677 if (!m_deref_valobj) { - if (HasSyntheticValue()) { + // FIXME: C++ stdlib formatters break with incomplete types (e.g. + // `std::vector &`). Remove ObjC restriction once t

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

zequanwu updated this revision to Diff 475517. zequanwu marked 2 inline comments as done. zequanwu added a comment. Herald added a reviewer: shafik. Move RequireCompleteType to TypeSystemClang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134066/ne

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu abandoned this revision. zequanwu added a comment. In D137873#3926821 , @labath wrote: > This dual environment thing is tricky.. MSVC is probably a better default, > but it would still mean that the same bugs will appear if the situation is > r

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu reclaimed this revision. zequanwu added a comment. Oh, they are not the same. I will work on a similar setting for minidump. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137873/new/ https://reviews.llvm.org/D137873 __

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu updated this revision to Diff 475538. zequanwu marked 2 inline comments as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 Files: clang/lib/CodeGen/Backe

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

aprantl created this revision. aprantl added reviewers: JDevlieghere, kastiglione. Herald added a project: All. aprantl requested review of this revision. Because Host::RunShellCommand runs commands through `$SHELL` there is an opportunity for this to fail spectacularly on systems that use custom

[Lldb-commits] [PATCH] D134066: [LLDB][NativePDB] Forcefully complete a record type if it has empty debug info and is required to have complete type.

rnk added a comment. Following the direction of the DWARF plugin sounds good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134066/new/ https://reviews.llvm.org/D134066 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

kastiglione added inline comments. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:384 -Log *log = GetLog(LLDBLog::Host); +Log *log = GetLog(LLDBLog::Host | LLDBLog::Types); if (log) { Maybe a comment explaining how this is useful in t

[Lldb-commits] [lldb] 8d41609 - [lldb/test] Fix app_specific_backtrace_crashlog.test (NFC)

Author: Med Ismail Bennani Date: 2022-11-15T14:25:52-08:00 New Revision: 8d416099240a2c090bd461f99c3014bac828cf98 URL: https://github.com/llvm/llvm-project/commit/8d416099240a2c090bd461f99c3014bac828cf98 DIFF: https://github.com/llvm/llvm-project/commit/8d416099240a2c090bd461f99c3014bac828cf98.

[Lldb-commits] [lldb] 0869a69 - NFC test if rosetta debugserver exists before testing rosetta

Author: Jason Molenda Date: 2022-11-15T14:35:02-08:00 New Revision: 0869a699173f6d92949153e5301e6cfadf33201c URL: https://github.com/llvm/llvm-project/commit/0869a699173f6d92949153e5301e6cfadf33201c DIFF: https://github.com/llvm/llvm-project/commit/0869a699173f6d92949153e5301e6cfadf33201c.diff

[Lldb-commits] [lldb] 1447ea0 - NFC test if rosetta is installed before running x86 binary on AS

Author: Jason Molenda Date: 2022-11-15T14:44:35-08:00 New Revision: 1447ea059b4ac0995418950c1146fd936d57fee6 URL: https://github.com/llvm/llvm-project/commit/1447ea059b4ac0995418950c1146fd936d57fee6 DIFF: https://github.com/llvm/llvm-project/commit/1447ea059b4ac0995418950c1146fd936d57fee6.diff

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Awesome! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137583/new/ https://reviews.llvm.org/D137583 ___

[Lldb-commits] [lldb] 4bc86ae - [lldb-vscode] Send Selected Statistics Dump in Terminated Event

Author: Wanyi Ye Date: 2022-11-15T15:24:36-08:00 New Revision: 4bc86ae83e956cd6d5b9e5fdbec6a85ccc579fc9 URL: https://github.com/llvm/llvm-project/commit/4bc86ae83e956cd6d5b9e5fdbec6a85ccc579fc9 DIFF: https://github.com/llvm/llvm-project/commit/4bc86ae83e956cd6d5b9e5fdbec6a85ccc579fc9.diff LOG:

[Lldb-commits] [PATCH] D137665: [lldb-vscode] Send Selected Statistics Dump in Terminated Event

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bc86ae83e95: [lldb-vscode] Send Selected Statistics Dump in Terminated Event (authored by kusmour). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D138077: Send statistics in initialized event

GeorgeHuyubo created this revision. Herald added a project: All. GeorgeHuyubo requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138077 Files: lldb/packages/Python/lldbsuite/t

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks updated this revision to Diff 475627. aeubanks added a comment. add bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137983/new/ https://reviews.llvm.org/D137983 Files: lldb/source/Core/ValueObject.cpp Index: lldb/source/Core/ValueOb

[Lldb-commits] [PATCH] D137873: [LLDB][Minidump] Set abi environment for windows.

zequanwu updated this revision to Diff 475628. zequanwu added a comment. Herald added subscribers: llvm-commits, mstorsjo. Herald added a project: LLVM. Add `settings set plugin.process.minidump.abi msvc/gnu` to override minidump abi triple. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D137983: [lldb] Disable looking at pointee types to find synthetic value for non-ObjC

aeubanks added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:2676-2677 if (!m_deref_valobj) { - if (HasSyntheticValue()) { + // FIXME: C++ stdlib formatters break with incomplete types (e.g. + // `std::vector &`). Remove ObjC restriction once t

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

aprantl updated this revision to Diff 475630. aprantl edited the summary of this revision. aprantl added a comment. Implemented error handling of sorts. Because the computation result is cached and most uses are nested deep in places that have no proper error handling themselves I'm logging to t

[Lldb-commits] [lldb] cb0ffa5 - [lldb] Fix simple template names and template params with scope qualifiers

Author: Arthur Eubanks Date: 2022-11-15T16:52:34-08:00 New Revision: cb0ffa529a0f7f907fd89587fc2ab4f6ffd57cf5 URL: https://github.com/llvm/llvm-project/commit/cb0ffa529a0f7f907fd89587fc2ab4f6ffd57cf5 DIFF: https://github.com/llvm/llvm-project/commit/cb0ffa529a0f7f907fd89587fc2ab4f6ffd57cf5.diff

[Lldb-commits] [PATCH] D137583: [lldb] Fix simple template names and template params with scope qualifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb0ffa529a0f: [lldb] Fix simple template names and template params with scope qualifiers (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D136650: Make CompilerType safe [Was: Add a check for TypeSystem use-after-free problems]

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/CompilerType.h:58 +template TypeSystemType *dyn_cast_or_null() { + return llvm::dyn_cast_or_null(m_typesystem_sp.get()); +} labath wrote: > Maybe do something like this instead: > `

[Lldb-commits] [PATCH] D138060: Improve error logging when xcrun fails to execute successfully

JDevlieghere requested changes to this revision. JDevlieghere added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm:410 + LLDB_LOG(log, "xcrun returned exit code %d", status); + return ""; +

[Lldb-commits] [lldb] 7fe3586 - Send statistics in initialized event

Author: George Hu Date: 2022-11-15T19:09:05-08:00 New Revision: 7fe3586cda5b683766ec6b6d5ca2d98c2baaf162 URL: https://github.com/llvm/llvm-project/commit/7fe3586cda5b683766ec6b6d5ca2d98c2baaf162 DIFF: https://github.com/llvm/llvm-project/commit/7fe3586cda5b683766ec6b6d5ca2d98c2baaf162.diff LOG

[Lldb-commits] [PATCH] D138077: Send statistics in initialized event

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fe3586cda5b: Send statistics in initialized event (authored by GeorgeHuyubo). Changed prior to commit: https://reviews.llvm.org/D138077?vs=475624&id=475662#toc Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

MaskRay added a comment. In D137217#3926601 , @tejohnson wrote: > @MaskRay wondering if this is a good change to make for ELF as well, wdyt? Yes, I think this is a good idea and improves debuggability. The change is non-trivial so so this patch focusing

[Lldb-commits] [PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

MaskRay added inline comments. Comment at: lld/COFF/LTO.cpp:229 +StringRef ltoObjName; +if (bitcodeFilePath == "ld-temp.o") { + ltoObjName = MaskRay wrote: > tejohnson wrote: > > zequanwu wrote: > > > tejohnson wrote: > > > > This case should always

[Lldb-commits] [PATCH] D138077: Send statistics in initialized event

omjavaid added a comment. This test fails on Arm/AArch64 Linux. I have marked it as an XFAIL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138077/new/ https://reviews.llvm.org/D138077 ___ lldb-commits m

[Lldb-commits] [lldb] d599ac4 - [LLDB] Xfail TestVSCode_eventStatistic.py on Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2022-11-16T10:45:24+04:00 New Revision: d599ac41aabddeb2442db7b31faacf143d63abe4 URL: https://github.com/llvm/llvm-project/commit/d599ac41aabddeb2442db7b31faacf143d63abe4 DIFF: https://github.com/llvm/llvm-project/commit/d599ac41aabddeb2442db7b31faacf143d63ab

[Lldb-commits] [PATCH] D136809: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

paperchalice updated this revision to Diff 475696. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136809/new/ https://reviews.llvm.org/D136809 Files: clang/lib/Headers/CMakeLists.txt clang/lib/Tooling/CMakeLists.txt clang/runtime/CMakeLists.txt cmake/Modules/GetClangResourceDir.cm