[Lldb-commits] [lldb] 4db7832 - [LLDB] Make API tests to run using MSYS tools

Author: Muhammad Omair Javaid Date: 2022-09-01T14:00:46+05:00 New Revision: 4db78322031ffbd5ea607d7ff66fed5fafb40d68 URL: https://github.com/llvm/llvm-project/commit/4db78322031ffbd5ea607d7ff66fed5fafb40d68 DIFF: https://github.com/llvm/llvm-project/commit/4db78322031ffbd5ea607d7ff66fed5fafb40d

[Lldb-commits] [lldb] 0e6a71e - [LLDB] Make build.py use uname to set platform

Author: Muhammad Omair Javaid Date: 2022-09-01T14:00:47+05:00 New Revision: 0e6a71e6a3d11f6d9c9664b56f304757edf1c82e URL: https://github.com/llvm/llvm-project/commit/0e6a71e6a3d11f6d9c9664b56f304757edf1c82e DIFF: https://github.com/llvm/llvm-project/commit/0e6a71e6a3d11f6d9c9664b56f304757edf1c8

[Lldb-commits] [PATCH] D133002: [LLDB] Make API tests to run using MSYS tools

This revision was automatically updated to reflect the committed changes. Closed by commit rG4db78322031f: [LLDB] Make API tests to run using MSYS tools (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133002/new/ https://review

[Lldb-commits] [PATCH] D133011: [LLDB] Make build.py use uname to set platform

This revision was automatically updated to reflect the committed changes. Closed by commit rG0e6a71e6a3d1: [LLDB] Make build.py use uname to set platform (authored by omjavaid). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133011/new/ https://revie

[Lldb-commits] [PATCH] D133024: [LLDB] Simplify cmake for instruction emulation unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGd46ea783e6fa: [LLDB] Simplify cmake for instruction emulation unit tests (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133024/ne

[Lldb-commits] [lldb] d46ea78 - [LLDB] Simplify cmake for instruction emulation unit tests

Author: David Spickett Date: 2022-09-01T09:40:04Z New Revision: d46ea783e6fad5d92f9f0aaa96f979ca826403e3 URL: https://github.com/llvm/llvm-project/commit/d46ea783e6fad5d92f9f0aaa96f979ca826403e3 DIFF: https://github.com/llvm/llvm-project/commit/d46ea783e6fad5d92f9f0aaa96f979ca826403e3.diff LOG

[Lldb-commits] [PATCH] D132283: [lldb] [Core] Reimplement Communication::ReadThread using MainLoop

mgorny added inline comments. Comment at: lldb/source/Core/Communication.cpp:427 // Notify the read thread. - m_connection_sp->InterruptRead(); labath wrote: > mgorny wrote: > > labath wrote: > > > Have you considered putting this code (some version of it)

[Lldb-commits] [lldb] 39e0a87 - [lldb] [Core] Pass error/status from Communication::ReadThread()

Author: Michał Górny Date: 2022-09-01T14:16:38+02:00 New Revision: 39e0a87c26e0d2b7498186a446dda4ec3d9b709d URL: https://github.com/llvm/llvm-project/commit/39e0a87c26e0d2b7498186a446dda4ec3d9b709d DIFF: https://github.com/llvm/llvm-project/commit/39e0a87c26e0d2b7498186a446dda4ec3d9b709d.diff

[Lldb-commits] [PATCH] D132577: [lldb] [Core] Pass error/status from Communication::ReadThread()

This revision was automatically updated to reflect the committed changes. Closed by commit rG39e0a87c26e0: [lldb] [Core] Pass error/status from Communication::ReadThread() (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D132577?vs=455950&id=

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve added a comment. > is used by (a lot) more tests than just TestAppleSimulatorOSType. In that > case, I would say that this argument should be passed directly from python, > as a part of the `self.build` command (the test already passes a bunch of > arguments there anyway). Good catc

[Lldb-commits] [PATCH] D132940: [lldb] Use just-built libcxx for tests when available

fdeazeve updated this revision to Diff 457252. fdeazeve added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132940/new/ https://reviews.llvm.org/D132940 Files: lldb/packages/Python/lldbsuite/test/make/Makefil

[Lldb-commits] [PATCH] D131160: [WIP][lldb] Add "event" capability to the MainLoop class

mgorny added a comment. In D131160#3738805 , @labath wrote: > What's the reasoning behind `TriggerPendingCallbacks`? I was assuming that > the addition of a callback would cause it to run automatically... To be honest, I didn't think about it much. The

[Lldb-commits] [PATCH] D133129: [lldb] Add boilerplate for debugger interrupts

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a subscriber: mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Jim is looking into adding support for interrupts to the SB API. Part of that work requires clearing the inte

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

kastiglione created this revision. kastiglione added reviewers: mib, JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fixes broken support for: `target.module[re.compile("libFoo")]` The

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Makes sense, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133130/new/ https://reviews.llvm.org/D133130 _

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

mib accepted this revision. mib added a comment. LGTM! I guess this API was not exercised (since no one noticed the `path` -> `file` typo) ... Could you add a test before landing this ? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133130/n

[Lldb-commits] [PATCH] D133130: [lldb][bindings] Fix module_access handling of regex

kastiglione added a comment. @mib will do Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133130/new/ https://reviews.llvm.org/D133130 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D133038: Add GetSourceMap public API

clayborg added inline comments. Comment at: lldb/bindings/interface/SBTarget.i:969 +lldb::SBStructuredData GetSourceMap(); + Do we want to actually have something more like this: ``` lldb::SBStructuredData GetSetting(const char *setting); ``` That allows us

[Lldb-commits] [PATCH] D132578: [lldb] [Core] Use thread for Communication::Write() as well

mgorny added a comment. Well, my "baseline" idea was something like that: having a shared (e.g. via `shared_ptr`) `m_gdb_comm`, and running async thread as part of that. The thread would read packets from remote and split them into two groups: asynchronous events (i.e. stop reasons and related

[Lldb-commits] [lldb] afeb2d0 - [LLDB][NativePDB] Fix a minor bug.

Author: Zequan Wu Date: 2022-09-01T13:10:57-07:00 New Revision: afeb2d0a21e383b5436b539f311ea00803d24e24 URL: https://github.com/llvm/llvm-project/commit/afeb2d0a21e383b5436b539f311ea00803d24e24 DIFF: https://github.com/llvm/llvm-project/commit/afeb2d0a21e383b5436b539f311ea00803d24e24.diff LOG

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

aprantl updated this revision to Diff 457416. aprantl added a comment. Address feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133069/new/ https://reviews.llvm.org/D133069 Files: lldb/include/lldb/Target/Target.h lldb/packages/Python/lldbsuite/test/gdbclientutils.py lldb/

[Lldb-commits] [PATCH] D133164: Add the ability to show when variables fails to be available when debug info is valid.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, yinghuitan. Herald added a project: All. clayborg requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. M

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. That test is not going to win any beauty pageants but it looks like it gets the job done. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133069/new/ https://reviews.

[Lldb-commits] [lldb] ced4e00 - Fix inconsistent target arch when attaching to arm64 binaries on

Author: Adrian Prantl Date: 2022-09-01T16:39:35-07:00 New Revision: ced4e0006fab22f37a165635896a6776f79bc4a9 URL: https://github.com/llvm/llvm-project/commit/ced4e0006fab22f37a165635896a6776f79bc4a9 DIFF: https://github.com/llvm/llvm-project/commit/ced4e0006fab22f37a165635896a6776f79bc4a9.diff

[Lldb-commits] [PATCH] D133069: Fix inconsistent target arch when attaching to arm64 binaries on arm64e platforms.

This revision was automatically updated to reflect the committed changes. Closed by commit rGced4e0006fab: Fix inconsistent target arch when attaching to arm64 binaries on (authored by aprantl). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Mo

[Lldb-commits] [lldb] ff7b876 - [LLDB][RISCV] Add more instruction decode and execute for EmulateInstructionRISCV

Author: Emmmer Date: 2022-09-02T10:17:09+08:00 New Revision: ff7b876aa75d1d4df581ada78befb707dfdbb129 URL: https://github.com/llvm/llvm-project/commit/ff7b876aa75d1d4df581ada78befb707dfdbb129 DIFF: https://github.com/llvm/llvm-project/commit/ff7b876aa75d1d4df581ada78befb707dfdbb129.diff LOG: [

[Lldb-commits] [PATCH] D132789: [LLDB][RISCV] Add more instruction decode and execute for EmulateInstructionRISCV

This revision was automatically updated to reflect the committed changes. Closed by commit rGff7b876aa75d: [LLDB][RISCV] Add more instruction decode and execute for… (authored by Emmmer). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D133181: [test] Ensure MainLoop has time to start listening for signals.

rupprecht created this revision. Herald added a project: All. rupprecht requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This test, specifically `TwoSignalCallbacks`, can be a little bit flaky, failing in around 5/2000 runs. My suspicion is

[Lldb-commits] [lldb] 4535dbd - [lldb] Fix a warning

Author: Kazu Hirata Date: 2022-09-01T22:14:25-07:00 New Revision: 4535dbd55962989e16f0f7208fae9ce75ed9863c URL: https://github.com/llvm/llvm-project/commit/4535dbd55962989e16f0f7208fae9ce75ed9863c DIFF: https://github.com/llvm/llvm-project/commit/4535dbd55962989e16f0f7208fae9ce75ed9863c.diff L