[Lldb-commits] [PATCH] D131086: [lldb/crashlog] Improve exception reporting for interactive mode

2022-08-03 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 449849. mib added a comment. Remove the comment from `MachException::ExceptionCode` since the function returns now an `llvm::Optional` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131086/new/ https://reviews.llvm.org/D131086 Files: lldb/examples/py

[Lldb-commits] [lldb] c988c26 - [lldb] Re-enable TestCCallingConventions on Apple Silicon

2022-08-03 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-08-03T20:50:05-07:00 New Revision: c988c267cf6e302ceda1edc5c7c679ecb64eab75 URL: https://github.com/llvm/llvm-project/commit/c988c267cf6e302ceda1edc5c7c679ecb64eab75 DIFF: https://github.com/llvm/llvm-project/commit/c988c267cf6e302ceda1edc5c7c679ecb64eab75.d

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

2022-08-03 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: mib, JDevlieghere. Herald added a project: All. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Change the `_to_str` functions in lldbutil to be dynamic. Instead o

[Lldb-commits] [PATCH] D131083: [lldb] Add assertStopReason helper function

2022-08-03 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added inline comments. Herald added a subscriber: Michael137. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:269-272 +elif enum == lldb.eStopReasonInstrumentation: +return "instrumentation" +elif enum == lldb.eStopReasonProcessorTrace: +

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

2022-08-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice. Thanks for taking care of this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131138/new/ https://reviews.llvm.org/D131138 __

[Lldb-commits] [PATCH] D131122: [lldb] Fixed a number of typos

2022-08-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks, these all look good. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131122/new/ https://reviews.llvm.org/D131122 _

[Lldb-commits] [PATCH] D131033: [lldb/crashlog] Remove 'process_path' parsing logic

2022-08-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131033/new/ https://reviews.llvm.org/D131033 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D131032: [lldb/crashlog] Update frame regex matcher

2022-08-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D131032#3698163 , @mib wrote: > In D131032#3698108 , @JDevlieghere > wrote: > >> Can we test this by modifying an address in the existing test case? > > Sure but we won't be able

[Lldb-commits] [PATCH] D131138: [lldb] Dynamically generate enum names in lldbutil

2022-08-03 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. This is awesome 🤩 ! I was also thinking of changing the way enums are exposed to python: instead of having everything added to the `lldb` python module, we could create a class per enum and have static attributes for each enum value so we could do something like `lldb.StopR

[Lldb-commits] [PATCH] D131036: [lldb/crashlog] Add `-s|--skip-status` option to interactive mode

2022-08-03 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:1198-1204 +option_parser.add_option( +'--skip-status', +'-s', +dest='skip_status', +action='store_true', +help='prevent the interac

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

2022-08-03 Thread Tiancheng Zhang via Phabricator via lldb-commits
tzb99 added a comment. In D128250#3661588 , @Emmmer wrote: > This commit updates: > > - Add the pc register according to the implementation of gdb >

[Lldb-commits] [PATCH] D124314: lldb: Disable unittests if llvm_gtest target does not exist

2022-08-03 Thread Tom Stellard via Phabricator via lldb-commits
tstellar updated this revision to Diff 449880. tstellar added a comment. Move new logic to LLDBStandalone.cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124314/new/ https://reviews.llvm.org/D124314 Files: lldb/CMakeLists.txt lldb/cmake/mo

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

2022-08-03 Thread Emmmer S via Phabricator via lldb-commits
Emmmer added a comment. > Hello: > > Thank you so much for sharing the patch files. One thing I am still curious > is what the ABISysv file you are using. Would you mind also sharing the > remaining patches added for the lldb-server support? I didn't add any ABISysV code before uploading this p

[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

2022-08-03 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Yeah, I can't say I'm surprised by that. It's fairly annoying that such basic functionality is missing there. Let me see what I can do about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131075/new/ https://reviews.ll

<    1   2