[Lldb-commits] [PATCH] D129455: [lldb] Reduce the stack alignment requirements for the Windows x86_64 ABI

labath added a comment. In D129455#3642015 , @mstorsjo wrote: > In D129455#3641967 , @labath wrote: > >> You say that the issue is the lack of symtab in the "msvc" mode. What makes >> this test work then? > > Whe

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nice! Few minor stylistic comments inside. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:403 + + // this must be a ValueObject* because it is a child of th

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Nice cleanup, thanks! Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h:356 struct StructVars { -StructVars() : m_result_name(), m_obj

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:609 } else { -ValueObjectSP size_mode(dataval_sp->GetChildAtIndexPath({1, 0, 0})); -if (!size_mode) +if (ValueObjectSP size_mode = s

[Lldb-commits] [lldb] d438115 - [lldb/libc++] Simplify the libc++ string formatter

Author: Pavel Labath Date: 2022-07-12T09:57:13+02:00 New Revision: d4381153ea63e9458ffb9dd20ea92fb35d4e3042 URL: https://github.com/llvm/llvm-project/commit/d4381153ea63e9458ffb9dd20ea92fb35d4e3042 DIFF: https://github.com/llvm/llvm-project/commit/d4381153ea63e9458ffb9dd20ea92fb35d4e3042.diff

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rGd4381153ea63: [lldb/libc++] Simplify the libc++ string formatter (authored by labath). Changed prior to commit: https://reviews.llvm.org/D129490?vs=443648&id=443

[Lldb-commits] [PATCH] D129521: Add the ability to run expressions that call fork() or vfork().

labath added a subscriber: mgorny. labath added a comment. The general idea makes sense, as we don't stop for forks even during normal execution. I'll too defer to @jingham on the implementation. I am also wondering what is the current and expected behavior in the `follow-fork=child` mode. The

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 updated this revision to Diff 443861. Michael137 added a comment. - `LocationExpressionIsValid` returns false for invalid ValueObjects - Add asserts to `EntityValueObject` overrides - Add docs for `AddValueObject` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D129078: [LLDB][ClangExpression] Allow expression evaluation from within C++ Lambdas

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: lldb/source/Expression/Materializer.cpp:819 + + bool LocationExpressionIsValid() const override { return true; } + Michael137 wrote: > jingham wrote: > > Is this right? F

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 updated this revision to Diff 443867. Michael137 marked 3 inline comments as done. Michael137 added a comment. - Address stylistic comments - Change test name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129364/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:411 + ".__i_.__node_", nullptr, nullptr, + ValueObject::GetValueForExpressionPathOptions() +

[Lldb-commits] [lldb] d1e9d0b - [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

Author: Michael Buch Date: 2022-07-12T10:13:55+01:00 New Revision: d1e9d0b27f3a59f80787bfe5cf10d4373275c477 URL: https://github.com/llvm/llvm-project/commit/d1e9d0b27f3a59f80787bfe5cf10d4373275c477 DIFF: https://github.com/llvm/llvm-project/commit/d1e9d0b27f3a59f80787bfe5cf10d4373275c477.diff

[Lldb-commits] [PATCH] D129364: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1e9d0b27f3a: [LLDB][DataFormatter] Add data formatter for libcxx std::unordered_map iterator (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Michael137 updated this revision to Diff 443880. Michael137 added a comment. - Default constructor for `StructVars` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129367/new/ https://reviews.llvm.org/D129367 Files: lldb/source/Plugins/ExpressionP

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Michael137 marked an inline comment as done. Michael137 added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.h:356 struct StructVars { -StructVars() : m_result_name(), m_object_pointer_type(nullptr, nullptr) {} +StructVa

[Lldb-commits] [lldb] 4d26faa - [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

Author: Michael Buch Date: 2022-07-12T10:33:41+01:00 New Revision: 4d26faa5262e7940399df04533a31d9642d23349 URL: https://github.com/llvm/llvm-project/commit/4d26faa5262e7940399df04533a31d9642d23349 DIFF: https://github.com/llvm/llvm-project/commit/4d26faa5262e7940399df04533a31d9642d23349.diff

[Lldb-commits] [PATCH] D129367: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d26faa5262e: [LLDB][ClangExpression] Remove unused StructVars::m_object_pointer_type (authored by Michael137). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

labath added a comment. I originally wanted to stay out of this, but then we got a path-resolving bug report which got me thinking about all of this. Generally I would say I agree with Jim, that this is a important problem to solve, but the implementation is somewhat unusual. I don't really hav

[Lldb-commits] [lldb] 4135abc - [lldb] add SBSection.alignment to python bindings

Author: Pavel Labath Date: 2022-07-12T12:14:54+02:00 New Revision: 4135abca897d1b945193f767cbf42a200b55bbdc URL: https://github.com/llvm/llvm-project/commit/4135abca897d1b945193f767cbf42a200b55bbdc DIFF: https://github.com/llvm/llvm-project/commit/4135abca897d1b945193f767cbf42a200b55bbdc.diff

[Lldb-commits] [PATCH] D128069: [lldb] add SBSection.alignment to python bindings

This revision was automatically updated to reflect the committed changes. Closed by commit rG4135abca897d: [lldb] add SBSection.alignment to python bindings (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128069/new/ https://revi

[Lldb-commits] [lldb] 918b1e7 - Revert "[lldb] add SBSection.alignment to python bindings"

Author: Pavel Labath Date: 2022-07-12T12:17:29+02:00 New Revision: 918b1e7bbdd7f7b0228fa2535190f52c4b54d346 URL: https://github.com/llvm/llvm-project/commit/918b1e7bbdd7f7b0228fa2535190f52c4b54d346 DIFF: https://github.com/llvm/llvm-project/commit/918b1e7bbdd7f7b0228fa2535190f52c4b54d346.diff

[Lldb-commits] [lldb] 1e3ee76 - [lldb] add SBSection.alignment to python bindings

Author: David M. Lary Date: 2022-07-12T12:18:38+02:00 New Revision: 1e3ee766bb580ead0a482f213255d334f9af8276 URL: https://github.com/llvm/llvm-project/commit/1e3ee766bb580ead0a482f213255d334f9af8276 DIFF: https://github.com/llvm/llvm-project/commit/1e3ee766bb580ead0a482f213255d334f9af8276.diff

[Lldb-commits] [PATCH] D129554: [lldb] [gdb-remote] Ensure that all threads stop in non-stop mode

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Issue a `vCont;t` request after getting an asynchronous stop notification in non-stop mode in o

[Lldb-commits] [PATCH] D129554: [lldb] [gdb-remote] Ensure that all threads stop in non-stop mode

mgorny updated this revision to Diff 443906. mgorny added a comment. Remove leftover debug hack. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129554/new/ https://reviews.llvm.org/D129554 Files: lldb/packages/Python/lldbsuite/test/gdbclientutils.py lldb/source/Plugins/Process/gdb-r

[Lldb-commits] [lldb] 68cc1ee - [LLDB] Fix NativePDB/local-variables.cpp for AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-07-12T16:26:47+05:00 New Revision: 68cc1eeb1d7fbcaf307fbf199a7c61debf1dd1c1 URL: https://github.com/llvm/llvm-project/commit/68cc1eeb1d7fbcaf307fbf199a7c61debf1dd1c1 DIFF: https://github.com/llvm/llvm-project/commit/68cc1eeb1d7fbcaf307fbf199a7c61debf1dd1

[Lldb-commits] [lldb] 7b69843 - [LLDB] Catagory decorator for watchpoint test in TestCompletion.py

Author: Muhammad Omair Javaid Date: 2022-07-12T17:15:33+05:00 New Revision: 7b69843f0b502bb765206f534d7f50dcf88a60e5 URL: https://github.com/llvm/llvm-project/commit/7b69843f0b502bb765206f534d7f50dcf88a60e5 DIFF: https://github.com/llvm/llvm-project/commit/7b69843f0b502bb765206f534d7f50dcf88a60

[Lldb-commits] [lldb] 7f83dae - try to fix lldb build after d489268392d23

Author: Nico Weber Date: 2022-07-12T11:08:44-04:00 New Revision: 7f83dae7f584b21f0f76b466579bbb7b99b06dc5 URL: https://github.com/llvm/llvm-project/commit/7f83dae7f584b21f0f76b466579bbb7b99b06dc5 DIFF: https://github.com/llvm/llvm-project/commit/7f83dae7f584b21f0f76b466579bbb7b99b06dc5.diff LO

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

JDevlieghere added a comment. Looks like this broke GreenDragon: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/45284/testReport/junit/lldb-api/functionalities_data-formatter_data-formatter-stl_libcxx_string/TestDataFormatterLibcxxString_py/ Repository: rG LLVM Github Monorepo CHA

[Lldb-commits] [lldb] b74a01a - Reland "[LLDB][NFC] Decouple dwarf location table from DWARFExpression."

Author: Zequan Wu Date: 2022-07-12T10:54:24-07:00 New Revision: b74a01a80b72f581c68d336b0de5ed9757efbaa8 URL: https://github.com/llvm/llvm-project/commit/b74a01a80b72f581c68d336b0de5ed9757efbaa8 DIFF: https://github.com/llvm/llvm-project/commit/b74a01a80b72f581c68d336b0de5ed9757efbaa8.diff LOG

[Lldb-commits] [lldb] a72306e - [lldb] Fix TestDataFormatterLibcxxString broken by D129490

Author: Pavel Labath Date: 2022-07-12T20:12:22+02:00 New Revision: a72306e202eedaed7c1a25caf4565bf5577110ce URL: https://github.com/llvm/llvm-project/commit/a72306e202eedaed7c1a25caf4565bf5577110ce DIFF: https://github.com/llvm/llvm-project/commit/a72306e202eedaed7c1a25caf4565bf5577110ce.diff

[Lldb-commits] [PATCH] D129490: [lldb/libc++] Simplify the libc++ string formatter

labath added a comment. Thanks. I can see the problem. rGa72306e202e ought to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129490/new/ https://reviews.llvm.org/D129490

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace accepted this revision. wallace added a comment. I'll commit this for you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128477/new/ https://reviews.llvm.org/D128477 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D129456: [lldb] Add image dump pcm-info command

kastiglione updated this revision to Diff 444057. kastiglione added a comment. simplify error handling by checking for .pcm extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129456/new/ https://reviews.llvm.org/D129456 Files: clang/include

[Lldb-commits] [lldb] b620852 - [lldb] Make the g_arguments_data constexpr and fix the static assert

Author: Jonas Devlieghere Date: 2022-07-12T13:12:36-07:00 New Revision: b620852d235079e56a4fdf71828bf8e7c66f813f URL: https://github.com/llvm/llvm-project/commit/b620852d235079e56a4fdf71828bf8e7c66f813f DIFF: https://github.com/llvm/llvm-project/commit/b620852d235079e56a4fdf71828bf8e7c66f813f.d

[Lldb-commits] [PATCH] D129529: [lldb] Make the g_arguments_data constexpr and fix the static assert

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGb620852d2350: [lldb] Make the g_arguments_data constexpr and fix the static assert (authored by JDevlieghere). Herald adde

[Lldb-commits] [PATCH] D129588: [trace] Avoid a crash in the dumper when disassembling fails

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. In rare situations, disassemblying would fail that produce an invalid Instruc

[Lldb-commits] [lldb] 5edfc0b - [lldb] Fix macOS Ventura version number checks

Author: Jonas Devlieghere Date: 2022-07-12T13:29:46-07:00 New Revision: 5edfc0b928b9ac4c653188828c5637de70bcf8ff URL: https://github.com/llvm/llvm-project/commit/5edfc0b928b9ac4c653188828c5637de70bcf8ff DIFF: https://github.com/llvm/llvm-project/commit/5edfc0b928b9ac4c653188828c5637de70bcf8ff.d

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

clayborg added a comment. In D129307#3644044 , @jingham wrote: > In D129307#3643426 , @yinghuitan > wrote: > >> @jingham, thanks for sharing the thoughts. > > First off, I am supportive of your project, this is a

[Lldb-commits] [PATCH] D129307: Add a new breakpoint partial match settings

clayborg added a comment. In D129307#3644730 , @labath wrote: > I originally wanted to stay out of this, but then we got a path-resolving bug > report which got me thinking about all of this. > > Generally I would say I agree with Jim, that this is a imp

[Lldb-commits] [PATCH] D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

JDevlieghere added inline comments. Comment at: lldb/test/API/tools/lldb-vscode/variables/TestVSCode_variables.py:493-498 +if arch == 'x86_64': +pc_name = 'rip' +elif arch == 'x86': +pc_name = 'rip' +elif arch.startswith('arm'): +

[Lldb-commits] [PATCH] D128250: [LLDB][RISCV]Add initial support for lldb-server.

Emmmer updated this revision to Diff 443482. Emmmer added a comment. This patch change: - Add the recognition of architecture riscv64 in `HostInfoBase.cpp` - Add the recognition of architecture riscv64 and riscv32 in `ObjectFilePECOFF.cpp` - Add riscv's `ebreak` command to `Platform.cpp` Now ll

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

MaskRay added a comment. As I mentioned, the proper approach is to add zstd functionality along with the CMake change, instead of adding CMake to all llvm-project components without a way to test them. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABL

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added a comment. The review shows the diff with the previous iteration of the patch. Can you generate a diff with the current top-of-tree? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129377/new/ https://reviews.llvm.org/D129377 ___

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 443687. ckissane added a comment. clean a space and make accurate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeLists.txt

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 443768. cassanova added a comment. Shows top-of-tree changes, however CMake generation fails that the ProtobufMutator target already exists for clang-fuzzer: CMake Error at /opt/homebrew/Cellar/cmake/3.23.1_1/share/cmake/Modules/ExternalProject.cmake:34

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov added a comment. Herald added a subscriber: JDevlieghere. In D111509#3168178 , @shafik wrote: > llvm-lit -sv lldb/test --filter TestScalarURem.py > > The change looks expected. Thanks for letting me know. Unfortunately that test is not suppor

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 443769. Herald added subscribers: lldb-commits, Enna1. Herald added projects: LLDB, All. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.ll

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 443772. Herald added subscribers: usaxena95, kadircet, arphaman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/Ext

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane added inline comments. Comment at: lld/test/lit.site.cfg.py.in:21 config.have_zlib = @LLVM_ENABLE_ZLIB@ +config.have_zstd = @LLVM_ENABLE_ZSTD@ config.have_libxar = @LLVM_HAVE_LIBXAR@ MaskRay wrote: > MaskRay wrote: > > This needs a change in lld/test/C

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova added inline comments. Comment at: lldb/tools/lldb-fuzzer/lldb-expression-fuzzer/CMakeLists.txt:21 + +include(ProtobufMutator) +include_directories(${ProtobufMutator_INCLUDE_DIRS}) Commenting out this line causes the project to generate, but I g

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM

ckissane updated this revision to Diff 444044. ckissane added a comment. - make sure LLVM_ENABLE_ZSTD OFF turns into 0 - add zstd compression namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 File

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 443951. mizvekov marked 2 inline comments as done. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3642997 , @MaskRay wrote: > As I mentioned, the proper approach is to add zstd functionality along with > the CMake change, instead of adding CMake to all llvm-project components > without a way to test them. @MaskR

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

rsmith accepted this revision. rsmith added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

mizvekov updated this revision to Diff 444066. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111509/new/ https://reviews.llvm.org/D111509 Files: clang-tools-extra/clangd/unittests/tweaks/ExtractVariableTests.cpp clang-tools-extra/test/clang-tid

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 444067. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

MaskRay added a comment. In D128465#3646203 , @ckissane wrote: > In D128465#3642997 , @MaskRay wrote: > >> As I mentioned, the proper approach is to add zstd functionality along with >> the CMake change, instead

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

mib added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() If feels wrong to me that the cl

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane updated this revision to Diff 444078. ckissane added a comment. - add zstd tests to CompressionTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128465/new/ https://reviews.llvm.org/D128465 Files: clang-tools-extra/clangd/CMakeList

[Lldb-commits] [PATCH] D111509: [clang] use getCommonSugar in an assortment of places

rsmith accepted this revision. rsmith added a comment. Looks good to me. Comment at: clang/lib/Sema/SemaExprCXX.cpp:6504-6516 // If we have function pointer types, unify them anyway to unify their // exception specifications, if any. if (LTy->isFunctionPointerTyp

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

ckissane added a comment. In D128465#3646258 , @MaskRay wrote: > In D128465#3646203 , @ckissane > wrote: > >> In D128465#3642997 , @MaskRay >> wrote: >> >>> As I mention

[Lldb-commits] [PATCH] D128465: [llvm] cmake config groundwork to have ZSTD in LLVM and add ZSTD compression namespace

MaskRay added a comment. In D128465#3646561 , @ckissane wrote: > In D128465#3646258 , @MaskRay wrote: > >> In D128465#3646203 , @ckissane >> wrote: >> >>> In D128465#3642

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() mib wrote: > If feels wron

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

cassanova updated this revision to Diff 444074. cassanova added a comment. The ProtobufMutator CMake module will build targets for clang and lldb individually depending on which project is building the mutator, instead of both fuzzers trying to build the same target. The expression fuzzer's sou

[Lldb-commits] [PATCH] D129528: Modify all register values whose byte size matches the address size to be formatter as eFormatAddressInfo.

clayborg updated this revision to Diff 444092. clayborg added a comment. Only change the format for registers in the first register set and only change the format if the format was eFormatDefault or eFormatHex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D129603: [lldb/crashlog] Fix interactive crashlog test

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix the interactive crashlog test by checking in the binary and debug info so tha

Re: [Lldb-commits] [PATCH] D124409: Filter non-external static members from SBType::GetFieldAtIndex.

On Wed, May 4, 2022 at 11:26 AM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath accepted this revision. > labath added a comment. > This revision is now accepted and ready to land. > > Looks good. Thanks for the patch. Do you need me to commit this for you? > Yes please -

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

mizvekov updated this revision to Diff 444104. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112374/new/ https://reviews.llvm.org/D112374 Files: clang-tools-extra/clang-change-namespace/ChangeNamespace.cpp clang-tools-extra/clang-include-fixer/f

[Lldb-commits] [lldb] ad7bcda - [trace] Add a flag to the decoder to output the instruction type

Author: Walter Erquinigo Date: 2022-07-12T16:23:03-07:00 New Revision: ad7bcda9402d4473c12461a76a2bc27a600a8001 URL: https://github.com/llvm/llvm-project/commit/ad7bcda9402d4473c12461a76a2bc27a600a8001 DIFF: https://github.com/llvm/llvm-project/commit/ad7bcda9402d4473c12461a76a2bc27a600a8001.di

[Lldb-commits] [lldb] dbc0cb0 - [trace] Avoid a crash in the dumper when disassembling fails

Author: Walter Erquinigo Date: 2022-07-12T16:23:03-07:00 New Revision: dbc0cb0198129fbded7ff3be5d080cd12ad91783 URL: https://github.com/llvm/llvm-project/commit/dbc0cb0198129fbded7ff3be5d080cd12ad91783 DIFF: https://github.com/llvm/llvm-project/commit/dbc0cb0198129fbded7ff3be5d080cd12ad91783.di

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGad7bcda9402d: [trace] Add a flag to the decoder to output the instruction type (authored by Walter Erquinigo

[Lldb-commits] [PATCH] D129588: [trace] Avoid a crash in the dumper when disassembling fails

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdbc0cb019812: [trace] Avoid a crash in the dumper when disassembling fails (authored by Walter Erquinigo ). Changed prior to commit:

[Lldb-commits] [PATCH] D129603: [lldb/crashlog] Fix interactive crashlog test

JDevlieghere added a comment. Can we use obj2yaml / yaml2obj for the binary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129603/new/ https://reviews.llvm.org/D129603 ___ lldb-commits mailing list lldb-

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbdc6974f9230: [clang] Implement ElaboratedType sugaring for types

[Lldb-commits] [PATCH] D129377: [lldb/Fuzzer] Add fuzzer for expression evaluator

JDevlieghere added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:4-5 + set (PBM_PREFIX clang_protobuf_mutator) +elseif(${CMAKE_CURRENT_SOURCE_DIR} MATCHES "lldb") + set (PBM_PREFIX lldb_protobuf_mutator) +endif() cassanova wrote: > mib

[Lldb-commits] [PATCH] D129611: [lldb/crashlog] Add '-t|--target' option to interactive mode

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new flag for the interactive crashlog mode, that allow the user to specify,

[Lldb-commits] [PATCH] D129613: [trace][intel pt] Add a nice parser for the trace size

wallace created this revision. wallace added reviewers: persona0220, jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Thanks to rnofe...@fb.com for coming up with these changes. This diff adds s

[Lldb-commits] [PATCH] D129614: [lldb/crashlog] Surface error using SBCommandReturnObject argument

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch allows the crashlog script to surface its errors to lldb by using the provided SBCommand

[Lldb-commits] [PATCH] D129613: [trace][intel pt] Add a nice parser for the trace size

wallace updated this revision to Diff 444132. wallace added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129613/new/ https://reviews.llvm.org/D129613 Files: lldb/source/Plugins/Trace/intel-pt/CommandObjectTraceStartIntelPT.cpp