[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace added inline comments. Comment at: lldb/include/lldb/Core/Disassembler.h:82-86 + lldb::InstructionControlFlowType + instruction_decode(uint8_t opcode, uint8_t modrm, uint8_t map); + + lldb::InstructionControlFlowType + GetControlFlowInstructionKind(const ExecutionCont

[Lldb-commits] [PATCH] D128477: [trace] Add a flag to the decoder to output the instruction type

wallace added a comment. nice job!! Comment at: lldb/source/Commands/Options.td:304 + def disassemble_options_kind : Option<"kind", "k">, +Desc<"Show instruction control flow type.">; def disassemble_options_context : Option<"context", "C">, Arg<"NumLines">, ---

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

wallace created this revision. wallace added reviewers: jj10306, persona0220. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. https://reviews.llvm.org/D128453 recently added some safety checks for comman

[Lldb-commits] [lldb] 6564ca1 - [trace] Fix errors when handling command arguments

Author: Walter Erquinigo Date: 2022-06-28T17:54:30-07:00 New Revision: 6564ca188a122c79c36ad7e4b3d362fb22fbd0b5 URL: https://github.com/llvm/llvm-project/commit/6564ca188a122c79c36ad7e4b3d362fb22fbd0b5 DIFF: https://github.com/llvm/llvm-project/commit/6564ca188a122c79c36ad7e4b3d362fb22fbd0b5.di

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6564ca188a12: [trace] Fix errors when handling command arguments (authored by Walter Erquinigo ). Reposit

[Lldb-commits] [PATCH] D128776: Handle a stop when another thread has hit a breakpoint with a failed condition

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Threads which hit a breakpoint but fail the condition are considered not to be hit.

[Lldb-commits] [PATCH] D128576: [trace] Make events first class items in the trace cursor and rework errors

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:171 + /// information failed to load, an \a llvm::Error is returned. + virtual llvm::Expected + CreateNewCursor(Thread &thread) = 0; jj10306 wrote: > Do we want to keep the cursor

[Lldb-commits] [PATCH] D128638: [lldb] [llgs] Add base nonstop fork/vfork tests

mgorny added a comment. I am trying to but unfortunately the server seems to be down. Unfortunately, I can't reproduce this on my aarch64 test machine but maybe the test is taking too long now (we've been suspecting that might be the case). I'm going to split it and see if that helps. Reposit

[Lldb-commits] [PATCH] D128775: [trace] Fix errors when handling command arguments

persona0220 added a comment. lgtm. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128775/new/ https://reviews.llvm.org/D128775 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [lldb] 7fc12da - [lldb] [test] Split TestGdbRemoteFork in two

Author: Michał Górny Date: 2022-06-29T06:57:38+02:00 New Revision: 7fc12da898e05e68ec59fbe852c4402378938efa URL: https://github.com/llvm/llvm-project/commit/7fc12da898e05e68ec59fbe852c4402378938efa DIFF: https://github.com/llvm/llvm-project/commit/7fc12da898e05e68ec59fbe852c4402378938efa.diff

[Lldb-commits] [PATCH] D128780: [lldb] [test] Use raise(SIGSTOP) instead of trap in fork tests

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added subscribers: kristof.beyls, arichardson. Herald added a project: All. mgorny requested review of this revision. Replace the use of "trap" with a new "stop" command in fork tests, that maps to `

<    1   2