[Lldb-commits] [PATCH] D126668: LLDB: Fix resolving nested template parameters

2022-06-13 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. > I don't really have the full context here, but I am wondering if we shouldn't > somehow take the DW_AT_declaration attribute into account here. It seems like > that should give a more definitive answer as to whether we can expect to see > a full set of template para

[Lldb-commits] [PATCH] D127667: [PATCH] [lldb] [llgs] Implement the vKill packet

2022-06-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski, jingham. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Implement the support for the vKill packet. This is the modern packet used by the GDB Remote S

[Lldb-commits] [PATCH] D127667: [PATCH] [lldb] [llgs] Implement the vKill packet

2022-06-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 436441. mgorny added a comment. Remove leftover `exit_regex` from test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127667/new/ https://reviews.llvm.org/D127667 Files: lldb/include/lldb/Utility/StringExtractorGDBRemote.h lldb/source/Plugins/Pr

[Lldb-commits] [PATCH] D116136: [lldb] Add missing UTF-8 char basic type entries

2022-06-13 Thread Luís Ferreira via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG6d5b86f851a1: [lldb] Add missing UTF-8 char basic type entries (authored by ljmf00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116136/new/ https://revie

[Lldb-commits] [lldb] 6d5b86f - [lldb] Add missing UTF-8 char basic type entries

2022-06-13 Thread Luís Ferreira via lldb-commits
Author: Luís Ferreira Date: 2022-06-13T17:33:46Z New Revision: 6d5b86f851a1ee6475c767b8f94e3598cdd5a9fe URL: https://github.com/llvm/llvm-project/commit/6d5b86f851a1ee6475c767b8f94e3598cdd5a9fe DIFF: https://github.com/llvm/llvm-project/commit/6d5b86f851a1ee6475c767b8f94e3598cdd5a9fe.diff LOG:

[Lldb-commits] [lldb] 3222f95 - [LLDB][NativePDB] Convert backslash to slash when creating CU and filter out CU with no function in ResolveSymbolContext.

2022-06-13 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2022-06-13T12:04:25-07:00 New Revision: 3222f95ea8c4de153f908c138cdec178e22acaf4 URL: https://github.com/llvm/llvm-project/commit/3222f95ea8c4de153f908c138cdec178e22acaf4 DIFF: https://github.com/llvm/llvm-project/commit/3222f95ea8c4de153f908c138cdec178e22acaf4.diff LOG

[Lldb-commits] [lldb] ae60869 - Minor fix to 3222f95ea8c4de153f908c138cdec178e22acaf4

2022-06-13 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2022-06-13T12:06:07-07:00 New Revision: ae60869908db6e8f45b51bc35d983706e8a296ae URL: https://github.com/llvm/llvm-project/commit/ae60869908db6e8f45b51bc35d983706e8a296ae DIFF: https://github.com/llvm/llvm-project/commit/ae60869908db6e8f45b51bc35d983706e8a296ae.diff LOG

[Lldb-commits] [lldb] 98c2a85 - Minor fix to ae60869908db6e8f45b51bc35d983706e8a296ae

2022-06-13 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2022-06-13T12:08:26-07:00 New Revision: 98c2a853eb5e8b0e855f6da935889309544f6d9b URL: https://github.com/llvm/llvm-project/commit/98c2a853eb5e8b0e855f6da935889309544f6d9b DIFF: https://github.com/llvm/llvm-project/commit/98c2a853eb5e8b0e855f6da935889309544f6d9b.diff LOG

[Lldb-commits] [PATCH] D127481: [LLDB][formatters] Add formatter for libc++'s std::span

2022-06-13 Thread Adrian Prantl via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGea9ff9fac3a6: [LLDB][formatters] Add formatter for libc++'s std::span (authored by aprantl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127481/new/ https

[Lldb-commits] [lldb] ea9ff9f - [LLDB][formatters] Add formatter for libc++'s std::span

2022-06-13 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2022-06-13T12:59:38-07:00 New Revision: ea9ff9fac3a6ea77b488081dd9faabc8fe334b46 URL: https://github.com/llvm/llvm-project/commit/ea9ff9fac3a6ea77b488081dd9faabc8fe334b46 DIFF: https://github.com/llvm/llvm-project/commit/ea9ff9fac3a6ea77b488081dd9faabc8fe334b46.diff

[Lldb-commits] [lldb] 602a951 - Partially revert 3222f95ea8c4de153f908c138cdec178e22acaf4

2022-06-13 Thread Zequan Wu via lldb-commits
Author: Zequan Wu Date: 2022-06-13T13:29:32-07:00 New Revision: 602a951bfe3401f81e2759089b14a549c39dc394 URL: https://github.com/llvm/llvm-project/commit/602a951bfe3401f81e2759089b14a549c39dc394 DIFF: https://github.com/llvm/llvm-project/commit/602a951bfe3401f81e2759089b14a549c39dc394.diff LOG

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

2022-06-13 Thread jeffrey tan via Phabricator via lldb-commits
yinghuitan created this revision. yinghuitan added reviewers: clayborg, labath, jingham, jdoerfert, JDevlieghere, aadsm, kusmour. Herald added a project: All. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch implements

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

2022-06-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/tools/lldb-vscode/breakpoint/TestVSCode_logpoints.py:60 +[loop_line, after_loop_line], +[{'logMessage': l

[Lldb-commits] [PATCH] D127702: Support logpoints in lldb-vscode

2022-06-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/BreakpointBase.cpp:126 +const llvm::StringRef &expr = bp->evalExpressions[i]; +// TODO: try local variables first. +lldb::SBValue value = frame.EvaluateExpression(expr.str().c_str());

[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

2022-06-13 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This is good, but it also illustrates how the strings "->" and ".'" should actually come from the typesystem and not be hardcoded. We're just lucky that all languages have a "." operator.

[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

2022-06-13 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl added a comment. More elegant would be to just add an API to TypeSystem to get the operator to access ivars. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127605/new/ https://reviews.llvm.org/D127605 __

[Lldb-commits] [PATCH] D127605: [lldb] Support non-pointer implicit this/self in GetValueForVariableExpressionPath

2022-06-13 Thread Dave Lee via Phabricator via lldb-commits
kastiglione added a comment. > This is good, but it also illustrates how the strings "->" and ".'" should > actually come from the typesystem and not be hardcoded. We're just lucky that > all languages have a "." operator. > > More elegant would be to just add an API to TypeSystem to get the ope

[Lldb-commits] [lldb] 926a7ec - [lldb] Fix TCPSocket::Connect when getaddrinfo returns multiple addrs

2022-06-13 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-06-14T08:49:02+02:00 New Revision: 926a7ecdc8b21f01b06a1db78bdd81f1dacaad61 URL: https://github.com/llvm/llvm-project/commit/926a7ecdc8b21f01b06a1db78bdd81f1dacaad61 DIFF: https://github.com/llvm/llvm-project/commit/926a7ecdc8b21f01b06a1db78bdd81f1dacaad61.diff

[Lldb-commits] [PATCH] D126702: [lldb] Fix TCPSocket::Connect when getaddrinfo returns multiple addrs

2022-06-13 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG926a7ecdc8b2: [lldb] Fix TCPSocket::Connect when getaddrinfo returns multiple addrs (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12670

[Lldb-commits] [PATCH] D126702: [lldb] Fix TCPSocket::Connect when getaddrinfo returns multiple addrs

2022-06-13 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Committed now, thanks for the patch. I'm not sure if there will be another 14.x release, but you can file a bug to track this, if there happens to be one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126702/new/ https://re