[Lldb-commits] [PATCH] D127048: [lldb] Set COFF and PDB module env from default target triple

alvinhochun added a comment. Thanks for the hint. I think I can add a setting, say `plugin.object-file.pe-coff.abi`. It needs some plumbing but should be doable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127048/new/ https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. This LGTM. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:929 + if (GetDebugLinkContents

[Lldb-commits] [lldb] e4ed7ca - [LLDB] Avoid using -fno-builtin for building API tests

Author: Muhammad Omair Javaid Date: 2022-06-07T12:41:29+04:00 New Revision: e4ed7ca996ba5bb1be7b877c4c53ef2a5fb534f5 URL: https://github.com/llvm/llvm-project/commit/e4ed7ca996ba5bb1be7b877c4c53ef2a5fb534f5 DIFF: https://github.com/llvm/llvm-project/commit/e4ed7ca996ba5bb1be7b877c4c53ef2a5fb534

[Lldb-commits] [PATCH] D127191: [lldb] [llgs] Include process id in W/X stop reasons

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Include the process identifier in W/X stop reasons when multiprocess extensions are enabled. The LLDB c

[Lldb-commits] [PATCH] D127192: [lldb] [llgs] Include process ID in stop responses

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Include the process identifier in the `T` stop responses when multiprocess extension is enabled (i.e. pr

[Lldb-commits] [PATCH] D127193: [lldb] [llgs] Fix signo sent with fork/vfork/vforkdone events

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. Herald added a project: All. mgorny requested review of this revision. Fix sending stop reasons to include SIGTRAP as the signal number for fork/vfork/vforkdone events. Since

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun updated this revision to Diff 434800. alvinhochun added a comment. Applied suggested change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126367/new/ https://reviews.llvm.org/D126367 Files: lldb/source/Plugins/ObjectFile/PECOFF/Objec

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun planned changes to this revision. alvinhochun added a comment. Sorry, I just realized the crc change broke a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126367/new/ https://reviews.llvm.org/D126367 _

[Lldb-commits] [PATCH] D127192: [lldb] [llgs] Include process ID in stop responses

mgorny updated this revision to Diff 434818. mgorny added a comment. Fix formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127192/new/ https://reviews.llvm.org/D127192 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp lldb/test/API/tools/lld

[Lldb-commits] [lldb] d3d9bbd - [LLDB] Fix TestBase.generateSource for AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-06-07T19:25:35+04:00 New Revision: d3d9bbd104368850d5e362ce8c5982f468272ae8 URL: https://github.com/llvm/llvm-project/commit/d3d9bbd104368850d5e362ce8c5982f468272ae8 DIFF: https://github.com/llvm/llvm-project/commit/d3d9bbd104368850d5e362ce8c5982f468272a

[Lldb-commits] [lldb] 7daa9a9 - [LLDB] Remove decorator from XPASSes AArch64/Windows

Author: Muhammad Omair Javaid Date: 2022-06-07T19:30:26+04:00 New Revision: 7daa9a9b40a22c8ebac529f2fe7772191f2cea5a URL: https://github.com/llvm/llvm-project/commit/7daa9a9b40a22c8ebac529f2fe7772191f2cea5a DIFF: https://github.com/llvm/llvm-project/commit/7daa9a9b40a22c8ebac529f2fe7772191f2cea

[Lldb-commits] [PATCH] D126367: [lldb] Add gnu-debuglink support for Windows PE/COFF

alvinhochun added a comment. The test https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/Minidump/Windows/find-module.test fails with this patch. That test opens a minidump and checks that the associated exe is loaded. The minidump contains a codeview PDB record for the exe which i

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

alvinhochun updated this revision to Diff 434875. alvinhochun retitled this revision from "[lldb] Set COFF and PDB module env from default target triple" to "[lldb] Set COFF module ABI from default triple and make it an option". alvinhochun edited the summary of this revision. alvinhochun added a

[Lldb-commits] [PATCH] D125509: [LLDB][NFC] Decouple dwarf location table from DWARFExpression.

rnk added a comment. @labath, ping, I see you just got back from vacation and this is a lot of code, but any high level design feedback would be helpful to know if this is the right direction. Comment at: llvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp:180 if (!Loc) - re

[Lldb-commits] [PATCH] D127234: [lldb] Add setting to override PE/COFF ABI by module name

alvinhochun created this revision. Herald added a subscriber: mstorsjo. Herald added a project: All. alvinhochun requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The setting `plugin.object-file.pe-coff.module-abi` is a string-to-enum map tha

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

dschuff added inline comments. Comment at: llvm/lib/ObjCopy/wasm/WasmReader.cpp:32-35 -// If the section type is CUSTOM, it has a name already. If it's a new type -// of section that we don't explicitly handle here, it will have an empty -// name and objcopy won't be

[Lldb-commits] [lldb] 2ae385e - [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

Author: Derek Schuff Date: 2022-06-07T12:05:23-07:00 New Revision: 2ae385e560a62a18942cbc202cd19313c6c59470 URL: https://github.com/llvm/llvm-project/commit/2ae385e560a62a18942cbc202cd19313c6c59470 DIFF: https://github.com/llvm/llvm-project/commit/2ae385e560a62a18942cbc202cd19313c6c59470.diff

[Lldb-commits] [PATCH] D127164: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ae385e560a6: [WebAssembly] Add WASM_SEC_LAST_KNOWN to BinaryFormat section types list [NFC] (authored by dschuff). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D127247: On Darwin systems, follow transition from on-disk dyld to shared-cache dyld at process launch

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. In macOS Ventura et al, the dynamic linker, dyld, has moved int

[Lldb-commits] [PATCH] D127247: On Darwin systems, follow transition from on-disk dyld to shared-cache dyld at process launch

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. This was also reviewed internally and we've been living on this patch for a while now. Testing is provided by running the existing test suite on macOS Ventura. Repository:

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl accepted this revision. aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:403 case DW_AT_type: - type = form_value; + if (!type.IsValid()) +type = form_value; Could you add a com

[Lldb-commits] [PATCH] D127247: On Darwin systems, follow transition from on-disk dyld to shared-cache dyld at process launch

This revision was automatically updated to reflect the committed changes. Closed by commit rG8d5a6007f968: Track transition from launch dyld to shared-cache dyld (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D127247?vs=434921&id=434936#toc Repository: rG LLVM

[Lldb-commits] [lldb] 8d5a600 - Track transition from launch dyld to shared-cache dyld

Author: Jason Molenda Date: 2022-06-07T13:34:30-07:00 New Revision: 8d5a6007f9681ded3e6442bafdea87e733d771ea URL: https://github.com/llvm/llvm-project/commit/8d5a6007f9681ded3e6442bafdea87e733d771ea DIFF: https://github.com/llvm/llvm-project/commit/8d5a6007f9681ded3e6442bafdea87e733d771ea.diff

[Lldb-commits] [PATCH] D127252: [lldb] Use objc_getRealizedClassList_trylock if available

JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Herald added a project: LLDB. In order to avoid stranding the Objective-C runtime lock, we switched from `objc_copyRealizedClassList` to its non

[Lldb-commits] [lldb] d572fc3 - Skip TestConcurrentWatchBreak.py on Darwin arm64

Author: Jason Molenda Date: 2022-06-07T14:33:40-07:00 New Revision: d572fc3b49bd53b7871223b3054b235cf99f6b61 URL: https://github.com/llvm/llvm-project/commit/d572fc3b49bd53b7871223b3054b235cf99f6b61 DIFF: https://github.com/llvm/llvm-project/commit/d572fc3b49bd53b7871223b3054b235cf99f6b61.diff

[Lldb-commits] [PATCH] D126240: [lldb] Tighten the scope of a couple of locks in DataFormatters.

jgorbe added a comment. I've been experimenting a little bit and it seems that I can avoid the deadlocks I was seeing by applying only the modification to `TypeCategoryMap::Add`. This would avoid the problem that @hawkinsw pointed out in my change to `FormatManager::GetCategoryForLanguage`. How

[Lldb-commits] [PATCH] D127258: [lldb] Mark API tests as XFAIL if they have expected failures and no passing tests

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, mib. Herald added a project: All. JDevlieghere requested review of this revision. Currently, when an API test has no passing tests but at least one unsupported test, we report the test as unsupported. This patch slightly c

[Lldb-commits] [PATCH] D127258: [lldb] Mark API tests as XFAIL if they have expected failures and no passing tests

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Makes more sense. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127258/new/ https://reviews.llvm.org/D127258 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D127258: [lldb] Mark API tests as XFAIL if they have expected failures and no passing tests

JDevlieghere updated this revision to Diff 434984. JDevlieghere added a comment. I was in the process of writing a comment saying that we could be even more accurate by parsing the number of tests with a particular result code from the dotest output but that that seemed overkill before I changed

[Lldb-commits] [PATCH] D127258: [lldb] Mark API tests as XFAIL if they have expected failures and no passing tests

mib accepted this revision. mib added a comment. Even better! LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127258/new/ https://reviews.llvm.org/D127258 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

JDevlieghere added a comment. Here are the results: Before: Unsupported: 145 Passed : 873 Failed : 7 After: Unsupported : 167 Passed : 834 Expectedly Failed: 16 Unresolved : 1 Failed : 7 Note that this pat

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham updated this revision to Diff 435013. jingham added a comment. Allow for specifying breakpoint locations as well as breakpoints. Also fix the sync setting & resetting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://review

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham marked an inline comment as done. jingham added a comment. In D126513#3550588 , @kastiglione wrote: > I noticed that the example python command and this feature don't support > specifying breakpoint locations. Should it? Man, that was WAY harde

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham marked an inline comment as done. jingham added a comment. Added the ability to specify breakpoint locations to run to as well as breakpoints and breakpoint names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https://reviews.l

[Lldb-commits] [PATCH] D126513: Add -b (--continue-to-breakpoint) option to the "process continue" command

jingham added a comment. I have to fix the doc string for the -b option since it's now a bkpt_id_list. But that won't affect the logic so I'll do that and update the patch tomorrow. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126513/new/ https:

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

kastiglione added a comment. > That means that if you have a test that has 3 passes and 4 skips, it will be > reported as unsupported (while currently it's considered a pass). My initial reaction to this is that I don't love it. I think N passes and M skips is a **pass**, even if M>N. ==

[Lldb-commits] [PATCH] D127258: [lldb] Parse the dotest output to determine the most appropriate result code

kastiglione added a comment. instead of reducing and picking returning a single result, can we return the raw counts and then report the totals of the counts? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127258/new/ https://reviews.llvm.org/D127258 ___

[Lldb-commits] [PATCH] D114491: WIP -- add CLI to lldb-vscode

lanza abandoned this revision. lanza added a comment. Herald added a project: All. 😢 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114491/new/ https://reviews.llvm.org/D114491 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D127048: [lldb] Set COFF module ABI from default triple and make it an option

omjavaid added a comment. I am not fully familiar with PE/COFF but lets try to get this merged. For starters I have a couple of questions here: 1. This rev apparently assumes x86_64 only but what about Arm/AArch64? 2. If we have DLLs what abi setting they ll follow the one set by the user or de