[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 428880. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/source/API/SBProcess.cpp Index: lldb/source/API/SBPro

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat marked 3 inline comments as done. PatriosTheGreat added a comment. Thanks for clarifications. Fixed header doc and parameter name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib added a comment. Address @jingham feedbacks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125437/new/ https://reviews.llvm.org/D125437 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D125347: Add "indexedVariables" to variables with lots of children.

wallace added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125347/new/ https://reviews.llvm.org/D125347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [lldb] 3339000 - We don't require users to type out the full context of a function, for

Author: Jim Ingham Date: 2022-05-12T12:39:28-07:00 New Revision: 3339000e0bda696c2e29173d15958c0a4978a143 URL: https://github.com/llvm/llvm-project/commit/3339000e0bda696c2e29173d15958c0a4978a143 DIFF: https://github.com/llvm/llvm-project/commit/3339000e0bda696c2e29173d15958c0a4978a143.diff LO

[Lldb-commits] [PATCH] D124579: Make partial function name matching match on context boundaries

This revision was automatically updated to reflect the committed changes. jingham marked 4 inline comments as done. Closed by commit rG3339000e0bda: We don't require users to type out the full context of a function, for (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125437/new/ https://reviews.llvm.org/D125437 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class

wallace created this revision. wallace added a reviewer: jj10306. Herald added a project: All. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We have two different "process trace" implementations: per thread and per core. As a way

[Lldb-commits] [lldb] c6799d9 - Revision 3339000e0bda696c2e29173d15958c0a4978a143 caused the Language

Author: Jim Ingham Date: 2022-05-12T14:32:00-07:00 New Revision: c6799d98435df03872b960d95fcfa32718971bd6 URL: https://github.com/llvm/llvm-project/commit/c6799d98435df03872b960d95fcfa32718971bd6 DIFF: https://github.com/llvm/llvm-project/commit/c6799d98435df03872b960d95fcfa32718971bd6.diff LO

[Lldb-commits] [PATCH] D125503: [trace][intelpt] Support system-wide tracing [7] - Create a base IntelPTProcessTrace class

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.cpp:70 -Expected -IntelPTPerThreadProcessTrace::Start(const TraceIntelPTStartRequest &request, this shouldn't have been here since the beginning Com

[Lldb-commits] [PATCH] D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. This is a nice piece of work, and a good cleanup, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125434/new/ https://reviews.ll

[Lldb-commits] [PATCH] D125505: Cache tilde expansions to avoid redundant lookups

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. Herald added a project: All. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. We have tilde's in our dSYMs internally, and expanding these ca

[Lldb-commits] [lldb] b1aed14 - [llvm][lldb] use FindLibEdit.cmake everywhere

Author: Tobias Ribizel Date: 2022-05-12T15:59:41-07:00 New Revision: b1aed14bfea07508e4b9d864168c1ae6b5b5c665 URL: https://github.com/llvm/llvm-project/commit/b1aed14bfea07508e4b9d864168c1ae6b5b5c665 DIFF: https://github.com/llvm/llvm-project/commit/b1aed14bfea07508e4b9d864168c1ae6b5b5c665.diff

[Lldb-commits] [PATCH] D124673: [llvm][lldb] use FindLibEdit.cmake everywhere

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb1aed14bfea0: [llvm][lldb] use FindLibEdit.cmake everywhere (authored by upsj, committed by MaskRay). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg added a comment. It might be a good idea to add a test for this. There seems to be a test already in this file: lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py In fact looking at this test, it seems they specify the "SaveCoreStyle" via an opt

[Lldb-commits] [PATCH] D125505: Cache tilde expansions to avoid redundant lookups

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I don't think the cache belongs in a global in the TildeExpressionResolver class. The derived ExpressionResolvers might very well resolve the same ~foo to different paths (e.g. if

[Lldb-commits] [PATCH] D125505: Cache tilde expansions to avoid redundant lookups

jasonmolenda added a comment. Yeah, you're right. And as I walk through in my head what I'm solving with this -- it's not the really expensive part of this whole operation, I don't think. I should check more carefully but it's the stat's over NFS partitions that are impacting performance, and

[Lldb-commits] [lldb] a6926d5 - [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

Author: Med Ismail Bennani Date: 2022-05-12T16:54:22-07:00 New Revision: a6926d576131c9ad849fef6f1d43134caab5025e URL: https://github.com/llvm/llvm-project/commit/a6926d576131c9ad849fef6f1d43134caab5025e DIFF: https://github.com/llvm/llvm-project/commit/a6926d576131c9ad849fef6f1d43134caab5025e.

[Lldb-commits] [lldb] 8b9caad - [lldb/test] Skip TestCppIncompleteTypeMembers.py on Darwin (NFC)

Author: Med Ismail Bennani Date: 2022-05-12T16:54:23-07:00 New Revision: 8b9caad8eb449c1dc4df13e566a5f6c59de9be7c URL: https://github.com/llvm/llvm-project/commit/8b9caad8eb449c1dc4df13e566a5f6c59de9be7c DIFF: https://github.com/llvm/llvm-project/commit/8b9caad8eb449c1dc4df13e566a5f6c59de9be7c.

[Lldb-commits] [lldb] 2a21700 - In 92eaad2dd7adb5ee92f397cef85ab11f2612294e I made it possible to run

Author: Jim Ingham Date: 2022-05-12T17:11:01-07:00 New Revision: 2a21700bc5be24532952c2705fbbe784f8ec3164 URL: https://github.com/llvm/llvm-project/commit/2a21700bc5be24532952c2705fbbe784f8ec3164 DIFF: https://github.com/llvm/llvm-project/commit/2a21700bc5be24532952c2705fbbe784f8ec3164.diff LO

[Lldb-commits] [PATCH] D124947: Allow `target create` with no local file

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a21700bc5be: In 92eaad2dd7adb5ee92f397cef85ab11f2612294e I made it possible to run (authored by jingham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1249

[Lldb-commits] [lldb] 2d7b49f - [lldb/test] Skip TestCppIncompleteTypeMembers.py for -gmodules on macOS

Author: Med Ismail Bennani Date: 2022-05-12T17:12:13-07:00 New Revision: 2d7b49f389781751eac36f479b59d854664e9da5 URL: https://github.com/llvm/llvm-project/commit/2d7b49f389781751eac36f479b59d854664e9da5 DIFF: https://github.com/llvm/llvm-project/commit/2d7b49f389781751eac36f479b59d854664e9da5.

[Lldb-commits] [PATCH] D125509: [WIP][LLDB][NFC] Decouple dwarf location table from DWARFExpression.

zequanwu created this revision. Herald added subscribers: hiraditya, mgorny. Herald added a reviewer: shafik. Herald added a project: All. zequanwu requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. Repository: rG LLVM Gith