[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 428577. PatriosTheGreat edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/so

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat marked 3 inline comments as done. PatriosTheGreat added a comment. Hi Greg. Thanks for the review. I fixed the feedback. I forgot the default initialization of plugin_name parameter in SBProcess.i in previous version, but I assume it's still better to explicitly create a separat

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

jj10306 accepted this revision. jj10306 added a comment. This revision is now accepted and ready to land. couple minor things, but looks good overall Comment at: lldb/docs/lldb-gdb-remote.txt:465-474 // "tid": , // "binaryData": [ //{ // "kind": ,

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

jj10306 added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTCollector.h:152-156 + IntelPTPerThreadProcessTraceUP m_per_thread_process_trace_up; + /// Cores traced due to per-core "process tracing". Only one active + /// "process tracing" instance is all

[Lldb-commits] [PATCH] D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor

jj10306 accepted this revision. jj10306 added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Utility/TraceGDBRemotePackets.cpp:136 {"tid", packet.tid}, -{"size", packet.size}}); +

[Lldb-commits] [PATCH] D124731: [lldb] Consider binary as module of last resort

hawkinsw added a comment. Sorry to bother you all (@jingham, @JDevlieghere and @labath), but I just wondered if there was anything else that I could do to spruce this up! I want to make sure that it meets everyone's expectations! It's been awesome to work on this submission! Will Repository

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:465-474 // "tid": , // "binaryData": [ //{ // "kind": , // Identifier for some binary data related to this thread to // fetch with the jLLDBTraceGet

[Lldb-commits] [PATCH] D124858: [trace][intelpt] Support system-wide tracing [4] - Support per core tracing on lldb-server

wallace updated this revision to Diff 428687. wallace added a comment. address comments In a newer diff I'll create a base class for all "process tracing" strategies, so that we don't need to use two unique pointers for both process tracing classes in the collector. I'm not doing it here becaue

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

jingham added a comment. In D125325#3505305 , @PatriosTheGreat wrote: > Hi Greg. > > Thanks for the review. > I fixed the feedback. > I forgot the default initialization of plugin_name parameter in SBProcess.i > in previous version, but I assume it's st

[Lldb-commits] [PATCH] D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state

wallace added inline comments. Comment at: lldb/source/Plugins/Process/Linux/IntelPTSingleBufferTrace.cpp:234 +IntelPTSingleBufferTrace::GetTraceBuffer(size_t offset, size_t size, + bool flush) { std::vector data(size, 0); --

[Lldb-commits] [PATCH] D124962: [trace][intelpt] Support system-wide tracing [5] - Disable/enable per-core tracing based on the process state

wallace updated this revision to Diff 428695. wallace added a comment. - remove the flush parameter - use perf_event_attr.disabled to set the initial state of the collection Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124962/new/ https://reviews.

[Lldb-commits] [PATCH] D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor

wallace added inline comments. Comment at: lldb/source/Utility/TraceGDBRemotePackets.cpp:136 {"tid", packet.tid}, -{"size", packet.size}}); +{"size", static_cast(packet.size)}}); } -

[Lldb-commits] [PATCH] D125047: [trace][intelpt] Support system-wide tracing [6] - Break IntelPTCollector into smaller files and minor refactor

wallace updated this revision to Diff 428701. wallace added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125047/new/ https://reviews.llvm.org/D125047 Files: lldb/include/lldb/Utility/TraceGDBRemotePackets.h lldb/source/Plugi

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBProcess.h:340 /// Save the state of the process in a core file (or mini dump on Windows). + lldb::SBError SaveCore(const char *file_name, const char *plugin_name); I would modify the header

[Lldb-commits] [PATCH] D125347: Add "indexedVariables" to variables with lots of children.

clayborg updated this revision to Diff 428789. clayborg added a comment. Remove logging change from VSCode.cpp that was accidentally left in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125347/new/ https://reviews.llvm.org/D125347 Files: lldb/

[Lldb-commits] [PATCH] D125347: Add "indexedVariables" to variables with lots of children.

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:1055 + const char *first_child_name = v.GetChildAtIndex(0).GetName(); + if (first_child_name && strcmp(first_child_name, "[0]") == 0) +object.try_emplace("indexedVariables", num_chi

[Lldb-commits] [lldb] 91d5bfd - Add "indexedVariables" to variables with lots of children.

Author: Greg Clayton Date: 2022-05-11T16:17:57-07:00 New Revision: 91d5bfdb7996b353097c886128fc984e310f7122 URL: https://github.com/llvm/llvm-project/commit/91d5bfdb7996b353097c886128fc984e310f7122 DIFF: https://github.com/llvm/llvm-project/commit/91d5bfdb7996b353097c886128fc984e310f7122.diff

[Lldb-commits] [PATCH] D125347: Add "indexedVariables" to variables with lots of children.

This revision was automatically updated to reflect the committed changes. Closed by commit rG91d5bfdb7996: Add "indexedVariables" to variables with lots of children. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125347/new/ h

[Lldb-commits] [PATCH] D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions

jingham created this revision. jingham added reviewers: JDevlieghere, jasonmolenda, labath. Herald added a project: All. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. For relatively uninteresting reasons, it is not possible when r

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib created this revision. mib added reviewers: jingham, JDevlieghere. mib added a project: LLDB. Herald added a subscriber: arphaman. Herald added a project: All. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds a new `GetIndexForLineEntry` method to

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This needs a doctoring for the API and some test. Comment at: lldb/source/API/SBCompileUnit.cpp:86 + uint32_t index = UINT32_MAX; + if (m_opaque_ptr && line_ent

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib added inline comments. Comment at: lldb/source/API/SBCompileUnit.cpp:94 + +if (!exact || +(exact && !LineEntry::Compare(line_entry.ref(), found_line_entry))) jingham wrote: > Why do you have to do this Compare? You already passed exact to > Find

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib updated this revision to Diff 428829. mib added a comment. Addressed @jingham comments: - Use early returns - Remove `LineEntry::Compare` call since it's already handled by `CompileUnit::FindLineEntry` - Add docstring CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125437/new/ https

[Lldb-commits] [PATCH] D125437: [lldb/API] Add SBCompileUnit::GetIndexForLineEntry method to SB API

mib updated this revision to Diff 428841. mib added a comment. I forgot to add the test in the previous diffs --' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125437/new/ https://reviews.llvm.org/D125437 Files: lldb/bindings/interface/SBCompileUnit.i lldb/include/lldb/API/SBCompil

[Lldb-commits] [PATCH] D125434: Make a more convenient way to allow Darwin users to ignore certain Mach Exceptions

hawkinsw added a comment. I hope that those minor edits help at least a little! Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformMacOSXProperties.td:14 + "(e.g. 'EXC_BAD_ACCESS|EXC_BAD_INSTRUCTION'). " + "lldb will instead stop on the BSD signal the excep