[Lldb-commits] [lldb] af92100 - [lldb] Remove the global platform list

2022-04-13 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-04-13T14:41:13+02:00 New Revision: af921006d3792fa28d1070f015dcfd145e082ed2 URL: https://github.com/llvm/llvm-project/commit/af921006d3792fa28d1070f015dcfd145e082ed2 DIFF: https://github.com/llvm/llvm-project/commit/af921006d3792fa28d1070f015dcfd145e082ed2.diff

[Lldb-commits] [PATCH] D120810: [lldb] Remove the global platform list

2022-04-13 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaf921006d379: [lldb] Remove the global platform list (authored by labath). Changed prior to commit: https://reviews.llvm.org/D120810?vs=420507&id=422489#toc Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [lldb] 7d70b1a - [lldb] Fixup af921006d3792f for non-linux platforms

2022-04-13 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-04-13T15:38:36+02:00 New Revision: 7d70b1a4058cc07e527a3b16eef000b892e29797 URL: https://github.com/llvm/llvm-project/commit/7d70b1a4058cc07e527a3b16eef000b892e29797 DIFF: https://github.com/llvm/llvm-project/commit/7d70b1a4058cc07e527a3b16eef000b892e29797.diff

[Lldb-commits] [PATCH] D104629: [lldb] Escape semicolons for all shells

2022-04-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. This is good in general, but I'm not sure we want to escape $. One of the uses of shell expansion is to get shell variables expanded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104629/new/ https://reviews.llvm.org/D104

[Lldb-commits] [PATCH] D123420: [demangler] Rust demangler buffer reuse

2022-04-13 Thread Nathan Sidwell via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG201c4b9cc4a6: [demangler] Rust demangler buffer return (authored by urnathan). Herald added a project: LLDB. Herald added a subscriber: lldb-commits.

[Lldb-commits] [lldb] 201c4b9 - [demangler] Rust demangler buffer return

2022-04-13 Thread Nathan Sidwell via lldb-commits
Author: Nathan Sidwell Date: 2022-04-13T08:50:04-07:00 New Revision: 201c4b9cc4a649e4a54b418749ab5b8bd227e4f0 URL: https://github.com/llvm/llvm-project/commit/201c4b9cc4a649e4a54b418749ab5b8bd227e4f0 DIFF: https://github.com/llvm/llvm-project/commit/201c4b9cc4a649e4a54b418749ab5b8bd227e4f0.diff

[Lldb-commits] [PATCH] D123690: [lldb] Expand $ when using tcsh

2022-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: jingham. Herald added a project: All. JDevlieghere requested review of this revision. Unlike for any of the other shells, we were escaping $ when using tcsh. There's nothing special about $ in tcsh and this prevents you from expand

[Lldb-commits] [PATCH] D123358: [trace][intelpt] Remove code smell when printing the raw trace size

2022-04-13 Thread walter erquinigo via Phabricator via lldb-commits
wallace closed this revision. wallace added a comment. Committed as 44103c96fa6b00e7824319de1b10ce26781e3852 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123358/new/ https://re

[Lldb-commits] [PATCH] D123357: [trace][intelpt] Add task timer classes

2022-04-13 Thread walter erquinigo via Phabricator via lldb-commits
wallace closed this revision. wallace added a comment. Committed as bdf3e7e5b886ab690a82e8d34b4502d9c6c5d6a9 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123357/new/ https://re

[Lldb-commits] [PATCH] D123690: [lldb] Expand $ when using tcsh

2022-04-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. tcsh is different from the other shells in that a non-existent variable is trapped by the shell, and an error produced BEFORE running the command, whereas in other shells it just gets passed

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

2022-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: kastiglione. Herald added a project: All. JDevlieghere requested review of this revision. Port the two Process::PrintWarning functions to use the new diagnostic events through Debugger::ReportWarning. I kept the wrapper function

[Lldb-commits] [lldb] acc56e5 - [lldb] Expand $ when using tcsh

2022-04-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-13T13:01:09-07:00 New Revision: acc56e55feee61fc0038bc132a94e54ce56ced98 URL: https://github.com/llvm/llvm-project/commit/acc56e55feee61fc0038bc132a94e54ce56ced98 DIFF: https://github.com/llvm/llvm-project/commit/acc56e55feee61fc0038bc132a94e54ce56ced98.d

[Lldb-commits] [PATCH] D123690: [lldb] Expand $ when using tcsh

2022-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGacc56e55feee: [lldb] Expand $ when using tcsh (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D123690?vs=422551&id=422622#toc Repository: r

[Lldb-commits] [PATCH] D123698: [lldb] Port Process::PrintWarning* to use the new diagnostic events

2022-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 422647. JDevlieghere added a comment. Update tests to check stderr CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123698/new/ https://reviews.llvm.org/D123698 Files: lldb/include/lldb/Core/Module.h lldb/include/lldb/Target/Process.h lldb/

[Lldb-commits] [lldb] 763ff89 - [debugserver ] Un-conditionalize use of libcompression

2022-04-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-13T14:36:25-07:00 New Revision: 763ff89c0e0dcf77ee14c92936205bcf1b38385a URL: https://github.com/llvm/llvm-project/commit/763ff89c0e0dcf77ee14c92936205bcf1b38385a DIFF: https://github.com/llvm/llvm-project/commit/763ff89c0e0dcf77ee14c92936205bcf1b38385a.d

[Lldb-commits] [PATCH] D123616: [debugserver ] Un-conditionalize use of libcompression

2022-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG763ff89c0e0d: [debugserver ] Un-conditionalize use of libcompression (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [lldb] 343f3de - [lldb] Fix a bug in the decorator matching logic.

2022-04-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-13T15:07:33-07:00 New Revision: 343f3de559c636dcec941613dca91e4fff6547a3 URL: https://github.com/llvm/llvm-project/commit/343f3de559c636dcec941613dca91e4fff6547a3 DIFF: https://github.com/llvm/llvm-project/commit/343f3de559c636dcec941613dca91e4fff6547a3.d

[Lldb-commits] [PATCH] D123401: [lldb] Fix debug_info decorators for NO_DEBUG_INFO_TESTCASE

2022-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG343f3de559c6: [lldb] Fix a bug in the decorator matching logic. (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D123401?vs=421548&id=422673#to

[Lldb-commits] [PATCH] D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM

2022-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: jasonmolenda. Herald added a project: All. JDevlieghere requested review of this revision. Show the user the DBGError (if available) when dsymForUUID fails. rdar://90949180 https://reviews.llvm.org/D123743 Files: lldb/include

[Lldb-commits] [PATCH] D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM

2022-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 422688. JDevlieghere added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123743/new/ https://reviews.llvm.org/D123743 Files: lldb/include/lldb/Symbol/LocateSymbolFile.h lldb/source/Commands/CommandObjectTarget.cpp lld

[Lldb-commits] [lldb] 80c600f - [lldb] Format LocateSymbolFileMacOSX (NFC)

2022-04-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-13T16:27:02-07:00 New Revision: 80c600fe98ed1d0be4cc2a34d791cdaffdfb9c8e URL: https://github.com/llvm/llvm-project/commit/80c600fe98ed1d0be4cc2a34d791cdaffdfb9c8e DIFF: https://github.com/llvm/llvm-project/commit/80c600fe98ed1d0be4cc2a34d791cdaffdfb9c8e.d

[Lldb-commits] [lldb] 6443d0d - [lldb] Remove reproducer logic from LocateSymbolFileMacOSX

2022-04-13 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-04-13T16:27:02-07:00 New Revision: 6443d0d413df7b67b149e7618c295c38869ecbcb URL: https://github.com/llvm/llvm-project/commit/6443d0d413df7b67b149e7618c295c38869ecbcb DIFF: https://github.com/llvm/llvm-project/commit/6443d0d413df7b67b149e7618c295c38869ecbcb.d

[Lldb-commits] [PATCH] D123746: [lldb] Prevent crash when adding a stop hook with --shlib

2022-04-13 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: mib. Herald added a project: All. JDevlieghere requested review of this revision. Currently, lldb crashes when adding a stop hook with --shlib because we unconditionally use the target in `SymbolContextSpecifier::AddSpecification`

[Lldb-commits] [PATCH] D123746: [lldb] Prevent crash when adding a stop hook with --shlib

2022-04-13 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. This is fine, though the fact that it crashed when you tried to specify the shared library means we don't have any tests that the shared library gets copied over from the dummy target correctly. Might be nice to extend the test to have a "file not_called_test" and "bre