[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

2022-03-12 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: clayborg. labath added a comment. Are you sure we don't want to handle this at a higher level? The way I understand it, the main reason for the existence of PrintAsync and StreamAsynchronousIO machinery is to provide precise control about when the various bits of output

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

2022-03-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D121500#3377321 , @labath wrote: > Are you sure we don't want to handle this at a higher level? The way I > understand it, the main reason for the existence of PrintAsync and > StreamAsynchronousIO machinery is to provid

[Lldb-commits] [PATCH] D121502: [lldb] Use the debugger's asynchronous output stream for writing progress events.

2022-03-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 414883. JDevlieghere retitled this revision from "[lldb] Use the debugger's output stream for writing in HandleProgressEvent" to "[lldb] Use the debugger's asynchronous output stream for writing progress events.". JDevlieghere edited the summary of this

[Lldb-commits] [PATCH] D121536: [lldb] Use the IOHandler's output/error stream instead of the debugger one in PrintAsync

2022-03-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg. Herald added a project: All. JDevlieghere requested review of this revision. I was looking into PrintAsync because Pavel brought it up in D121500 . The whole point seems to be to

[Lldb-commits] [PATCH] D121537: [lldb] Synchronize the output through the IOHandler

2022-03-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added a reviewer: labath. Herald added a project: All. JDevlieghere requested review of this revision. Alternative to D121500 that does the locking at the IOHandler level. https://reviews.llvm.org/D121537 Files

[Lldb-commits] [PATCH] D121500: [lldb] Protect the debugger's output and error stream

2022-03-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D121500#3377434 , @JDevlieghere wrote: > In D121500#3377321 , @labath wrote: > >> Are you sure we don't want to handle this at a higher level? The way I >> understand it, the mai

[Lldb-commits] [PATCH] D121511: [lldb] Report debugger diagnostics as events

2022-03-12 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere updated this revision to Diff 414899. JDevlieghere added a comment. Use the asynchronous error stream CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121511/new/ https://reviews.llvm.org/D121511 Files: lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/DebuggerEven