[Lldb-commits] [lldb] aaa9f40 - [lldb/test] Replace gnu-style-compression.cpp with a yaml file

2022-01-27 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-01-27T10:05:05+01:00 New Revision: aaa9f40e3fd2dd081e965d39f10649bcd8bf1d21 URL: https://github.com/llvm/llvm-project/commit/aaa9f40e3fd2dd081e965d39f10649bcd8bf1d21 DIFF: https://github.com/llvm/llvm-project/commit/aaa9f40e3fd2dd081e965d39f10649bcd8bf1d21.diff

[Lldb-commits] [lldb] 7afd052 - [lldb/DWARF] Make manual dwarf index deterministic

2022-01-27 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-01-27T10:05:05+01:00 New Revision: 7afd05211282c7516f0e9b3e7743b5dcc2605491 URL: https://github.com/llvm/llvm-project/commit/7afd05211282c7516f0e9b3e7743b5dcc2605491 DIFF: https://github.com/llvm/llvm-project/commit/7afd05211282c7516f0e9b3e7743b5dcc2605491.diff

[Lldb-commits] [lldb] 6730df4 - [lldb] Convert ProcessWindowsLog to the new API

2022-01-27 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-01-27T10:05:05+01:00 New Revision: 6730df4779cd2f6328fe8cb6dec1dced8cabe4c5 URL: https://github.com/llvm/llvm-project/commit/6730df4779cd2f6328fe8cb6dec1dced8cabe4c5 DIFF: https://github.com/llvm/llvm-project/commit/6730df4779cd2f6328fe8cb6dec1dced8cabe4c5.diff

[Lldb-commits] [PATCH] D118251: [lldb/DWARF] Make manual dwarf index deterministic

2022-01-27 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7afd05211282: [lldb/DWARF] Make manual dwarf index deterministic (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118251/new/ https://rev

[Lldb-commits] [lldb] 4cd8877 - [lldb/test] Fix gnu-style-compression.yaml

2022-01-27 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-01-27T10:23:21+01:00 New Revision: 4cd8877a3453d5ee4289348db45d89b8e249cf72 URL: https://github.com/llvm/llvm-project/commit/4cd8877a3453d5ee4289348db45d89b8e249cf72 DIFF: https://github.com/llvm/llvm-project/commit/4cd8877a3453d5ee4289348db45d89b8e249cf72.diff

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

2022-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/API/SBThread.cpp:1326-1334 + if (!process.IsValid()) { +error.SetErrorString("no process"); +return value; + } + SBTarget target = proc

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

2022-01-27 Thread Michał Górny via Phabricator via lldb-commits
mgorny added inline comments. Comment at: lldb/source/API/SBThread.cpp:1326-1334 + if (!process.IsValid()) { +error.SetErrorString("no process"); +return value; + } + SBTarget target = process.GetTarget(); + if (!target.IsValid()) { +error.SetErrorString("unable t

[Lldb-commits] [lldb] 3053e14 - [lldb] [Platform] Support synthesizing siginfo_t

2022-01-27 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2022-01-27T13:33:47+01:00 New Revision: 3053e143bef273a2e65519cea15be8f7ce6cd854 URL: https://github.com/llvm/llvm-project/commit/3053e143bef273a2e65519cea15be8f7ce6cd854 DIFF: https://github.com/llvm/llvm-project/commit/3053e143bef273a2e65519cea15be8f7ce6cd854.diff

[Lldb-commits] [lldb] 1a8f60f - [lldb] [gdb-remote] Support getting siginfo via API

2022-01-27 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2022-01-27T13:33:47+01:00 New Revision: 1a8f60f5f5b8638a3e8e7fb31ba7ae9e17a7ff2d URL: https://github.com/llvm/llvm-project/commit/1a8f60f5f5b8638a3e8e7fb31ba7ae9e17a7ff2d DIFF: https://github.com/llvm/llvm-project/commit/1a8f60f5f5b8638a3e8e7fb31ba7ae9e17a7ff2d.diff

[Lldb-commits] [PATCH] D117707: [lldb] [Platform] Support synthesizing siginfo_t

2022-01-27 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3053e143bef2: [lldb] [Platform] Support synthesizing siginfo_t (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

2022-01-27 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1a8f60f5f5b8: [lldb] [gdb-remote] Support getting siginfo via API (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D118358: [lldb][ARM/AArch64] Update dissembler to v9.3-a

2022-01-27 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added subscribers: ctetreau, kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This means sve2 is enabled by default and the v8.8 mops (memcpy and memset acceleration in

[Lldb-commits] [lldb] 33eb3f1 - [lldb] Delete TestBacktraceAll.py

2022-01-27 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-01-27T15:01:08+01:00 New Revision: 33eb3f14eb42316524efe71a916b727fe563d973 URL: https://github.com/llvm/llvm-project/commit/33eb3f14eb42316524efe71a916b727fe563d973 DIFF: https://github.com/llvm/llvm-project/commit/33eb3f14eb42316524efe71a916b727fe563d973.diff

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

2022-01-27 Thread Jim Ingham via Phabricator via lldb-commits
jingham reopened this revision. jingham added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. We don't return errors separately for any of the API's that return an SBValue. SBValue's carry their error with them (SBValue.GetError()) so it would

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-27 Thread Simon Pilgrim via Phabricator via lldb-commits
RKSimon updated this revision to Diff 403574. RKSimon added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. update lldb docs as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D114639: Raise the minimum Visual Studio version to VS2019

2022-01-27 Thread Aaron Ballman via Phabricator via lldb-commits
aaron.ballman added a comment. Herald added a subscriber: JDevlieghere. In D114639#3273831 , @RKSimon wrote: > In D114639#3273761 , > @stella.stamenova wrote: > >> Can we update the lldb instructions as part of t

[Lldb-commits] [lldb] 48c36a1 - [lldb/test] Disable test_launch_scripted_process_stack_frames on x86_64

2022-01-27 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2022-01-27T18:42:08+01:00 New Revision: 48c36a15a363e32757c51aa69de7adf88c143c37 URL: https://github.com/llvm/llvm-project/commit/48c36a15a363e32757c51aa69de7adf88c143c37 DIFF: https://github.com/llvm/llvm-project/commit/48c36a15a363e32757c51aa69de7adf88c143c37.

[Lldb-commits] [PATCH] D118405: [LLD][MinGW] Add --heap argument support

2022-01-27 Thread Mateusz Mikuła via Phabricator via lldb-commits
mati865 created this revision. mati865 added a reviewer: mstorsjo. mati865 added a project: lld. Herald added a subscriber: dang. mati865 requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Noticed in https://github.com/msys2/MINGW-packages/pul

[Lldb-commits] [lldb] cd31763 - Disable TestLldbGdbServer on Dwarf2 and clang versions below 14

2022-01-27 Thread Shubham Sandeep Rastogi via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2022-01-27T13:29:34-08:00 New Revision: cd317637708decd8faf34dd9773a8b2dec424010 URL: https://github.com/llvm/llvm-project/commit/cd317637708decd8faf34dd9773a8b2dec424010 DIFF: https://github.com/llvm/llvm-project/commit/cd317637708decd8faf34dd9773a8b2dec42

[Lldb-commits] [PATCH] D118395: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14

2022-01-27 Thread Shubham Sandeep Rastogi via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcd317637708d: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14 (authored by rastogishubham). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Git

[Lldb-commits] [lldb] ee54868 - Revert "Disable TestLldbGdbServer on Dwarf2 and clang versions below 14"

2022-01-27 Thread Shubham Sandeep Rastogi via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2022-01-27T13:36:21-08:00 New Revision: ee54868a76e32fdfa8d1efe5e418460e54246a4e URL: https://github.com/llvm/llvm-project/commit/ee54868a76e32fdfa8d1efe5e418460e54246a4e DIFF: https://github.com/llvm/llvm-project/commit/ee54868a76e32fdfa8d1efe5e418460e5424

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

2022-01-27 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. In D118055#3276558 , @jingham wrote: > We don't return errors separately for any of the API's that return an > SBValue. SBValue's carry their error with them (SBValue.GetError()) so it > would be confusing to have two errors. I

[Lldb-commits] [PATCH] D118265: [lldb] Make ReadCStringFromMemory default to read from the file-cache.

2022-01-27 Thread Adrian Prantl via Phabricator via lldb-commits
aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. force_live_memory=false means use the file cache iff: - the address has a Section - the section is read-only Otherwise it reads from memory. Based on that this looks safe to me. Repositor

[Lldb-commits] [lldb] 867fdec - Disable TestLldbGdbServer on Dwarf2 and clang versions below 14

2022-01-27 Thread Shubham Sandeep Rastogi via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2022-01-27T14:02:35-08:00 New Revision: 867fdec1945df3c1031d3cefdc97903131a3482b URL: https://github.com/llvm/llvm-project/commit/867fdec1945df3c1031d3cefdc97903131a3482b DIFF: https://github.com/llvm/llvm-project/commit/867fdec1945df3c1031d3cefdc97903131a3

[Lldb-commits] [lldb] cf93a08 - Fixed typos in TestLldbGdbServer.py

2022-01-27 Thread Shubham Sandeep Rastogi via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2022-01-27T14:12:24-08:00 New Revision: cf93a085754e221f73a2877c946dcb2beb6039d7 URL: https://github.com/llvm/llvm-project/commit/cf93a085754e221f73a2877c946dcb2beb6039d7 DIFF: https://github.com/llvm/llvm-project/commit/cf93a085754e221f73a2877c946dcb2beb60

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

2022-01-27 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. Yes, you probably need to make another change, which is actually probably a good idea as well. The immediate problem is that the default constructed SBValue is empty, it has a null ValueObjectSP, so until you somehow make it valid you can't get a valid error from it, i

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

2022-01-27 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova created this revision. stella.stamenova added reviewers: JDevlieghere, dblaikie. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The existing instructions for lldb on Windows can be more explicit. This adds

[Lldb-commits] [lldb] 4a64955 - [lldb] Remove reproducers documentation

2022-01-27 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-27T19:35:28-08:00 New Revision: 4a64955c37570ef5f98db705d290d75adbeaf442 URL: https://github.com/llvm/llvm-project/commit/4a64955c37570ef5f98db705d290d75adbeaf442 DIFF: https://github.com/llvm/llvm-project/commit/4a64955c37570ef5f98db705d290d75adbeaf442.d

[Lldb-commits] [PATCH] D118425: [lldb] Update the lldb build instructions on Windows

2022-01-27 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. From my own notes: - I wrote down that I neede "MSVC C++ x64/x86 build tool". Not sure if that's really required? - As someone who's used to working on the command line, it

[Lldb-commits] [PATCH] D118395: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14

2022-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. What's the failure mode? I find it highly unlikely that compiler or dwarf info version has anything to do with the failures. lldb-server tests don't read debug info at all and they might just as well be compiled with -g0. The only unusual thing I can think of which make

[Lldb-commits] [PATCH] D78801: [LLDB] Add class WasmProcess for WebAssembly debugging

2022-01-27 Thread Xu Jun via Phabricator via lldb-commits
xujuntwt95329 added a comment. Hi @paolosev, **many thanks for such a great patch which makes it possible to debug WebAssembly applications.** It is really really useful especially in non-browser environments. We have enabled source debugging feature in **WebAssembly Micro Runtime

[Lldb-commits] [PATCH] D118395: Disable TestLldbGdbServer on Dwarf2 and clang versions below 14

2022-01-27 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. Also, if you're running these tests on some kind of a matrix bot, maybe you can just skip all lldb-server tests completely (dotest.py --skip-categories llgs). Given that they don't use debug info, they definitely don't provide any useful signal in these contexts. Repos