[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

2022-01-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. Could you try replacing the new function with the old one and seeing if that helps? Or alternatively, trying to build a kernel from the commit just before that change and with that change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 7d19566 - [lldb] Ignore non-address bits in "memory find" arguments

2022-01-24 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-24T10:42:49Z New Revision: 7d19566c3bfb3efacb629d18839e2d85761156ab URL: https://github.com/llvm/llvm-project/commit/7d19566c3bfb3efacb629d18839e2d85761156ab DIFF: https://github.com/llvm/llvm-project/commit/7d19566c3bfb3efacb629d18839e2d85761156ab.diff LOG

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

2022-01-24 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7d19566c3bfb: [lldb] Ignore non-address bits in "memory find" arguments (authored by DavidSpickett). Changed prior to commit: https://reviews.llvm.org/D117299?vs=401904&id=402441#toc Repository: rG L

[Lldb-commits] [lldb] 5f290c0 - Move STLFunctionalExtras out of STLExtras

2022-01-24 Thread via lldb-commits
Author: serge-sans-paille Date: 2022-01-24T14:13:21+01:00 New Revision: 5f290c090a2404238a5b0ae4233f3ae9daec319e URL: https://github.com/llvm/llvm-project/commit/5f290c090a2404238a5b0ae4233f3ae9daec319e DIFF: https://github.com/llvm/llvm-project/commit/5f290c090a2404238a5b0ae4233f3ae9daec319e.d

[Lldb-commits] [lldb] 25e8f5f - Add missing STLExtras.h include from lldb/unittests/TestingSupport/MockTildeExpressionResolver.cpp

2022-01-24 Thread via lldb-commits
Author: serge-sans-paille Date: 2022-01-24T15:03:11+01:00 New Revision: 25e8f5f827bfbc8aed24c9db116c4869f437fb9d URL: https://github.com/llvm/llvm-project/commit/25e8f5f827bfbc8aed24c9db116c4869f437fb9d DIFF: https://github.com/llvm/llvm-project/commit/25e8f5f827bfbc8aed24c9db116c4869f437fb9d.d

[Lldb-commits] [PATCH] D115508: Reland "[lldb] Remove non address bits when looking up memory regions"

2022-01-24 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 402542. DavidSpickett added a comment. Rebase and update release notes format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115508/new/ https://reviews.llvm.org/D115508 Files: lldb/include/lldb/Target

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

2022-01-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: jingham, labath, emaste, krytarowski. mgorny requested review of this revision. Add Thread::GetSiginfo() and SBThread::GetSiginfo() methods to retrieve the siginfo value from server. https://reviews.llvm.org/D118055 Files: lldb/bindings/in

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

2022-01-24 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D117928#3265048 , @ljmf00 wrote: > In D117928#3263992 , @mgorny wrote: > >> Thank you. Yes, please test on an older kernel, in case it's specifically a >> kernel regression. > > I can c

[Lldb-commits] [lldb] 4858fe0 - [lldb/Plugins] Add ScriptedProcess::GetThreadsInfo interface

2022-01-24 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2022-01-24T20:25:53+01:00 New Revision: 4858fe04a1571e78ff97b778c0fb6a46855c3d6a URL: https://github.com/llvm/llvm-project/commit/4858fe04a1571e78ff97b778c0fb6a46855c3d6a DIFF: https://github.com/llvm/llvm-project/commit/4858fe04a1571e78ff97b778c0fb6a46855c3d6a.

[Lldb-commits] [lldb] 1b86344 - [lldb/Plugins] Move ScriptedThreadInterface to ScriptedThread

2022-01-24 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2022-01-24T20:25:53+01:00 New Revision: 1b86344fa80bd11853e0347ea33dc6cb5a460c4f URL: https://github.com/llvm/llvm-project/commit/1b86344fa80bd11853e0347ea33dc6cb5a460c4f DIFF: https://github.com/llvm/llvm-project/commit/1b86344fa80bd11853e0347ea33dc6cb5a460c4f.

[Lldb-commits] [lldb] d3e0f7e - [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

2022-01-24 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2022-01-24T20:25:53+01:00 New Revision: d3e0f7e1503b1bca8baa6483d3b5c452a91f60a6 URL: https://github.com/llvm/llvm-project/commit/d3e0f7e1503b1bca8baa6483d3b5c452a91f60a6 DIFF: https://github.com/llvm/llvm-project/commit/d3e0f7e1503b1bca8baa6483d3b5c452a91f60a6.

[Lldb-commits] [lldb] cfa55bf - [lldb/Plugins] Enrich ScriptedThreads Stop Reasons with Exceptions

2022-01-24 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2022-01-24T20:25:54+01:00 New Revision: cfa55bfe781474a30467b1bbf2e7874985171196 URL: https://github.com/llvm/llvm-project/commit/cfa55bfe781474a30467b1bbf2e7874985171196 DIFF: https://github.com/llvm/llvm-project/commit/cfa55bfe781474a30467b1bbf2e7874985171196.

[Lldb-commits] [lldb] 45148bf - [lldb/Plugins] Fix ScriptedThread IndexID reporting

2022-01-24 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2022-01-24T20:25:54+01:00 New Revision: 45148bfe8aece6ca319dcc32351e20bba26b2ea7 URL: https://github.com/llvm/llvm-project/commit/45148bfe8aece6ca319dcc32351e20bba26b2ea7 DIFF: https://github.com/llvm/llvm-project/commit/45148bfe8aece6ca319dcc32351e20bba26b2ea7.

[Lldb-commits] [lldb] 91bb116 - [lldb/Interpreter] Make `ScriptedInterface::ErrorWithMessage` static (NFC)

2022-01-24 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2022-01-24T20:25:54+01:00 New Revision: 91bb116190cdc598863a7a3fda57e431dd832449 URL: https://github.com/llvm/llvm-project/commit/91bb116190cdc598863a7a3fda57e431dd832449 DIFF: https://github.com/llvm/llvm-project/commit/91bb116190cdc598863a7a3fda57e431dd832449.

[Lldb-commits] [PATCH] D117068: [lldb/Plugins] Add ScriptedProcess::GetThreadsInfo interface

2022-01-24 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4858fe04a157: [lldb/Plugins] Add ScriptedProcess::GetThreadsInfo interface (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D117070: [lldb/Plugins] Move ScriptedThreadInterface to ScriptedThread

2022-01-24 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b86344fa80b: [lldb/Plugins] Move ScriptedThreadInterface to ScriptedThread (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

2022-01-24 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3e0f7e1503b: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess (authored by mib). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D117074: [lldb/Plugins] Enrich ScriptedThreads Stop Reasons with Exceptions

2022-01-24 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfa55bfe7814: [lldb/Plugins] Enrich ScriptedThreads Stop Reasons with Exceptions (authored by mib). Changed prior to commit: https://reviews.llvm.

[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

2022-01-24 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45148bfe8aec: [lldb/Plugins] Fix ScriptedThread IndexID reporting (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[Lldb-commits] [PATCH] D117374: [lldb/Interpreter] Make `ScriptedInterface::ErrorWithMessage` static (NFC)

2022-01-24 Thread Med Ismail Bennani via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91bb116190cd: [lldb/Interpreter] Make `ScriptedInterface::ErrorWithMessage` static (NFC) (authored by mib). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

2022-01-24 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. @clayborg Does the latest scheme look good to you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117914/new/ https://reviews.llvm.org/D117914 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

2022-01-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. To explain a bit, `PT_SETXMMREGS` exists because originally `PT_SETFPREGS` used FSAVE format on i386, and this format didn't support setting XMM registers. Newer CPUs support FXSAVE instead, and this is exposed via `PT_SETFPREGS` on amd64 and `PT_SETXMMREGS` on i386. R

[Lldb-commits] [PATCH] D118055: [lldb] [gdb-remote] Support getting siginfo via API

2022-01-24 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 402622. mgorny added a comment. Add another test using FreeBSD `siginfo_t`, to make sure we select the platform correctly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118055/new/ https://reviews.llvm.org/D118055 Files: lldb/bindings/interface/S

[Lldb-commits] [lldb] c3ca2c6 - [lldb/test] Fix `TestScriptedProcess.test_scripted_process_and_scripted_thread`

2022-01-24 Thread Med Ismail Bennani via lldb-commits
Author: Med Ismail Bennani Date: 2022-01-24T21:48:31+01:00 New Revision: c3ca2c6b14f91f8232525373c4f5b1dc504a39a1 URL: https://github.com/llvm/llvm-project/commit/c3ca2c6b14f91f8232525373c4f5b1dc504a39a1 DIFF: https://github.com/llvm/llvm-project/commit/c3ca2c6b14f91f8232525373c4f5b1dc504a39a1.

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

2022-01-24 Thread Pavel Labath via Phabricator via lldb-commits
labath marked 7 inline comments as done. labath added a comment. In D117490#3261743 , @shafik wrote: > This is a nice refactor, I am curious was there a motivating bug or issue for > this change or just refactoring? Well.. my motivation was D117382

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

2022-01-24 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 402636. labath marked an inline comment as done. labath edited the summary of this revision. labath added a comment. - use uint64_t for channel mask - ensure constants are in ascending order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

2022-01-24 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. I'm happy with this. LGTM assuming Greg feels the same way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://review

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

2022-01-24 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. Yep! Looks good. As a follow up patch it would be great to ask the SymbolFile classes to break down some memory usage. I know in the SymbolFileDWARF we have each DWARFUnit that may or may not parse the unit DIE or all of the DIEs. These

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

2022-01-24 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. In D117914#3267657 , @clayborg wrote: > Yep! Looks good. > > As a follow up patch it would be great to ask the SymbolFile classes to break > down some memory usage. I know in the SymbolFileDWARF we have each DWARFUnit > tha

[Lldb-commits] [lldb] cd8122b - [lldb] Add ConstString memory usage statistics

2022-01-24 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-24T15:13:17-08:00 New Revision: cd8122b27f8fb9cbf222ef946bff3b698625e2f4 URL: https://github.com/llvm/llvm-project/commit/cd8122b27f8fb9cbf222ef946bff3b698625e2f4 DIFF: https://github.com/llvm/llvm-project/commit/cd8122b27f8fb9cbf222ef946bff3b698625e2f4.d

[Lldb-commits] [PATCH] D117914: [lldb] Add ConstString memory usage statistics

2022-01-24 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcd8122b27f8f: [lldb] Add ConstString memory usage statistics (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D117490: [lldb] Make logging machinery type-safe

2022-01-24 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117490/new/ https://reviews.llvm.org/D117490 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [lldb] 16bff06 - [lldb] Make PythonDataObjects work with Python 2

2022-01-24 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-24T17:23:09-08:00 New Revision: 16bff06790a7652b282352b07250b627e5787c8c URL: https://github.com/llvm/llvm-project/commit/16bff06790a7652b282352b07250b627e5787c8c DIFF: https://github.com/llvm/llvm-project/commit/16bff06790a7652b282352b07250b627e5787c8c.d

[Lldb-commits] [PATCH] D118091: [lldb] Remove ConstString::StaticMemorySize

2022-01-24 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: labath, clayborg, kastiglione. JDevlieghere requested review of this revision. Remove `ConstString::StaticMemorySize` as it is unused. It is referenced in a bunch of doc comments but I don't really understand why. My best guess it

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

2022-01-24 Thread Luís Ferreira via Phabricator via lldb-commits
ljmf00 added a comment. In D117928#3265583 , @mgorny wrote: > Could you try replacing the new function with the old one and seeing if that > helps? Or alternatively, trying to build a kernel from the commit just before > that change and with that change