Author: Kazu Hirata
Date: 2021-12-26T09:39:26-08:00
New Revision: 0542d15211cb1fb45bcd79d485d122c69cd23f28
URL:
https://github.com/llvm/llvm-project/commit/0542d15211cb1fb45bcd79d485d122c69cd23f28
DIFF:
https://github.com/llvm/llvm-project/commit/0542d15211cb1fb45bcd79d485d122c69cd23f28.diff
L
rZhBoYao added inline comments.
Comment at: lldb/source/Core/Mangled.cpp:79-81
Mangled::operator void *() const {
return (m_mangled) ? const_cast(this) : nullptr;
}
clayborg wrote:
> Looks like there is a similar bug here in this function as well. We should
rZhBoYao updated this revision to Diff 396261.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116217/new/
https://reviews.llvm.org/D116217
Files:
lldb/include/lldb/Core/Mangled.h
lldb/source/Core/Mangled.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
lldb/unittests/C
rZhBoYao updated this revision to Diff 396263.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116217/new/
https://reviews.llvm.org/D116217
Files:
lldb/include/lldb/Core/Mangled.h
lldb/source/Core/Mangled.cpp
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
lldb/unittests/C
rZhBoYao added inline comments.
Comment at: lldb/source/Core/Mangled.cpp:87
// { ...
-bool Mangled::operator!() const { return !m_mangled; }
+bool Mangled::operator!() const { return !m_mangled && !m_demangled; }
Should we remove `Mangled::operator!` altogeth
