[Lldb-commits] [lldb] 11dc235 - [lldb] Fix matchers for char array formatters

Author: Pavel Labath Date: 2021-12-17T10:06:38+01:00 New Revision: 11dc235c7dda298befa84833a51ac9cdc92e7c2e URL: https://github.com/llvm/llvm-project/commit/11dc235c7dda298befa84833a51ac9cdc92e7c2e DIFF: https://github.com/llvm/llvm-project/commit/11dc235c7dda298befa84833a51ac9cdc92e7c2e.diff

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

This revision was automatically updated to reflect the committed changes. Closed by commit rG11dc235c7dda: [lldb] Fix matchers for char array formatters (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112709/new/ https://reviews.

[Lldb-commits] [PATCH] D115925: [lldb/python] Fix (some) dangling pointers in our glue code

labath created this revision. labath added reviewers: JDevlieghere, mib. labath requested review of this revision. Herald added a project: LLDB. This starts to fix the other half of the lifetime problems in this code - dangling references. SB objects created on the stack will go away when the fu

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

siger-young created this revision. siger-young added reviewers: JDevlieghere, tammela. siger-young requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This commit supports registerubg breakpoint callback when using liblldb in Lua. (able to `Set

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

siger-young updated this revision to Diff 395076. siger-young added a comment. Remove "return" to prevent memory leakage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115926/new/ https://reviews.llvm.org/D115926 Files: lldb/bindings/interface/S

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. I actually quite like this, but we should figure out a way to do it while respecting our SB contracts. See inline comments for details. Comment at: lldb/bindings/l

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

labath added a comment. I don't know if you've seen this but we have some description of it here https://lldb.llvm.org/design/sbapi.html. The gist of it is: - be backward compatible - don't depend on other stuff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

siger-young added a comment. In D115926#3199496 , @labath wrote: > I don't know if you've seen this but we have some description of it here > https://lldb.llvm.org/design/sbapi.html. The gist of it is: > > - be backward compatible > - don't depend on oth

[Lldb-commits] [lldb] 586765c - [lldb/qemu] Add emulator-env-vars setting

Author: Pavel Labath Date: 2021-12-17T13:59:21+01:00 New Revision: 586765c0ee518310612d286f3a731786b4ea4148 URL: https://github.com/llvm/llvm-project/commit/586765c0ee518310612d286f3a731786b4ea4148 DIFF: https://github.com/llvm/llvm-project/commit/586765c0ee518310612d286f3a731786b4ea4148.diff

[Lldb-commits] [lldb] 12873d1 - Silence unused variable warning in release builds

Author: Benjamin Kramer Date: 2021-12-17T16:07:02+01:00 New Revision: 12873d1a670b4a82b5853dabc8b6ea4d300759af URL: https://github.com/llvm/llvm-project/commit/12873d1a670b4a82b5853dabc8b6ea4d300759af DIFF: https://github.com/llvm/llvm-project/commit/12873d1a670b4a82b5853dabc8b6ea4d300759af.dif

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

clayborg created this revision. clayborg added reviewers: labath, wallace, aadsm, jingham, JDevlieghere. Herald added subscribers: arphaman, mgorny. clayborg requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a proje

[Lldb-commits] [PATCH] D115925: [lldb/python] Fix (some) dangling pointers in our glue code

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Thanks for fixing this! LGTM beside a small nit. Comment at: lldb/test/API/commands/command/script/TestCommandScript.py:172 +self.runCmd("command script add -f persistence.

[Lldb-commits] [PATCH] D115926: [lldb/lua] Support external breakpoint callback

jingham added a comment. In D115926#3199520 , @siger-young wrote: > In D115926#3199496 , @labath wrote: > >> I don't know if you've seen this but we have some description of it here >> https://lldb.llvm.org/desi

[Lldb-commits] [lldb] 2a844c8 - Fix macOS buildbots after https://reviews.llvm.org/D115324.

Author: Greg Clayton Date: 2021-12-17T12:14:44-08:00 New Revision: 2a844c8869909960fb006a668d30c7349f55ee7e URL: https://github.com/llvm/llvm-project/commit/2a844c8869909960fb006a668d30c7349f55ee7e DIFF: https://github.com/llvm/llvm-project/commit/2a844c8869909960fb006a668d30c7349f55ee7e.diff

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg added a comment. Some mac buildbots were failing due to "lldb/test/API/functionalities/module_cache/universal/TestModuleCacheUniversal.py" failing to build the executable with the makefile due to lack of arm64 support in the SDK that was being used. commit 2a844c8869909960fb006a668d30

[Lldb-commits] [lldb] 67bc243 - [lldb] Remove --reproducer-finalize and associated functionality

Author: Jonas Devlieghere Date: 2021-12-17T12:19:55-08:00 New Revision: 67bc2435359a8f09f607d6c3fc0a196bd496d31f URL: https://github.com/llvm/llvm-project/commit/67bc2435359a8f09f607d6c3fc0a196bd496d31f DIFF: https://github.com/llvm/llvm-project/commit/67bc2435359a8f09f607d6c3fc0a196bd496d31f.d

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

wallace added inline comments. Comment at: lldb/include/lldb/Symbol/Symtab.h:279 m_mutex; // Provide thread safety for this symbol table - bool m_file_addr_to_index_computed : 1, m_name_indexes_computed : 1; + bool m_file_addr_to_index_computed : 1, m_name_indexes_comput

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

wallace created this revision. wallace added a reviewer: clayborg. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds some important remarks to the data formatter documentation. Repository: rG LLVM Github Monorepo https:

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

JDevlieghere added a comment. Please reflow your text to fit in the existing 80 col limit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115974/new/ https://reviews.llvm.org/D115974 ___ lldb-commits mail

[Lldb-commits] [lldb] fa12606 - [lldb] Remove reproducer replay functionality

Author: Jonas Devlieghere Date: 2021-12-17T17:14:52-08:00 New Revision: fa1260697ec80ac0586d67c0de8758818ca865c0 URL: https://github.com/llvm/llvm-project/commit/fa1260697ec80ac0586d67c0de8758818ca865c0 DIFF: https://github.com/llvm/llvm-project/commit/fa1260697ec80ac0586d67c0de8758818ca865c0.d

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

jingham added a comment. Those are useful tips, thanks! Comment at: lldb/docs/use/variable.rst:77 +which is what the user would expect from a good debugger. + There are several features related to data visualization: formats, summaries, This is a nice example,

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

jingham added inline comments. Comment at: lldb/docs/use/variable.rst:77 +which is what the user would expect from a good debugger. + There are several features related to data visualization: formats, summaries, jingham wrote: > This is a nice example, but we sh