[Lldb-commits] [PATCH] D114796: [lldb/qemu] Add support for pty redirection

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114796/new/ https://reviews.llvm.org/D114796 _

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

omjavaid added a comment. Hi @clayborg This breaks LLDB Arm/Linux buildbot. https://lab.llvm.org/buildbot/#/builders/17/builds/14035 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114288/new/ https://reviews.llvm.org/D114288 _

[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: labath, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: JDevlieghere. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. A compiler can produce F

[Lldb-commits] [PATCH] D114862: Replace StackID's operator "<" with a function returning FrameComparison

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: labath, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: JDevlieghere. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. "false" result of the op

[Lldb-commits] [PATCH] D114877: [lldb] Add missing space in C string format memory read warning

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Also add tests to check that we print the warning in the right circumstances. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[Lldb-commits] [PATCH] D114877: [lldb] Add missing space in C string format memory read warning

DavidSpickett updated this revision to Diff 391013. DavidSpickett added a comment. Put the command in a string and add in the size each time since that's all that changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114877/new/ https://reviews.l

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

rnk added inline comments. Comment at: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuilder.cpp:1019 + if (parent->isRecord()) { +struct ProcessOneMethodRecord : public TypeVisitorCallbacks { + ProcessOneMethodRecord(PdbIndex &m_index, TypeSystemClang &m_clang, --

[Lldb-commits] [lldb] da7e3fc - Revert "[lldb] Temporarily skip TestTsanBasic on Darwin"

Author: Jonas Devlieghere Date: 2021-12-01T10:40:42-08:00 New Revision: da7e3fc9abed2f0d8b48c16a9f774318bb1fb1e1 URL: https://github.com/llvm/llvm-project/commit/da7e3fc9abed2f0d8b48c16a9f774318bb1fb1e1 DIFF: https://github.com/llvm/llvm-project/commit/da7e3fc9abed2f0d8b48c16a9f774318bb1fb1e1.d

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg added a comment. In D114288#3163808 , @omjavaid wrote: > Hi @clayborg > This breaks LLDB Arm/Linux buildbot. > https://lab.llvm.org/buildbot/#/builders/17/builds/14035 I will check this out on linux. Any reason why I did not get a message to m

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391115. zequanwu marked an inline comment as done. zequanwu added a comment. Fix style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu added inline comments. Comment at: lldb/test/Shell/SymbolFile/NativePDB/find-functions.cpp:89 +// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int (void)" +// FIND-OVERLOAD: FuncType: id = {{.*}}, compiler_type = "int (char)" +// FIND-OVERLOAD: FuncType: id = {

[Lldb-commits] [PATCH] D114907: [lldb] Skip two lldb tests on Windows because they are flaky

stella.stamenova created this revision. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These tests work fine with VS2017, but become more flaky with VS2019 and the buildbot is about to get upgraded. Repository: rG LLV

[Lldb-commits] [PATCH] D114911: [lldb] Introduce absolutely minimal FreeBSDKernel plugin

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added a subscriber: arichardson. mgorny requested review of this revision. Introduce an absolutely minimal FreeBSDKernel plugin that currently provides the ability to read memory from FreeBSD vmcores via libf

[Lldb-commits] [PATCH] D114911: [lldb] Introduce absolutely minimal FreeBSDKernel plugin

mgorny added a comment. @labath, I'm waiting for your feedback. I suspect you're going to hate it for being so incomplete (but then, we don't expect it to be able to do much more than this) but also love it for being so simple :-P. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114911/n

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391147. zequanwu added a comment. Select correct the OneMethodRecord for overloaded method by checking TypeIndex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://reviews.llvm.org/D113930 Fil

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Seems fine to me to break this into running and not running cases, but you should use the right lldbutil method for the running case. Comment at: lldb/test/API/l

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/test/API/lang/cpp/char8_t/TestCxxChar8_t.py:40-43 +lldbutil.run_to_breakpoint_make_target(self) + lldbutil.run_break_set_by_source_regexp(self, "// break here", "-

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

JDevlieghere updated this revision to Diff 391168. JDevlieghere marked an inline comment as done. JDevlieghere added a comment. Address Jim's comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114819/new/ https://reviews.llvm.org/D114819 Files: lldb/test/API/lang/cpp/char8_t/TestC

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114819/new/ https://reviews.llvm.org/D114819 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] 8f329ce - [lldb] Split TestCxxChar8_t

Author: Jonas Devlieghere Date: 2021-12-01T16:58:43-08:00 New Revision: 8f329cee423735c2767d3ba490e39db49f649c21 URL: https://github.com/llvm/llvm-project/commit/8f329cee423735c2767d3ba490e39db49f649c21 DIFF: https://github.com/llvm/llvm-project/commit/8f329cee423735c2767d3ba490e39db49f649c21.d

[Lldb-commits] [PATCH] D114819: [lldb] Split TestCxxChar8_t

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f329cee4237: [lldb] Split TestCxxChar8_t (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114819/new/

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

mib created this revision. mib added reviewers: JDevlieghere, jasonmolenda. mib added a project: LLDB. Herald added subscribers: omjavaid, kristof.beyls. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds support for arm64(e) targets to ScriptedProcess,

[Lldb-commits] [lldb] 8176768 - [lldb] Fix DYLD_INSERT_LIBRARIES on AS

Author: Jonas Devlieghere Date: 2021-12-01T20:03:05-08:00 New Revision: 8176768b46b7839a8495d58341198dffad11bc14 URL: https://github.com/llvm/llvm-project/commit/8176768b46b7839a8495d58341198dffad11bc14 DIFF: https://github.com/llvm/llvm-project/commit/8176768b46b7839a8495d58341198dffad11bc14.d

[Lldb-commits] [PATCH] D114791: [lldb] Clarify StructuredDataImpl ownership

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM with some minor nits. Comment at: lldb/bindings/lua/lua-wrapper.swig:31 lldb::BreakpointLocationSP bp_loc_sp, StructuredDataImpl *extra_args_impl ) M

[Lldb-commits] [lldb] fcd2d85 - [lldb] Skip test_launch_scripted_process_stack_frames with ASan

Author: Jonas Devlieghere Date: 2021-12-01T21:35:00-08:00 New Revision: fcd2d85cc9438ffe8e4a4948898077dfc253fe9d URL: https://github.com/llvm/llvm-project/commit/fcd2d85cc9438ffe8e4a4948898077dfc253fe9d DIFF: https://github.com/llvm/llvm-project/commit/fcd2d85cc9438ffe8e4a4948898077dfc253fe9d.d