[Lldb-commits] [PATCH] D114403: [formatters] Add a formatter for libstdc++ optional

labath added a comment. I'm seeing some very funky behavior after this patch. My machine has both libc++ and libstdc++, so both versions of this test run normally, and then libstdc++ fails. If I run just the libstdc++ version then it passes just fine. If I change the test order so that the libs

[Lldb-commits] [lldb] f66b69a - [lldb] Fix lookup for global constants in namespaces

Author: Tonko Sabolčec Date: 2021-11-23T12:53:03+01:00 New Revision: f66b69a3925c547b1ee8ea93800f4bf7e31f407b URL: https://github.com/llvm/llvm-project/commit/f66b69a3925c547b1ee8ea93800f4bf7e31f407b DIFF: https://github.com/llvm/llvm-project/commit/f66b69a3925c547b1ee8ea93800f4bf7e31f407b.diff

[Lldb-commits] [PATCH] D112147: [lldb] Fix lookup for global constants in namespaces

This revision was automatically updated to reflect the committed changes. Closed by commit rGf66b69a3925c: [lldb] Fix lookup for global constants in namespaces (authored by tonkosi, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114433 Files: lldb/bindings/interface/SBTarget.i lldb/examples/syntheti

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan added inline comments. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:66-69 if not _list_uses_loop_detector: logger >> "Asked not to use loop detection" +_list_uses_loop_detector = True return False --

[Lldb-commits] [PATCH] D114444: [lldb] Deflake TestTsanBasic.py

dvyukov created this revision. dvyukov added reviewers: vitalybuka, melver. dvyukov requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The test flaked on bots: http://green.lab.llvm.org/green/job/lldb-cmake/38666/ The test expects that tsan wi

[Lldb-commits] [PATCH] D114444: [lldb] Deflake TestTsanBasic.py

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. Would using `__tsan_testonly_barrier` be appropriate here? If it's not meant to use any tricks to achieve the race then I guess retrying a bunch of times is fine. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

wallace requested changes to this revision. wallace added inline comments. This revision now requires changes to proceed. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:14-16 +if valobj.GetNumChildren() >= list_capping_size: +return "(capped) size=" + str(valobj

[Lldb-commits] [PATCH] D114444: [lldb] Deflake TestTsanBasic.py

dvyukov added a comment. In D11#3148963 , @melver wrote: > Would using `__tsan_testonly_barrier` be appropriate here? If it's not meant > to use any tricks to achieve the race then I guess retrying a bunch of times > is fine. I did not want to leak

[Lldb-commits] [PATCH] D114444: [lldb] Deflake TestTsanBasic.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGa114f151930d: [lldb] Deflake TestTsanBasic.py (authored by dvyukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D114

[Lldb-commits] [lldb] a114f15 - [lldb] Deflake TestTsanBasic.py

Author: Dmitry Vyukov Date: 2021-11-23T17:55:20+01:00 New Revision: a114f151930d29967963fd22f328a906638a2818 URL: https://github.com/llvm/llvm-project/commit/a114f151930d29967963fd22f328a906638a2818 DIFF: https://github.com/llvm/llvm-project/commit/a114f151930d29967963fd22f328a906638a2818.diff

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

RamNalamothu created this revision. RamNalamothu added reviewers: JDevlieghere, teemperor, DavidSpickett, zturner. RamNalamothu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Certain commands like 'memory write', 'register read' etc all us

[Lldb-commits] [PATCH] D114450: Improve optional formatter

wallace created this revision. wallace added a reviewer: labath. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As suggested by @labath in https://reviews.llvm.org/D114403, we should make the formatter more resilient to corrupted d

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

labath added a comment. I don't believe this solution is correct. How did this work before? Is it because `ObjectFileELF::GetSymtab` contained the same (incorrect) unique_ptr pattern? How about we just prime the symtab (or whatever is needed) before we start the thread pool indexing? ==

[Lldb-commits] [PATCH] D114450: Improve optional formatter

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I didn't realize that _M_engaged has type bool. That means the max value this could have is 255, which isn't nearly as bad as 0x. Nonetheless, this is a good change. That said, I'm mo

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

wallace created this revision. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We need to add checks that ensure that some core variables are valid, so that we avoid printing out garbage data. The worst that could happen is that an

[Lldb-commits] [PATCH] D114450: Improve optional formatter

wallace added a comment. > That said, I'm more worried about the strange interactions between libc++ and > libstdc++ formatters I reported. yes, I'm trying to install libc++ on my machine now Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:24 self.value = se

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan updated this revision to Diff 389249. danilashtefan marked 3 inline comments as done. danilashtefan added a comment. Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114433/new/ https://reviews.llvm.org/D114433 Files: lldb/bindi

[Lldb-commits] [PATCH] D114450: Improve optional formatter

labath added a comment. In D114450#3149281 , @wallace wrote: >> That said, I'm more worried about the strange interactions between libc++ >> and libstdc++ formatters I reported. > > yes, I'm trying to install libc++ on my machine now Cool, thanks. ==

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

labath added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/main.cpp:16 -int main() { +int main() { // Set break point at this line. std::unordered_map map; It'd be better to be more explicit

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. add generic tests for list Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114433/new/ https://reviews.llvm.org/D114433 _

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. In D11#3143966 , @shafik wrote: > Apologies, this dropped off my radar it LGTM, thank you! Thanks! Sorry for my ignorance, but what's the next step to land this? Do you want me to rebase it first and push that, or is s

[Lldb-commits] [PATCH] D114450: Improve optional formatter

wallace updated this revision to Diff 389260. wallace added a comment. fix the issue when both formatters run together and apply labath's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114450/new/ https://reviews.llvm.org/D114450 Files:

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

wallace added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered/main.cpp:16 -int main() { +int main() { // Set break point at this line. std::unordered_map map; labath wrote: > It'd be better to

[Lldb-commits] [PATCH] D114461: Draft PR for the bitset capping size limitation avoidance

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114461 Files: lldb/source/Plugins/Language/CPlusPlus/GenericBitset.cpp

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

wallace updated this revision to Diff 389267. wallace added a comment. labath's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114458/new/ https://reviews.llvm.org/D114458 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [PATCH] D114461: [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset data formatters.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great!!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114461/new/ https://reviews.llvm.org/D114461 _

[Lldb-commits] [PATCH] D114465: [lldb] Move create_relative_symlink function up in CMake hierarchy

dim created this revision. dim added reviewers: clayborg, emaste, labath, lawrence_danna, siger-young, tammela. Herald added a subscriber: mgorny. dim requested review of this revision. Herald added a project: LLDB. Configuring lldb with `LLDB_ENABLE_PYTHON=OFF` and `LLDB_ENABLE_LUA=ON` results

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I don't see a reason why not to. If we allows lookup functions by full names, I can change the test case in D113930

[Lldb-commits] [lldb] b5a927b - [lldb] Move create_relative_symlink function up in CMake hierarchy

Author: Dimitry Andric Date: 2021-11-23T21:59:49+01:00 New Revision: b5a927b972b2c07b4597e93ed0b57803bfc0e6ae URL: https://github.com/llvm/llvm-project/commit/b5a927b972b2c07b4597e93ed0b57803bfc0e6ae DIFF: https://github.com/llvm/llvm-project/commit/b5a927b972b2c07b4597e93ed0b57803bfc0e6ae.diff

[Lldb-commits] [PATCH] D114465: [lldb] Move create_relative_symlink function up in CMake hierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rGb5a927b972b2: [lldb] Move create_relative_symlink function up in CMake hierarchy (authored by dim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114465/new/

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan updated this revision to Diff 389300. danilashtefan added a comment. List tests unification for libcxx and libstdcpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114433/new/ https://reviews.llvm.org/D114433 Files: lldb/bindings/in

[Lldb-commits] [PATCH] D114433: [formatters] Draft PR for the list nad forward_list capping_size

danilashtefan updated this revision to Diff 389303. danilashtefan added a comment. Deleted duplicated tests from both platforms Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114433/new/ https://reviews.llvm.org/D114433 Files: lldb/bindings/inter

[Lldb-commits] [lldb] 4ba5da8 - Improve optional formatter

Author: Walter Erquinigo Date: 2021-11-23T13:52:17-08:00 New Revision: 4ba5da8e3d38f38ed7845c22baadd8908729c520 URL: https://github.com/llvm/llvm-project/commit/4ba5da8e3d38f38ed7845c22baadd8908729c520 DIFF: https://github.com/llvm/llvm-project/commit/4ba5da8e3d38f38ed7845c22baadd8908729c520.di

[Lldb-commits] [lldb] a485011 - Make some libstd++ formatters safer

Author: Walter Erquinigo Date: 2021-11-23T13:52:32-08:00 New Revision: a48501150b9ef64fd61d24f8cef2645237facc44 URL: https://github.com/llvm/llvm-project/commit/a48501150b9ef64fd61d24f8cef2645237facc44 DIFF: https://github.com/llvm/llvm-project/commit/a48501150b9ef64fd61d24f8cef2645237facc44.di

[Lldb-commits] [PATCH] D114450: Improve optional formatter

This revision was automatically updated to reflect the committed changes. Closed by commit rG4ba5da8e3d38: Improve optional formatter (authored by Walter Erquinigo ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114450/new/ https://

[Lldb-commits] [PATCH] D114458: Make some libstd++ formatters safer

This revision was automatically updated to reflect the committed changes. Closed by commit rGa48501150b9e: Make some libstd++ formatters safer (authored by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.org/D114458?vs=389267&id=389315#toc Repository: rG LLV

[Lldb-commits] [lldb] 193bf2e - [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset data formatters.

Author: Danil Stefaniuc Date: 2021-11-23T14:03:59-08:00 New Revision: 193bf2e820520dd4a2d5ed0e7d50ee45e8127071 URL: https://github.com/llvm/llvm-project/commit/193bf2e820520dd4a2d5ed0e7d50ee45e8127071 DIFF: https://github.com/llvm/llvm-project/commit/193bf2e820520dd4a2d5ed0e7d50ee45e8127071.dif

[Lldb-commits] [PATCH] D114461: [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset data formatters.

This revision was automatically updated to reflect the committed changes. Closed by commit rG193bf2e82052: [formatters] Capping size limitation avoidance for the libcxx and libcpp bitset… (authored by danilashtefan, committed by Walter Erquinigo ). Changed prior to commit: http

[Lldb-commits] [PATCH] D114433: [formatters] List and forward_list capping_size determination and application

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a9d9a9b00af: [formatters] List and forward_list capping_size determination and application (authored by danilashtefan, committed by Walter Erquinig

[Lldb-commits] [lldb] 9a9d9a9 - [formatters] List and forward_list capping_size determination and application

Author: Danil Stefaniuc Date: 2021-11-23T14:18:51-08:00 New Revision: 9a9d9a9b00af5b60514ab9ada09ba02dfb86945e URL: https://github.com/llvm/llvm-project/commit/9a9d9a9b00af5b60514ab9ada09ba02dfb86945e DIFF: https://github.com/llvm/llvm-project/commit/9a9d9a9b00af5b60514ab9ada09ba02dfb86945e.dif

[Lldb-commits] [lldb] 877433a - Fix a48501150b9ef64fd61d24f8cef2645237facc44

Author: Walter Erquinigo Date: 2021-11-23T14:23:38-08:00 New Revision: 877433ad453cd1bd77497ec47828074b6e010edb URL: https://github.com/llvm/llvm-project/commit/877433ad453cd1bd77497ec47828074b6e010edb DIFF: https://github.com/llvm/llvm-project/commit/877433ad453cd1bd77497ec47828074b6e010edb.di

[Lldb-commits] [lldb] 22ced33 - [LLDB][NativePDB] Allow find functions by full names

Author: Zequan Wu Date: 2021-11-23T17:57:05-08:00 New Revision: 22ced33a2f769815834efdd0eb0b25172c6f8a61 URL: https://github.com/llvm/llvm-project/commit/22ced33a2f769815834efdd0eb0b25172c6f8a61 DIFF: https://github.com/llvm/llvm-project/commit/22ced33a2f769815834efdd0eb0b25172c6f8a61.diff LOG

[Lldb-commits] [PATCH] D114467: [LLDB][NativePDB] Allow find functions by full names

This revision was automatically updated to reflect the committed changes. Closed by commit rG22ced33a2f76: [LLDB][NativePDB] Allow find functions by full names (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114467/new/ https:/

[Lldb-commits] [PATCH] D114491: lldb-vscode plugin

lanza created this revision. lanza requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Just uploading this incase I want to look at it again at some point in the future. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114491

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 389364. zequanwu added a comment. This revision is now accepted and ready to land. Use `lldb-test symbols --find=function --name=full::name --function-flags=full` for testing. Add some information about static/virtual/artificial and access type. Repository

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu added a reviewer: rnk. zequanwu marked an inline comment as done. zequanwu added a subscriber: rnk. zequanwu added a comment. Add @rnk for code view records reading part. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113930/new/ https://re

[Lldb-commits] [PATCH] D114450: Improve optional formatter

labath added a comment. thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114450/new/ https://reviews.llvm.org/D114450 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/