[Lldb-commits] [lldb] f3b7cc8 - [lldb/test] Add ability to terminate connection from a gdb-client handler

2021-11-19 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2021-11-19T18:00:14+01:00 New Revision: f3b7cc8bb2ea599e0c344e8ae16639667d9f0eff URL: https://github.com/llvm/llvm-project/commit/f3b7cc8bb2ea599e0c344e8ae16639667d9f0eff DIFF: https://github.com/llvm/llvm-project/commit/f3b7cc8bb2ea599e0c344e8ae16639667d9f0eff.diff

[Lldb-commits] [PATCH] D114156: [lldb/test] Add ability to terminate connection from a gdb-client handler

2021-11-19 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf3b7cc8bb2ea: [lldb/test] Add ability to terminate connection from a gdb-client handler (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] 587a397 - Skip tests when compiler with older versions of clang

2021-11-19 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2021-11-19T09:05:48-08:00 New Revision: 587a397917b267fb570cf9f6c7dd0f718b51d9de URL: https://github.com/llvm/llvm-project/commit/587a397917b267fb570cf9f6c7dd0f718b51d9de DIFF: https://github.com/llvm/llvm-project/commit/587a397917b267fb570cf9f6c7dd0f718b51d9de.diff

[Lldb-commits] [PATCH] D114259: [lldb] Fix [some] leaks in python bindings

2021-11-19 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: JDevlieghere, jingham. labath requested review of this revision. Herald added a project: LLDB. Using an lldb_private object in the bindings involves three steps - wrapping the object in it's lldb::SB variant - using swig to convert/wrap that t

[Lldb-commits] [PATCH] D114259: [lldb] Fix [some] leaks in python bindings

2021-11-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/bindings/python/python-swigsafecast.swig:61-67 +PythonObject ToSWIGWrapper(std::unique_ptr value_sb) { + return ToSWIGHelper(value_sb.release(), SWIGTYPE_p_lldb__SBValue); +} + +PythonObject ToSWIGWrapper(lldb::ValueObjectSP value_s

[Lldb-commits] [PATCH] D114259: [lldb] Fix [some] leaks in python bindings

2021-11-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Nice cleanup. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114259/new/ https://reviews.llvm.org/D114259

[Lldb-commits] [PATCH] D114266: [formatters] Draft Optional PR

2021-11-19 Thread Danil Stefaniuc via Phabricator via lldb-commits
danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114266 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-11-19 Thread Ben Jackson via Phabricator via lldb-commits
puremourning added a comment. In D11#3141363 , @jingham wrote: > In D11#3141355 , @puremourning > wrote: > >> Sorry, but is anything further required from me on this patch ? > > You addressed an issue Sha

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

2021-11-19 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Apologies, this dropped off my radar it LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D112

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

2021-11-19 Thread Greg Clayton via Phabricator via lldb-commits
clayborg created this revision. clayborg added reviewers: labath, jingham, JDevlieghere. Herald added subscribers: sbc100, emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay, aheejin. Herald added a project: LLDB. Symbol table parsing has evolved ov

[Lldb-commits] [PATCH] D113965: [NFC] Refactor symbol table parsing.

2021-11-19 Thread Greg Clayton via Phabricator via lldb-commits
clayborg added a comment. I resubmitted with a fix in https://reviews.llvm.org/D114288 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113965/new/ https://reviews.llvm.org/D113965 ___ lldb-commits mailing