siger-young updated this revision to Diff 375081.
siger-young added a comment.
This update mainly fixed problematic typemaps and adding necessary comments.
Together, it forced Lua installation path as "PREFIX/lib/lua/5.3" and removed
"lit.util" in tests.
Repository:
rG LLVM Github Monorepo
siger-young updated this revision to Diff 375086.
siger-young added a comment.
Remove "REQUIRED" flags when finding Lua at "FindLuaAndSwig.cmake".
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108515/new/
https://reviews.llvm.org/D108515
Files:
mgorny marked 3 inline comments as done.
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1667
+addr_t page;
+if (llvm::to_integer(x, page))
dirty_page_list.push_back(page);
-
mgorny marked an inline comment as not done.
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1667
+addr_t page;
+if (llvm::to_integer(x, page))
dirty_page_list.push_back(page
mgorny created this revision.
mgorny added reviewers: labath, teemperor, krytarowski, JDevlieghere, emaste,
lattner, rriddle.
Herald added subscribers: dexonsmith, hiraditya.
mgorny requested review of this revision.
Herald added a project: LLVM.
Add a llvm::split() implementation that can be use
mgorny added inline comments.
Comment at: llvm/lib/IR/DataLayout.cpp:219
/// Checked version of split, to ensure mandatory subparts.
-static Error split(StringRef Str, char Separator,
- std::pair &Split) {
I needed to rename this due to collisi
siger-young updated this revision to Diff 375100.
siger-young added a comment.
Fix typo in SBData test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108090/new/
https://reviews.llvm.org/D108090
Files:
lldb/test/API/lua_api/TestComprehensive.lua
siger-young updated this revision to Diff 375103.
siger-young added a comment.
Rebase commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108090/new/
https://reviews.llvm.org/D108090
Files:
lldb/CMakeLists.txt
lldb/bindings/lua/CMakeLists.t
tammela added a comment.
Just one last thing and I think we are done!
Thanks for your work.
Comment at: lldb/test/API/lua_api/lua_lldb_test.lua:3
+EXPORT_ASSERT_TO_GLOBALS = true
+require('luaunit')
+
Could we not use an external dependency?
For instance in my
mgorny marked an inline comment as done.
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:1667
+addr_t page;
+if (llvm::to_integer(x, page))
dirty_page_list.push_back(page);
-
Author: Michał Górny
Date: 2021-09-26T21:23:26+02:00
New Revision: e2f780fba96c55b0dcb7aa3c4719110875b36dfb
URL:
https://github.com/llvm/llvm-project/commit/e2f780fba96c55b0dcb7aa3c4719110875b36dfb
DIFF:
https://github.com/llvm/llvm-project/commit/e2f780fba96c55b0dcb7aa3c4719110875b36dfb.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe2f780fba96c: [lldb] [gdb-remote] Use
llvm::StringRef.split() and llvm::to_integer() (authored by mgorny).
Herald added a project: LLDB.
Changed prior to commit:
https://reviews.llvm.org/D110472?vs=3750
mgorny updated this revision to Diff 375126.
mgorny added a comment.
Convert more LLDB gdb-remote calls.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110496/new/
https://reviews.llvm.org/D110496
Files:
lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
lldb/so
mgorny created this revision.
mgorny added reviewers: labath, krytarowski, emaste, JDevlieghere, teemperor.
mgorny requested review of this revision.
Remove the redudant "0x" prefix in the "dirty-pages" key of
qMemoryRegionInfo packet. The client accepts hex values both with
and without the prefi
lattner accepted this revision.
lattner added a comment.
This revision is now accepted and ready to land.
This is really nice! Please fix the clang-tidy casing issues, but otherwise
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110496/new/
https://reviews.llvm.org/D110496
_
15 matches
Mail list logo
