[Lldb-commits] [PATCH] D110020: [lldb] [gdb-remote] Remove unused arg from GDBRemoteRegisterContext::ReadRegisterBytes()

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. https://reviews.llvm.org/D110020 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterCont

[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

mgorny updated this revision to Diff 373410. mgorny added a comment. Add a helper function. Test the weird invalidate_regs expansion logic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109906/new/ https://reviews.llvm.org/D109906 Files: lldb/unittests/Process/Utility/CMakeLists.txt

[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

mgorny updated this revision to Diff 373411. mgorny added a comment. Eliminate unused vars. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109906/new/ https://reviews.llvm.org/D109906 Files: lldb/unittests/Process/Utility/CMakeLists.txt lldb/unittests/Process/Utility/DynamicRegister

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Replace value_regs/invalidate_regs in AddRegister()

mgorny updated this revision to Diff 373412. mgorny retitled this revision from "[lldb] [DynamicRegisterInfo] Update RegisterInfo with copy of value_regs/invalidate_regs" to "[lldb] [DynamicRegisterInfo] Replace value_regs/invalidate_regs in AddRegister()". mgorny edited the summary of this revis

[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Add a convenience method to add supplementary registers that takes care of adding invalidate_regs to all (potentially) overlapping registers. https://reviews.llvm.org/D110

[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

mgorny added a comment. Currently it's still using process plugin regnums in value_regs/invalidate_regs; I'm going to try changing that next. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110023/new/ https://reviews.llvm.org/D110023 ___ lldb

[Lldb-commits] [PATCH] D110025: [lldb] [gdb-remote] Refactor getting remote regs to use local vector [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Refactor ProcessGDBRemote::GetGDBServerRegisterInfo() and helper routines to collect remote registers into a local std::vector rather than adding them straight into DynamicR

[Lldb-commits] [PATCH] D110025: [lldb] [gdb-remote] Refactor getting remote regs to use local vector [WIP]

mgorny added a comment. @labath, please tell me if you like this design. If it's ok, I'm going to convert the other routine to it, then move the conversion to `DynamicRegisterInfo` into a common function. (also I haven't reformatted the code yet) CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Replace value_regs/invalidate_regs in AddRegister()

mgorny updated this revision to Diff 373426. mgorny added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109879/new/ https://reviews.llvm.org/D109879 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/source/Plugins/Process/Utility/Dynami

[Lldb-commits] [PATCH] D110023: [lldb] [DynamicRegisterInfo] Add a convenience method to add suppl. registers

mgorny updated this revision to Diff 373427. mgorny added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110023/new/ https://reviews.llvm.org/D110023 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/source/Plugins/Process/Utility/Dynami

[Lldb-commits] [PATCH] D110027: [lldb] [gdb-remote] Use local regnos for value_regs/invalidate_regs

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Switch the gdb-remote client logic to use local (LLDB) register numbers in value_regs/invalidate_regs rather than remote regnos. This involves translating regnos received f