[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

2021-09-02 Thread Kamil Rytarowski via Phabricator via lldb-commits
krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. Looks good CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100503/new/ https://reviews.llvm.org/D100503 ___ lldb-commits mailing l

[Lldb-commits] [lldb] e387c8c - [lldb server] Tidy up LLDB server return codes and associated tests

2021-09-02 Thread Raphael Isemann via lldb-commits
Author: Sebastian Schwartz Date: 2021-09-02T11:16:37+02:00 New Revision: e387c8c413e2127bc93950fb6d786290237b4a9f URL: https://github.com/llvm/llvm-project/commit/e387c8c413e2127bc93950fb6d786290237b4a9f DIFF: https://github.com/llvm/llvm-project/commit/e387c8c413e2127bc93950fb6d786290237b4a9f.

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

2021-09-02 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe387c8c413e2: [lldb server] Tidy up LLDB server return codes and associated tests (authored by saschwartz, committed by teemperor). Repository: rG

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

2021-09-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 370216. mib added a comment. Add test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108953/new/ https://reviews.llvm.org/D108953 Files: lldb/bindings/interface/SBMemoryRegionInfo.i lldb/bindings/interface/SBM

[Lldb-commits] [lldb] 4a2a947 - [lldb] [client] Implement follow-fork-mode

2021-09-02 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-09-02T12:16:58+02:00 New Revision: 4a2a947317bf702178bf1af34dffd0d280d49970 URL: https://github.com/llvm/llvm-project/commit/4a2a947317bf702178bf1af34dffd0d280d49970 DIFF: https://github.com/llvm/llvm-project/commit/4a2a947317bf702178bf1af34dffd0d280d49970.diff

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

2021-09-02 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a2a947317bf: [lldb] [client] Implement follow-fork-mode (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://revi

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

2021-09-02 Thread Jan Kratochvil via Phabricator via lldb-commits
jankratochvil added a comment. The new test is failing on all Linux buildbots such as: lldb-x86_64-fedora = https://lab.llvm.org/staging/#/builders/16 lldb-x86_64-debian = https://lab.llvm.org/buildbot/#/builders/68 https://lab.llvm.org/buildbot/#/builders?tags=lldb Repository: rG LLVM Github

[Lldb-commits] [lldb] bbcb4d6 - Revert "[lldb server] Tidy up LLDB server return codes and associated tests"

2021-09-02 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-09-02T15:27:39+02:00 New Revision: bbcb4d6bc0db612698ab8938ce209029cd8551e0 URL: https://github.com/llvm/llvm-project/commit/bbcb4d6bc0db612698ab8938ce209029cd8551e0 DIFF: https://github.com/llvm/llvm-project/commit/bbcb4d6bc0db612698ab8938ce209029cd8551e0.dif

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

2021-09-02 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor reopened this revision. teemperor added a comment. This revision is now accepted and ready to land. Thanks, reverted the commit. @saschwartz Can you take a look at the failure? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ ht

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

2021-09-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib marked 3 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:80 - return static_cast(*should_stop); -} - -Status ScriptedProcessPythonInterface::Stop() { - return GetStatusFromMet

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

2021-09-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 370258. mib marked an inline comment as done. mib added a comment. Tighten to PythonInterpreter Lock. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107521/new/ https://reviews.llvm.org/D107521 Files: lldb/bindin

[Lldb-commits] [PATCH] D108351: [lldb server] Tidy up LLDB server return codes and associated tests

2021-09-02 Thread Sebastian Schwartz via Phabricator via lldb-commits
saschwartz added a comment. Yes, will take a look. I had `check-lldb` pass for the new tests locally previously - I'll rebase and rerun and see what happens. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108351/new/ https://reviews.llvm.org/D10835

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

2021-09-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 370261. mib added a comment. Tighten PythonInterpreter Lock. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 Files: lldb/bindings/interface/SBMemoryRegionInfo.i lldb/

[Lldb-commits] [lldb] 7f544f7 - Try to unbreak lldb build after 973519826edb76

2021-09-02 Thread Nico Weber via lldb-commits
Author: Nico Weber Date: 2021-09-02T11:32:28-04:00 New Revision: 7f544f7658357045bde67c2f897a088558310f16 URL: https://github.com/llvm/llvm-project/commit/7f544f7658357045bde67c2f897a088558310f16 DIFF: https://github.com/llvm/llvm-project/commit/7f544f7658357045bde67c2f897a088558310f16.diff LO

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

2021-09-02 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Can you explain why we need the memory region? When we're using an SB class from the ScriptedProcess plugin, we need to be very careful to avoid introducing cyclic dependencies. The memory region seems like a pretty "dumb" class (i.e. it's basically just a few ivar

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

2021-09-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 370300. mib added a comment. Remove code related to `D108953` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107585/new/ https://reviews.llvm.org/D107585 Files: lldb/bindings/python/python-wrapper.swig lldb/exa

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

2021-09-02 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib added a comment. In D107585#2979988 , @JDevlieghere wrote: > Can you explain why we need the memory region? When we're using an SB class > from the ScriptedProcess plugin, we need to be very careful to avoid > introducing cyclic dependencies. The m

[Lldb-commits] [lldb] ebbf7f9 - Fix lldb after D108614

2021-09-02 Thread Arthur Eubanks via lldb-commits
Author: Arthur Eubanks Date: 2021-09-02T12:58:41-07:00 New Revision: ebbf7f90b5529460bf5cc9dde3f35aa3ee6a6093 URL: https://github.com/llvm/llvm-project/commit/ebbf7f90b5529460bf5cc9dde3f35aa3ee6a6093 DIFF: https://github.com/llvm/llvm-project/commit/ebbf7f90b5529460bf5cc9dde3f35aa3ee6a6093.diff

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

2021-09-02 Thread Rumeet Dhindsa via Phabricator via lldb-commits
rdhindsa added a comment. Thank you for suggestion to try! After adding the assertions in memory region info trick, 3 testcases from only one test failed because of assertion : lldb/test/API/functionalities/load_unload/TestLoadUnload.py test_lldb_process_load_and_unload_commands test_load_unlo

[Lldb-commits] [PATCH] D100503: [lldb] [client] Implement follow-fork-mode

2021-09-02 Thread Nico Weber via Phabricator via lldb-commits
thakis added a comment. The new tests here fall for me on macOS: [4303/4304] Running lldb shell test suite llvm-lit: /Users/thakis/src/llvm-project/lldb/test/Shell/helper/toolchain.py:126: note: using SDKROOT: '/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk' llvm-lit: /Users/th