[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. Looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100206/new/ https://reviews.llvm.org/D100206 ___ lldb-commits mailing

[Lldb-commits] [lldb] 0a1d80d - [lldb] [gdb-remote client] Support minimal fork/vfork handling

Author: Michał Górny Date: 2021-08-30T10:24:38+02:00 New Revision: 0a1d80d56e6a0e062d493e262d3322d2ac3a04d4 URL: https://github.com/llvm/llvm-project/commit/0a1d80d56e6a0e062d493e262d3322d2ac3a04d4 DIFF: https://github.com/llvm/llvm-project/commit/0a1d80d56e6a0e062d493e262d3322d2ac3a04d4.diff

[Lldb-commits] [PATCH] D100206: [lldb] [llgs client] Support minimal fork/vfork handling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a1d80d56e6a: [lldb] [gdb-remote client] Support minimal fork/vfork handling (authored by mgorny). Herald added a project: LLDB. Repository: rG LL

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for the patch! As Jonas pointed out, tests are usually expected for these kind of patches. But the IOHandler logic has some really quirky way to write tests, so just wen

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst

teemperor accepted this revision. teemperor added a comment. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/new/ https://reviews.llvm.org/D108812 ___ lldb-commits mailing list lldb-co

[Lldb-commits] [lldb] f3ad3ea - [lldb][NFC] Remove TypeSystemClang::CreateFunctionType overload

Author: Raphael Isemann Date: 2021-08-30T12:28:20+02:00 New Revision: f3ad3ea4719bd025711062725732dd597533a8c9 URL: https://github.com/llvm/llvm-project/commit/f3ad3ea4719bd025711062725732dd597533a8c9 DIFF: https://github.com/llvm/llvm-project/commit/f3ad3ea4719bd025711062725732dd597533a8c9.dif

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK marked 8 inline comments as done and an inline comment as not done. Aj0SK added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:519 +lldb_private::Status +MinidumpFileBuilder::AddMemoryList(const lldb::ProcessSP &process_sp) { +

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK updated this revision to Diff 369410. Aj0SK marked 2 inline comments as done and an inline comment as not done. Aj0SK added a comment. Add error for dump core style other than stack and change procedure getting the memory list stream. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

HirokiImai updated this revision to Diff 369412. HirokiImai added a comment. Add a regression test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108817/new/ https://reviews.llvm.org/D108817 Files: lldb/source/Host/common/Editline.cpp lldb/test

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

HirokiImai added a comment. Thanks for the review! I didn't know how to write tests very well, so the review was very helpful for me. I found the LLVM project to be beautiful in its componentization. I'll learn more about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D108468: [lldb] [gdb-remote] Fix displaying i387_ext & vec regs with gdbserver

mgorny updated this revision to Diff 369415. mgorny added a comment. Correct the test case to actually include data for all XMM registers (NFC). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108468/new/ https://reviews.llvm.org/D108468 Files: lldb/source/Plugins/Process/gdb-remote/Pr

[Lldb-commits] [PATCH] D108468: [lldb] [gdb-remote] Fix displaying i387_ext & vec regs with gdbserver

mgorny updated this revision to Diff 369419. mgorny added a comment. Actually, the test should include 16 XMM registers and MXCSR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108468/new/ https://reviews.llvm.org/D108468 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. In D108817#2972047 , @HirokiImai wrote: > Thanks for the review! > I didn't know how to write tests very well, so the review was very helpful >

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny updated this revision to Diff 369421. mgorny added a comment. Add writing tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt lldb/source/Plugins/Process/gdb-remote/GDB

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

mgorny updated this revision to Diff 369422. mgorny added a comment. Add tests for reading back (should verify invalidation). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/ https://reviews.llvm.org/D108831 Files: lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt lldb

[Lldb-commits] [lldb] 3973d8b - [lldb] Return all line entries matchign a line if no column is specified

Author: Kim-Anh Tran Date: 2021-08-30T14:45:46+02:00 New Revision: 3973d8b29e249a6ea4aceaa4225dfde5663937c6 URL: https://github.com/llvm/llvm-project/commit/3973d8b29e249a6ea4aceaa4225dfde5663937c6 DIFF: https://github.com/llvm/llvm-project/commit/3973d8b29e249a6ea4aceaa4225dfde5663937c6.diff

[Lldb-commits] [PATCH] D108816: [lldb] Return all line entries matchign a line if no column is specified

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3973d8b29e24: [lldb] Return all line entries matchign a line if no column is specified (authored by kimanh). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D108816: [lldb] Return all line entries matchign a line if no column is specified

kimanh added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108816/new/ https://reviews.llvm.org/D108816 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:/

[Lldb-commits] [lldb] ffcf571 - [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

Author: Hiroki Date: 2021-08-30T15:14:09+02:00 New Revision: ffcf571107594ff5d02bc2410266efe527787fb0 URL: https://github.com/llvm/llvm-project/commit/ffcf571107594ff5d02bc2410266efe527787fb0 DIFF: https://github.com/llvm/llvm-project/commit/ffcf571107594ff5d02bc2410266efe527787fb0.diff LOG: [

[Lldb-commits] [PATCH] D108817: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using file path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffcf57110759: [LLDB] Fix 'std::out_of_range' crashing bug when file name completion using… (authored by HirokiImai, committed by teemperor). Reposi

[Lldb-commits] [lldb] 2ce889f - [lldb][NFC] Add size tests for empty records with alignment and with empty members

Author: Raphael Isemann Date: 2021-08-30T16:38:13+02:00 New Revision: 2ce889fa4e5cab75fc65d03a4dfae52784d57db9 URL: https://github.com/llvm/llvm-project/commit/2ce889fa4e5cab75fc65d03a4dfae52784d57db9 DIFF: https://github.com/llvm/llvm-project/commit/2ce889fa4e5cab75fc65d03a4dfae52784d57db9.dif

[Lldb-commits] [PATCH] D108937: [lldb] [Process/gdb-remote] Support combining xmm* and ymm*h regs into ymm*

mgorny created this revision. mgorny added reviewers: emaste, krytarowski, jasonmolenda, JDevlieghere, labath. Herald added a subscriber: mgrang. mgorny requested review of this revision. gdbserver does not expose combined ymm* registers but rather XSAVE-style split xmm* and ymm*h portions. Exten

[Lldb-commits] [PATCH] D108944: [LLDB][GUI] Add source file searcher

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. This patch adds a new

[Lldb-commits] [PATCH] D108944: [LLDB][GUI] Add source file searcher

OmarEmaraDev added a comment. An example typical workflow for navigating to a file and adding a breakpoint. F18748669: 20210830-221617.mp4 <https://reviews.llvm.org/F18748669> Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108944/new/

Re: [Lldb-commits] [lldb] 2ce889f - [lldb][NFC] Add size tests for empty records with alignment and with empty members

Interesting to note that zero sized arrays are an extension, so are empty structs which require a diagnostic in C but are well-formed C++. It is unfortunate that we have divergence in that extension. > On Aug 30, 2021, at 7:38 AM, Raphael Isemann via lldb-commits > wrote: > > > Author: Raph

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for all of the changes! Looks great. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:549 +bool is_interesting = false; +for (si

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh updated this revision to Diff 369547. kimanh added a comment. - Updating error messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107456/new/ https://reviews.llvm.org/D107456 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp

[Lldb-commits] [PATCH] D107456: [lldb] Support .debug_rnglists.dwo sections in dwp file

kimanh added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:556 + " (ranges list base: 0x%" PRIx64 "): %s", + offset, m_ranges_base, toString(table_or_error.takeError()).c_str()); } jankratochvil wrote: > kima

[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. So do the shared library files on disk that are exploded from a shared cache of an iOS device have the file addresses set to where they are in the shared cache? I am guessing this must the

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

clayborg added a comment. the multi-threaded test often times out for me. I wonder if it is timing out for you as well when you run the test suite locally? Maybe this is covering up the crash because the crash doesn't happen before the test times out for you? Repository: rG LLVM Github Monor

[Lldb-commits] [PATCH] D108395: [lldb] Delete IRExecutionUnit::CollectCandidateCPlusPlusNames

bulbazord added a comment. Embarassingly I found out my test environment was not working correctly, this does indeed fail some tests. I will upload a patch to actually refactor it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108395/new/ https:

[Lldb-commits] [PATCH] D107585: [lldb/Plugins] Add support for ScriptedThread in ScriptedProcess

mib updated this revision to Diff 369566. mib marked 3 inline comments as done. mib added a comment. - Address @JDevlieghere feedbacks - Use the new `ScriptedPythonInterface::Dispatch` method in `ScriptedThreadPythonInterface` - Add Test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D108889: Use dSYM SymbolFile Sections file addr instead of ObjectFile Section file addr when they differ in ObjectFileMachO

jasonmolenda added a comment. In D108889#2973300 , @clayborg wrote: > So do the shared library files on disk that are exploded from a shared cache > of an iOS device have the file addresses set to where they are in the shared > cache? I am guessing this

[Lldb-commits] [PATCH] D108953: [lldb/Plugins] Add memory region support in ScriptedProcess

mib created this revision. mib added reviewers: JDevlieghere, jasonmolenda, jingham. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds support for memory regions in Scripted Processes. This is necessary to read the stack memo

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

rdhindsa added a comment. For me, this test passes every time. I have tried multiple times with instructions from failing bot, but haven't been able to reproduce the failure locally yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108061/new/ h

[Lldb-commits] New feature suggestion: Tacking variable update

Hi All, We would like to propose a variable tracking for LLDB. The objective and definition of the project are updated in this document . We would like to know id this a project that the community woul

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 marked 2 inline comments as done. Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html" +set(LLVM_INSTALL_OCAML

[Lldb-commits] [PATCH] D99484: Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 363801. Ericson2314 added a comment. Herald added subscribers: wrengr, Chia-hungDuan. Rebase, push again after previous PR changed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99484/new/ https://reviews.ll

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 363799. Ericson2314 added a comment. Fix things in response to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists

[Lldb-commits] [PATCH] D107470: 2/4: [llvm+lldb] Remove dead-code in DWARFListTableHeader::extract modifying DWARFDataExtractor

jankratochvil created this revision. jankratochvil added reviewers: ikudrin, dblaikie, labath, clayborg. jankratochvil added projects: LLDB, LLVM. Herald added subscribers: JDevlieghere, hiraditya. jankratochvil requested review of this revision. @ikudrin has correctly noticed

[Lldb-commits] [PATCH] D107528: [llvm][clang][NFC] updates inline licence info

cjdb created this revision. cjdb added reviewers: aaron.ballman, chandlerc, lattner, tonic. Herald added subscribers: dexonsmith, martong, pengfei, arphaman, kbarton, hiraditya, nemanjai, qcolombet, MatzeB. cjdb requested review of this revision. Herald added projects: clang, LLDB, LLVM, clang-too

[Lldb-commits] [PATCH] D107528: [llvm][clang][NFC] updates inline licence info

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. There are some spurious whitespace changes that should be dropped, but otherwise, this LGTM. Thank you for the cleanup! Comment at: clang/lib/Tooling/Dependenc

[Lldb-commits] [PATCH] D107528: [llvm][clang][NFC] updates inline licence info

lattner accepted this revision. lattner added a comment. Thank you for catching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107528/new/ https://reviews.llvm.org/D107528 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit created this revision. gAlfonso-bit added a project: LLVM. Herald added subscribers: libcxx-commits, tstellar, mgorny. Herald added a reviewer: MaskRay. Herald added a project: libunwind. Herald added a reviewer: libunwind. gAlfonso-bit requested review of this revision. Herald added p

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

ldionne accepted this revision. ldionne added a comment. This LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. Alright. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365039. Herald added a subscriber: JDevlieghere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMock

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365275. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake compiler-rt/cmake

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added inline comments. Comment at: llvm/CMakeLists.txt:589 CACHE STRING "Doxygen-generated HTML documentation install directory") -set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "share/doc/llvm/ocaml-html" +set(LLVM_INSTALL_OCAMLDOC_HTML_DIR "${CMAKE_INSTALL_DOCDIR}/${proje

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. So does that mean this is ready to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365507. gAlfonso-bit added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLL

[Lldb-commits] [PATCH] D107528: [llvm][clang][NFC] updates inline licence info

cjdb updated this revision to Diff 365648. cjdb added a comment. uploading solely for a fast visual inspection on the diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107528/new/ https://reviews.llvm.org/D107528 Files: clang-tools-extra/clang-

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne is this ok? any other changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D107528: [llvm][clang][NFC] updates inline licence info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. cjdb marked 3 inline comments as done. Closed by commit rGc874dd53628d: [llvm][clang][NFC] updates inline licence info (authored by cjdb). Changed prior to commit: h

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 365802. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockL

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366014. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockL

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366497. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/Compile

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne can we land this please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 366671. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake compiler-rt/cmake

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. I don't think there are any other outstanding issues. Are we good to accept and merge? @ldionne CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

pfaffe added a comment. This change breaks all existing uses of relative comp_dirs that don't accidentally make all of them relative to the executable's directory already. It's easy to construct broken use cases: Consider compiling your program like `clang -g ./src/src.c -gsplit-dwarf -o ./out/

[Lldb-commits] [PATCH] D97786: LLDB: Use path relative to binary, not relative to debugger CWD, for finding .dwo files.

dblaikie added a comment. In D97786#2972153 , @pfaffe wrote: > This change breaks all existing uses of relative comp_dirs that don't > accidentally make all of them relative to the executable's directory already. > > It's easy to construct broken use case

[Lldb-commits] [lldb] 3af9847 - [LLDB][Docs] Convert some .txt files to .rst

Author: Shivam Gupta Date: 2021-08-31T11:45:24+05:30 New Revision: 3af9847a9581fca3c81c7f8669f6f617e35ba9e5 URL: https://github.com/llvm/llvm-project/commit/3af9847a9581fca3c81c7f8669f6f617e35ba9e5 DIFF: https://github.com/llvm/llvm-project/commit/3af9847a9581fca3c81c7f8669f6f617e35ba9e5.diff

[Lldb-commits] [lldb] 654e8d6 - [LLDB][Docs] Move best-practices.txt contain to resources/test.rst

Author: Shivam Gupta Date: 2021-08-31T11:45:24+05:30 New Revision: 654e8d6c318a0c4eb9bfd74a9ace6d1a1bda5100 URL: https://github.com/llvm/llvm-project/commit/654e8d6c318a0c4eb9bfd74a9ace6d1a1bda5100 DIFF: https://github.com/llvm/llvm-project/commit/654e8d6c318a0c4eb9bfd74a9ace6d1a1bda5100.diff

[Lldb-commits] [PATCH] D108807: [LLDB][Docs] Convert links.md & lldb-for-gdb-users.txt file to respective .rst files

This revision was automatically updated to reflect the committed changes. Closed by commit rG3af9847a9581: [LLDB][Docs] Convert some .txt files to .rst (authored by xgupta). Changed prior to commit: https://reviews.llvm.org/D108807?vs=369253&id=369633#toc Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D108812: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst

This revision was automatically updated to reflect the committed changes. Closed by commit rG654e8d6c318a: [LLDB][Docs] Move best-practices.txt contain to resources/test.rst (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108812/n