[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

DavidSpickett added a comment. > This looks good but the test fails on arm 32 bit. I had a few of those last time, I will build the whole series on 32 bit to check for more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105630/new/ https://review

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I'm really sorry, I don't understand what kind of review is expected here given the state of this patch. - The patch **still** doesn't include the tests that I asked for in my

[Lldb-commits] [PATCH] D100048: [lldb][Editline] Fix crash when navigating through empty command history.

iii added a comment. lldb-arm-ubuntu (https://lab.llvm.org/buildbot/#/builders/17/builds/9015) fails with: FAIL: LLDB (/home/tcwg-buildslave/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: test_nav_arrow_up_empty_pr49845 (TestMultilineNavigation.TestCase)

[Lldb-commits] [PATCH] D106035: Remove conditional compilation for WCHAR support in libedit

teemperor added a comment. I actually expected after the RFC that we would remove all the non-wchar code, but this seems also fine. I think this LGTM in general, but I feel a bit nervous about touching stuff that depends so much on OS/environment. What OS/environment did you test this patch on?

[Lldb-commits] [PATCH] D100048: [lldb][Editline] Fix crash when navigating through empty command history.

rupprecht added a comment. In D100048#2879669 , @iii wrote: > lldb-arm-ubuntu (https://lab.llvm.org/buildbot/#/builders/17/builds/9015) > fails with: > > FAIL: LLDB > (/home/tcwg-buildslave/worker/lldb-arm-ubuntu/build/bin/clang-arm) :: > test_nav_ar

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

DavidSpickett updated this revision to Diff 358972. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105178/new/ https://reviews.llvm.org/D105178 Files: lldb/source/Plugins/Process/Linux/NativeThreadLinux.cpp

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

DavidSpickett updated this revision to Diff 358973. DavidSpickett added a comment. Rebase and correct printf formatting to fix 32 bit test issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105630/new/ https://reviews.llvm.org/D105630 Files:

[Lldb-commits] [PATCH] D105179: [lldb][AArch64] Add tag packing and repetition memory tag manager

DavidSpickett updated this revision to Diff 358975. DavidSpickett added a comment. Rebase, correct the commit title and printf formatters for 32 bit build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105179/new/ https://reviews.llvm.org/D105179

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

DavidSpickett updated this revision to Diff 358976. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105180/new/ https://reviews.llvm.org/D105180 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h l

[Lldb-commits] [PATCH] D105181: [lldb][AArch64] Add memory tag writing to lldb

DavidSpickett updated this revision to Diff 358977. DavidSpickett added a comment. Rebase, update use of SendPacketAndWaitForResponse. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105181/new/ https://reviews.llvm.org/D105181 Files: lldb/include

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

DavidSpickett updated this revision to Diff 358978. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105182/new/ https://reviews.llvm.org/D105182 Files: lldb/source/Commands/CommandObjectMemoryTag.cpp lldb/te

[Lldb-commits] [PATCH] D105183: [lldb] Add "memory tag write" --end-addr option

DavidSpickett updated this revision to Diff 358980. DavidSpickett added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105183/new/ https://reviews.llvm.org/D105183 Files: lldb/source/Commands/CommandObjectMemoryTag.cpp lldb/so

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

DavidSpickett updated this revision to Diff 358982. DavidSpickett added a comment. Update comment about save/restoring end of range. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105630/new/ https://reviews.llvm.org/D105630 Files: lldb/include/l

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

aprantl added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2693 +other_die = dcu->LookupAddress( +symtab->SymbolAtIndex(symbol_indexes[index])->GetFileAddress()); + } should there be an early exit

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang created this revision. Herald added subscribers: dexonsmith, fedor.sergeev. akhuang requested review of this revision. Herald added projects: clang, LLDB. Herald added subscribers: lldb-commits, cfe-commits. Constructor homing reduces the amount of class type info that is emitted by emitti

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105655/new/ https://reviews.llvm.org/D105655

[Lldb-commits] [lldb] 0321dbc - [LLDB][GUI] Add Process Attach form

Author: Omar Emara Date: 2021-07-15T15:12:27-07:00 New Revision: 0321dbc87e43e651c50998701f349d1791fa9cb6 URL: https://github.com/llvm/llvm-project/commit/0321dbc87e43e651c50998701f349d1791fa9cb6 DIFF: https://github.com/llvm/llvm-project/commit/0321dbc87e43e651c50998701f349d1791fa9cb6.diff LO

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0321dbc87e43: [LLDB][GUI] Add Process Attach form (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace dump ctf -f ` command

clayborg added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:41 + size_t m_num_instructions; + std::unordered_map m_func_calls; + friend llvm::json::Value toJSON(const HTRBlockMetadata &metadata); wallace wrote: > jj10306 wrote: > > clayborg

[Lldb-commits] [lldb] 2e7ec44 - [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API

Author: Peter S. Housel Date: 2021-07-16T00:45:22+02:00 New Revision: 2e7ec447cc7eab89a72413ad91a897049f551c56 URL: https://github.com/llvm/llvm-project/commit/2e7ec447cc7eab89a72413ad91a897049f551c56 DIFF: https://github.com/llvm/llvm-project/commit/2e7ec447cc7eab89a72413ad91a897049f551c56.dif

[Lldb-commits] [PATCH] D105389: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2e7ec447cc7e: [lldb] Add AllocateMemory/DeallocateMemory to the SBProcess API (authored by housel, committed by teemperor). Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

wallace updated this revision to Diff 359200. wallace added a comment. Followed the recommendations. Now I'm making sure that TraceInstructionDumper uses the state of the Cursor and doesn't modify it, this makes the class reusable for other purposes. Having the direction and granularity as part

[Lldb-commits] [PATCH] D105531: [trace][intel pt] Implement the Intel PT cursor

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Very close! Just a few nits. Comment at: lldb/include/lldb/Target/TraceCursor.h:101 + /// Set the direction to use in the \a TraceCursor::Move() method. + voi

[Lldb-commits] [PATCH] D106122: Add a mutex to guard access to the ThreadPlanStack class

jingham created this revision. jingham added reviewers: JDevlieghere, kastiglione. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We've seen reports of crashes (none we've been able to reproduce locally) that look like th

[Lldb-commits] [PATCH] D105179: [lldb][AArch64] Add tag packing and repetition memory tag manager

omjavaid added a comment. Looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105179/new/ https://reviews.llvm.org/D105179 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] b5a84e2 - [debugserver] Un-conditionalize code guarded by macOS 10.10 checks

Author: Jonas Devlieghere Date: 2021-07-15T23:18:05-07:00 New Revision: b5a84e214d49c56d13dc1fb76273f575e6752c68 URL: https://github.com/llvm/llvm-project/commit/b5a84e214d49c56d13dc1fb76273f575e6752c68 DIFF: https://github.com/llvm/llvm-project/commit/b5a84e214d49c56d13dc1fb76273f575e6752c68.d