Re: [Lldb-commits] [lldb] 3bea730 - [lldb] Fix compilation with gcc-6.5

On Tue, Jun 15, 2021 at 4:29 PM Tom Stellard wrote: > On 6/15/21 4:28 PM, Chandler Carruth wrote: > > +Tom Stellard - Could this get > cherry-picked into 12.0.N for the next point release? Without it, LLDB in > the 12 release doesn't build with GCC <= 6.5 which the do

[Lldb-commits] [lldb] 3b7795a - [lldb] vwprintw -> vw_printw in IOHandlerCursesGUI

Author: Raphael Isemann Date: 2021-06-16T13:14:08+02:00 New Revision: 3b7795aeceb153b04493c5ba93e707e39afbe41f URL: https://github.com/llvm/llvm-project/commit/3b7795aeceb153b04493c5ba93e707e39afbe41f DIFF: https://github.com/llvm/llvm-project/commit/3b7795aeceb153b04493c5ba93e707e39afbe41f.dif

[Lldb-commits] [lldb] 59d5886 - [lldb] Require Clang 8 for gpubnames test

Author: Raphael Isemann Date: 2021-06-16T14:07:03+02:00 New Revision: 59d58863bc0ea72a396aa9b08a7a5cb3f29e75b6 URL: https://github.com/llvm/llvm-project/commit/59d58863bc0ea72a396aa9b08a7a5cb3f29e75b6 DIFF: https://github.com/llvm/llvm-project/commit/59d58863bc0ea72a396aa9b08a7a5cb3f29e75b6.dif

[Lldb-commits] [PATCH] D101361: [LLDB] Support AArch64/Linux watchpoint on tagged addresses

DavidSpickett added a comment. Since you landed the underlying ABI patch, looking at this again. Seems like no comments on the BSD side, in which case to be safe we could just have the default `FixWatchpointHitAddress` make no changes. Then remove TBI and PAC for AArch64 Linux, no surprises tha

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Since https://reviews.llvm.org/D103701 AppendError<...> sets this for you. This change includes all of the non-command uses. Some uses rema

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

DavidSpickett added a reviewer: teemperor. DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. There'll be a part 2 once this has passed the bots, which will cover all the `CommandObject*` files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The idea is now that AppendError<...> will set eReturnStatusFailed for you so you don't have to call SetStatus again. Previously if the erro

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/StructuredData/DarwinLog/StructuredDataDarwinLog.cpp:835 if (!error.Success()) { result.AppendError(error.AsCString()); - result.SetStatus(eReturnStatusFailed); https://reviews

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. At least on the test suite on Linux that branch is anyway never taken, so LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1043

[Lldb-commits] [PATCH] D104379: [lldb] Remove redundant calls to set eReturnStatusFailed

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM and passes on macOS and Linux for me. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104379/new/ https://reviews.llvm.org/D104

Re: [Lldb-commits] [lldb] 3bea730 - [lldb] Fix compilation with gcc-6.5

On 6/15/21 4:28 PM, Chandler Carruth wrote: +Tom Stellard  - Could this get cherry-picked into 12.0.N for the next point release? Without it, LLDB in the 12 release doesn't build with GCC <= 6.5 which the docs indicate is supposed to work. Can you file a bug for t

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds initial support for forms and dialogs for the LLDB

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. Herald added a subscriber: JDevlieghere. An example form: F17429353: 20210616-174753.mp4 <https://reviews.llvm.org/F17429353> class TestFormDelegate : public FormDelegate { public: TestFormDelegate() { m_path_field = AddTextField("Path&qu

[Lldb-commits] [PATCH] D104404: Change PathMappingList::RemapPath to return an optional result (NFC)

aprantl created this revision. aprantl added reviewers: JDevlieghere, shafik, jingham. aprantl requested review of this revision. This is an NFC modernization refactoring that replaces the combination of a bool return + reference argument, with an Optional return value. https://reviews.llvm.org

[Lldb-commits] [PATCH] D104405: Change PathMappingList::FindFile to return an optional result (NFC)

aprantl created this revision. aprantl added reviewers: JDevlieghere, shafik, jingham. aprantl requested review of this revision. This is an NFC modernization refactoring that replaces the combination of a bool return + reference argument, with an Optional return value. https://reviews.llvm.org

[Lldb-commits] [PATCH] D104406: Express PathMappingList::FindFile() in terms of PathMappingList.h::RemapPath() (NFC)

aprantl created this revision. aprantl added reviewers: jingham, shafik, JDevlieghere, labath. aprantl requested review of this revision. This patch replaces the function body FindFile() with a call to RemapPath(), since the two functions implement the same functionality. https://reviews.llvm.o

[Lldb-commits] [PATCH] D104407: Improve path remapping in cross-debugging scenarios

aprantl created this revision. aprantl added reviewers: jingham, labath, shafik, JDevlieghere. aprantl requested review of this revision. This patch implements a slight improvement when debugging across platforms and remapping source paths that are in a non-native format. See the unit test for e

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: teemperor, jarin. PatriosTheGreat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Right now if the LLDB is compiled under the windows with static vcruntime library, th

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Target/Process.cpp:5854 + if (auto abi = GetABI()) { +// TODO: can we always assume data addresses here? +load_addr = abi->FixDataAdd

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace created this revision. wallace added reviewers: clayborg, vsk. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. As a follow up of D103588 , I'm reinitiating the discussion with a new proposa

[Lldb-commits] [lldb] f9aba9a - Move the definition of LLVM_SUPPORT_XCODE_SIGNPOSTS into llvm-config.h

Author: Adrian Prantl Date: 2021-06-16T14:40:37-07:00 New Revision: f9aba9a5afe09788eceb9879aa5c3ad345e0f1e9 URL: https://github.com/llvm/llvm-project/commit/f9aba9a5afe09788eceb9879aa5c3ad345e0f1e9 DIFF: https://github.com/llvm/llvm-project/commit/f9aba9a5afe09788eceb9879aa5c3ad345e0f1e9.diff

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin created this revision. aheejin added reviewers: tlively, sbc100. Herald added subscribers: wingo, ecnelises, rupprecht, sunfish, hiraditya, jgravelle-google, dschuff. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. aheejin requested review of this revision. Herald ad

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin planned changes to this revision. aheejin added a comment. Herald added a subscriber: JDevlieghere. Oh, forgot to fix comments... will fix soon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin updated this revision to Diff 352570. aheejin added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423 Files: lld/include/lld/Common/LLVM.h lld/test/wasm/Inputs/event-se

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin updated this revision to Diff 352571. aheejin added a comment. Typo fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423 Files: lld/include/lld/Common/LLVM.h lld/test/wasm/Inputs/event-sectio

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

omjavaid requested changes to this revision. omjavaid added a comment. This revision now requires changes to proceed. This doesnt build ... you need to include #include "lldb/Target/ABI.h" in lldb/source/Commands/CommandObjectMemory.cpp Comment at: lldb/test/API/linux/aarch64

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

pcc added a comment. In D103626#2796554 , @DavidSpickett wrote: > The side effect here is that you do "memory read " and you see > untagged addresses for the lines. It's not really that confusing but maybe > something we should make a general decision

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

clayborg added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:224 + /// failed to load, an \a llvm::Error is returned. + virtual llvm::Expected GetThreadEndCursor( + Thread &thread, If the trace cursor contains an error, do we need llvm:

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

aheejin updated this revision to Diff 352590. aheejin added a comment. clang-tidy fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104423/new/ https://reviews.llvm.org/D104423 Files: lld/include/lld/Common/LLVM.h lld/test/wasm/Inputs/event-se

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg added a comment. Looks very nice. A few things to consider here, and I am open to everyone's opinion here, did you consider implementing each field as a Window? It seems that a lot of the window code is duplicated, DrawBox for one. I know we would need to make modifications to the Win

[Lldb-commits] [lldb] 42e2a90 - Relax language comparison when matching up C++ forward decls with definitions

Author: Adrian Prantl Date: 2021-06-16T18:21:43-07:00 New Revision: 42e2a90684196d6ffadf785e98ea5de0876b4a3e URL: https://github.com/llvm/llvm-project/commit/42e2a90684196d6ffadf785e98ea5de0876b4a3e DIFF: https://github.com/llvm/llvm-project/commit/42e2a90684196d6ffadf785e98ea5de0876b4a3e.diff

[Lldb-commits] [PATCH] D103500: [trace][intel-pt] Create basic SB API

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. a few nits! Comment at: lldb/include/lldb/API/SBTarget.h:847 + /// \return + /// The trace object. It might be undefined. + lldb::SBTrace GetTrace(); -

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace updated this revision to Diff 352605. wallace added a comment. - Simplified Trace.h by simply having lldb::TraceCursorUP GetCursor, as suggested. - Improved the documentation including a sample code. - Added methods to quickly move the trace to the beginning or the end. - Renamed TraceIns

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid created this revision. nealsid added a reviewer: LLDB. nealsid requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This small patch adds a test for functions & lldb commands with unicode characters in them. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid updated this revision to Diff 352612. nealsid added a comment. Herald added a subscriber: JDevlieghere. Add newline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104437/new/ https://reviews.llvm.org/D104437 Files: lldb/test/Shell/Breakp

[Lldb-commits] [PATCH] D104423: [WebAssembly] Rename event to tag

tlively accepted this revision. tlively added a comment. This revision is now accepted and ready to land. LGTM! My only comments are about wording in some of the code comments. Comment at: lld/wasm/Symbols.h:419 +// attribute and a type. Currently the attribute can only specify

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

clayborg added inline comments. Comment at: lldb/include/lldb/Target/TraceCursor.h:39-40 +/// +/// The Trace initially points to a dummy invalid instruction error signaling +/// the end of a trace, similar to a C++ collections' end iterator. +/// Should the Tra