[Lldb-commits] [PATCH] D103390: [lldb] Remove SBCommandReturnObject::ref

teemperor created this revision. teemperor added a reviewer: jankratochvil. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. This function was added in D67589

[Lldb-commits] [PATCH] D103390: [lldb] Remove SBCommandReturnObject::ref

teemperor added a comment. IIUC this was originally public but then we made the other users friends (but the public remained). But still putting this up for review in case I missed something Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103390/new

[Lldb-commits] [PATCH] D103390: [lldb] Remove SBCommandReturnObject::ref

jankratochvil accepted this revision. jankratochvil added a comment. This revision is now accepted and ready to land. I agree it should not be permitted to return the internal object from SB API. And if it still compiles after moving to `private:` then why not. Repository: rG LLVM Github Mono

[Lldb-commits] [PATCH] D103391: [lldb] Add missing reproducer instrumentation to some SB classes

teemperor created this revision. teemperor added a reviewer: JDevlieghere. teemperor added a project: LLDB. teemperor requested review of this revision. Herald added a subscriber: lldb-commits. I noticed that there might be some missing instrumentation after a related change popped up in D103381

[Lldb-commits] [lldb] 24ee6d3 - [lldb][NFC] Remove unused var in SBDebugger::GetInternalVariableValue

Author: Raphael Isemann Date: 2021-05-31T11:19:02+02:00 New Revision: 24ee6d3d3c6215db11e9015e94f5f4a9b5a7b750 URL: https://github.com/llvm/llvm-project/commit/24ee6d3d3c6215db11e9015e94f5f4a9b5a7b750 DIFF: https://github.com/llvm/llvm-project/commit/24ee6d3d3c6215db11e9015e94f5f4a9b5a7b750.dif

[Lldb-commits] [PATCH] D103391: [lldb] Add missing reproducer instrumentation to some SB classes

brucem added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:165 bool &is_debugger_specific) { + LLDB_RECORD_STATIC_METHOD( + const char *, SBDebugger, GetProgressFromEvent, This one is already prese

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

PatriosTheGreat requested review of this revision. PatriosTheGreat added a comment. Thanks for feedback. I made a small sample: https://pastebin.com/F8nde1zi Compile command: clang++ -O0 -g -pthread sample.cpp LLDB command: breakpoint set -f sample.cpp -l 24 --condition 'i == 100' This break sh

[Lldb-commits] [PATCH] D102092: [lldb] Enable -Wmisleading-indentation

danilaml added a comment. I remember some noise due to this option (albeit on GCC), because it stops tracking indentation when the number of lines is too big, as it is for files including TableGen'ed inc files. Not sure if there is a way to improve it. Repository: rG LLVM Github Monorepo CH