[Lldb-commits] [PATCH] D103217: Make ignore counts work as "after stop" modifiers so they play nicely with conditions

2021-05-28 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/include/lldb/Breakpoint/BreakpointLocation.h:300-305 + /// BreakpointLocation::IgnoreCountShouldStop can only be called once + /// per st

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

2021-05-28 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere created this revision. JDevlieghere added reviewers: teemperor, labath, mib, jingham. Herald added a subscriber: pengfei. JDevlieghere requested review of this revision. When executing a `script` command in `HandleCommand(s)` we currently print its output twice: once directly to the

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

2021-05-28 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. A command that knew it was streaming a lot of output is supposed to be able to choose to have the CommandInterpreter directly stream the results while the command is executing. That's good for something that is likely to print a lot of output, since then you don't have