[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

DavidSpickett added inline comments. Comment at: lldb/docs/resources/test.rst:222 +``gmodules`` need to recompile external headers when they encounter +test-specific flags (including defines) which can be very expensive. + Does this mean only use the flag

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

teemperor added a comment. I am wondering how SourceLocationSpec is related to lldb's Declaration class (which is FileSpec + line + column and describes a location in source code)? It seems like the current SourceLocationSpec is just a Declaration with the two additional search variables (and t

[Lldb-commits] [PATCH] D101285: [lldb] [llgs server] Support creating core dumps on NetBSD [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Add a new SaveCore() process method that can be used to request a core dump. This is currently implemented on NetBSD via the PT_DUMPCORE ptrace(2) request, and enabled via

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

teemperor marked 7 inline comments as done. teemperor added a comment. Addressing feedback. Comment at: lldb/docs/resources/test.rst:206 + +**Don't unnecessarily launch the test executable.** +Launching a process and running to a breakpoint can often be the most ---

[Lldb-commits] [lldb] e439a46 - [lldb] Use forward type in pointer-to-member

Author: Emre Kultursay Date: 2021-04-26T15:23:58+02:00 New Revision: e439a463a30833f1c7d366ed722f0f12d1682638 URL: https://github.com/llvm/llvm-project/commit/e439a463a30833f1c7d366ed722f0f12d1682638 DIFF: https://github.com/llvm/llvm-project/commit/e439a463a30833f1c7d366ed722f0f12d1682638.diff

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe439a463a308: [lldb] Use forward type in pointer-to-member (authored by emrekultursay, committed by teemperor). Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

teemperor updated this revision to Diff 340520. teemperor marked 5 inline comments as done. teemperor added a comment. - Update diff with feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101153/new/ https://reviews.llvm.org/D101153 Files: lldb/docs/resources/test.rst Index: l

Re: [Lldb-commits] Buildbot failure in LLVM Buildbot on lldb-aarch64-ubuntu

[AMD Public Use] Hi, The below commit I made is an NFC and moreover, AFAIU, it has got nothing to do with LLDB. What should I do? Regards, Ram -Original Message- From: llvm.buildmas...@lab.llvm.org Sent: Saturday, April 24, 2021 6:59 AM To: Nalamothu, Venkata Ramanaiah Cc: gkistan..

Re: [Lldb-commits] Buildbot failure in LLVM Buildbot on lldb-aarch64-ubuntu

You can ignore that, that seems to be either a flaky test or an issue with the bot (the next test run passes just fine). - Raphael Am Mo., 26. Apr. 2021 um 17:04 Uhr schrieb Nalamothu, Venkata Ramanaiah via lldb-commits : > > [AMD Public Use] > > Hi, > > The below commit I made is an NFC and more

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

stella.stamenova added a comment. Looks like this is failing on the Windows LLDB bot: https://lab.llvm.org/buildbot/#/builders/83/builds/6033 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 _

[Lldb-commits] [PATCH] D101285: [lldb] [llgs server] Support creating core dumps on NetBSD

mgorny updated this revision to Diff 340558. mgorny retitled this revision from "[lldb] [llgs server] Support creating core dumps on NetBSD [WIP]" to "[lldb] [llgs server] Support creating core dumps on NetBSD". mgorny added a comment. Create a temporary file if `path-hint` is not provided. CH

[Lldb-commits] [PATCH] D101285: [lldb] [llgs server] Support creating core dumps on NetBSD

mgorny updated this revision to Diff 340560. mgorny added a comment. Remove unnecessary `const_cast`, reformat. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101285/new/ https://reviews.llvm.org/D101285 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/include/lldb/

[Lldb-commits] [lldb] 7d850db - [lldb] Don't use ::fork or ::vfork on watchOS or tvOS

Author: Jonas Devlieghere Date: 2021-04-26T09:31:35-07:00 New Revision: 7d850db6b6438221555b800d31ef5dc63f50dc89 URL: https://github.com/llvm/llvm-project/commit/7d850db6b6438221555b800d31ef5dc63f50dc89 DIFF: https://github.com/llvm/llvm-project/commit/7d850db6b6438221555b800d31ef5dc63f50dc89.d

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

teemperor added a comment. Sorry and thanks for commenting Stella! So it seems that using an incomplete type in the test is rejected by GCC and MSVC but accepted by Clang and ICC. I believe that should be accepted and that's also what the internet(TM) and Shafik are saying, so I'm going to skip

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

teemperor added a comment. Actually it seems Clang also rejects it when running on Windows? I would have assumed that only the `-fms-compatibility-version=19.0` or something like `-fdelayed-template-parsing` matters here but I'm not sure why this is different on Windows. I'm skipping for GCC an

[Lldb-commits] [lldb] a0c735e - [lldb] Skip TestPointerToMemberTypeDependingOnParentSize on Windows and GCC

Author: Raphael Isemann Date: 2021-04-26T18:55:54+02:00 New Revision: a0c735e29a4fd471fa4a9ee60b3bdea79a066e28 URL: https://github.com/llvm/llvm-project/commit/a0c735e29a4fd471fa4a9ee60b3bdea79a066e28 DIFF: https://github.com/llvm/llvm-project/commit/a0c735e29a4fd471fa4a9ee60b3bdea79a066e28.dif

[Lldb-commits] [PATCH] D101157: [lldb] [test] Add tests for coredumps with multiple threads

mgorny updated this revision to Diff 340586. mgorny added a comment. Add FreeBSD/aarch64 test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101157/new/ https://reviews.llvm.org/D101157 Files: lldb/test/Shell/Register/Core/Inputs/aarch64-freebsd-multithread.core lldb/test/Shell/Reg

[Lldb-commits] [PATCH] D101198: [lldb-vscode] Read requests asynchronously

clayborg added a comment. This will be tricky to do right and I really don't know how much extra performance we will get out of this for all of the possible issues we will can introduce by multi-threading things. That being said, I am happy to help see if this will actually improve performance.

[Lldb-commits] [PATCH] D101285: [lldb] [llgs server] Support creating core dumps on NetBSD

mgorny updated this revision to Diff 340638. mgorny added a comment. Fix missing `+` in qSupported. Fix known stub features. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101285/new/ https://reviews.llvm.org/D101285 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h lldb/

[Lldb-commits] [PATCH] D101250: Wrap edit line configuration calls into helper functions

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! I can to land this for you, but first let's wait a bit to see if anyone else has any comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

clayborg added a comment. A bit of history on laying out classes: layout used to be a problem before we were able to give all of the field offsets directly to clang to assist in laying out. The main issues were: - #pragma pack directives are not in DWARF so we must use the DW_AT_data_member_lo

[Lldb-commits] [PATCH] D101329: [lldb] Support SaveCore() from gdb-remote client

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. Extend PluginManager::SaveCore() to support saving core dumps via Process plugins. Implement the client-side part of qSaveCore request in the gdb-remote plugin, that create

[Lldb-commits] [PATCH] D101329: [lldb] Support SaveCore() from gdb-remote client [WIP]

mgorny added a comment. I need to implement path hints and add tests still. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101329/new/ https://reviews.llvm.org/D101329 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D101250: Wrap edit line configuration calls into helper functions

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. I wonder if we would want to wrap this in a macro to get rid of the `EditLineConstString` duplication while keeping the type safety. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D101131: [lldb-vscode] Follow up of D99989 - store some strings more safely

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2939 break; variable_name_counts[variable.GetName()]++; } This will

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

omjavaid updated this revision to Diff 340680. omjavaid added a comment. Resolved review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99941/new/ https://reviews.llvm.org/D99941 Files: lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_arm64.cpp lldb/source/Plugins/

[Lldb-commits] [PATCH] D99941: [LLDB] Support AArch64 PAC elf-core register read

omjavaid marked an inline comment as done. omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/RegisterContextPOSIXCore_arm64.cpp:32 + if (pac_data.GetByteSize() > sizeof(uint64_t)) +opt_regsets.Set(RegisterInfoPOSIX_arm64::eRegsetMaskPAuth); +

[Lldb-commits] [PATCH] D101333: Also display the underlying error message when displaying a fixit

aprantl created this revision. aprantl added reviewers: teemperor, shafik, jingham. aprantl requested review of this revision. When the user running LLDB with default settings sees the fixit notification it means that the auto-applied fixit didn't work. This patch shows the underlying error mess

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 PAC elf-core stack unwinder support

omjavaid updated this revision to Diff 340686. omjavaid added a comment. Moved mask calculation to ABISysV_arm64 class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99944/new/ https://reviews.llvm.org/D99944 Files: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp lldb/source/Plug

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

mib updated this revision to Diff 340701. mib marked 2 inline comments as done. mib added a comment. Use `llvm::Expected` error when possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100965/new/ https://reviews.llvm.org/D100965 Files: lldb

[Lldb-commits] [PATCH] D99947: [LLDB] AArch64 Linux PAC unwinder support

omjavaid updated this revision to Diff 340702. omjavaid added a comment. Fixed review comments and rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99947/new/ https://reviews.llvm.org/D99947 Files: lldb/test/API/functionalities/unwind/aarch64_unwind_pac/Makefile lldb/test/AP

[Lldb-commits] [PATCH] D100965: [lldb] Refactor argument group by SourceLocationSpec (NFCI)

mib added a comment. In D100965#2716239 , @teemperor wrote: > I am wondering how SourceLocationSpec is related to lldb's Declaration class > (which is FileSpec + line + column and describes a location in source code)? > It seems like the current SourceL

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

shafik added a comment. I think @dblaikie original idea of adding a DWARF attribute for this case is the right way to go here. AFAICT this will change the answer to basic questions such as what size a `struct` is and this will likely lead to confusion from our users who will expect the answers

[Lldb-commits] [PATCH] D101250: Wrap edit line configuration calls into helper functions

nealsid added a comment. In D101250#2718107 , @JDevlieghere wrote: > LGTM. I wonder if we would want to wrap this in a macro to get rid of the > `EditLineConstString` duplication while keeping the type safety. Thanks! I looked into removing the EditLi

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

jankratochvil planned changes to this revision. jankratochvil added a comment. In D101237#2718456 , @shafik wrote: > AFAICT this will change the answer to basic questions such as what size a > `struct` is and this will likely lead to confusion from our u

[Lldb-commits] [PATCH] D101237: [lldb] Fix [[no_unique_address]] and libstdc++ 11's std::unique_ptr

dblaikie added a comment. In D101237#2718456 , @shafik wrote: > I think @dblaikie original idea of adding a DWARF attribute for this case is > the right way to go here. AFAICT this will change the answer to basic > questions such as what size a `struct`

[Lldb-commits] [PATCH] D101153: [lldb][NFC] Specify guidelines for API tests

jasonmolenda added a comment. Nice addition, these are great guidelines. I'd do a s/just// pass over the text, there's some extraneous "just"s that could go. This is a very bad habit of my own lately, I re-read emails I write, and try to remove "justs" that snuck into the text I typed before