[Lldb-commits] [PATCH] D100931: Set binaries-loaded/unloaded breakpoint on a name, not an address on macOS

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. I don't know what I was thinking when I wrote this; setting this on an addr_t just removes infor

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

labath added a comment. In D100191#2692882 , @mgorny wrote: > In D100191#2689489 , @labath wrote: > >> We should also start thinking about tests. I suppose the smallest piece of >> functionality that could be use

[Lldb-commits] [lldb] cd64273 - [lldb/ELF] Fix IDs of synthetic eh_frame symbols

Author: Pavel Labath Date: 2021-04-21T11:24:43+02:00 New Revision: cd64273f5ed39ec697ff1e20a1fe25ebd3502629 URL: https://github.com/llvm/llvm-project/commit/cd64273f5ed39ec697ff1e20a1fe25ebd3502629 DIFF: https://github.com/llvm/llvm-project/commit/cd64273f5ed39ec697ff1e20a1fe25ebd3502629.diff

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny added a comment. In D100191#2704403 , @labath wrote: > Let's identify the set of patches needed to make this testable via the > lldb-server suite (this one, D100153 , > D100208

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

labath added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:389 +m_enabled_extensions = flags; +return llvm::Error::success(); + } mgorny wrote: > labath wrote: > > Are you sure that returning success is the best "defa

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3562-3567 +(process_features & NativeProcessProtocol::Extension::fork) == +NativeProcessProtocol::Extension::fork) + m_fork_events_suppo

[Lldb-commits] [lldb] 08ce2ba - [lldb] [MainLoop] Support multiple callbacks per signal

Author: Michał Górny Date: 2021-04-21T12:18:20+02:00 New Revision: 08ce2ba518031425643ce3a4a0476f770c9b8dcd URL: https://github.com/llvm/llvm-project/commit/08ce2ba518031425643ce3a4a0476f770c9b8dcd DIFF: https://github.com/llvm/llvm-project/commit/08ce2ba518031425643ce3a4a0476f770c9b8dcd.diff

[Lldb-commits] [PATCH] D100418: [lldb] [MainLoop] Support multiple callbacks per signal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG08ce2ba51803: [lldb] [MainLoop] Support multiple callbacks per signal (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

werat added a comment. In D98370#2686515 , @jingham wrote: > If persisting already persistent variables is indeed the only failure case, > then I wonder if it wouldn't be more straightforward to just see if the > ValueObject is already a persistent varia

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

mgorny marked 4 inline comments as done. mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3562-3567 +(process_features & NativeProcessProtocol::Extension::fork) == +NativeProcessProtocol::Ex

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3562-3567 +(process_features & NativeProcessProtocol::Extension::fork) == +NativeProcessProtocol::Extension::fork) + m_fork_events_suppo

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

labath added a comment. In D100191#2704492 , @mgorny wrote: > In D100191#2704403 , @labath wrote: > >> Let's identify the set of patches needed to make this testable via the >> lldb-server suite (this one, D10015

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny added a comment. In D100191#2704681 , @labath wrote: > In D100191#2704492 , @mgorny wrote: > >> In D100191#2704403 , @labath wrote: >> >>> Let's identify the set of

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

labath added a comment. In D100191#2704748 , @mgorny wrote: > In D100191#2704681 , @labath wrote: > >> In D100191#2704492 , @mgorny wrote: >> >>> In D100191#2704403

[Lldb-commits] [PATCH] D100153: [lldb] [Process] Introduce protocol extension support API

mgorny updated this revision to Diff 339193. mgorny marked an inline comment as done. mgorny added a comment. Implemented the suggested changes, including `bool()` use in `SetEnabledExtensions()`. Removed the client announcements of `fork-events` and `vfork-events` support. I've left the server

[Lldb-commits] [PATCH] D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork

mgorny updated this revision to Diff 339198. mgorny retitled this revision from "[lldb] Introduce new stop reasons for fork and vfork" to "[lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork". mgorny edited the summary of this revision. mgorny added a comment. @labath, does

[Lldb-commits] [PATCH] D76964: Fix an issue where the IgnoreName function was not allowing "Class" to be looked up inside a namespace or other class.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I think this review got kind of stuck. I think the only missing thing is simplifying the `self.dbg.CreateTarget` call in the test, but otherwise this looks good to me. I'm just going to

[Lldb-commits] [PATCH] D100196: [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork

mgorny added a comment. For other readers: as discussed in D100191 , I've stripped client part of this (except for trivial enumerations). The server part will be used in tests but the stop reasons won't be reported to regular clients as they don't report `fork-

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

teemperor accepted this revision. teemperor added a comment. Thanks for updating and thanks for the patch! I can land it right now. Comment at: lldb/unittests/Core/FormatEntityTest.cpp:154 +TEST(FormatEntity, LookupAllEntriesInTree) { + for (const auto &testString : lookupStri

[Lldb-commits] [lldb] e203914 - Some FormatEntity.cpp cleanup and unit testing

Author: Neal (nealsid) Date: 2021-04-21T15:12:59+02:00 New Revision: e2039142f6b196e9a491c8e0b18faa033c4d9f10 URL: https://github.com/llvm/llvm-project/commit/e2039142f6b196e9a491c8e0b18faa033c4d9f10 DIFF: https://github.com/llvm/llvm-project/commit/e2039142f6b196e9a491c8e0b18faa033c4d9f10.diff

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2039142f6b1: Some FormatEntity.cpp cleanup and unit testing (authored by nealsid, committed by teemperor). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D100191: [lldb] [llgs] Support owning and detaching extra processes

mgorny updated this revision to Diff 339217. mgorny marked an inline comment as done. mgorny added a comment. Remove the test, update the API to pass `std::unique_ptr<>` instance instead of ref. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100191/new/ https://reviews.llvm.org/D100191

[Lldb-commits] [lldb] 953f580 - [lldb/test] Modernize lldb-server test inferior

Author: Pavel Labath Date: 2021-04-21T17:02:41+02:00 New Revision: 953f580b904989af11a69a2fbcb046cf0e10cdc5 URL: https://github.com/llvm/llvm-project/commit/953f580b904989af11a69a2fbcb046cf0e10cdc5 DIFF: https://github.com/llvm/llvm-project/commit/953f580b904989af11a69a2fbcb046cf0e10cdc5.diff

[Lldb-commits] [PATCH] D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP]

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I like this. I should note that, in the mean time, obj2yaml support for program headers has been greatly improved, to the point where one may actually be able to generate a reasonably-looking

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

labath added a comment. I would love to do something about this, but currently I have no idea when I would be able to take on a review of this size. I know it's not what you wanted to hear. Sorry. :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil added a comment. That's sure fine, thanks for the reply. Great there is at least the plan to review it in the future. I understand you are busy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96236/new/ https://reviews.llvm.org/D96236

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. Herald added a subscriber: mgorny. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new utility class, SourceLocationSpec. A source location spe

[Lldb-commits] [PATCH] D100964: [lldb][WIP-ish] Add a assertPacketResponse utility to lldb-server tests

labath created this revision. labath added a reviewer: mgorny. labath requested review of this revision. Herald added a project: LLDB. The goal is to replace the awkward add_log_lines dance. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100964 Files: lldb/packages/Python/ll

[Lldb-commits] [PATCH] D100964: [lldb][WIP-ish] Add a assertPacketResponse utility to lldb-server tests

labath added a comment. Herald added a subscriber: JDevlieghere. I was going to wait until this is fully functional, but since you're about to write some lldb-server tests, I figured it's a good time to get some feedback. The main part that's missing is the ability to wait for some output to be p

[Lldb-commits] [lldb] 55ee541 - [lldb/test] Clean up TestThreadSpecificBpPlusCondition inferior

Author: Pavel Labath Date: 2021-04-21T17:37:30+02:00 New Revision: 55ee541653a817c77a6b5b837c4b8cc50ed3ae0e URL: https://github.com/llvm/llvm-project/commit/55ee541653a817c77a6b5b837c4b8cc50ed3ae0e DIFF: https://github.com/llvm/llvm-project/commit/55ee541653a817c77a6b5b837c4b8cc50ed3ae0e.diff

[Lldb-commits] [PATCH] D100965: [lldb] Refactor (FileSpec+Line) to SourceLocationSpec (NFCI)

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. This patch refactors a good part of the code base turning FileSpec+Line pairs into

[Lldb-commits] [PATCH] D100965: [lldb] Refactor (FileSpec+Line) to SourceLocationSpec (NFCI)

mib updated this revision to Diff 339255. mib edited reviewers, added: teemperor, jingham; removed: jdoerfert. Herald added a reviewer: jdoerfert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100965/new/ https://reviews.llvm.org/D100965 Files: ll

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:12-19 +#include + +#include "lldb/Utility/FileSpec.h" + +#include "llvm/ADT/Optional.h" + +#include Comment at: lldb/include/lldb/Utility/SourceLo

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny updated this revision to Diff 339257. mgorny retitled this revision from "[lldb] [Process/Linux] Report fork/vfork stop reason to client" to "[lldb] [Process/Linux] Report fork/vfork stop reason". mgorny edited the summary of this revision. mgorny added a comment. Now includes lldb-server

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

mib marked an inline comment as done. mib added inline comments. Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:184 + FileSpec m_file_spec; + uint32_t m_line; + llvm::Optional m_column; JDevlieghere wrote: > Are there situations where the line is o

[Lldb-commits] [PATCH] D100965: [lldb] Refactor (FileSpec+Line) to SourceLocationSpec (NFCI)

JDevlieghere added a comment. Nice, it's great to see functions taking less arguments for a change ;-) Comment at: lldb/include/lldb/Breakpoint/BreakpointResolverFileLine.h:12-14 #include "lldb/Breakpoint/BreakpointResolver.h" +#include "lldb/Utility/SourceLocationSpec.h" --

[Lldb-commits] [PATCH] D100962: [lldb/Utility] Add SourceLocationSpec class (NFC)

JDevlieghere added inline comments. Comment at: lldb/include/lldb/Utility/SourceLocationSpec.h:184 + FileSpec m_file_spec; + uint32_t m_line; + llvm::Optional m_column; mib wrote: > JDevlieghere wrote: > > Are there situations where the line is optional too?

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

labath added a comment. This seems reasonable. Why don't we have tests that detach from the parent process (and maybe continue the child)? Does that already work? (or in general, what is expected to work after this patch?) Comment at: lldb/source/Plugins/Process/Linux/Native

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

labath added a comment. Note that you don't actually have to use/extend this particular inferior for these tests. Feel free to create special purpose inferiors, if that's a better fit for the test, just like we do with "normal" tests... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

rupprecht updated this revision to Diff 339264. rupprecht marked 4 inline comments as done. rupprecht added a comment. - Add comments about memory management for m_ipd_buf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100795/new/ https://reviews.ll

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

rupprecht added inline comments. Comment at: lldb/source/Core/RichManglingContext.cpp:23 +RichManglingContext::~RichManglingContext() { + std::free(m_ipd_buf); + ResetCxxMethodParser(); dblaikie wrote: > JDevlieghere wrote: > > shafik wrote: > > > rupprecht wro

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

dblaikie added a comment. If this is going to be plumbed through everywhere (ie: a DWARFDIE is mostly useless without both its lexical DWARFUnit and its imported-into DWARFUnit) then maybe it makes more sense to add this DWARFUnit* to the DWARFBaseDie type alongside the lexical DWARFUnit? Rep

[Lldb-commits] [PATCH] D98370: [lldb] Fix SBValue::Persist() for constant values

jingham added a comment. In D98370#2704597 , @werat wrote: > In D98370#2686515 , @jingham wrote: > >> If persisting already persistent variables is indeed the only failure case, >> then I wonder if it wouldn't be m

[Lldb-commits] [PATCH] D100965: [lldb] Refactor (FileSpec+Line) to SourceLocationSpec (NFCI)

jingham added a comment. It seems like most of the places where you use the SourceLocationSpec, you also pass "check_inlines" and "exact". Those seem to me natural parts of a source location search specification class, and including them in the Spec would clean up the API's even further. Not

[Lldb-commits] [PATCH] D100977: Use forward type in pointer-to-member

emrekultursay created this revision. Herald added a reviewer: shafik. emrekultursay requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This change is similar in spirit to the change at: https://reviews.llvm.org/rG34c697c85e9d0af11a72ac4df5578a

[Lldb-commits] [PATCH] D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP]

mgorny added a comment. I'll try to keep this in mind. I expect to have some vacation time ~1 month from now, so maybe then ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91963/new/ https://reviews.llvm.org/D91963 ___ lldb-commits mailin

[Lldb-commits] [lldb] e414ede - [lldb] [test/Register] Initial tests for regsets in core dumps

Author: Michał Górny Date: 2021-04-21T19:41:09+02:00 New Revision: e414ede2cd54b03f3ff7d547132f06d1b836e5bb URL: https://github.com/llvm/llvm-project/commit/e414ede2cd54b03f3ff7d547132f06d1b836e5bb DIFF: https://github.com/llvm/llvm-project/commit/e414ede2cd54b03f3ff7d547132f06d1b836e5bb.diff

[Lldb-commits] [PATCH] D91963: [lldb] [test/Register] Initial tests for regsets in core dumps [WIP]

This revision was automatically updated to reflect the committed changes. Closed by commit rGe414ede2cd54: [lldb] [test/Register] Initial tests for regsets in core dumps (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny added a comment. In D100208#2705455 , @labath wrote: > This seems reasonable. > > Why don't we have tests that detach from the parent process (and maybe > continue the child)? Does that already work? (or in general, what is expected > to work aft

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

clayborg added a comment. Much of this patch requires all places that took a DWARFDie object now also must take an extra parameter. Is there really no way to have DWARFDie be able to discover the main unit via its contained DWARFUnit? DWARFDie objects are transient, so they can contain more in

[Lldb-commits] [PATCH] D100243: [LLDB][GUI] Expand selected thread tree item by default

clayborg added inline comments. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:2212 +item[i].Expand(); } return; yeah, we need one frame item to be selected at all times so it indicates the current thread/frame that is selected

[Lldb-commits] [PATCH] D100208: [lldb] [Process/Linux] Report fork/vfork stop reason

mgorny updated this revision to Diff 339350. mgorny marked 5 inline comments as done. mgorny added a comment. Implemented all the requests, modulo claim that PID and TID are duplicate ;-). Also found cases for `bool()` with `Extension` stuff. CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] eb5e11f - [lldb] Fix RichManglingContext::FromCxxMethodName() leak

Author: Jordan Rupprecht Date: 2021-04-21T12:32:08-07:00 New Revision: eb5e11f460b1bcace77127de00b8bd15d409ea3a URL: https://github.com/llvm/llvm-project/commit/eb5e11f460b1bcace77127de00b8bd15d409ea3a DIFF: https://github.com/llvm/llvm-project/commit/eb5e11f460b1bcace77127de00b8bd15d409ea3a.di

[Lldb-commits] [PATCH] D100795: [lldb] Fix RichManglingContext::FromCxxMethodName() leak

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeb5e11f460b1: [lldb] Fix RichManglingContext::FromCxxMethodName() leak (authored by rupprecht). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

teemperor added a comment. Were you able to reduce the reproducer you got to a test? If it's really the same bug as in D100180 then I guess a similar test case should trigger the issue (e.g., a class with a pointer-to-member member that references some type th

Re: [Lldb-commits] [lldb] cd64273 - [lldb/ELF] Fix IDs of synthetic eh_frame symbols

Having side effects in the argument to a function call just feels like a bad idea in general even if it seems obviously correct here e.g. ++last_symbol_id, Can’t we just do: uint64_t last_symbol_id = num_symbols ? symbol_table->SymbolAtIndex(num_symbols - 1)->GetID() + 1: 1; Thank

[Lldb-commits] [lldb] 5d1c43f - [lldb] Use the compiler from the SDK in simulator tests

Author: Jonas Devlieghere Date: 2021-04-21T13:22:58-07:00 New Revision: 5d1c43f333c2327be61604dc90ea675f0d1e6913 URL: https://github.com/llvm/llvm-project/commit/5d1c43f333c2327be61604dc90ea675f0d1e6913 DIFF: https://github.com/llvm/llvm-project/commit/5d1c43f333c2327be61604dc90ea675f0d1e6913.d

[Lldb-commits] [lldb] 79fbbeb - [lldb-vscode] Add postRunCommands

Author: Walter Erquinigo Date: 2021-04-21T13:51:30-07:00 New Revision: 79fbbeb41280ed170a387ad925c5397c0af32364 URL: https://github.com/llvm/llvm-project/commit/79fbbeb41280ed170a387ad925c5397c0af32364 DIFF: https://github.com/llvm/llvm-project/commit/79fbbeb41280ed170a387ad925c5397c0af32364.di

[Lldb-commits] [PATCH] D100340: [lldb-vscode] Add postRunCommands

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG79fbbeb41280: [lldb-vscode] Add postRunCommands (authored by wallace). Changed prior to commit: https://reviews.llvm.org/D100340?vs=336942&id=3393

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 1/9: Pass main DWARFUnit * along DWARFDIEs

jankratochvil added a comment. In D96236#2705715 , @dblaikie wrote: > (similar idea) In D96236#2705920 , @clayborg wrote: > > Is there really not way to ask the contained "U" DWARFUnit member for the > main

[Lldb-commits] [PATCH] D99974: [lldb-vscode] redirect stderr/stdout to the IDE's console

wallace updated this revision to Diff 339385. wallace added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99974/new/ https://reviews.llvm.org/D99974 Files:

[Lldb-commits] [lldb] 12a2507 - Fix TestVSCode_launch test

Author: Walter Erquinigo Date: 2021-04-21T14:33:34-07:00 New Revision: 12a25076463d0b04b535d07982d7420971bcea3e URL: https://github.com/llvm/llvm-project/commit/12a25076463d0b04b535d07982d7420971bcea3e DIFF: https://github.com/llvm/llvm-project/commit/12a25076463d0b04b535d07982d7420971bcea3e.di

[Lldb-commits] [lldb] 64f47c1 - [lldb-vscode] redirect stderr/stdout to the IDE's console

Author: Walter Erquinigo Date: 2021-04-21T14:48:48-07:00 New Revision: 64f47c1e58a10de160ce3fb3afbc50c0243e2977 URL: https://github.com/llvm/llvm-project/commit/64f47c1e58a10de160ce3fb3afbc50c0243e2977 DIFF: https://github.com/llvm/llvm-project/commit/64f47c1e58a10de160ce3fb3afbc50c0243e2977.di

[Lldb-commits] [PATCH] D99989: [lldb-vscode] Distinguish shadowed variables in the scopes request

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a0754b443b: [lldb-vscode] Distinguish shadowed variables in the scopes request (authored by wallace). Herald added a project: LLDB. Herald added a

[Lldb-commits] [lldb] c9a0754 - [lldb-vscode] Distinguish shadowed variables in the scopes request

Author: Walter Erquinigo Date: 2021-04-21T15:09:39-07:00 New Revision: c9a0754b443ba73623574db880a7b0b14826fedb URL: https://github.com/llvm/llvm-project/commit/c9a0754b443ba73623574db880a7b0b14826fedb DIFF: https://github.com/llvm/llvm-project/commit/c9a0754b443ba73623574db880a7b0b14826fedb.di

[Lldb-commits] [lldb] c4a83c4 - Fix TestVSCode_runInTerminal

Author: Walter Erquinigo Date: 2021-04-21T15:20:47-07:00 New Revision: c4a83c4e69f1c858df787723df4923c41a23e00d URL: https://github.com/llvm/llvm-project/commit/c4a83c4e69f1c858df787723df4923c41a23e00d DIFF: https://github.com/llvm/llvm-project/commit/c4a83c4e69f1c858df787723df4923c41a23e00d.di

[Lldb-commits] [lldb] 875654f - Fix VSCode/TestOptions.test

Author: Walter Erquinigo Date: 2021-04-21T15:46:26-07:00 New Revision: 875654f897ac01ad91a1a5f5dc23d07ac548a0e0 URL: https://github.com/llvm/llvm-project/commit/875654f897ac01ad91a1a5f5dc23d07ac548a0e0 DIFF: https://github.com/llvm/llvm-project/commit/875654f897ac01ad91a1a5f5dc23d07ac548a0e0.di

[Lldb-commits] [lldb] 39ea3ce - [lldb] Disable TestSimulatorPlatform.py because it's causing a SIGHUP

Author: Jonas Devlieghere Date: 2021-04-21T20:00:51-07:00 New Revision: 39ea3ceda31cd02ef7e29bbeca74271feed3fc53 URL: https://github.com/llvm/llvm-project/commit/39ea3ceda31cd02ef7e29bbeca74271feed3fc53 DIFF: https://github.com/llvm/llvm-project/commit/39ea3ceda31cd02ef7e29bbeca74271feed3fc53.d

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay updated this revision to Diff 339483. emrekultursay added a comment. Added functionality/lazy-loading test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 Files: lldb/source/Plugins/Symbo

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay updated this revision to Diff 339485. emrekultursay added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100977/new/ https://reviews.llvm.org/D100977 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTPar

[Lldb-commits] [PATCH] D100977: [lldb] Use forward type in pointer-to-member

emrekultursay added a comment. I added a lazy-loading test. I also attempted to write a test similar to `lang/cpp/static_member_type_depending_on_parent_size/TestStaticMemberTypeDependingOnParentSize.py`, but I could not get it to produce an incorrect struct size (just like I couldn't reduce th