[Lldb-commits] [lldb] 8cdcd41 - [lldb/Interpreter][NFC] Remove explicit default initialization of members and base classes

Author: Tatyana Krasnukha Date: 2021-02-28T19:23:18+03:00 New Revision: 8cdcd41e384b4901cd796f7be58c461647e54d18 URL: https://github.com/llvm/llvm-project/commit/8cdcd41e384b4901cd796f7be58c461647e54d18 DIFF: https://github.com/llvm/llvm-project/commit/8cdcd41e384b4901cd796f7be58c461647e54d18.d

[Lldb-commits] [lldb] 54d03a4 - [lldb/Interpreter][NFC] Replace default constructors/destructors bodies with "=default"

Author: Tatyana Krasnukha Date: 2021-02-28T19:23:16+03:00 New Revision: 54d03a4985bc9a0a84c4dff835ec6ed0f607582f URL: https://github.com/llvm/llvm-project/commit/54d03a4985bc9a0a84c4dff835ec6ed0f607582f DIFF: https://github.com/llvm/llvm-project/commit/54d03a4985bc9a0a84c4dff835ec6ed0f607582f.d

[Lldb-commits] [lldb] b2faf30 - [lldb][NFC] Make OptionValueArgs::GetArgs constant

Author: Tatyana Krasnukha Date: 2021-02-28T19:23:20+03:00 New Revision: b2faf30189449a894b5c1cb2bb6b0cc04986c7fe URL: https://github.com/llvm/llvm-project/commit/b2faf30189449a894b5c1cb2bb6b0cc04986c7fe DIFF: https://github.com/llvm/llvm-project/commit/b2faf30189449a894b5c1cb2bb6b0cc04986c7fe.d

[Lldb-commits] [lldb] ef447fe - [lldb] OptionValueProperties::Get[Set]PropertyAtIndexAsArgs should handle OptionValueArgs

Author: Tatyana Krasnukha Date: 2021-02-28T19:23:22+03:00 New Revision: ef447fe0088cacc38027028d4c43c1938d3eb9e7 URL: https://github.com/llvm/llvm-project/commit/ef447fe0088cacc38027028d4c43c1938d3eb9e7 DIFF: https://github.com/llvm/llvm-project/commit/ef447fe0088cacc38027028d4c43c1938d3eb9e7.d

[Lldb-commits] [lldb] 9182117 - [lldb/Interpreter][NFC] Remove more deleted const char* overloads

Author: Tatyana Krasnukha Date: 2021-02-28T19:23:14+03:00 New Revision: 9182117861896a03499bbca3612fc66ca4d36944 URL: https://github.com/llvm/llvm-project/commit/9182117861896a03499bbca3612fc66ca4d36944 DIFF: https://github.com/llvm/llvm-project/commit/9182117861896a03499bbca3612fc66ca4d36944.d

[Lldb-commits] [lldb] f0f183e - [lldb/Interpreter] Fix deep copying for OptionValue classes

Author: Tatyana Krasnukha Date: 2021-02-28T19:23:25+03:00 New Revision: f0f183ee4ad952d94234cf6971c69a044e05c9df URL: https://github.com/llvm/llvm-project/commit/f0f183ee4ad952d94234cf6971c69a044e05c9df DIFF: https://github.com/llvm/llvm-project/commit/f0f183ee4ad952d94234cf6971c69a044e05c9df.d

[Lldb-commits] [lldb] 1d6a6f3 - [lldb/Target] Remove outdated code

Author: Tatyana Krasnukha Date: 2021-02-28T19:23:27+03:00 New Revision: 1d6a6f3b0c710ccd6558644d195cf939c4995d84 URL: https://github.com/llvm/llvm-project/commit/1d6a6f3b0c710ccd6558644d195cf939c4995d84 DIFF: https://github.com/llvm/llvm-project/commit/1d6a6f3b0c710ccd6558644d195cf939c4995d84.d

[Lldb-commits] [PATCH] D96952: CRTP-based version of D96817

This revision was automatically updated to reflect the committed changes. tatyana-krasnukha marked 2 inline comments as done. Closed by commit rGf0f183ee4ad9: [lldb/Interpreter] Fix deep copying for OptionValue classes (authored by tatyana-krasnukha). Herald added a project: LLDB. Herald added a s

[Lldb-commits] [PATCH] D96952: CRTP-based version of D96817

tatyana-krasnukha added inline comments. Comment at: lldb/source/Interpreter/OptionValueFileSpecList.cpp:169 std::lock_guard lock(m_mutex); - return OptionValueSP(new OptionValueFileSpecList(m_current_value)); + return std::make_shared(*this); } JDevliegher

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha abandoned this revision. tatyana-krasnukha added a comment. D96952 is landed instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96817/new/ https://reviews.llvm.org/D96817 ___ lldb-commit

Re: [Lldb-commits] [lldb] 54d03a4 - [lldb/Interpreter][NFC] Replace default constructors/destructors bodies with "=default"

Any chance of removing some of these entirely, when they're the default (like the first class in this patch, `CommandHistory` - a default ctor (assuming it has no other ctors) and dtor are implicit, and don't need to be written out)? On Sun, Feb 28, 2021 at 8:24 AM Tatyana Krasnukha via lldb-commi

Re: [Lldb-commits] [lldb] 8cdcd41 - [lldb/Interpreter][NFC] Remove explicit default initialization of members and base classes

Nice cleanup! On Sun, Feb 28, 2021 at 8:24 AM Tatyana Krasnukha via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Tatyana Krasnukha > Date: 2021-02-28T19:23:18+03:00 > New Revision: 8cdcd41e384b4901cd796f7be58c461647e54d18 > > URL: > https://github.com/llvm/llvm-project/commit/8c

[Lldb-commits] [PATCH] D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0

jasonmolenda created this revision. jasonmolenda added a reviewer: clayborg. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. This patch allows a RegisterContext to record if it behaves like a 0th frame -- where its pc va

[Lldb-commits] [PATCH] D97644: Allow RegisterContext to track if behaves-like-frame-0, allow LanguageRuntime for above frame 0

jasonmolenda added a comment. Another alternative to RegisterContext::BehavesLikeZerothFrame that I've thought of is RegisterContext::GetPCForSymbolication, similar to GetPC() today. I think everyone who is decrementing $pc is doing it for symbolication, so having this hint and then leaving it